396826 Commits

Author SHA1 Message Date
Noel Grandin
6df2c90c08 loplugin:countusersofdefaultparams in vcl
Change-Id: I046e6f16c5b171a06e2be2da2f72340634f3e979
Reviewed-on: https://gerrit.libreoffice.org/28891
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15 06:35:33 +00:00
Gabor Kelemen
c77b933f90 Updated core
Project: help  eb949d8e2f087ea0358719948e75a4aeacddd74f

tdf#102198 Fix references to the "Save As Template" menu item

Change-Id: I63a78ca9b99447bf8e458377419b0ba92550fe37
Reviewed-on: https://gerrit.libreoffice.org/28903
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-15 05:54:26 +00:00
Zdeněk Crhonek
7a49cffaed add FORECAST.ETS.MULT test case
Change-Id: Ibc555a9a3c3c7158012b6809b2d8c7d9bf4fda2f
Reviewed-on: https://gerrit.libreoffice.org/28912
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-15 02:55:36 +00:00
Zdeněk Crhonek
8697d18f71 add OFFSET test case
Change-Id: Ifdb1a0d83ba9b539ea5bda0345f292330e691277
Reviewed-on: https://gerrit.libreoffice.org/28881
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-15 02:54:52 +00:00
Zdeněk Crhonek
dc73f699da add ROWS test case
Change-Id: Ied7286dc5fa480ef3403ed5cfed3ab9b6a30b049
Reviewed-on: https://gerrit.libreoffice.org/28914
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-15 02:53:48 +00:00
Norbert Thiebaud
91cc48f3d4 cid#1372878 modulo by zero
Change-Id: I37ed251597f44d382fde96c39ff9d07e4d14c50a
Reviewed-on: https://gerrit.libreoffice.org/28859
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-09-14 21:51:16 +00:00
Jochen Nitschke
0f33526ec2 put all SfxShell feature flags in one typed_flags class
make values unique across modules.
check if flag used in correct module.

Change-Id: I656ffd3d527dd895777e14e1cc933c8b9b3f6e46
Reviewed-on: https://gerrit.libreoffice.org/28906
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14 20:05:29 +00:00
Miklos Vajna
bee4ff508a desktop lok: avoid unnecessary setPart() in paintPartTile()
If possible, switch views, not parts, that way started Impress text
edits don't end as a side-effect.

Change-Id: I3f18d4dda6bc24235bf1219416f153248a867fa4
2016-09-14 19:47:48 +02:00
Eike Rathke
b9a27d5856 sc: disable function test documents for 32-bit PLATFORMID=linux_x86
Change-Id: I18ee46abbb5de79a35c4c78292dc9d6d43017de2
Reviewed-on: https://gerrit.libreoffice.org/28893
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-09-14 15:46:17 +00:00
Michael Stahl
999499ab25 gbuild-to-ide: MSVC 2012 no longer supported, replace with 2015
Of course not tested in any way but with any luck the project file
format hasn't changed and it will "just work".

Change-Id: I81c5043259feeabd69ef31ea7ef160901ac7ebdc
2016-09-14 17:04:27 +02:00
Stephan Bergmann
15f92676f7 external/firebird: Hack around detection of clock_gettime on Mac OS X
...where the 10.12 SDK includes clock_gettime, marked as

  __attribute__((availability(macosx,introduced=10.12)))

in time.h.  However, the way firebird's configure checks for it, it gets
detected as available regardless of the used -mmacosx-version-min value (and
even if the configure check would go via the time.h header, the availability
attribute would only cause a -Wpartial-availability warning, not an error, so
we'd need to pass CFLAGS=-Werror=partial-availability into firebird's
configure.)

Change-Id: I67e12743e1df0574e7fc4b2121add9fe1fb7677b
2016-09-14 16:18:49 +02:00
Andras Timar
486f906436 Revert 8c4dbcef8f and provide a better fix
This reverts commit 8c4dbcef8f92c9bd1c2208e7de7971f184f8a3ff.

bccu#1781 bug was in LibreOffice Online. After deletion of the selected
editeng text, the selection did not disappear. By making the fix conditional
to LibreOfficeKit::isActive(), we can avoid the weird selection problem in
desktop editeng.

Change-Id: I78c68b5a79db816ea4d0bdf3d75dd1ba4c269106
Reviewed-on: https://gerrit.libreoffice.org/28900
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-14 14:16:35 +00:00
Stephan Bergmann
16bbeb5713 Change the shared bridgetest code from static to dynamic library
...so ASan builds do not complain about ODR violations due to multiple instances
of vtable for testtools::bridgetest::CurrentContextChecker after
a53808c0ed577468393aced90963af6496706959 "loplugin:dllprivate" removed the
SAL_DLLPRIVATE from class CurrentContextChecker (which apparently /did/ have an
impact with -fvisibility-ms-compat, as used by Linux Clang ASan/UBSan builds).

Change-Id: Ifb1ba1819f7ea989300f4696d44f9599a1436563
2016-09-14 15:52:04 +02:00
Stephan Bergmann
0f6cb25be8 loplugin:override
Change-Id: If6d03fd0d3b5b69f3b07e697c4f6d7a3668ee69a
2016-09-14 14:48:18 +02:00
Stephan Bergmann
c765a6757f loplugin:override
Change-Id: I0cd2007c9169fe480e28e684cfe1bd8b24da7123
2016-09-14 14:35:36 +02:00
Stephan Bergmann
b932b19960 loplugin:override
Change-Id: I1971301f2b07a6d0608d13d1ab60c6339a079468
2016-09-14 14:25:06 +02:00
Stephan Bergmann
f734b24f4f loplugin:override
Change-Id: I73f96cb391a430443f9bb80a5406627c5564dcd9
2016-09-14 14:19:44 +02:00
Stephan Bergmann
386aeda1f0 loplugin:override
Change-Id: Id9c234d605b4f8107833980825b402006e4f0031
2016-09-14 14:15:31 +02:00
Miklos Vajna
eefccb4a10 sd lok draw text: make sure watching views have no cursors
These additional views are only created to follow the updates done in
the editing view, not to contribute additional cursors.

With this, if the first view edits a shape text and the second view is
created, then no unwanted text view cursor is created in the first view
for the shape text from the second view.

Be precise in the unit test and make sure that cursors from all views
are hidden, because even without a fix the cursor of view #2 is hidden,
but not from view #3, so the test wouldn't fail without the fix. (But
hardcoding the 0-1 and 2-3 view IDs exposed by Impress before/after
initializeForRendering() would be ugly.)

Change-Id: Idf64f7bfcc35c98a5eada9a0a523a9b45b65a211
2016-09-14 14:02:12 +02:00
Stephan Bergmann
bd132e558d loplugin:override
Change-Id: Ica137897f02c5caa4c4891f75531ada3957025d9
2016-09-14 12:53:30 +02:00
Caolán McNamara
fc6744603a Resolves: tdf#101859 dispose unused popupmenu before dtor
Change-Id: I097a342f29aa88ab2d0a6a80b9ac6e1e9a5e3d5a
2016-09-14 10:27:00 +01:00
Miklos Vajna
ecc29bf323 sfx2: use range-based for loop in lokhelper
Change-Id: I7c3421231dd74c8d1e2678a6aee92288fdd3221a
2016-09-14 11:24:57 +02:00
Noel Grandin
0ea50b5b43 loplugin:countusersofdefaultparams in xmloff
Change-Id: Ia92a878ac97b3cc668594946e77a718f27a3e3ed
Reviewed-on: https://gerrit.libreoffice.org/28890
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14 08:47:48 +00:00
Noel Grandin
20a9e101d9 loplugin:constantparam
clean up the plugin a little, and try to catch params which are default
constructed, which doesn't seem to be working yet

Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12
Reviewed-on: https://gerrit.libreoffice.org/28861
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14 08:47:06 +00:00
Noel Grandin
0761f97525 loplugin:constantparam in accessibility to basic
Change-Id: Id77cbcaefebf310a5d99c6ac12d154e182fd0a1c
Reviewed-on: https://gerrit.libreoffice.org/28860
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14 08:46:12 +00:00
Justin Luth
e44addfd5d writerfilter style: use emplace_back, avoiding typedef
Change-Id: I106f94ad4b8c8711a563971cb43d71aa90b139f8
Reviewed-on: https://gerrit.libreoffice.org/28868
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-14 08:15:45 +00:00
Miklos Vajna
7b784e4e39 sw draw text: emit LOK_CALLBACK_VIEW_LOCK from registerCallback()
With this, in case the first view has an active text edit and a new view
is created, then the shape text lock is instantly visible in the second
view, even if the first view does not end + begin the text edit again
later.

Change-Id: I82d98ab1431a54a1a8897d16ce7fa0856baa2a10
2016-09-14 10:06:58 +02:00
Jochen Nitschke
f1018190a8 tdf#88205 use list ctor for uno::Sequence a11y to canvas
Change-Id: Ib719c94c0488b8a48fdb013bc8fbd1a988595d18
Reviewed-on: https://gerrit.libreoffice.org/28866
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14 07:23:51 +00:00
Noel Grandin
1e49e33c26 loplugin:constantparam in chart2..connectivity
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d
Reviewed-on: https://gerrit.libreoffice.org/28834
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14 06:40:30 +00:00
Zdeněk Crhonek
e1822c809b add EXPON.DIST test case
Change-Id: Ic038ec8030dd05120f74f5cc9a299e40671484c1
Reviewed-on: https://gerrit.libreoffice.org/28882
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-14 00:50:00 +00:00
Zdeněk Crhonek
a63bd06b5f add F.TEST testcase
Change-Id: I31fdab18b0e8c133f41877977c4a3b97f8af54fd
Reviewed-on: https://gerrit.libreoffice.org/28883
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-14 00:49:34 +00:00
Zdeněk Crhonek
08641cc939 add PV test case
Change-Id: Ib420b55de35c6110a3e08d4539ad2d3176379462
Reviewed-on: https://gerrit.libreoffice.org/28884
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-14 00:48:52 +00:00
Maxim Monastirsky
74fd959945 tdf#74377 Keyboard shortcuts for context menus
Configurable through the options dialog. The default behavior
depends on the current vclplug (hide for gtk2/3 and OS X, show
otherwise).

Menus currently affected by this change:

- SfxDispatcher based context menus
- chart2 context menus
- vcl's Edit control context menu
- Several MenuBarManager based toolbar dropdowns.

Change-Id: Iad9fb99dc90e01c17cba9c07c1a2b262b920e11d
Reviewed-on: https://gerrit.libreoffice.org/28849
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-09-13 23:06:38 +00:00
Stephan Bergmann
ebe46f14a2 loplugin:override
Change-Id: I7b746d652887d61e6a8a63b5b3ba37e0a158817e
2016-09-14 00:05:56 +02:00
Stephan Bergmann
6af14d2d18 loplugin:override
Change-Id: I25cbca130c3e075d614d9bbb63b6264e8e73c165
2016-09-13 23:55:33 +02:00
Zdeněk Crhonek
c15e1d9b8e add FISHERINV test case
Change-Id: I9bf023d07fdc4e85d956eee0327f57b9ba5b495e
Reviewed-on: https://gerrit.libreoffice.org/28874
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-13 20:59:18 +00:00
Stephan Bergmann
a53808c0ed loplugin:dllprivate
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
2016-09-13 22:26:22 +02:00
Eike Rathke
ccfbc9d3ac unconditionally replacing Y after G (era) with E was always wrong
For example, in en-US locale  G MM/DD/YYYY  saved and reloaded lead to
G MM/DD/EE  using the Hebrew calendar.

Use E or EE only if a secondary calendar was given.

Change-Id: I6db22e89f435342aa4a1bce7fa13711c138007f5
2016-09-13 22:10:01 +02:00
Zdeněk Crhonek
4e7b0af624 add FORECAST test case
Change-Id: I5cc3df27a75ad56126ef6ade3167af93a1570733
Reviewed-on: https://gerrit.libreoffice.org/28875
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-13 19:22:31 +00:00
Miklos Vajna
2ea385a54b sw draw text: emit LOK_CALLBACK_TEXT_VIEW_SELECTION from registerCallback()
With this, in case the first view has an active text edit selection and
a new view is created, then the text selection is instantly visible in
the second view, even if the first view's text selection does not change
later.

Change-Id: I3255febd5d65d6576ddbc57cf96836bdf0b06a72
2016-09-13 20:27:51 +02:00
Eike Rathke
e12c9b4101 do not add calendar modifier to format code when importing as E or EE keyword
... with implicit calendar switch.

Change-Id: Ie4d848e261fe86bbe504954b2e0c7cf24bc181bc
2016-09-13 20:03:54 +02:00
Eike Rathke
426723912f that copypasta comment fragment makes no sense
Change-Id: I835fd6045e5ab5aeb93c91edb07037b1ed3ea4a9
2016-09-13 20:03:53 +02:00
Caolán McNamara
abbe758454 Resolves: tdf#101924 fatal exception on Sounds like Japanese options
suspected regression from

commit 1a967fead616b201535449fa812775c88d5b2e3b
Author: Eike Rathke <erack@redhat.com>
Date:   Tue Mar 24 15:53:23 2015 +0000

    do not include non-mask bits in masks

Change-Id: Ic35a4aecc4834fc255eae81d3d83cc4e74618604
Reviewed-on: https://gerrit.libreoffice.org/28764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-09-13 18:00:59 +00:00
Yousuf Philips
9adafa3283 tdf#87794 Hide contextual media player toolbar
Change-Id: I71dce7a5ad7f898b4338f95b1fc3bfca5080907a
Reviewed-on: https://gerrit.libreoffice.org/28820
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-13 17:32:10 +00:00
Caolán McNamara
a6a193666d Enable breeze dark icon theme
This reverts commit 480ee0a664f6c2227973e46e1cd26c2bf885c2e0.

Change-Id: Iad58d7c4b6f9196845efda9a22479093a8c4e367
Reviewed-on: https://gerrit.libreoffice.org/28869
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-13 17:27:11 +00:00
Tor Lillqvist
6e18d56c77 Remove totally bogus comment
Was initially in German with glorious ASCII graphics, but equally
bogus.

Change-Id: I9f7286049ed6a0ec7c1511dd3da018e5f6442b15
2016-09-13 18:12:27 +03:00
Tor Lillqvist
647360d948 Add comment wondering whether a #if makes sense
Change-Id: Ib6e6ab79632325dd3d592265a9ee859b1bc2c3ca
2016-09-13 18:12:27 +03:00
Stephan Bergmann
8332db757c loplugin:override
Change-Id: Ia2445bb53ea3508ee3be4e3eb5eb031e26f1bf9c
2016-09-13 17:09:34 +02:00
Michael Stahl
66bdcb96ed xmloff: invoke SvXMLImportContext destructor with proper namespace map
The recent pRewindMap fix revealed that the xContext object is destroyed
too late so the destructors containing half the import code (because
where else would you put complex logic that can fail?) are invoked with
the namespace map of the parent element, which breaks RDFa import and
JunitTest_sfx2_complex.

(regression from 32ccb4ea863651c22bf33cc15012971d2a2d2810)

Change-Id: I0c897ea0cae2db4d35f2ba19ba2f6e8026f1b3ec
2016-09-13 17:01:12 +02:00
Miklos Vajna
586789fe75 sw draw text: emit LOK_CALLBACK_INVALIDATE_VIEW_CURSOR from registerCallback()
With this, in case the first view has an active text edit and a new view
is created, then the cursor position is instantly visible in the second
view, even if the first view's cursor does not move later.

Change-Id: Ia82e7dc1ce9bb58c67a280179ecadc74d3b63026
2016-09-13 16:48:28 +02:00