mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
396,826 Commits 1 Branch 0 Tags
Commit Graph

764 Commits

Author SHA1 Message Date
Stephan Bergmann
2d74cbe769 loplugin:nullptr: Check for more pointer types 
(but did not turn up further matches)

Change-Id: I7e4843d00a2e3b46edec46c5b56b6ba1b2e098fd
 2016-03-31 15:49:28 +02:00
Stephan Bergmann
d2f9f27774 loplugin:nullptr: Find some more cases in templates 
Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
 2016-03-30 18:59:54 +02:00
Stephan Bergmann
dde79dd504 Rename OfficeIPCThread to RequestHandler 
Change-Id: I2076d903e83a0b8eb3aa0ce2413630e2c5415b15
 2016-03-29 14:54:20 +02:00
Noel Grandin
ef3ca022d9 constantparam loplugin improvements 
clean up the python code, filter out setter methods

Change-Id: I8294dd305a30708cf0e81c5328935ec8f6cdc8d4
Reviewed-on: https://gerrit.libreoffice.org/23466
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-23 12:05:37 +00:00
Stephan Bergmann
779f06f9a8 Ambiguity between clang:: and llvm::PointerType 
Change-Id: I2727ef17b9ab780c608878aaca9ce0fda01b9c22
 2016-03-20 13:29:50 +01:00
Noel Grandin
f0f973da85 loplugin:constantparams in vcl/ 
also some improvements to the plugin

Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871
Reviewed-on: https://gerrit.libreoffice.org/23289
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-16 08:42:37 +00:00
Noel Grandin
b47cb646ff loplugin:constantparam 
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
 2016-03-15 08:27:25 +02:00
Wastack
9a13cff647 tdf#97966: Remove 'static' keywords 
Change-Id: Id991cead4f01830eafd9cf8dd63b519ef07c9451
Reviewed-on: https://gerrit.libreoffice.org/23134
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-03-11 08:57:51 +00:00
Maxim Monastirsky
21b92f386c MenuDispatcher::m_pMenuManager is always nullptr 
... as shown by 7da15debe39b50255cc08b3fef7ae38185a9174f.
Which means that MenuManager is unused, and MenuDispatcher
does nothing useful.

Change-Id: Ic85619531054a573d971d38b52609e1cbcaf780c
Reviewed-on: https://gerrit.libreoffice.org/23117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-03-10 15:23:31 +00:00
Stephan Bergmann
7024c86b17 Extract checking code to its own check.cxx 
Change-Id: I9d5b14c374ce62ac7b970faa30c38a5a76568ed4
 2016-03-08 21:37:42 +01:00
Stephan Bergmann
1316543eb8 TODO: Work around loplugin:salbool in cppu/source/uno/data.cxx for now 
Change-Id: I1730c09669426e049aba941ef27341581ce31887
 2016-03-08 18:16:58 +01:00
Noel Grandin
b4fda7b3f9 new loplugin:constantparam 
finds parameters that are only ever being called with a single value

Change-Id: Ibd0c9b6e6dbc1d1b5d5a005eaa19959560a6e50f
 2016-03-08 09:04:47 +02:00
Noel Grandin
359e0b47a0 loplugin:unuseddefaultparams 
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795
Reviewed-on: https://gerrit.libreoffice.org/22971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-07 09:16:00 +00:00
Noel Grandin
70f87284c6 improve defaultparams loplugin 
to catch calling params with defaults like "= OUSString()"

Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9
Reviewed-on: https://gerrit.libreoffice.org/22932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-07 05:57:17 +00:00
Noel Grandin
37a6bafea8 loplugin:unuseddefaultparam in various 
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0
Reviewed-on: https://gerrit.libreoffice.org/22900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-07 05:56:59 +00:00
Markus Mohrhard
a3d8833bd8 fix crash in cppunitassertequals plugin 
Change-Id: I0427c70aa3a7f55aba4bbe0fe571aab08596541a
Reviewed-on: https://gerrit.libreoffice.org/22922
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-03-05 11:44:27 +00:00
Noel Grandin
1fd781e7cd loplugin:unuseddefaultparam in oox/reportdesign/sd 
Change-Id: Ia26cf182ddc7c903d86bf74a8175858adb88121c
 2016-03-04 14:01:19 +02:00
Noel Grandin
46c67c4323 loplugin:unuseddefaultparam in tools 
Change-Id: I027f4d53e3aa793bd61bf110899e464a9b6430ec
Reviewed-on: https://gerrit.libreoffice.org/22891
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-04 11:20:09 +00:00
Noel Grandin
9a1e6d916e loplugin:unuseddefaultparam in sfx2 
and fix an issue with calls to templated methods in the plugin

Change-Id: I9c9537a0690ff671286c007846d5f4cfb7d2982b
 2016-03-04 11:48:04 +02:00
Noel Grandin
f5e131b2bc loplugin:unuseddefaultparams in vcl and xmloff 
and teach the plugin about code that takes the address of a function

Change-Id: Ia9d5afef44520aca236659e8176f1e27135ef4fc
Reviewed-on: https://gerrit.libreoffice.org/22861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-04 06:13:25 +00:00
Matúš Kukan
5a1cd2f30d OSingletonRegistration is dead now 
Change-Id: I64a5ffa8790496bd39ba26e0c789db9eedc51071
Reviewed-on: https://gerrit.libreoffice.org/22788
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matúš Kukan <matus@libreoffice.org>
 2016-03-01 19:36:58 +00:00
Miklos Vajna
4fe23a7972 compilerplugins: fix clang-3.7 build 
Change-Id: I2d845d3e008cec085ce2b355c9a058363bd021cb
 2016-02-29 09:37:33 +01:00
Maxim Monastirsky
7affe26a12 Kill sfx2 menu support 
Change-Id: I340a066881b1962a4bcd5a2b7d9a0425d8b9557c
 2016-02-28 09:10:19 +02:00
Stephan Bergmann
75e24386af Missed CLANG_VERSION for compilerplugins/clang/store/rtlconstasciimacro.cxx 
Change-Id: I24d2dc570070a55f39dcd708eb7c47cd71dc0d02
 2016-02-26 14:46:23 +01:00
Stephan Bergmann
a2dcac011a New COMPILER_PLUGINS_CXX to specify compiler to build Clang plugins with 
...instead of trying to second-guess what to strip off $(CXX) to make it fit.
Keep the old way for existing build scripts that rely on it.

Change-Id: I145bdcba6d02002a9b653b4deb6e7f5a9c76cc8f
 2016-02-26 14:34:31 +01:00
Stephan Bergmann
af89738d22 -Werror=return-type 
Change-Id: I44e627fa9de9c48a534cbc9ade6cc9d567553709
 2016-02-26 14:34:30 +01:00
Stephan Bergmann
2db16f4bdc -Werror=return-type 
Change-Id: I7691fa50d827b688cab299c85c933adabb29994c
 2016-02-26 14:34:30 +01:00
Stephan Bergmann
8631cecb86 -Werror=maybe-uninitialized 
Change-Id: Ib456e717b65c3dce3aaca73b2d55872a53d30828
 2016-02-26 14:34:30 +01:00
Stephan Bergmann
34082fa5a8 Silence -Werror=comment about a "multi-line comment" 
Change-Id: I19f09c7d253bb86bbe3b10083f762a5791e2f370
 2016-02-26 14:34:30 +01:00
Stephan Bergmann
01f3b95884 These version checks are about the Clang the plugins are built /against/ 
...not the (Clang) compiler they are being built /with/.  (Also simplifies the
checking #if code.)

Change-Id: I416321be4ef4478785be40571f81500fd3b6feb8
 2016-02-26 14:34:29 +01:00
Stephan Bergmann
cd2725de90 Revert "compilerplugins: Build them in parallel." 
This reverts commit 4101fa184150663ddee6688c19eb4a44e341e8d4.

Just configure --without-parallelism and always use an explicit make -jN, and be
done with it.  I just can't stand that "make[1]: Entering/Leaving directory"
noise around each "[build CXX] compilerplugins/clang/*.cxx" line any more.
 2016-02-26 14:34:29 +01:00
Stephan Bergmann
f467269e1a That #if for Clang < 3.2 is probably good to go by now 
Change-Id: I019405884dec5767de733e3fa0114b3b461e777d
 2016-02-26 12:05:34 +01:00
Noel Grandin
9c6b6c6c07 turn unuseddefaultparams plugin off by default 
add fix the method override logic

Change-Id: Ia75bc70aa1b8d26a65a4082956dc88a0fd17be9e
 2016-02-25 11:57:47 +02:00
Noel Grandin
4fbf95deba new loplugin:unuseddefaultparams 
Change-Id: I2c3e7d66be9e3883ea2801ff394948cc580d1e44
 2016-02-25 11:42:35 +02:00
Noel Grandin
e236cc1676 new loplugin:cppunitassertequals 
look for places we should be calling CPPUNIT_ASSERT_EQUALS instead of
CPPUNIT_ASSERT

Change-Id: Ia836555d569069c6d0dce592f1c9a78bf8d8adb8
 2016-02-24 13:35:05 +02:00
Noel Grandin
c45d3badc9 new loplugin: commaoperator 
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
 2016-02-23 08:08:56 +02:00
Noel Grandin
778e9a65bf new loplugin: find write-only fields 
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717
Reviewed-on: https://gerrit.libreoffice.org/22498
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-19 11:23:57 +00:00
Noel Grandin
198f3ec116 loplugin:unusedmethods 
Change-Id: I0fb06079ff8a9d0b2f5a2929f31846f91391f5c4
Reviewed-on: https://gerrit.libreoffice.org/22229
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-12 06:14:02 +00:00
Stephan Bergmann
5a5dbb31d5 Use rtl::Reference<CppType> instead of HardCppRef<UnoType,CppType> 
Change-Id: I089b5caca5e05726105f78aeb00db1869d0a17f4
 2016-02-09 18:30:54 +01:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Andrea Gelmini
534b2a4b58 Fix typos 
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3
Reviewed-on: https://gerrit.libreoffice.org/21797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-02-05 06:48:38 +00:00
Stephan Bergmann
39accf65cd loplugin:fpcomparison: Fix check for floating-point zero 
...so that isZeroConstant doesn't trigger an assert inside Clang's
isCXX11ConstantExpr when expr is sizeof(x) with x being dependent on a template
argument.

Change-Id: I6bab46e64cc085d597db25994d8bfdc66417fe83
 2016-02-04 11:04:04 +01:00
Noel Grandin
4e9b528dcc new loplugin fpcomparison 
Find code that compares floating point values with == or !=
It should rather use rtl::math::approxEqual

Change-Id: I9026e08823340fa1d6a042c430515344c93215bd
Reviewed-on: https://gerrit.libreoffice.org/21997
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-04 06:41:35 +00:00
Noel Grandin
d34d792230 new loplugin to find public methods that can be private 
based on the unusedmethods plugin, which I should probably rename at
some point

Change-Id: If197423c59d4350ea1fdc69e99d24b631d9751b9
 2016-02-01 14:53:19 +02:00
Michael Stahl
f3f305b6a5 compilerplugins: rejoice, for pStaticThesSubMenu is dead 
Change-Id: I6c7f250af4c1f09feb836aef3c468d97e8266e4b
 2016-01-25 12:31:39 +01:00
Noel Grandin
370294f6d1 new loplugin sfxpoolitem 
generates a warning about subclasses that add members but do not
override operator==()

Change-Id: If6df1a2cbd115f17bcca22f9b7995181dcf55c03
Reviewed-on: https://gerrit.libreoffice.org/20468
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-01-22 12:14:56 +00:00
Noel Grandin
90d892664a loplugin: unused return values 
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7
Reviewed-on: https://gerrit.libreoffice.org/21628
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-21 07:18:38 +00:00
Caolán McNamara
4ebe249104 drop basebmp entirely now 
Change-Id: I534848c4be8eadf86b7f31ac742a80982405f56f
 2016-01-20 09:43:28 +00:00
Noel Grandin
5fe99ea3ee loplugin:unusedmethods in sw/ 
Change-Id: Id452bfac5c83f130a138e06984a0c79c37af70ac
 2016-01-19 11:01:56 +02:00
Noel Grandin
a7f6efc68b loplugin: unused return values 
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af
Reviewed-on: https://gerrit.libreoffice.org/21571
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-18 12:50:09 +00:00