Commit Graph

396826 Commits

Author SHA1 Message Date
Noel Grandin
8bfcb53c3d loplugin:constantparam in svx
Change-Id: Id08850b90a0e286ff837dd6b0c1691fa7dc793fa
Reviewed-on: https://gerrit.libreoffice.org/28746
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09 06:43:43 +00:00
Noel Grandin
976a4803e4 disallow calls to ::Create in VclPtr subclasses
where it can be actively dangerous, if the calling code thinks it's
creating a ScopedVclPtrInstance, and it actually only gets a VclPtr

Change-Id: I638b28207d60e8fc4ca3d31000c0735d06ce2eb3
Reviewed-on: https://gerrit.libreoffice.org/28714
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09 06:37:40 +00:00
David Tardon
0f9a81c8f5 remove manual memory management
Change-Id: I07960df50645fb77b24eaad4a60f93b715cbb6a9
2016-09-09 07:30:30 +02:00
David Tardon
6678ff2e84 improve comment
Change-Id: I475902aa68b426ce27782ed80f45344b57eadd9c
2016-09-09 07:30:30 +02:00
David Tardon
084de9dda4 remove manual memory management
Change-Id: Ic715adae42ff34be892d19802629aa50077dc120
2016-09-09 07:30:30 +02:00
David Tardon
7dd877b4be remove manual memory management
Change-Id: I218784e052ee4d7b9a64ac54cdfaa0f8d08aacad
2016-09-09 07:30:30 +02:00
David Tardon
c6a6513743 use std::unique_ptr
Change-Id: I352e542de656d22963eb872f79b40e20008d0a32
2016-09-09 07:30:30 +02:00
David Tardon
516992ec6e remove manual memory management
Change-Id: Ice48916fc9841a29b3a02997375347c7b605effe
2016-09-09 07:30:30 +02:00
David Tardon
73f32870cf use std::unique_ptr
Change-Id: I3cbe6058cd0d1bccb786866a6adf4859424e36ab
2016-09-09 07:30:30 +02:00
David Tardon
655b94643c remove manual memory management
Change-Id: I3f5259ac7cf099a5d03d95a7e9132cc8cb6d0734
2016-09-09 07:30:30 +02:00
David Tardon
4bda91ca86 use std::unique_ptr
Change-Id: I26ab9b4fa441fcbcce8eb013a1d7dce5c8591b6d
2016-09-09 07:30:30 +02:00
David Tardon
a363175cfc remove direct memory management
Change-Id: I9c7d53a9cfd5c03e1551626a96cdaa30fc4e546b
2016-09-09 07:30:30 +02:00
David Tardon
a66933a890 use std::unique_ptr
Change-Id: I5128b3e950657f3fe6fc71a8de56c9dd87ac2324
2016-09-09 07:30:30 +02:00
David Tardon
91c8bec906 remove direct memory management
Change-Id: I269d42704004f2d6e620fedc82a27e7982ecda23
2016-09-09 07:30:30 +02:00
David Tardon
7977914ae7 remove direct memory management
Change-Id: I9ab3fccd5b8a0cc64bfe7b70ed7a3e36d0e58a33
2016-09-09 07:30:30 +02:00
David Tardon
3ef084c9bd remove direct memory management
Change-Id: Id0278f15e0c46a32cf07900dffdf27b3acb2649c
2016-09-09 07:30:30 +02:00
David Tardon
4f776e0ff2 drop useless comments
Change-Id: Idbecb59bbefb4e63e1de80b8a28033be31e3dd58
2016-09-09 07:30:30 +02:00
David Tardon
4da3d1e3d7 fix indentation
Change-Id: I0292b9408b0ff74f133daba955a81d9ac706b336
2016-09-09 07:30:30 +02:00
David Tardon
45df4baf4e use std::unique_ptr
Change-Id: Ic6ebe839fa22e6a7b9904ad00877eddd78331ba4
2016-09-09 07:30:30 +02:00
David Tardon
bb35e4dcf9 remove direct memory management
Change-Id: I5dd5d9130f11f47c4b48c1aae9748434ac751d95
2016-09-09 07:30:30 +02:00
David Tardon
8b229333ae fix indentation
Change-Id: I7f2bf5b4ee507cd50904a193bfd64b293cbdd922
2016-09-09 07:30:30 +02:00
David Tardon
d0d596fc73 drop useless comments
Change-Id: I0493541da0d444ab94676365e93d4e0e5712bbea
2016-09-09 07:30:30 +02:00
David Tardon
db77b0c691 use std::unique_ptr
Change-Id: If5e2e9a47480cca5fea09f96e876aece9cb21f9e
2016-09-09 07:30:30 +02:00
David Tardon
5b010b43d7 remove direct memory management
Change-Id: I15823666ce8ea1840dc7b927d1a6f2f810edf2d2
2016-09-09 07:30:30 +02:00
David Tardon
6c28509928 remove direct memory management
Change-Id: I9696b1c0ffe100c8089494197940377d3c6223f5
2016-09-09 07:30:30 +02:00
David Tardon
e501c39a48 remove direct memory management
Change-Id: I5857df56c782131a5849417f69067e6481fd6f6f
2016-09-09 07:30:30 +02:00
David Tardon
1e8140083d remove direct memory management
Change-Id: Ie5103347fc30095778d96d46ce702bf4f0da00a6
2016-09-09 07:30:30 +02:00
David Tardon
32ccb4ea86 resolve the snafu with 2 separate refcounted bases
Change-Id: Ia275596d54ea27436f03d01297fb78b6ca09e8a6
2016-09-09 07:30:30 +02:00
David Tardon
a013b85055 upload libzmf 0.0.1
Change-Id: I706d454226d17fe1386c876782f6ad2843f17197
Reviewed-on: https://gerrit.libreoffice.org/28718
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
2016-09-09 05:29:27 +00:00
Maarten Bosmans
6cf44da039 Related: tdf#100709 Add unit test
This tests for the two bugs fixed in d16070a3.

Change-Id: I453fc603ca98895c56c6e8df6315b8d1ea96bfde
Reviewed-on: https://gerrit.libreoffice.org/28734
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-09 01:31:04 +00:00
Zdeněk Crhonek
4a751b1191 add F.DIST.RT test case
Change-Id: I8afc84c7e397061f9794985d3ffca54d81713fdc
Reviewed-on: https://gerrit.libreoffice.org/28645
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-09 00:00:16 +00:00
Zdeněk Crhonek
138d4fe2b6 add F.INV.RT test case
Change-Id: I7ef191f8665921b194efbe26e99e544be7243a65
Reviewed-on: https://gerrit.libreoffice.org/28643
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-09 00:00:08 +00:00
Zdeněk Crhonek
9b3699b3b8 add F.DIST test case
Change-Id: I85ab3fab1fc1c7bd709befb269a60e90aa33e66d
Reviewed-on: https://gerrit.libreoffice.org/28647
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-09 00:00:02 +00:00
Zdeněk Crhonek
1ec04556c9 add ERF.PRECISE test case
Change-Id: I1d6e4bedd63800f7070e1d4b1e4bbeeaba8e0fcf
Reviewed-on: https://gerrit.libreoffice.org/28639
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-08 23:59:55 +00:00
Zdeněk Crhonek
ed1dc7bcd8 add F.INV test case
Change-Id: I49cbe991ccbca0a4a420ad19c26cf4681d4d60a8
Reviewed-on: https://gerrit.libreoffice.org/28646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-08 23:59:49 +00:00
Zdeněk Crhonek
3d1391e05a add INDIRECT test case
Change-Id: Ifcfcf47dd22560a1e6abdd393e9712ec68a4d5e6
Reviewed-on: https://gerrit.libreoffice.org/28638
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-08 23:38:05 +00:00
Zdeněk Crhonek
d6c6b9764f add EXPONDIST test case
Change-Id: I47ce7ff494484d4cbf2dbb0505c3d98d8640d72b
Reviewed-on: https://gerrit.libreoffice.org/28644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-08 23:37:56 +00:00
Yousuf Philips
2846aae8fe tdf#92218 Implement Impress single toolbar mode toolbar
Change-Id: I38c5b6a85c63da55be1382dc4e6ad42a22d33f26
Reviewed-on: https://gerrit.libreoffice.org/28741
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-09-08 22:45:38 +00:00
Yousuf Philips
191b4d9644 tdf#91820 Add Insert > Form Control submenu into Calc
Change-Id: Id5271b9eed490c70f5969a20642ff8b0c2393170
Reviewed-on: https://gerrit.libreoffice.org/28740
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-09-08 22:12:50 +00:00
Gabor Kelemen
8dc38d9ded Remove obsolete OxygenOffice bits
Since 77104ccd76 the OxygenOffice
distro configs are removed and no other official distro uses these.

Change-Id: I2b4d5fea7e4b9098ac88733821af219db23c48fe
Reviewed-on: https://gerrit.libreoffice.org/28738
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-09-08 21:20:58 +00:00
Mike Kaganski
ba18832cee tdf#75221: make margin collapsing implementation conform OASIS proposal
Since the margin collapsing (aka contextual spacing, implemented
for LO 3.6 by Miklos Vajna, commits
6f04bf5e90,
0662778b0b,
1105933171,
03f9b6bebc,
8631dbf85f,
9f4bb5bd4f,
f722299e13) is only meant
to suppress fo:margin-top and fo:margin-bottom, as seen in
https://issues.oasis-open.org/browse/OFFICE-3767, current
implementation is inconsistent: it nullifies all spacing, including
normal line spacing.

This patch makes sure that collapsing conforms to specification.

Change-Id: I413f6469d7891dd85f1f7a2c666f219187ddaec4
Reviewed-on: https://gerrit.libreoffice.org/28692
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-08 21:08:56 +00:00
Caolán McNamara
d45d8ae3c5 Resolves: tdf#101881 gtk3 3.18 menubar doesn't grab keyboard...
the same way gtk3 3.20 does with gtk_grab_add, so on gtk_menu_shell_deselect
the keyboard focus doesn't remain in the menubar.

bisecting gtk itself I find...

commit 5cbbb90e311d95192d1b68ba89c3190cdb652868
Author: Carlos Garnacho <carlosg@gnome.org>
Date:   Thu Nov 26 19:54:31 2015 +0100

    GtkCellRendererAccel: Use gdk_seat_grab()

    https://bugzilla.gnome.org/show_bug.cgi?id=759309

is the commit that makes it do what I want, so add an extra
gtk_grab_add/gtk_grab_remove around our entry and exit of the menubar

Change-Id: I5bf09834b4e1a14d30403208d03b3abd28a382a8
2016-09-08 22:02:06 +01:00
Caolán McNamara
bcf8f87889 remove IMAGEROTATION and IMAGEREFLECTION SfxSlotMode enums...
unused since...

commit 7affe26a12
Author: Maxim Monastirsky <momonasmon@gmail.com>
Date:   Mon Feb 22 18:47:15 2016 +0200

    Kill sfx2 menu support

Change-Id: I902957b8379be7c314f5357750aeba5a2fcc0a00
Reviewed-on: https://gerrit.libreoffice.org/28749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-08 21:01:31 +00:00
Maxim Monastirsky
d704c2b95e Wrong command for shape name
Change-Id: I99719229fe58233053ce39aa3f07b0d112b32bd7
2016-09-08 23:50:16 +03:00
Miklos Vajna
a7b0cd1411 sw: remove qa/tiledrendering/tiledrendering.cxx again
It was first removed in aa94466699
(Executable_tiledrendering is obsolete and can be killed, 2015-03-24),
and then it was re-introduced with
00f2787a4a (vclwidgets: wrap all
vcl::Window subclasses allocated on stack in VclPtr, 2015-04-09) due to
a mismerge.

Change-Id: I243375d6a8d7804ed23f2080d2dbb3c0132789f1
Reviewed-on: https://gerrit.libreoffice.org/28747
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-09-08 20:37:43 +00:00
Maxim Monastirsky
28ffa3e2ab Unused strings
Since 7affe26a12
("Kill sfx2 menu support").

Change-Id: Ib08ba64e7d3dc479df15f04f4e9ab81e13611202
2016-09-08 17:20:02 +03:00
Justin Luth
3870c0555a tdf#81345 docx import fix default page break regression
"regression" from 4e653d15ef

If there are new style elements, then don't treat a
default break in columns as a continuous break.

This fixes both round-tripping, and initial import of
columns and headers on this particular document. Since
MS and LO treat sections so differently, it is a balancing
act of what to change.

Change-Id: I9c79bc1246108da6a5ebbf744acbcfcbb9d33d48
Reviewed-on: https://gerrit.libreoffice.org/28728
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-09-08 12:57:26 +00:00
Noel Grandin
0f8a303186 loplugin:constantparam in sw
Change-Id: Ibae4cac28e6ff52298c804519f683017729c07a5
2016-09-08 11:47:19 +02:00
Noel Grandin
ac1c3f2ab6 more workaround lack of constexpr
Change-Id: I1be117f9845d502d4b8dfa238dc13198f8b76dd6
2016-09-08 11:41:22 +02:00
Noel Grandin
4e5ec21c51 workaround lack of constexpr
when dealing with switch statements and o3tl::typed_flags

Change-Id: Ia72a3ff643ea1c41f9b328e980ba51f3cdfdf582
2016-09-08 11:30:35 +02:00