Commit Graph

389158 Commits

Author SHA1 Message Date
Stephan Bergmann
7024c86b17 Extract checking code to its own check.cxx
Change-Id: I9d5b14c374ce62ac7b970faa30c38a5a76568ed4
2016-03-08 21:37:42 +01:00
Marco Cecchetti
6651aca57b tdf#98052 - even polygons were not drawn on the alpha device
Change-Id: I5725ec23869b295c8021bef0330ee6f69f206351
Reviewed-on: https://gerrit.libreoffice.org/23024
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-08 20:23:13 +00:00
Eike Rathke
0947c9be4d Revert "tdf#98403: UGX Currency is "Uganda" not "Ganda""
This reverts commit 42032f5d3b.

langtab.src lists language/locale names!
2016-03-08 19:40:48 +01:00
Eike Rathke
6f6c21ad91 Revert "tdf#98403: "Ugandan" is better than "Uganda""
This reverts commit da75a89925.

langtab.src lists language/locale names!
2016-03-08 19:40:46 +01:00
Dennis Francis
7c0f6b9d0f tdf#94561 : Create notes drawing objects only once on sheet copy
Skip copying notes in CopyToColumn() and then
call CopyCellNotesToDocument() only after copying hidden rows
and filtered rows info. Skip copying notes drawing objects
in ScDocument::DrawCopyPage() when inside ScDocument::CopyTab().

Change-Id: I38296bb5d1cc062d473ea4a5a3143f6c1787fc4a
Reviewed-on: https://gerrit.libreoffice.org/22331
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-03-08 18:06:09 +00:00
Eike Rathke
10f048bafa unit test for tdf#98389 huge external range reference matrix
Change-Id: I838421dc6e15baea5f209d1b096509742dea58dc
2016-03-08 18:43:47 +01:00
Wastack
7218090791 tdf#97966 Drop static keywords from two functions inside an unnamed namespace
Change-Id: I4fca1e813eccfeb5185e7a50aa301e7ad1ee61b5
Reviewed-on: https://gerrit.libreoffice.org/23015
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-08 17:31:16 +00:00
Miklos Vajna
32c2a2f8dc sw: detect copy&paste between different classification levels
With this we cover all 4 cases of copy&paste between possibly classified
documents. When both are classified, then we also check the
classification level, if they have the same scale.

Change-Id: I8c02781fc9755114cd6a2fb93be11dca7b3441d0
2016-03-08 18:19:12 +01:00
Miklos Vajna
740a72e66d sfx2 classification: expose impact scale and level
This allows application code to prevent copypaste from a more
confidential to a less confidential document.

Change-Id: I121c7566c948340e7b41d3f8462b0d65a2441b0f
2016-03-08 18:19:12 +01:00
Stephan Bergmann
1316543eb8 TODO: Work around loplugin:salbool in cppu/source/uno/data.cxx for now
Change-Id: I1730c09669426e049aba941ef27341581ce31887
2016-03-08 18:16:58 +01:00
Stephan Bergmann
c94f5b0260 loplugin:cstylecast
Change-Id: I3771f84ec94c62988c075dd26ee1de17200af705
2016-03-08 18:16:18 +01:00
Stephan Bergmann
c2fe73d6a9 Remove redundant checks (that trigger loplugin:implicitboolconversion])
Change-Id: I86c0b56b7d330e3e3450a5806a89ca8fb7a1bfae
2016-03-08 18:15:52 +01:00
Rohan Kumar
05bca56923 tdf#91794: Remove OSL_DEBUG_LEVEL > 1 conditionals
Updates pointed by sberg

Change-Id: Ie12548dfa9ad3a6836efbfe64153bc075f138fc6
Reviewed-on: https://gerrit.libreoffice.org/22622
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08 16:57:42 +00:00
Chirag Manwani
b38f58a3f9 tdf#97703 Removed empty setUp/tearDown methods
Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5
Reviewed-on: https://gerrit.libreoffice.org/22985
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08 16:54:50 +00:00
Caolán McNamara
68b5875647 convert custom bibliography toolbar to .ui format
Change-Id: I70eb0e2ff96879d1168b241852a0079f540b0319
2016-03-08 16:23:45 +00:00
Caolán McNamara
f14e5f5dea Updated core
Project: help  7d13cf69810e9a6ea8ab42bbf943d9a708e66fc6

update help ids for bibliography toolbar conversion

Change-Id: I3059a98f6ad79f413395550bc1a270a5396decf3
2016-03-08 16:23:11 +00:00
Steven Guo
5819268ad7 tdf#94306 Replace boost::noncopyable with plain C++11 deleted copy ctors
Replaced boost::noncopyable with plain C++11 deleted copy ctors
in /basic/* files.

Change-Id: I9c0eb0a51ec5cb25c88c72b55f42864e73006e6b
Reviewed-on: https://gerrit.libreoffice.org/22969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-08 16:10:46 +00:00
Stephan Bergmann
b9a25b254b Various loplugin warnings
Change-Id: I7a405bc22d6ff337d53ad2c187f2ae1726798bb5
2016-03-08 17:08:34 +01:00
Takeshi Abe
7fd9579c36 starmath: Use assert for impossible null-dereference
Change-Id: I3a0e78985470f210dd093dce3e87671980e647f4
Reviewed-on: https://gerrit.libreoffice.org/23016
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-08 16:07:38 +00:00
Samuel Mehrbrodt
16fb0d3d0f tdf#98407 PathSubstitution: Add substitution for $(username)
This allows to use the username as a placeholder in the config paths (Autotext, Gallery, etc)

Change-Id: I76434e980cd8ec8785a5587d0bc5fdd67dc42de2
Reviewed-on: https://gerrit.libreoffice.org/22901
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08 15:35:54 +00:00
Stephan Bergmann
f9ddda3538 Remove ornamental noise
Change-Id: Ic8d33142b6bd7d271e94ec93661f0260bb2ea6e2
2016-03-08 16:12:01 +01:00
Stephan Bergmann
2ed1b3e0cd Keep entries sorted (and no need for a @section here)
Change-Id: I356a6bde62d883adf4cfa9e34e87791eee9668ca
2016-03-08 16:09:09 +01:00
Stephan Bergmann
a3fd689663 Remove unused macros
Change-Id: Icc1f5dbe7bac1d80429cafda7e88061193dd137a
2016-03-08 16:05:22 +01:00
Stephan Bergmann
987626ee94 Remove dead code
Change-Id: Iebaf8af5dbf11cd255f67202bbb18f61b1bd39fd
2016-03-08 16:03:49 +01:00
Stephan Bergmann
07c514662a Remove unnecessary include
Change-Id: I5a0b1528a7ad3cff15d185600d4bd74c25fb30bb
2016-03-08 16:02:49 +01:00
Maxim Monastirsky
6b879eefa7 Unused define
Change-Id: I3f0218ad6fec542d285bfbfdd2d508375f74dee5
2016-03-08 16:32:34 +02:00
Michael Stahl
466c03f956 Revert "tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals"
In a build --with-lang=2 languages this generates millions of lines of
output, it prints for > 2 minutes straight.  Our build system is not a
terminal benchmark, and i have no idea what the problem with
"OSL_DEBUG_LEVEL > 1" conditionals is anyway, so revert it for now.

This reverts commit 3f80f144cf.
2016-03-08 15:20:24 +01:00
Katarina Behrens
291e00bb43 Don't leak docshells
Change-Id: Ifc19a005925342865384fa7bd189bba929c58d28
2016-03-08 15:17:11 +01:00
Tor Lillqvist
56f9a64899 Remove spurious \r from OSL_TRACE output
Change-Id: I84f34f25a5d0deb6a23c233b981daacea4fe9d33
2016-03-08 16:10:19 +02:00
Michael Stahl
07d4c443e2 sc: remove unnecessary orcus external usage from makefiles
This caused incremental builds to fail after today's orcus upgrade.

The cxx files of these tests don't actually include orcus headers, so
the libraries were not re-linked in incremental builds.

Change-Id: Ibfcf216a7848f3c0adfae4ef59c4b756c290d6b2
2016-03-08 15:05:31 +01:00
Stephan Bergmann
29cb1f1923 Remove ancient StarPortal leftovers
No UNO bridge has a "user" token in its description anyway, so
needsSecurityRestrictions always returned false.

Change-Id: Ibc3aa25212a2e8b245c13578fa29582be42791e6
2016-03-08 15:06:39 +01:00
Rohan Kumar
6326d76101 tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionals
Updates pointed by Sweet5hark

Change-Id: I747e92ca9ee39a027b1e9b27b131f249a33b77db
Reviewed-on: https://gerrit.libreoffice.org/22980
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-08 14:06:04 +00:00
Rohan Kumar
ea3151acb4 tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals
I replaced OSL_DEBUG_LEVEL > 1 to OSL_DEBUG_LEVEL > 0 in most of
the files as suggested in easy hack

Change-Id: I2c46dfd9de2ae965680494146120ea3c7530cc98
Reviewed-on: https://gerrit.libreoffice.org/23012
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-08 14:00:30 +00:00
Stephan Bergmann
5c1234eac2 loplugin:nullptr
Change-Id: I0c78ddab5efb7a295ccf42b6539b5aa3b7009bf9
2016-03-08 14:43:11 +01:00
Rohan Kumar
576ab77255 tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionals
I either replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0
statements or i used SAL_INFO(..)s

Change-Id: Iefb6b83e86e1767e55600b6e1989ee91207fb220
Reviewed-on: https://gerrit.libreoffice.org/23000
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-08 13:31:09 +00:00
Rohan Kumar
26b69a9d0f tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionals
I removed the fprintf statements and replaced them with
SAL_WARN statements.

Change-Id: Id75e310e3a95b249fdf92a4dd5a9bcf1b7fb9be6
Reviewed-on: https://gerrit.libreoffice.org/22984
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-08 13:29:14 +00:00
Rohan Kumar
856cf7115d tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionals
I removed OSL_DEBUG_LEVEL > 1 conditionals in order to
reduce debug levels.

Change-Id: Ia1890277aec8ba0b57e325564a107d7fe2f6e967
Reviewed-on: https://gerrit.libreoffice.org/23008
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-08 13:26:47 +00:00
Rohan Kumar
3f80f144cf tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals
I removed OSL_DEBUG_LEVEL > 1 conditionals, replaced them with
OSL_DEBUG_LEVEL > 0 as suggested in updated easy hack

Change-Id: I4af8cd2a9bf9980fc98967d499d1fc30642251f4
Reviewed-on: https://gerrit.libreoffice.org/23010
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-08 13:25:57 +00:00
Yeliz Taneroğlu
df750471d7 tdf#74608 comphelper: Constructor feature for InstanceLocker
Change-Id: If2c597d56d4dde74ec8361b74bdd1933f42afa4b
Reviewed-on: https://gerrit.libreoffice.org/22940
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08 13:25:01 +00:00
Caolán McNamara
9c72eca1fb need stdexcept
Change-Id: I008591c9d64a99939237e267b9ef6f28b2ef7964
2016-03-08 12:41:09 +00:00
Miklos Vajna
ad5427c03c sw: detect copy&paste from classified to non-classified documents
It still allows copy&paste between different classification levels,
though.

Change-Id: I142b6c2ab752a5b786fe6a16e29a89e549254d0f
2016-03-08 13:36:43 +01:00
Caolán McNamara
f16ceae46d avoid infinite regress in busted documents
Change-Id: I639617e41cd9a9a51a3dd3efa32ac1cf2991b9d2
2016-03-08 12:10:18 +00:00
Winfried Donkers
08306201bc tdf#94635 synchronise argument labels in function wizard with
used labels in the help text.
(See tdf#97021 for help text.)

Change-Id: If4812ee71806233c9e33ae904aa2c80b8bc4e3b5
Reviewed-on: https://gerrit.libreoffice.org/22978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-03-08 12:03:47 +00:00
Maxim Monastirsky
6d2db6cf7c Move anchor submenu to separate popupmenu file
Objectives:

- Reduce copy-paste, by defining the list of commands
  only once, and reusing everywhere (menubar, context
  menu, toolbar button).

- Kill SwTbxAnchor. Once we have separate popupmenu,
  we can just load it with the generic controller.

Change-Id: I5a8b47892471e293ee2331915361f8ce256dc76c
2016-03-08 13:53:46 +02:00
Noel Grandin
2600220f53 loplugin:constantparams in vcl
Change-Id: I2114436f4bef3ac71a3035a206186cefaf88bca1
Reviewed-on: https://gerrit.libreoffice.org/23023
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-08 11:45:47 +00:00
Noel Grandin
7f40ed57eb loplugin:constantparam in xmloff
Change-Id: I531dcf0861ab5a545eec16bf4aa92ac92eb9626e
Reviewed-on: https://gerrit.libreoffice.org/23022
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-08 10:37:11 +00:00
Eike Rathke
9cae3a8858 setCellRangeData: check matrix size before operating, tdf#98389 follow-up
Now that we can have the one element error matrix we can't blindly call
ExecuteOperation() on it that would access elements out of bounds.

Change-Id: Ib6e5525f685c9324235f128a943dd716ea7a3fca
2016-03-08 11:11:48 +01:00
Caolán McNamara
e82e698526 building against 110 different operation system variants is a pain
Change-Id: Icbb9e2590f1b8b18c021b978baf7f79c838c4c9c
2016-03-08 09:13:56 +00:00
Miklos Vajna
078c00e3a3 tdf#97601 sw: don't mark an already modified chart as modified
Regression from commit e2b260fc98 (sw: let
layout not mark embedded object as modified, 2014-06-03), an infinite
loop was caused by:

1) SwDoc::SetOLEObjModified() triggering the maOLEModifiedIdle Idle
2) which at the end called SwWrtShell::CalcAndSetScale()
3) which at the end called chart::ChartModel::setModified()
4) where chart code called back into SwDoc::SetOLEObjModified() via the
modification listener, and this happened again and again.

The original fix wanted to avoid marking the document as modified
without a user interaction, so fix the bug by only calling setModified()
if it prevents a not-modified -> modified transition. This keeps the
original bug fixed, but prevents the infinite loop, that is always a
modified -> modified transition.

Change-Id: I3b56a91afaacd3e0b7cb646a492fd15f1b5168ee
2016-03-08 10:01:00 +01:00
Tor Lillqvist
fcd8844cb0 Bin unneeded inclusions of dbggui.hxx
Change-Id: I5cac6fb0278e3952e2538f06188ed510644fcaa0
2016-03-08 10:23:15 +02:00