Why should clicking on a frame/image in a header act any differently from
a one insde the text body?
(The only time frames (or any kind of fly) required a double click occured
when switching from inside a header to a body-fly or from inside the body
to a h/f-fly. This patch removes that oddball corner-case.)
Now all frames are handled with a single click and there will not be
an impact on double-clicking anymore.
regression caused by 7e2f98d0a0 and its
prior commit which say:
> Header/Footer: fixed click on frames over the header/footer area.
> The main problem here was due to the click to show the separator when
> there is no header or footer under the frame. That code was just exiting
> MouseButtonDown too early, which isn't good.
> Now, double-click actually selects a frame anchored in header/footer.
confirmed that single-clicking on frames over the header/footer section
still shows the header blue-line.
Change-Id: I4770cfe7898202929742743931e22de8bf233b03
Reviewed-on: https://gerrit.libreoffice.org/30693
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
This is especially needed, as we don't bother compressing updated
objects into sections on signing, we simply use a separate section for
each updated object.
Work towards supporting xref streams and incremental updates at the same
time.
Change-Id: Ie9759edbba816991615fafc6602cdd440141b989
and account for the libreofficekit changes
This reverts commit 50e9065cbb.
that did in turn revert 4ae8c3c20b.
Change-Id: Ie02d8743b3608120ed63bfe2a014fa4139577b01
cause of the reported regression, it seems extradinary that this
would cause that, but it seems to be the case and I have no interest
in debugging the undebuggable scheduler.
This reverts commit 180a0eac23.
This can happen when the group calculation is disabled and falls
back to non-group calculations. And we only care about the first
entry in case of non-group calculation of grouped cells.
Change-Id: I545980acf8e35b4d0504aa2a77f86bdc85799e29
Reviewed-on: https://gerrit.libreoffice.org/30738
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
android studio/sdk manager doesn't provide a default way to install
multiple versions of the NDK, so typically only the latest one will be
available. Don't make configure error out in this case, but print a
warning instead.
Change-Id: I6af9a3f088daf7d12ebd9910286d7f44d264014a
Project: help 02139162f541bb56ddbaf0a2d6142256a0454372
digital signatures: briefly document OOXML/PDF signing effort
It may be unexpected for users to see that OOXML files are always only
partially signed.
Change-Id: Ie7c6c553580a4eb38ed72c8a50b75f4b7902613f
...seen a failure of JunitTest_sc_unoapi_3 with
> checking: [sc.ScDDELinkObj::com::sun:⭐:util::XRefreshable] is iface: [com.sun.star.util.XRefreshable] testcode: [ifc.util._XRefreshable]
> LOG> Execute: refresh()
> LOG> starting required method: addRefreshListener()
> LOG> Execute: addRefreshListener()
> Method addRefreshListener() finished with state OK
> LOG> addRefreshListener(): COMPLETED.OK
> warn:unotools.misc:30768:84:unotools/source/misc/mediadescriptor.cxx:690: caught Exception "" while opening <file:///data/lo/core/sc/qa/unoapi/testdocuments/ScDDELinksObj.ods>
> warn:filter.config:30768:84:filter/source/config/cache/typedetection.cxx:455: caught Exception "Could not open stream for <file:///data/lo/core/sc/qa/unoapi/testdocuments/ScDDELinksObj.ods>" while querying type of <file:///data/lo/core/sc/qa/unoapi/testdocuments/ScDDELinksObj.ods>
> Method refresh() finished with state FAILED
and it appears that all of sc.ScDDELinkObj, sc.ScDDELinksObj, and
sc.ScIndexEnumeration_DDELinksEnumeration try to open that file (necessarily for
writing?), and the first two are in JunitTest_sc_unoapi_3 (so are executed
sequentially), but the last one is in JunitTest_sc_unoapi_4 (so may be executed
in parallel with the others), so that may be the reason for such sporadic
failure. Easiest workaround appears to be to move the third test into the same
JunitTest as the other two...
Change-Id: Iefb94cf657bdc9c1eac92dd49ee6257eb5e80905
With this our xref stream output is close enough to Acrobat so that the
existing signature verifier runs without any problems.
Change-Id: I6eca7966890365759c269b465e4bf4d86d335219
...as that, somewhat surprisingly, causes 'make MODULE.all' do additional
targets that a plain top-level 'make' would never do. See discussion in mail
thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2016-November/075797.html>
"[Libreoffice-commits] core.git: Branch 'feature/dialog-screenshots' [...]".
Change-Id: I460f3c91cf00d3398c61833fdcd5eaebdc87fbf2
Its last user was
writerfilter::dmapper::DomainMapperTableHandler::getTable(), removed in
commit 6ea66657eb (loplugin:unusedmethods
writerfilter, 2015-07-20).
Change-Id: Ibaf536d4dd8f01f4413c3cec033db7438501e58c
Project: help 368c92d82e25d61746808d38afd3d5049f9bfe84
Remove one more dead plug-in menu item description
Change-Id: I5be88980aa527e5d03d4fcfd54dfd520a0b7b162
Reviewed-on: https://gerrit.libreoffice.org/30736
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Project: help 9f5f37dfe07c69e090d7b1cacfd56de91689834e
Remove embeds of the description of the Edit - Plug-in menu item
Change-Id: I57c83a56de0fe124f168adbcb7c4a3fdbd45d60d
Reviewed-on: https://gerrit.libreoffice.org/30734
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Project: help 42dcc36e303f8b7a5d534fb3163e5c2a647560a3
Remove a page about plug-ins
This feature was dropped from 5.2
Change-Id: Ia2721ac34c816e11c1ce3982c604bb7af01c6da4
Reviewed-on: https://gerrit.libreoffice.org/30732
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Drop useless typedef and use more general nomenclature as I’m going to
extend this in the next commits.
Change-Id: I12aa01fe9f5a6c9aca67f850f36b81661ee14913
Previously we used a symetric image to test JPEG import. This has
the flaw that we doesn't warn if the orientation of the JPEG
image was not correct. This commit fixes this flaw by making all
test images non-symetrical.
Change-Id: If87d257ae44d85b6a9042d09d62ba785ffc5c426
Reviewed-on: https://gerrit.libreoffice.org/30709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
So that when we have a single signature with ID="Signature2", then we
use "Signature3" for the next ID, not "Signature2". (Acrobat uses that ID
for the first signature.)
Change-Id: I7032fbf014184da2a5be24730a92abc32a9a1258
Reviewed-on: https://gerrit.libreoffice.org/30725
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
In case the input document used a PDF 1.5 xref stream, not an old xref
table, then write that as part of the incremental update. Acrobat seems
to require this.
Change-Id: I9f1f73140c26308f8720aa1ffe1b905d0e60ede0
Reviewed-on: https://gerrit.libreoffice.org/30724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Normally it's a direct dictionary, but it's OK to have it as a reference, and
then the referenced object is a dictionary.
Change-Id: If09edaf23501883be68148e430c42e721ec68247
Reviewed-on: https://gerrit.libreoffice.org/30719
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Sure, using a namespace means we have to decorate each function with the
XMLSECURITY_DLLPUBLIC, but who cares.
Change-Id: If9a364d1be9c5f4cd02f3f146e8b01bd608b373e
The password-to-modify misfeature does not actually provide any
security, but it may induce users to re-use passwords, so at least make
it harder to crack the passwords.
Change-Id: I0adf0e8e11b222fc469013e17a2695bd7122ad01
Given recent elections we need to build a higher wall to keep the
government out of our documents, and we will make the government
pay for it.
These iteration counts were considered appropriate a decade ago.
http://security.stackexchange.com/questions/3959/recommended-of-iterations-when-using-pkbdf2-sha256
We get similar numbers on SandyBridge-E desktop and Haswell i7-4600U laptop:
* with 10k iterations ~20 msec per derivation
* with 100k iterations ~195 msec per derivation
* with 150k iterations ~290 msec per derivation
We can't go too high though because in ODF every package stream gets
its own derived key with a different salt, so a document with embedded
images may need a lot of these.
Change-Id: I6894e71ed399f8c340eff97a9191c8d8419789a6
