... so admit that the VclPtr that ChartController used to have is really
owned by m_xViewWindow, and get fetch that (stack-scoped only) from
there.
Change-Id: Ib9e2cd20201ebe5019c3607a8c65cb1a9856812f
Reviewed-on: https://gerrit.libreoffice.org/35603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
...esp. when they dont even need it.
Change-Id: If9d00da3110328d88e832f12b8717a93f91393aa
Reviewed-on: https://gerrit.libreoffice.org/35602
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
The only place this function is called (SvxMSDffManager::ImportGraphic,
filter/source/msfilter/msdffimp.cxx) it is passed the sal_uInt32 return value
from a call to DffPropSet::GetPropertyValue, so that seems a better type.
(SvxMSDffManager::ImportOLE used long at least since
d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter";
DffPropSet::GetPropertyValue used UINT32 back then, changed to sal_uInt32 with
e8c2c1daae9008d383288f94600b1d34d2059fb1 "removetooltypes01: #i112600# remove
tooltypes from filter". Unclear if those had ever had more compatible types in
the distant past.)
Change-Id: Ia486d169cd2cc0e73042e72fd4476cc2ae0e8cc5
...esp. when they tend try to own our private parts.
Lets be honest here. Also remove pointless repeated private:s.
Change-Id: Idaa7621fbe812ef25f13bba1882a16cca4de9d61
Reviewed-on: https://gerrit.libreoffice.org/35600
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
...esp. when they tend try to own our private parts.
Lets be honest here. Also remove pointless dynamic_casts.
Change-Id: Ie6ef8a0c07a72aaa15e374e5ec6841520c0fafb1
Reviewed-on: https://gerrit.libreoffice.org/35599
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
and rely on new safe multiple check of
commit 4f0b226600fdad4e5aef9313fe8754c765cfee42
Author: Caolán McNamara <caolanm@redhat.com>
Date: Tue Mar 21 11:23:09 2017 +0000
check for overflow in multiply
rather than trying to detect them here in advance
Change-Id: I7fb9a9960e428cf00f745b6156a588e2c990c03f
Reviewed-on: https://gerrit.libreoffice.org/35595
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Since we want to avoid re-compressing the page stream create two form
XObjects: one that resets the graphic state to the default (e.g. line
width) and an other one that contains the original page stream as-is.
With this PDF images where the page stream is compressed are handled
correctly.
Change-Id: Ib44dae2e167e4d5604a0a3a3cf91e09795137343
This was added because CPPUNITTRACE='"$(DEVENV)" /debugexe' is less
convenient to write than CPPUNITTRACE='$(DEVENV) /debugexe'.
However DavidO points out that CPPUNITTRACE=TRUE is even more
convenient and sort of optimal already, and it turns out it's broken by
the extra quotes, so remove the hack.
Change-Id: Ic5d94f9a0774cd41821b68728404c205552d674e
Reviewed-on: https://gerrit.libreoffice.org/35589
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: Jenkins <ci@libreoffice.org>
cause I can get no traction with gnome#779143 to allow changing wayland
app_ids for windows, so might as well bodge something to make us look
less pathetic than the broken app icon
Change-Id: I9810ba4908dd06a2fdbb2e58e7ad6ff4978ddd43
and avoid skipping following tokens too much. This also saves
unnecessary stack operations.
Change-Id: I4f30be73a615341b2b3de70f2c8f3dd5c2f85910
Reviewed-on: https://gerrit.libreoffice.org/35583
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
This gives correct result in very simple cases when the page stream is
not compressed and it references no other objects from the original
file.
Change-Id: I11ed50180a256bdb5c587fd8927d21c925100a4d
Reviewed-on: https://gerrit.libreoffice.org/35580
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
and fix a bug in ScChangeActionContent::SetValueString where it was
passing the grammar as the ScMatrixMode to the ScFormulaCell
constructor.
Change-Id: I7c1a174cdd8365dedc30cff0b26e3079bb8b84f3
Reviewed-on: https://gerrit.libreoffice.org/35552
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Unused since commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae
"update unusedmethods plugin to deal with constructors"
where I removed a unused SfxDockingWindow constructor.
And in that case, the helpid was only being used to assign
the window a UniqueId.
Change-Id: I148e424424fcf08449440b83a8600071b39d7a07
Reviewed-on: https://gerrit.libreoffice.org/35554
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This reverts commit 646cbbfbc67b07d5f58166228bca1ac710175cd0 for now. Appears
that it made CppunitTest_sal_osl fail at least on some macOS builds, for reasons
not yet clear to me
(Though some deficiencies remain, e.g. when values are assumed to be valid
characters and not eof().)
Change-Id: Ia5ec681a68086e9843206a6b44a44f8ec3800b88
We should always be clear and precise, given that LibreOffice handles various
kinds of links.
Nobody at L10n wanted this change, but they were ignored.
This should fix tdf#103093, which was a consequence of the introduced ambiguity.
This reverts commit a1297fc2df243d765ffb14f18bbdde158459b9f4.
Change-Id: I29232c7a8384c3fa501c61aab26e061ebcb1a0d8
to reduce an excessive number of stack operations.
Change-Id: Ia4ef08dce76d318c56bf7d112f686e13d1b2660e
Reviewed-on: https://gerrit.libreoffice.org/35551
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
