Commit Graph

375720 Commits

Author SHA1 Message Date
Jacobo Aragunde Pérez
79f5d4465c Android: setup ownCloud provider with user-defined settings
Change-Id: I4ad4dd12854ca9f332055a50131959f60f7da504
Reviewed-on: https://gerrit.libreoffice.org/16194
Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10 17:14:15 +00:00
Jacobo Aragunde Pérez
d5c9d1dec6 Android: settings activity for document providers
Creates an activity to manage the settings of any document provider
that needs them, and populated it with the settings required by the
ownCloud implementation.

The settings screen is not yet plugged to the document browser UI but
can be launched with this command:

  adb shell am start -a android.intent.action.MAIN \
  -n org.libreoffice/.storage.DocumentProviderSettingsActivity

Change-Id: I83cff641fa61078f2bddbb98262af989c06985a9
Reviewed-on: https://gerrit.libreoffice.org/16193
Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10 17:12:18 +00:00
Jacobo Aragunde Pérez
d6f9e41537 Android: download documents from ownCloud.
Documents are downloaded to the private cache directory of the app,
and opened from there. That directory is cleared and created again
every time the application starts up.

Change-Id: I5c05c8ae750b6ced3b419c67d84063e8ee3d84aa
Reviewed-on: https://gerrit.libreoffice.org/16192
Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10 17:10:38 +00:00
Jacobo Aragunde Pérez
69773f54bb Android: initial implementation of ownCloud provider.
This implementation can connect to a local server and browser its
contents, but cannot download and open the documents yet.

TODO:

* Download and open documents.
* UI to configure server, user and password.
* Implement filtering to show only the documents of the desired type.
* Improve error handling.

Change-Id: I54a2e2e1d3e8ec8d824d75639e176ca452551f3e
Reviewed-on: https://gerrit.libreoffice.org/16191
Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
2015-06-10 17:08:00 +00:00
Miklos Vajna
b8b4ac9e6e sw: remove embedded data source on location deregistration
Change-Id: I5b2a24fee50a25a41ba26787f7e30409348d7808
2015-06-10 19:04:27 +02:00
Caolán McNamara
b04e1e79e6 Prop_pSegmentInfo is totally misunderstood apparently
digging into the crash on export of kde216114-1.odt
reveals various horrors

Change-Id: I0d24fe303d561a00a08098b306d10fd8273af928
2015-06-10 17:53:02 +01:00
Miklos Vajna
6cca91f7ad CppunitTest_sw_uiwriter: enable on Windows
I hope that the underlying problem is fixed now by commit
670100fcfb (Remove FastLoader
optimization, 2015-06-10).

Change-Id: I1cb577ec1f50a45b40683031e79c0999338a2926
2015-06-10 18:50:20 +02:00
Stephan Bergmann
d0b7be0fa5 syntax errors, still
(i.e., parentheses do need to be quoted in BERs, but do not forget to escape
brakets in configure.ac m4)

Change-Id: Ifabb68ede318e5c95a54c420cd06e238fefbd82f
2015-06-10 18:38:27 +02:00
Stephan Bergmann
2ed0de57db -Werror,-Winconsistent-missing-override
Change-Id: I2d1aa79a67bf130c3844b3bccb34a1761e8e4dfc
2015-06-10 18:32:58 +02:00
Stephan Bergmann
7fd168ad47 loplugin:salbool
Change-Id: I030321e8cb905be78b68f9e404926e22723632ef
2015-06-10 18:29:26 +02:00
Michael Meeks
48c2815dd2 tdf#91727 - Unwind non-dispatch of idle handlers.
This clobbers the functionality from commit:

    06d731428e

    make idle timers actually activate only when idle

Since now all rendering and re-sizing is done in idle handlers it
does effectively the opposite of what was intended. A better solution
would allow special-casing the processing of just rendering,
re-sizing and window management to spin for eg. progress bar
rendering.

Also add helpful debugging labels to the idle & timeouts.

Also cleanup the Idle vs. Scheduler handling.

Also ensure that starting an Idle triggers a mainloop wakeup.

Also add a unit test.

Change-Id: Ifb0756714378fdb790be599b93c7a3ac1f9209e6
2015-06-10 17:27:20 +01:00
Bjoern Michaelsen
ef4fd9c52f add ./logerrit testfeature
- ./logerrit testfeature will trigger a testbuild of the
  current feature branch as it is on gerrit
- ./logerrit testfeature $BRANCH will do the same for $BRANCH
- cloning to a tempdir and rm -rf'ing around isnt ideal, so
  consider this as a template for your own scripting

Change-Id: I50a3c80748af82d855522f245ddbff227c8adab2
2015-06-10 18:05:34 +02:00
Stephan Bergmann
bee2423eff syntax errors, still
Change-Id: I8ed4b4d221040ddf5f51d7e01134c855fc85a641
2015-06-10 17:53:45 +02:00
Michael Stahl
2676ee8ede sw: fix GCC undefined reference to `typeinfo for sw::LegacyModifyHint'
Stop pointlessly inlining these virtual functions.

Change-Id: I11d123bc704ec6cf54925a13d139fce70cc59566
2015-06-10 17:32:50 +02:00
Stephan Bergmann
f5ca824f4c Revert "There's SAL_DLLPUBLIC_RTTI for that"
This reverts commit 8761ab9b5ec7860eb5bc7d05271da081f66a452b; thinko, as the
RTTI needs to be visible with GCC too in the test code.
2015-06-10 17:28:56 +02:00
Katarina Behrens
72c7b9829d Bool2Any wants to get bool instead of sal_uInt8
which is what GetTransparency() returns. Iow, do what SvxBrushItem
does :)

Change-Id: Ief65ab75d8c0955c1ec264611a70dcc693412170
2015-06-10 17:00:55 +02:00
Noel Grandin
9a53236553 tdf#90077 fix freeze when enabling media toolbar in Impress
Change-Id: I402bd7319d31859510a06644eb7dc786d56b312e
Reviewed-on: https://gerrit.libreoffice.org/16213
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-10 14:59:48 +00:00
Varun
c979a944c7 Added Test for Export to Picture
Change-Id: I62d44e29cd4376f17270cef548d2cec6f4b621b9
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-10 16:51:04 +02:00
Varun
4deaf89bbe Added Test for tdf#91145 Set Cell Background Color
Change-Id: I7c41f1d596946706dde4adbeb5434ae0be58b04b

Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-10 16:51:04 +02:00
Stephan Bergmann
8761ab9b5e There's SAL_DLLPUBLIC_RTTI for that
Change-Id: I1937374b56b506681876d100112852b68f099038
2015-06-10 16:33:08 +02:00
Jacobo Aragunde Pérez
2e6ed9befe Android: fix ownCloud lib build
The build relied on the presence of ANDROID_HOME envvar, now we pass
it explicitly.

Change-Id: If33ee2c6a22435151aad244378ee5aaf7b3cc913
2015-06-10 14:30:06 +00:00
Katarina Behrens
321f4925a7 tdf#88055: Don't export transparent background colour as white
The fix is twofold:
1. retrieve transparency from colour in SvxBackgroundColorItem
(add QueryValue, PutValue methods, use additional memberID to
retrieve alpha channel as a bool property)
2. add CharBackTransparent bool property to Draw [text] shapes,
xmloff needs it to be able to output 'transparent' string instead of
'#XXYYZZ' colour code in ODF format

Change-Id: Id830bd18fd6da5d9a46e2a94aa254d5d2a6b7ebb
Reviewed-on: https://gerrit.libreoffice.org/16182
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-10 14:29:09 +00:00
Christian Lohmaier
62751ab180 update credits
Change-Id: Ife3131eac8c653bb851f44f05be618289b5c5116
2015-06-10 16:14:39 +02:00
Philippe Jung
35fe915b7c Fix sd ID conflicts and duplicates
Fix the following cases:
- two names for same ID in sd/inc/app.hrc. Two ID defined.
- ID defined in include/sfx2/sfxsids.hrc and redefined in
  sd/inc/app.hrc. Only the sfx2 ID is kept
- ID defined in include/svx/svxids.hrc and redefined in
  sd/inc/app.hrc. Only the svx ID is kept

Change-Id: I21c7c25cb6db3c43ea2f9aac5aac75fabe61eaf0
Reviewed-on: https://gerrit.libreoffice.org/16209
Reviewed-by: Philippe Jung <phil.jung@free.fr>
Tested-by: Philippe Jung <phil.jung@free.fr>
2015-06-10 13:57:46 +00:00
Jan Holesovsky
342d84218c sc tiled editing: Mapping has to be turned off after drawing the buttons.
Otherwise the redlines are on wrong positions in the tiled rendering case.

Also - we are actually never call with something else than MAP_PIXEL, so
let's kill the resetting of the mapmode; let's see if some obscure corner case
bites us here.

Change-Id: I8da07dd5448b8863df3148882ec50e6746760cca
2015-06-10 15:50:44 +02:00
Stephan Bergmann
54253f382e Ensure single RTTI symbol instance
...to make typeid comparison in sw::UnoCursorPointer::SwClientNotify work also
under the Itanium C++ ABI/libc++ semantics (as used on Mac OS X), not only the
less strict GCC/libstc++ semantics (as typically used on Linux).  This caused
CppunitTest_sw_uiwriter's testUnoCursorPointer to fail on Mac OS X.
(DocDisposingHint and LegacyModifyHint need to be SW_DLLPUBLIC even though they
are nominally only used inside the sw library, because they are also used from
the CppunitTest_sw_uiwriter test code.)

Change-Id: Ideceade22ca3049ae287aea468de93c72bee5fdc
2015-06-10 15:31:54 +02:00
Maxim Monastirsky
172a96e524 bSwitchOff is always false now
Change-Id: Ic79c0f1cf2816da60962f67c57efb75685d984f1
2015-06-10 16:10:27 +03:00
Maxim Monastirsky
71b3521226 tdf#88290 Adapt the numbering popup to more than 8 items
The items count of NumberingTypeMgr is limited by 8, but
some languages have more items, so remove that limitation.

Also fix the behavior of the 10th item. The old sidebar
popup had a "None" item, whose id was 10 (defined by
DEFAULT_NONE from include/svx/nbdtmg.hxx), and that causes
now the 10th item to behave as on/off toggle. Since we
don't have a "None" item anymore, get rid of that behavior
completely.

Change-Id: I5546ca637f9951cc093a7bbf8fda11dc35341d4e
2015-06-10 16:10:27 +03:00
Michael Stahl
ada6281a5b configure: make the error message for pkg-config on Mac more actionable
Change-Id: Ia7f99123625df28cd5459ee6d488e02b20d386f0
2015-06-10 14:42:02 +02:00
Miklos Vajna
4897f10bea SfxObjectShell::CopyStoragesOfUnknownMediaType: still try to copy Base streams
When Base is embedded in a Writer document, we still need this when the
document is saved for the first time after embedding.

Change-Id: I1103da01838abd4ac1b03dc4d44e10db3ce650bc
2015-06-10 14:46:07 +02:00
Miklos Vajna
23c467fd7a SwDBManager::LoadAndRegisterDataSource: restore lost hunk
Accidently removed in commit f01f31201f
(SwDBManager: extract StoreEmbeddedDataSource() from registration code,
2015-06-09).

Change-Id: I27e47249b92b8fd19dcd09a1226f5e80184ea8db
2015-06-10 14:46:07 +02:00
Michael Stahl
1ee5e1a17c pyuno: remove obsolete LC_NUMERIC to "C" mangling code
The CPython changelog says for version 2.4:

- Python no longer relies on the LC_NUMERIC locale setting to be
  the "C" locale; as a result, it no longer tries to prevent changing
  the LC_NUMERIC category.

Change-Id: I6d63c4dedca48c99bf81135d69285d9116a19740
2015-06-10 14:38:27 +02:00
Michael Stahl
82dbf859f1 svl: document SfxItemPropertyMapEntry
Change-Id: I7caa540d069addb610310830c26ecd647afc6538
2015-06-10 14:38:27 +02:00
Caolán McNamara
169cd9f675 VMLExport::Commit is riddled with out of bounds writes on export
Change-Id: I9490d888ad148caecba034ef12b7398ae5c66a3f
2015-06-10 13:42:37 +01:00
Caolán McNamara
c78c0441a2 cppcheck: noExplicitConstructor
Change-Id: I0081113bf312287fe6e14749a569709ee892d8dd
2015-06-10 13:29:27 +01:00
Caolán McNamara
80fbd731d8 similarly fix fatal export of kde216114-1.odt to docx
Change-Id: I78478de91473681fd8d836293dabe7b790dda516
2015-06-10 13:05:51 +01:00
Caolán McNamara
aeb52a855d fix fatal attempt to export kde302504-1.odt to docx
the enhanced-path contains decimal points so the
last element is a double not an integer

Change-Id: I90be76a2d4cb90ee7a904aa72fe65770c675fc53
2015-06-10 12:42:06 +01:00
Stephan Bergmann
80bff90943 loplugin:bodynotinblock
Change-Id: I97d74eebcb45f413dbc73ab96db447228eeb158f
2015-06-10 13:31:07 +02:00
Maxim Monastirsky
ef530d397b tdf#87651 Add outline buttons to impress sidebar
Change-Id: Id3cf58660bfcaf7424d027773894ce6888df788a
2015-06-10 14:04:40 +03:00
Stephan Bergmann
670100fcfb Remove FastLoader optimization
...that was introduced in b88a62cc97 "CWS-TOOLING:
integrate CWS dbaperf2," apparently to speed up later activity by pre-loading a
JVM or Calc.

The problem is that any spawned FastLoader thread was never joined, so could
still run during exit.  That caused many spurious failures of
CppunitTest_sw_uiwriter after df726c8b3e
"CppunitTest_sw_uiwriter: add embedded data source definition testcase"
triggered spawning such FastLoader threads there.

Adding code to join any spawned FastLoader thread is not easy, though.  For one,
it is not clear whether there would not be very many (terminated, waiting to be
joined, thus still holding up system resources) such treads when doing the join
in ~DatasourceURLListener or DatasourceURLListener::disposing.  For another, a
naive attempt at joining in ~DatasourceURLListener leads to deadlock, as it is
called with the SolarMutex locked and the E_CALC branch in FastLoader::run
blocks waiting to acquire it.

Thus, the best approach appears to be to remove this optimization.  Hopefully,
that does not have too dire performance impacts on typcial user scenarios.

Change-Id: Ifeab013ddd8acee1289423facba0c120684e9325
2015-06-10 12:36:54 +02:00
Caolán McNamara
6f9b3532ee fix crash on export of ooo67471-2.sxw to docx
This old-school table has three rows in it, but the second row is of 0 height
so is indistinguisable from the third row by layout positioning, so the
WW8TableNodeInfo view of the table is that it has two rows, and the comparison
of being on the last row is done with the m_xTableWrt->GetRows view which
considers it to have 3, so the table end marks are never output.

add a new finalEndOfLine property that the WW8TableNodeInfo sets on the last
end of row of the table as it sees it, which should resolve this.

old style tables are a cess pit, which is why they were replaced

Change-Id: I996aa59a338a594487f49ec0f228af3fb3032d15
2015-06-10 11:14:34 +01:00
Caolán McNamara
bb42b693c8 don't add gnomevfs requires to epm created rpms if GNOMEVFS is disabled
Change-Id: I689783e176921ea03475d3e113426563bf20b9d7
2015-06-10 11:05:07 +01:00
Stephan Bergmann
371cc81bd9 external/liborcus: Fix Linux RPATH
This has become necessary after edb38d702d "update
to liborcus 0.9.1; Includes switching to dynamic libs."

For one, pass -Wl,-rpath,$ORIGIN in via LDFLAGS, as is done for various external
projects.

For another, libtool (as internally used by liborcus) unhelpfully adds further
-Wl,-rpath arguments of its own, to make the resulting lib in its presumed
location find its dependent libs in their presumed locations.  But we override
all that to the single instdir/program/ directory and corresponding RPATH
$ORIGIN anyway, so the simplest fix to get a clean RPATH appears to outsmart
libtool's attempt add adding further -Wl,-rpath arguments by setting
hardcode_libdir_flag_spec_CXX to empty (see the internals of libtool for why
that works).  Other external projects (like redland) suffer from this problem
too and currently have a "dirty" RPATH; fix pending.  Until libreoffice-4-1 that
was generally not an issue, presumably because having all libs in solver
happened to cause libtool not to emit any additional -Wl,-rpath arguments.

Change-Id: I80dff5141a33c198f30aecb7c51b41bc06145f1c
2015-06-10 11:30:39 +02:00
Jan Holesovsky
c6dab8e7ba Enablaed -> Enabled.
Change-Id: Ia73ae54068d208d6b2db3439f38402664bfa8d29
2015-06-10 11:06:25 +02:00
Henry Castro
9c947faeae sc tiled editing: Corrected dropdown button offset
Change-Id: Ieff88d5de119db30c3fbd2f58ba52696eeb3d327
2015-06-10 11:06:25 +02:00
Tor Lillqvist
a799d7c9a6 Fix Firebird build against OS X SDK 10.11
Change-Id: I60c7540241c41f5063736f2a3d4817371411c8dc
2015-06-10 11:47:11 +03:00
Tor Lillqvist
7bfe288dab WaE: 'convertScreenToBase:' is deprecated: first deprecated in OS X 10.7
Change-Id: Ic25e9aca7a2a61ac677720427fae7a18a8a179fa
2015-06-10 11:47:11 +03:00
Tor Lillqvist
6c2f65dfe0 WaE: null passed to a callee that requires a non-null argument
Let's hope passing an empty NSDictionary works fine.

Change-Id: I90a9b09d421ae8cd202b602db97b2c08b149fd07
2015-06-10 11:47:10 +03:00
Miklos Vajna
4fabf093a3 sw: fix gcc-4.7 build
Change-Id: I6223691a25d5bdcf83b60a26e344fa964d995354
2015-06-10 10:38:53 +02:00
Miklos Vajna
26fb0ce19d sd: fix gcc-4.7 build
Change-Id: Ia368b9760097b6041757a27f228ace587e243683
2015-06-10 10:38:53 +02:00