Commit Graph

353212 Commits

Author SHA1 Message Date
Caolán McNamara
7d6e159df4 fix memory leak on pasting metafiles into writer
copying from mspaint to writer and then deleting the image in a loop will
eventually exhaust all memory.

regression since 004a29b9ac

Change-Id: I381285cda3823de7df0c1725a339943caf9536fe
2014-05-16 21:05:01 +01:00
Zolnai Tamás
821c42b10a OGLWindow: fix key capturing issue
Sometimes the event handler parent captures the mouse
moce which should grab the focus for key event handling.

Change-Id: Ida1022968543059154de824fc3d026c5cecba7b3
2014-05-16 19:53:34 +02:00
Zolnai Tamás
9199616e9d slideshow/glTF: make sure parent window does not cover the OpenGL window
Change-Id: I0da3978cefeb3d145f7411cc1c83a87d981cac62
2014-05-16 19:53:34 +02:00
Julien Nabet
224002ee63 Use SQL_DEFAULT_TXN_ISOLATION to get getDefaultTransactionIsolation
Change-Id: I7f4785088151490ae1d55d2bb78bce28357d5c45
Reviewed-on: https://gerrit.libreoffice.org/8863
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-16 17:20:37 +00:00
Jean-Pierre Ledure
b9f6c3f9ed Access2Base - Correct error message for some actions
Change-Id: I8b49886c3b9a884ffc8e68c7483be8f940c3449e
Reviewed-on: https://gerrit.libreoffice.org/9376
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-16 16:56:48 +00:00
Jean-Pierre Ledure
980f6b5058 Access2Base typo
Change-Id: Id5161f2b8e8132c2a8b68073b233137db3fe74b1
Reviewed-on: https://gerrit.libreoffice.org/9373
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-16 16:56:13 +00:00
Jean-Pierre Ledure
6e60f1a69c Access2Base - solve compatibility issues
1) AOO <> LO
"Append" is a reserved word in AOO Basic, not in LO
=> Append method replaced with Add

2) Windows <> Linux
ActiveConnection not ready under Windows for standalone forms when database is (user/password) protected
=> Connection may be postponed to first use of form

Change-Id: I8ba409191ba2a2a4c057480ec3287d7d48262073
Reviewed-on: https://gerrit.libreoffice.org/9372
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-16 16:55:29 +00:00
Caolán McNamara
4a9a10d169 coverity#708868 Unused pointer value
Change-Id: I5d25f7de37df6fe79bb195e1cb68876fb3b4fcca
2014-05-16 16:42:54 +01:00
Caolán McNamara
87ad02d5ad coverity#708847 Unused pointer value
Change-Id: Id16ebc576834e418a3bf2d3d6eb3e2545e0aac2b
2014-05-16 16:42:54 +01:00
Caolán McNamara
e772a97e1b coverity#708815 Unused pointer value
Change-Id: Ie58034f0475dc9a876eeb54f3bc6a3c415c3e0a1
2014-05-16 16:42:53 +01:00
Caolán McNamara
65219ed056 coverity#708811 Unused pointer value
Change-Id: I18ed52cc6c00c5c462629c4fff7804ea22035e3a
2014-05-16 16:42:52 +01:00
Caolán McNamara
0ff4909a55 coverity#984442 Use after free
Change-Id: I28822f6b74cbf8ace8f7a194248840cb401679be
2014-05-16 16:42:52 +01:00
Caolán McNamara
cb6464fd73 coverity#705542 Unintentional integer overflow
Change-Id: I87712c71689d45259bc9e4e2f71c92375bc887ea
2014-05-16 16:42:51 +01:00
Caolán McNamara
6c7f1e1b5a trivial cleanups
Change-Id: I50bc7ab36690e572825109de9f0b1bb11d26867f
2014-05-16 16:42:50 +01:00
Caolán McNamara
aa583636e3 coverity#1202771 Operands don't affect result
Change-Id: I6a0228594d31cda252f299cad55469ad02c6b353
2014-05-16 16:42:49 +01:00
Tor Lillqvist
633003965a Use SVM (metafile) instead of PNG for diagrams (SmartArt)
It seemed a bit pointless to waste CPU cycles on PNG-compressing a
bitmap image only to later then uncompress it anyway. vcl's PNG
writing code showed up as 13% on the time profile of TiledLibreOffice
when displaying a document full of SmartArts.

Miklos suggested I try using SVM (which I guess means "StarView
Metafile") instead. When using SVM, no rendering of diagrams to
bitmaps during loading is done, but the diagram stays stored in a
resolution-independent (vector-ish) form. Which means it will be
rendered nicely and crisply regardless of the zoom level.

At least, that is my understanding, and experimentation (on OS X and Linux)
seems to confirm.

ce8c0ff07559ddcc729bffd7a68f4c6f281882e3

Change-Id: Ice8c0ff07559ddcc729bffd7a68f4c6f281882e3
2014-05-16 18:18:20 +03:00
Miklos Vajna
66fce1f61e git pre-commit hook: block large files
Change-Id: Id27cfa805fc7cd0f4f6cc3d8bb770aa7abd536e1
2014-05-16 16:54:20 +02:00
Kohei Yoshida
fcf5b5c081 fdo#75056: Overline attribute needs special treatment as well.
Also fix the export of underline types as well.  It was always saved
as a single line.

Change-Id: I88cb0f3702a6afc14544ecbce8f200b5422fd78f
2014-05-16 10:47:58 -04:00
Kohei Yoshida
5c0b8937f4 fdo#75056: Write test for this.
Change-Id: I716467ffe81a1f71f03e0dc7a17c33b2ed39d334
2014-05-16 10:47:58 -04:00
Stephan Bergmann
45e8fd5fcc For now, reintroduce the horrible static counter into utl::TempFile
...i.e., bug fdo#41295 and its fix rediscovered.

Change-Id: If958fad74c853f51660a9e0bfffd99969052ea80
2014-05-16 16:34:48 +02:00
Miklos Vajna
e25bdf7f60 DOCX import: make sure inline shapes are not in the background
Change-Id: I80d684662ac3f94bff4448fcdae94f9e69fd1590
2014-05-16 16:32:17 +02:00
Zolnai Tamás
e0d94ef444 3D model insertion UI: add *.dae and *.kmz filters
Change-Id: I20f6bea3b1f5ba03cc461f461458f5460da716c3
2014-05-16 16:24:10 +02:00
Zolnai Tamás
b862a216f7 ODF filters: fallback glTF model to bitmap for older versions
Change-Id: I33161401a29f511e61429355dd2905d4643fe8ff
2014-05-16 16:24:10 +02:00
Zolnai Tamás
e627929e5e Fix class name typo in comment
Change-Id: Ie37583fb53578fb91a121f7d2ec654a4fae01002
2014-05-16 16:24:10 +02:00
Stephan Bergmann
06a45a1a17 loplugin:saloverride
Change-Id: I2b6e6a6654e888bec3ba4961f9130ca10b791f87
2014-05-16 16:20:56 +02:00
Tor Lillqvist
f6f208dd9a Add more info about XCODE_DEBUG_INFORMATION_FORMAT
Change-Id: I90b1140d9c3f70f01eb673e6d9113593bbe57a09
2014-05-16 16:41:08 +03:00
Miklos Vajna
942156b1ed sw doc model dump: show SdrObject::nOrdNum
Change-Id: I4ac2c3d883dd9bb111a2d600f5a17ea96a1e219e
2014-05-16 14:53:42 +02:00
Thomas Arnhold
fcfa1b7e1f idl: fix some include guards
Change-Id: I6f306ba26d888a617aae89d29fc80acd00bd71d8
2014-05-16 14:37:28 +02:00
Thomas Arnhold
638848d5ea idl: remove external header guards
Change-Id: I78661f0750e4213a20dd2341580cbb181897f3ba
2014-05-16 14:37:28 +02:00
Thomas Arnhold
93037e3061 fix-includes.pl: svgio
Change-Id: I660f0b2da8f5e6fd8de37e22fd4edd2bd8d21ef8
2014-05-16 14:37:27 +02:00
Thomas Arnhold
a6ef8ed1d6 clean up, remove eof comments
Change-Id: I166e781cb54181a8e5d08021cf5f6dfcd1fde5cb
2014-05-16 14:37:27 +02:00
Jacobo Aragunde Pérez
73ad72e820 ooxml: Preserve effects on pictures
If a picture contains some 2D (glow, shadow...) or 3D effect
(rotation, extrusion...), we prevent the importer from transforming
it into a XTextContent so the XShape grab bag is not removed and
the effects are preserved using the existing mechanisms. Added a unit
test for this issue, and modified some existing unit tests to match
the new behaviour.

Change-Id: I3b87069ea208604383a592d34d0a4ceb6b0f9fc7
2014-05-16 14:11:23 +02:00
Jacobo Aragunde Pérez
be415a0f9a ooxml: Preserve shape effects when there's more than one
Transformed the preservation process of shape effects to be able to
store more than one effect. For that we:

* Created the Effect struct and added a vector member to the
  EffectProperties struct.
* Changed the shadow effect to use the new Effect struct,
  EffectShadowProperties struct is preserved because the direction
  field still has some use but we should remove it.
* Changed the structure of the grab bag to store more than one effect.
* Modified an existing unit test to check shapes with several effects.

Change-Id: I0dd908fa1d9578827c02ef6272fc9e2b914391be
2014-05-16 14:11:22 +02:00
Jacobo Aragunde Pérez
a583528506 oox: always save all kinds of 3d effects to the grab bag.
This was actually a bug. It didn't matter much because a document with
an a:sp3d tag but without a:scene3d section would be invalid, but the
code was logically wrong.

Change-Id: Ifa838e425849642c2a1bf6fca6b6a8dc8ed3b465
2014-05-16 14:11:22 +02:00
Eike Rathke
5ad020235a introduce SvxLanguageBoxBase, SvxLanguageBox, SvxLanguageComboBox
In preparation of having a language box available as ComboBox to be able
to add language tags.

Change-Id: I5af5ea5bb06e558db1fcf9c0668be274d5cec04e
2014-05-16 12:54:54 +02:00
Tsutomu Uchino
5350520ec8 Resolves: #i98216# extract boolean value for AutoFill value of ComboBox model
(cherry picked from commit 213aafbf006a5099e951f65a472e4f8fa66256a4)

Change-Id: I862abc31b69b98f0ec766ca260fdc063d14a2ee4
2014-05-16 11:54:08 +01:00
Markus Mohrhard
ca52e5ff2c support property mapping in new 3D charts
Change-Id: I3da71e354ed2595c1f5b2eaeb5fb565205d24de0
2014-05-16 12:44:15 +02:00
Markus Mohrhard
2c7a4e8aff set the MVP matrix in picking mode
Change-Id: I11d4838a320ada1d454870436e540b2c56fa18fd
2014-05-16 12:42:44 +02:00
Caolán McNamara
6709d982a5 lsan: mpFontCharMap double-add-ref, never released
Change-Id: Id511d6d0d975434b4754786204cc0fc91568168e
2014-05-16 11:32:44 +01:00
Tor Lillqvist
d2397ab0ad Use correct header guard name in comment at #endif
Change-Id: I2df05054c4108cb173f80ce6fa66f30c713b70cd
2014-05-16 12:43:04 +03:00
Tor Lillqvist
7822b5535c Make the MacAVF code build also as 32-bit
When compiling 32-bit OS X code, the code will use the "legacy
Objective-C runtime", which means that instance variables of an
Objective-C class must be declared in the @interface block, not in the
@implementation.

CGRect and NSRect are not the same for 32-bit code.

Also, use boost::unordered_map.

Change-Id: Icc56ff298203565a7568714b0e9f42c7c6b89737
2014-05-16 12:43:03 +03:00
Noel Grandin
97d50c425f combine the pass-by-ref clang plugins
Change-Id: Idac24afb7cb67fa2d539553fb9fa049c2d61ecf0
2014-05-16 11:18:45 +02:00
Stephan Bergmann
0bc869459b Consolidate CreateTempName_Impl and lcl_createName more faithfully
This is a follow-up to fcf455d4ef "Consolidate
CreateTempName_Impl and lcl_createName," which apparently lead to hard-to-
diagnose sporadic "make check" failures on some machines.  Hope is that bLock
now more carefully tracking the behavior of the original two functions fixes
that.

Change-Id: I37ba00545f5921fd603ff9f1ea46927c42e88899
2014-05-16 11:05:41 +02:00
Pallavi Jadhav
a05e501628 fdo#78432 : DOCX: File gets corrupt after RoundTrip
Issue :
	- In RT in document.xml, value of Absolute Position Offset
	<wp:posOffset> was going out of bounds.
	- <wp:posOffset> is of type Int(32-bits), hence it's value
	should not cross the MAX and MIN limits of Int.

	Implementation :
	- Added check for <wp:posOffset> should not cross
	Maximum/Minimum limit of Int.
	- Written Export Unit test case.

Reviewed on:
	https://gerrit.libreoffice.org/9328

Change-Id: I22e75d7e603ebbf6a49e764fb1a3e6a4d2fd8b23
2014-05-16 11:03:37 +02:00
Markus Mohrhard
5a9399a628 small hickup 2014-05-16 08:40:11 +02:00
Kohei Yoshida
48eccfb812 fdo#77537: Exporting font names in edit text needs special handling.
Change-Id: Ia9c29d37eaf962e0245920e50f534dd779af72dc
2014-05-15 20:34:10 -04:00
Kohei Yoshida
90f7bd61fb fdo#77537: Write export test for this.
Change-Id: I2960713b1005c5f91fe78d12e33f1786978eac67
2014-05-15 20:34:10 -04:00
Tomaž Vajngerl
fd70beaccb vcl wmf test: null terminate stream
Change-Id: I10342262cacbe3e3d978fee652cdbc4692f46dc4
2014-05-15 23:50:58 +02:00
Tomaž Vajngerl
fb1e810553 test: don't create root element in startDocument() in xmlwriter
Change-Id: Ia08e9f8caf2a2fb42855dcb2245e013e1a181216
2014-05-15 23:50:58 +02:00
Lennard Wasserthal
b7cb2ae502 fdo#55582 Writer: Dont overwrite from even when selected, from writer.
This patch fixes the writer part, calc part is fixed long ago.
Problem: it overwrites when you paste from impress or calc.
This allows to keep the graphic's frame,
so the text doesn't have to be rearranged.
(i.e. it is desired, so I didn't change that)
I was trying to give the user a choice,
but I didn't succeed in keeping the frame when pasting from writer to writer.
coming soon!

Change-Id: I07271df9bb501779d06f332bb13edd05f0aefacb
Signed-off-by: Lennard Wasserthal <Wasserthal@nefkom.net>
2014-05-15 23:39:14 +02:00