Rework of offending code that changes the mouse pointer to a hand icon
when outline content visibility feature is active.
Change-Id: Ia30a8f951b341a4f44f8b900cc756c205f6a273d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108275
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
commit 797915bf0bc0ed82c3cf58b7bd03c42d3335ca18 prevents focus from
returning to the edit window when Navigate by previous or next buttons
in the Navigator tool box are pressed. This may be nice for activation
of the button by keyboard as it keeps focus on the button, but it
doesn't allow for cursor indication of the navigated position in the
edit window.
Change-Id: I0067ee7d80aa94a510c83a52c22f788ba4a03dc6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108276
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Strategy for management of Form and FormControl events:
At the contrary of Dialogs and DialogControls, which are always started from some code,
Forms and FormControls will be initiated most often by the user, even if the SFDocuments library
allows to start forms programmatically
For Forms started programmatically, the corresponding objects are built top-down
Event management of forms and their controls requires to being able to rebuild Form
and FormControl objects bottom-up
To avoid multiple rebuilds requested by multiple events,
1. The active form objects are cached in a global array of _FormCache types
2. FormControl objects are cached in Form objects
3. The bottom-up rebuild is executed only once, at instance creation
Change-Id: I76ebb8064a900397427554ca47464c99266e0e5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108325
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for
details.
(Turned some affected variables in included files into inline variables, to
avoid GCC warnings about unused variables.)
Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
It caused issues on Windows with an upcoming change that introduces more static
OUStringLiterals, and apparently one from msword ended up in the data structures
of editeng's SvxForbiddenCharactersTable, which in turn is owned by theEditDLL
singleton, which was destryoed at exit after the msword library had already been
unloaded, so an OUString referenced the dangling OUStringLiteral data.
Change-Id: I873f0b4e879a5820d1e8a1cda3b1b1fd49f809db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108321
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...to acknowledge
> [build CLR] cli_ure/source/climaker/climaker_emit.cxx
> cl : Command line warning D9025 : overriding '/EHs' with '/EHa'
> c1xx: error C2338: two-phase name lookup is not supported for C++/CLI or C++/CX; use /Zc:twoPhase-
> c1xx: fatal error C1903: unable to recover from previous error(s); stopping compilation
etc.
Change-Id: I09cf54123345f5816f7c5b21cc9779567fd0cece
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108320
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Since 7.1 hasn't been released yet there's still time to change it before having to be scared about backguards compatibility.
This way:
- It is more efficient than passing two arguments
- On definition it is simpler since both are declarated on same point.
So it is simpler to not loose sync between lists.
- Code is less long.
- Thanks to an idea proposed by Stephan Bergmann on other commit.
Change-Id: I16305a304c98eb8d4e11507c7938002da546778b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108028
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This reverts commit 51f4691e7f. The
gb_CppunitTest_localized case did need the sub-shell for its
$(if $(gb_CppunitTest_localized),|| exit $$?; done) \
part, or else a failed sub-command would exit the whole recipe line and suppress
the non-gb_CppunitTest__interactive postprocessing part.
Change-Id: I115388ce4fe834f73ebd0abf2591775189c0121b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108280
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...presumably related to --disable-pch and/or latest MSVC 2019 16.8.3 changes?
For one, various #includes and using directives were missing. For another,
UnoConversionUtilities<T>::variantToAny used reduceRange before its declaration.
Change-Id: I0f6107741c5eb85746c9bdaf7016f294112bef9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108263
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...presumably related to --disable-pch and/or latest MSVC 2019 16.8.3 changes?
OLEVariant is needed as a complete type in some of the Aolewrap.hxx template
code.
Change-Id: I0422674ba747c133cda03c540e6d0715f2a398a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108269
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Commit 3f9940c2e0 mistakenly removed
include/ucbhelper/getcomponentcontext.hxx seeing the getComponentContext method
as unused.
According to that file, ucbhelper::getComponentContext was just a duplicate of
comphelper::getComponentContext so this commit changes to calling that method
instead.
Change-Id: Ibd66b56a72afce437a26417d7944ec1ace34a4eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108262
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
if preset data is not found. Curve, polygon, and free form
motion paths do not have preset data. Create the path
in these cases as well.
Change-Id: Idd3b24b81a15de53e302e8cb7f3636d72e10b4da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108022
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
Split class functions into BitmapInfoAccess.cxx, BitmapReadAccess.cxx
and BitmapWriteAccess.cxx
Split header files into BitmapInfoAccess.hxx and BitmapReadAccess.hxx
Change-Id: I7dcbe1d26c5b64d297658a6b809c93d7ad7f053d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108039
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Also included in this patch:
- Modifications to make all outline content visible during move
operations.
- Removal of code intended to redraw buttons when layout is changed that
seems not to work as intended.
- Function IsOutlineContentFolded changed to IsOutlineContentVisible
- Change of delay before button is shown to half of what it was.
Change-Id: I0dde555ccd0693ca382c1f15326edfdc2fc44a93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107815
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
