Commit Graph

413136 Commits

Author SHA1 Message Date
Caolán McNamara
64e7dfaf6d normalize -> style
Change-Id: I10895e686c7f583dd3d4a002b878f4499d15efa3
Reviewed-on: https://gerrit.libreoffice.org/42697
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23 20:22:30 +02:00
jan Iversen
ac95e04e50 iOS, update distro
Added copy of autogen.input that works for arm64 and simulator.

Some of the disabled libraries might work, that is future work.

Change-Id: I7df3491872a1f13110dd49655fdc0a4ede3bfa28
2017-09-23 18:23:19 +02:00
jan Iversen
6132e8d286 iOS, dummy avmedia to satisty sdi files
if disable_avmedia is defined, change avmedia
to a dummy module.

libreOfficeLight links !

Change-Id: Ibb41ed3ba48cc3143f17000f1c6073611c798e53
2017-09-23 18:10:06 +02:00
Szymon Kłos
c0a6183296 tdf#112089 add charts to the ShapeMap
Charts weren't added to the collection what resulted
in missing ids during export (target field).

Change-Id: Ie96a4e33a52c5448342a3c3dcec0d8e8b244e270
Reviewed-on: https://gerrit.libreoffice.org/42552
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-23 17:43:20 +02:00
Caolán McNamara
1264964de7 ofz#3467 mul and div are the same
so can just pass the values through

Change-Id: I793ea0fd5fec00fc942b3b5a5c17c483ec2df267
Reviewed-on: https://gerrit.libreoffice.org/42675
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23 16:48:40 +02:00
Caolán McNamara
0656bcf98a coverity#1418337 Unchecked dynamic_cast
Change-Id: Ic7c7030687d39e35610f7aa14555d8b19b11acea
Reviewed-on: https://gerrit.libreoffice.org/42681
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23 16:47:45 +02:00
Szymon Kłos
22e94ab186 Watermark: apply when new page style is created
Change-Id: I0d0103f8cc351ec87f7c3bf936ef4725a166d315
Reviewed-on: https://gerrit.libreoffice.org/42581
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-23 16:37:06 +02:00
jan Iversen
f53b689052 iOS, simplified build demands
moved iOS build demand to same location as other os.

Change-Id: If235aff2af7b58b26b94cb6818404100fa50d2d8
2017-09-23 12:56:36 +02:00
Yousuf Philips
7dc82cc2e4 tdf#86083 Restore old operation buttons but have them hidden
Change-Id: I7d006d3d5e22ade59ddfe46f21fbc777a1c75dac
Reviewed-on: https://gerrit.libreoffice.org/42684
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-23 12:52:31 +02:00
Yousuf Philips
183c041e4c tdf#103733 Unify master doc menu and toolbars with writer
Change-Id: I1f6ce6c98cd7087ccb874001c29a8532cd7ed360
Reviewed-on: https://gerrit.libreoffice.org/42108
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-23 12:50:45 +02:00
Julien Nabet
9ebd8fba49 cid#1418339: resource leak
Change-Id: I87374e32e787f58aa5e4d1b6a78fcd1dddcccdf6
Reviewed-on: https://gerrit.libreoffice.org/42680
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-23 10:38:18 +02:00
Takeshi Abe
e9825f51dc vcl: no need to have dispose() here
Inlining it in dtor is enough.

Change-Id: I20769f4b0af51103dd8fb2c5d24ee5e6ef2be1f8
Reviewed-on: https://gerrit.libreoffice.org/42634
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23 09:20:19 +02:00
Takeshi Abe
ab34e1a34b vcl: Drop a couple of unused member variables
Its usage was gone at df6ba2adba.

Change-Id: Ia153cb8fb9247818684be09a81ac5eabdb1120e4
Reviewed-on: https://gerrit.libreoffice.org/42682
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23 09:18:41 +02:00
Noel Grandin
ee6bdeec8d loplugin:flatten in svl..svx
and implement a check in the plugin to prevent us modifying the
same patch of source code twice. This logic should probably be moved
into plugin.cxx at some point.

Change-Id: I7ebff6424cc8733bb2c8f7dba75eaaec68649290
Reviewed-on: https://gerrit.libreoffice.org/42660
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23 09:04:48 +02:00
Noel Grandin
a8622c77d2 loplugin:flatten in sdext..stoc
Change-Id: I460e813e20a691c53738373376d3363f553bbab2
Reviewed-on: https://gerrit.libreoffice.org/42636
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23 09:02:58 +02:00
Noel Grandin
2684aefcf5 new loplugin unnecessarycatchthrow
Change-Id: Iabab71ee076227bc38447ec109afaea1e53a86a6
Reviewed-on: https://gerrit.libreoffice.org/42643
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23 09:01:46 +02:00
Yousuf Philips
1fde962b71 tdf#106781 Enable a few hidden items in writer styles toolbar
Change-Id: I8c2131f31e98e1cf6c790d446ddd84b17507d0ee
Reviewed-on: https://gerrit.libreoffice.org/42679
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-23 08:51:06 +02:00
Andrea Gelmini
0db08432c6 Fix typo
Change-Id: I970201eb99c56db3ac5fefb9e113c0bb3b8c754b
Reviewed-on: https://gerrit.libreoffice.org/42678
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-23 00:59:11 +02:00
Michael Stahl
7597a4915d sw: actually SetTableNode() ought to always be called before delete
Change-Id: I5e830e91ae7c773ad3945550c640a190b6504796
2017-09-23 00:47:12 +02:00
Michael Stahl
02b406b5cb sw: fix crash on loading tdf109006-1.odt
~SwDDETable() accesses its boxes' start node but that follows the
SwTableNode and SwNodes::RemoveNode() counts backwards so the
box nodes are all dead.  This was always broken but spontaneously
started to crash today.

Because dtors don't have parameters, resort to a little subterfuge
to ensure ~SwDDETable() finds out where it is.

Change-Id: Id681005989dd1e9f2611e8c99841927a7c5f6bfa
2017-09-23 00:47:12 +02:00
Eike Rathke
b439971c9f Use const reference instead of copy
Change-Id: Idf5239e2037dcfa808e016a726f5a980d862ede6
Reviewed-on: https://gerrit.libreoffice.org/42669
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22 23:06:16 +02:00
Eike Rathke
4e1d53b406 GraphicExportFilter: adding FilterData defaults is unnecessary
... now that we use the proper dialog that sets the proper filter
properties.

Change-Id: Iabc3e4b2c13b60bccc0b596a851109df32fe535c
Reviewed-on: https://gerrit.libreoffice.org/42668
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22 23:05:54 +02:00
Eike Rathke
5d1bfa6586 Apply replaceFirst() only once
It's unnecessary to call if a replacement was already done and might
even harm, though unlikely. (e.g. file extension "web")

Change-Id: I6615c9a31178770429b523e0ee878661f1b2b6e8
Reviewed-on: https://gerrit.libreoffice.org/42667
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22 22:56:57 +02:00
Eike Rathke
4abe446536 Group member variables and functions and fix naming nitpicks
Change-Id: Ie0b13c0ed4657200b6c92ae66ea25093e35a6c8f
Reviewed-on: https://gerrit.libreoffice.org/42666
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22 22:56:44 +02:00
Eike Rathke
9faffc71a0 No using namespace in header file
And using namespace css is sufficient, it's actually good to see some
namespace..

Change-Id: I8cd3418e04769bb2fd1c632d6d671b368aae06b3
Reviewed-on: https://gerrit.libreoffice.org/42665
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22 22:51:18 +02:00
Eike Rathke
2d0d777fe8 Export to PNG: selected shapes via drawing::GraphicExportFilter, tdf#108317
Change-Id: Id09d9b21b2e6c018dd199a1911a9125c118abec2
Reviewed-on: https://gerrit.libreoffice.org/42658
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22 21:56:02 +02:00
Eike Rathke
5f5458ee59 Move implementation to filterRenderDocument()
Change-Id: I632a26c5f149fabbe3a4a1186bfbe822fff0ea24
Reviewed-on: https://gerrit.libreoffice.org/42656
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22 21:55:34 +02:00
Eike Rathke
fa60e32412 Remember XComponentContext
Change-Id: I52847249b3e17a31f6c6bf76af7bfe91a414d072
Reviewed-on: https://gerrit.libreoffice.org/42657
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22 21:55:07 +02:00
Eike Rathke
fe76af877a Check availability of XPageCursor
Change-Id: I458655d52992e40c2330ec10628fcea0fdc00f76
Reviewed-on: https://gerrit.libreoffice.org/42655
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22 21:54:14 +02:00
Eike Rathke
d026980813 GetGraphicSource: use DocumentToGraphicRenderer::isShapeSelected()
Change-Id: I50852360a29b4d5fd08277fcb2198f7956f9ebe0
Reviewed-on: https://gerrit.libreoffice.org/42654
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22 21:53:20 +02:00
Eike Rathke
3b06d9df29 Introduce DocumentToGraphicRenderer::isShapeSelected()
Change-Id: I66fc0e39a7a35969b937253c88326516949ea7e7
Reviewed-on: https://gerrit.libreoffice.org/42653
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22 21:52:30 +02:00
Mike Kaganski
d4b6e52439 Remove include of converters.hxx from precompiled_drawinglayer.hxx
Commit cf48347e7a didn't take into
account commit 632edfabe8 landed
before it.

Change-Id: I108027a460943b14194adcff4af2a41b7720f3be
Reviewed-on: https://gerrit.libreoffice.org/42677
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22 21:43:38 +02:00
Christian Lohmaier
09d954447f android: bump support library & buildtools/SDK versions
also add google maven repo, since

"The support libraries are now available through Google's Maven
repository. We no longer support downloading the libraries through the
SDK Manager, and that functionality will be removed soon.."
https://developer.android.com/topic/libraries/support-library/setup.html

Change-Id: Ica0a2542903f60c7bffa1daa2409b60422bde88f
2017-09-22 21:40:48 +02:00
Mike Kaganski
cf48347e7a Fresh run of bin/update_pch.sh
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06
Reviewed-on: https://gerrit.libreoffice.org/42565
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22 21:01:49 +02:00
Mike Kaganski
eef4c133e9 Windows: avoid dependence on UNICODE define; prefer W functions
Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1
Reviewed-on: https://gerrit.libreoffice.org/42560
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22 20:53:30 +02:00
Mike Kaganski
bb406680ce Put definition of _CRT_RAND_S into bin/update_pch
so it doesn't get removed again from sal/inc/pch/precompiled_sal.hxx
(see commit 4af9612f2b).

Also make necessary changes to some of the files that start to fail
building after running bin/update_pch.sh, so that the patch is
self-contained and leaves the tree in fully functional state.

tools namespace had to be prepended with :: to disambiguate from
drawinglayer::tools

vcl/inc/window.h includes were amended, because ExtTextInputAttr is
from vcl/commandevent.hxx, and enum class ShowTrackFlags is from
vcl/window.hxx

Change-Id: I47179622350754cba2f95d26a1bafd3dfbbc935b
Reviewed-on: https://gerrit.libreoffice.org/42559
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22 20:52:34 +02:00
Michael Stahl
ca8a4c81a4 vcl: [loplugin:badstatics] pManager
Move this to class GenericUnixSalData, which is deleted on shutdown.

Change-Id: I6366c12f255bfeca737b22259c3f58ffa2c6222c
Reviewed-on: https://gerrit.libreoffice.org/42632
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-22 20:42:23 +02:00
Caolán McNamara
893c08b59a move TestImportOLE2 where it can be used by fftester
Change-Id: I7b41d9ec673cfb96f51b5008540df63fe78a7581
Reviewed-on: https://gerrit.libreoffice.org/42639
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22 18:09:44 +02:00
Caolán McNamara
a395698d3d ofz#3466 avoid oom
Change-Id: I79f7390dda9c087ae4bc5af9855b72e888e284a1
Reviewed-on: https://gerrit.libreoffice.org/42641
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22 18:09:07 +02:00
Michael Stahl
dc99e5e9ba vcl: [loplugin:badstatics] aApp
DemoApp::xMSF doesn't need to be a member.

Change-Id: I3b2d0d4c58ab04e0a82b31938c5f64b274ca004e
2017-09-22 18:01:09 +02:00
Michael Stahl
d67ec7324b vcl: [loplugin:badstatics] aApplication
VisualBackendTestApp::xMSF doesn't need to be a member.

Change-Id: I307ba56377b822a148db809c16b8ff05708d0ca7
2017-09-22 18:01:09 +02:00
Michael Stahl
ba4151219a vcl: [loplugin:badstatics] PPDParser
class PPDContext actually looks harmless but it has an out-of-line
destructor so the plugin can't see that it's harmless, so use
default destructor instead.

Change-Id: I921a4cdaeb5c8fe286615162b9e9c2a8db47b300
Reviewed-on: https://gerrit.libreoffice.org/42633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-22 18:01:01 +02:00
Michael Stahl
aef3a494de vcl: [loplugin:badstatics] aInstance
Move this to struct ImplSVWinData, which is deleted on shutdown.

Change-Id: Ie604c2105f1176858b4050fb34d37cf376f8f82a
Reviewed-on: https://gerrit.libreoffice.org/42631
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-22 18:00:32 +02:00
Caolán McNamara
e0c9088315 ofz#2976 timeout in olefuzzer
Change-Id: Ic64e5eaa6b524403e46f9907499b0b853792a971
Reviewed-on: https://gerrit.libreoffice.org/42640
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22 18:00:03 +02:00
Michael Stahl
8b690f22c9 vcl: [loplugin:badstatics] xCharClass
There's even 2 of these; move them to struct ImplSVData
which is deleted on shutdown.

Change-Id: I8040cd6f9f31c0a1ab48987a490395f316d52220
Reviewed-on: https://gerrit.libreoffice.org/42630
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-22 17:59:36 +02:00
Caolán McNamara
c75a3ffd88 ofz: alloc+read+discard -> skipblock
Change-Id: I51aa0a1155c468aa5d360c63f6f7c8d347078bf1
Reviewed-on: https://gerrit.libreoffice.org/42638
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22 17:32:09 +02:00
jan Iversen
e69ed74e34 iOS, make simulator config copy of macosx.
When compiling for the simulator it is like compiling
for macosx (64bit) but with other libraries, therefore
the bridge should be like the macosx.

Change-Id: I59f1442a5c77d09ad0bc4bf31c2432fc32ef725e
2017-09-22 17:29:29 +02:00
Caolán McNamara
45dcb415e8 ofz#2902 eps timeout
Change-Id: I8001df3ac89b81bffab871404efc90b6606e3eb3
Reviewed-on: https://gerrit.libreoffice.org/42637
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22 17:03:16 +02:00
Tor Lillqvist
c32d54f244 Revert "Goodbye autogen.lastrun"
Welcome back autogen.lastrun. I just don't have the energy to convince
tinderbox maintainers to fix their scripts. Oh well.

This reverts commit 7496c83374.
2017-09-22 16:51:22 +03:00
Tamás Zolnai
7df3faa8eb Fix gtktiledviewer crash: this should be a null terminated list
Change-Id: I06e0923980b98b37b06ab45d8db68424b01d4f71
Reviewed-on: https://gerrit.libreoffice.org/42645
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-09-22 15:49:00 +02:00