mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
443,275 Commits 1 Branch 0 Tags
89c8f34c31c423321d10067f5250e51c3d901b56
Commit Graph

12639 Commits

Author SHA1 Message Date
Noel Grandin
158fbb78ca make some classes module-private 
Change-Id: I95845d7217fc5e77e3f8e205030e9cd761ad0cc5
Reviewed-on: https://gerrit.libreoffice.org/82116
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-11-15 08:13:06 +01:00
Caolán McNamara
da30c06a11 Resolves: tdf#128788 crash in autovalue 
Change-Id: Ifeb3b3fcb464e1d6db7e1a4a557b34b3ee30c82a
Reviewed-on: https://gerrit.libreoffice.org/82652
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-11-14 13:37:08 +01:00
Caolán McNamara
e151c12a14 Resolves: tdf#128748 warning dialog appearing on focus change 
so can't use cancel because focus out of the entry happens on
the effort to get to the cancel button

instead only show the dialog on ok, next and selecting a new
param in the treeview. Show an error indicator in the entry
on focus-out instead.

Change-Id: I5770142d7a1e7c62bb9ed89a171e72129a43f6c8
Reviewed-on: https://gerrit.libreoffice.org/82613
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-11-13 17:18:46 +01:00
Caolán McNamara
fc950a685e set parent for OParameterDialog 
Change-Id: I614d596599ce55ef9940fbeedf0fca4052e64138
Reviewed-on: https://gerrit.libreoffice.org/82592
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-11-13 16:43:22 +01:00
Caolán McNamara
02ebc564d7 set parent for message dialog 
Change-Id: I0f885e79dd9fca2596e0190af996e9cae74692a6
Reviewed-on: https://gerrit.libreoffice.org/82591
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-11-13 15:52:32 +01:00
Noel Grandin
9e087d4a30 loplugin:unusedvariablecheck tweak to find more stuff 
but leave the tweak commented out, since it generates false positives

Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c
Reviewed-on: https://gerrit.libreoffice.org/82121
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-11-06 10:47:15 +01:00
Noel Grandin
ab285c743a loplugin:stringadd 
tweak the plugin to be more permissive, then validate by hand
afterwards

Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654
Reviewed-on: https://gerrit.libreoffice.org/81942
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-11-03 17:11:14 +01:00
Stephan Bergmann
7f305223fa New loplugin:conditionalstring 
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3
Reviewed-on: https://gerrit.libreoffice.org/81946
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-11-02 21:47:38 +01:00
Caolán McNamara
36022becbe avoid intermediate vcl::Windows 
Change-Id: I5d6a03baed2af5801132f3e3a0411867ba60186e
Reviewed-on: https://gerrit.libreoffice.org/81760
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-31 17:11:14 +01:00
Stephan Bergmann
d526bd7dd5 Fix StringAdd::isCompileTimeConstant 
...to find StringLiteral on the RHS of +=.  Which revealed that the
VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that

  s += side_effect();
  s += "literal";
  s += side_effect();

only gets combined to

  s += side_effect() + "literal";
  s += side_effect();

and not all the way to

  s += side_effect() + "literal" + side_effect();

Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4
Reviewed-on: https://gerrit.libreoffice.org/81804
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-10-31 09:14:39 +01:00
Caolán McNamara
3e041c0689 remove some unnecessary includes 
Change-Id: I5cad1142641587ef4393cbf73384f93540d61038
Reviewed-on: https://gerrit.libreoffice.org/81712
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-30 09:12:44 +01:00
Caolán McNamara
05b2490998 don't need to include vcl/tabctrl.hxx 
Change-Id: Idb1f6700c5012303e45587db653b62a90e331c17
Reviewed-on: https://gerrit.libreoffice.org/81710
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-30 09:12:00 +01:00
Caolán McNamara
2cd6ff8a54 remove unnecessary includes 
Change-Id: Ia4a622b34ff3f71963cff7a1aa8658a4df12f04f
Reviewed-on: https://gerrit.libreoffice.org/81676
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-29 17:27:23 +01:00
Caolán McNamara
09e3d45cdc weld fpicker cluster 
Change-Id: I6566263809ff0032388a0b56571f0cf7428058d7
Reviewed-on: https://gerrit.libreoffice.org/81334
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-29 13:58:47 +01:00
Noel Grandin
e276c81264 size some stringbuffer to prevent re-alloc 
I started with 32 and kept doubling the size until the site
did not need re-alloc, but clamped it at 512 (e.g. in emfio/).

Change-Id: Ib7caf35a1b7e42b0e4ed8aa812493449e3eefc8f
Reviewed-on: https://gerrit.libreoffice.org/81540
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-26 12:38:33 +02:00
Stephan Bergmann
aaff734013 This probably wants to generate a "1".."10" string representation 
...instead of picking the OString(char) overload.  (Was introduced with
f62efe43a2 "weld ODbAdminDialog".)

Change-Id: Ia5225bbc16aedc71aea74ce1d004b29696f46f94
Reviewed-on: https://gerrit.libreoffice.org/81455
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-10-24 17:07:50 +02:00
Noel Grandin
7fb43031b7 loplugin:constantparam 
Change-Id: Ibfe70492683ff3ec208cee95d8a11155ec54f690
Reviewed-on: https://gerrit.libreoffice.org/81314
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-22 14:14:48 +02:00
Noel Grandin
db90e072fa loplugin:virtualdead unused params in OCacheSet 
these methods do nothing except forward to their similar named variants,
so just remove them

Change-Id: I28d31bbe2c1e39fe5a9c2d7eaa9e14006213ab27
Reviewed-on: https://gerrit.libreoffice.org/81247
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-22 08:13:45 +02:00
Noel Grandin
964ffdc068 loplugin:virtualdead unused param in IContainerApprove 
Change-Id: I59edede149d02085125ee946994b6088c3152e7b
Reviewed-on: https://gerrit.libreoffice.org/81246
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-22 08:13:38 +02:00
Noel Grandin
5dcee37fc4 loplugin:virtualdead unused param in IControlActionListener 
Change-Id: I2ce8df6a9a1ac2e6d6c5de08b32fb671bf10cd17
Reviewed-on: https://gerrit.libreoffice.org/81244
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 19:32:13 +02:00
Noel Grandin
501233bf55 loplugin:virtualdead unused param in OTableRowView 
Change-Id: Ice8d68284800e12af3e334722cc6109a1614e335
Reviewed-on: https://gerrit.libreoffice.org/81243
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-21 19:31:47 +02:00
Caolán McNamara
c02c1c2eee cid#1453991 Wrapper object use after free 
Change-Id: I6476c765589cbb3996ad8832a0e159aa4d965d32
Reviewed-on: https://gerrit.libreoffice.org/81173
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-20 21:15:37 +02:00
Caolán McNamara
4dde0d06bd cid#1453991 Wrapper object use after free 
Change-Id: I4ea3ed40deaf20e91e1a0a42ee115cf761853875
Reviewed-on: https://gerrit.libreoffice.org/81170
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-20 19:16:47 +02:00
Noel Grandin
74f938bb10 loplugin:unusedmethods 
Change-Id: I95e63105654952d12c1dfd62f51593de114be569
Reviewed-on: https://gerrit.libreoffice.org/81077
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 07:59:43 +02:00
Noel Grandin
3ebbb15024 loplugin:buffereadd find stuff involving adding *StringBuffer 
and create conversion methods on *StringBuffer to make this work

Change-Id: I3cf5ee3e139826168894b46eff8ee4bcde00cb7e
Reviewed-on: https://gerrit.libreoffice.org/80949
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-17 18:16:28 +02:00
Stephan Bergmann
8b4719c29f Rename OUStringLiteral1 to OUStringChar 
It started out as a wrapper around character literals, but has by now become a
wrapper around arbitrary single characters.  Besides updating the documentation,
this change is a mechanical

  for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done

Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f
Reviewed-on: https://gerrit.libreoffice.org/80892
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-10-17 07:28:49 +02:00
Noel Grandin
4a96fb8ec0 loplugin:bufferadd loosen some constraints 
and extend O*StringView to have a constructor that takes a pointer and a
length

Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8
Reviewed-on: https://gerrit.libreoffice.org/80872
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-16 12:12:31 +02:00
Noel Grandin
f13c6ad5f0 new loplugin:bufferadd 
look for OUStringBuffer append sequences that can be turned
into creating an OUString with + operations

Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6
Reviewed-on: https://gerrit.libreoffice.org/80809
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-15 14:33:57 +02:00
Caolán McNamara
f7a475dc7c ToolBoxHelper is now unused 
Change-Id: I5e492fda0ce2b88c4e6790a6972bc36f082003a1
Reviewed-on: https://gerrit.libreoffice.org/80691
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-13 16:16:52 +02:00
Noel Grandin
cdbac696fb simplify "a = a +" to "a +=" 
mostly so that my stringadd loplugin can point out places to improve

Change-Id: I9920ee1c99cdb6b811ba67ff9d8e32aa261884b5
Reviewed-on: https://gerrit.libreoffice.org/80618
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-11 07:18:11 +02:00
Noel Grandin
241bee7e4b convert WriteCharPtr..getStr to WriteOString 
and improve the WriteOString method, we can avoid the strlen here, we
already have the length

One change in behaviour to be noted - if the string contains
trailing zero bytes, which ARE INCLUDED IN THE STRING LENGTH,
i.e. I'm not talking about the normal terminating zero, then this
patch changes behaviour because we will now write those zeros to
the stream.

Change-Id: I4668b9b9eb877f820b1dc70d6cd10ba2623bc0a2
Reviewed-on: https://gerrit.libreoffice.org/80597
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-10 18:50:52 +02:00
Stephan Bergmann
7d361e96c9 loplugin:redundantpointerops 
(All related to uses of std::shared_ptr, which builds against libstdc++
apparently missed (fix forthcoming) and which I only now found with my macOS
build against libc++.)

Change-Id: If581e689f0e5ff62d9ce35513c9ff87b00328766
Reviewed-on: https://gerrit.libreoffice.org/80548
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-10-09 20:42:44 +02:00
Julien Nabet
8e0c45246a Resolve FIXME Decimal Separator should be OUString (connectivity/dbaccess/svx) 
instead of a sal_Char

Change-Id: I14fd983dac7ceb83a788c26dd4ea9d1c87444c9a
Reviewed-on: https://gerrit.libreoffice.org/80493
Tested-by: Jenkins
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-10-09 14:09:22 +02:00
Noel Grandin
682fdbf131 loplugin:redundantpointerops check other pointer types 
as well as unique_ptr

Change-Id: I54842bca161ee460fb96c46ca31b6f9c0a7dbbdf
Reviewed-on: https://gerrit.libreoffice.org/80455
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-09 07:44:49 +02:00
Noel Grandin
4390041224 enable -Wrange-loop-analysis on clang 
Change-Id: I2095308943c94ad16c110d5fac47715398eb5d39
Reviewed-on: https://gerrit.libreoffice.org/80187
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-07 09:42:23 +02:00
Caolán McNamara
48595c805d Related: tdf#127935 set default activate handler to toggle row expansion 
Change-Id: I2bbfb1445b8d2e748f642cdf4723d41b7f072e2b
Reviewed-on: https://gerrit.libreoffice.org/80305
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-06 22:14:17 +02:00
Noel Grandin
6a789e617e improve SfxPoolItem operator== implementations 
(*) make them all call the superclass operator==
(*) make the base class check which and typeid to ensure
we are only comparing the safe subclasses together
(*) remove a couple of operator== that were not doing
anything useful

Change-Id: Ia6234aed42df04157a5d6a323dc951916a9cb316
Reviewed-on: https://gerrit.libreoffice.org/80308
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-06 11:58:50 +02:00
Caolán McNamara
588dceaa38 don't need button.hxx here 
Change-Id: I6c3225e28a05633fb68d5a08e2134c1251308717
Reviewed-on: https://gerrit.libreoffice.org/80231
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-05 16:13:22 +02:00
Caolán McNamara
76c5f33e65 move file picker only code to fpicker 
Change-Id: I47cc2cb7db396a06a2abeffe4a5d40a039f21c58
Reviewed-on: https://gerrit.libreoffice.org/80222
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-05 16:06:59 +02:00
Caolán McNamara
3022dc22ce weld OCollectionView 
Change-Id: I3aac2b42442ec3f61c2d18369eae061ae44880a5
Reviewed-on: https://gerrit.libreoffice.org/80205
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-04 21:15:03 +02:00
Caolán McNamara
ea00e07467 drop some unnecessary includes 
Change-Id: I5bea83184dd900215ca6f60ba23a4d724789c753
Reviewed-on: https://gerrit.libreoffice.org/80190
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-04 20:39:17 +02:00
Caolán McNamara
a7411c2ee5 document 0 len case of set_max_length 
Change-Id: I8300ff2d68f35da38e2314eefa7f2a2184981eab
Reviewed-on: https://gerrit.libreoffice.org/80194
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-04 20:37:32 +02:00
Caolán McNamara
a6dfb3245f sSubFolder contents is always overwritten 
Change-Id: Ic2183a81f85dfec5361db9bf42174f2f9218ae5b
Reviewed-on: https://gerrit.libreoffice.org/80204
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-04 20:37:07 +02:00
Noel Grandin
316557d6f4 loplugin:unusedfields 
Change-Id: If0df5216dccd2c0a7aa790668471993f5d4d5d32
Reviewed-on: https://gerrit.libreoffice.org/80183
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-04 14:22:55 +02:00
Noel Grandin
9db8406b83 loplugin:virtualdead 
Change-Id: I86bae18ed2682871032aeb2a178f49f3e4601129
Reviewed-on: https://gerrit.libreoffice.org/80129
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-03 16:34:45 +02:00
Noel Grandin
09f77e8ed5 loplugin:unusedmethods 
Change-Id: I9790d053248ae6bd58ecc026c774014c4e5e04aa
Reviewed-on: https://gerrit.libreoffice.org/80115
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-03 16:34:31 +02:00
Caolán McNamara
8e7679cb34 fix DbaIndexDialog EditingActive 
Change-Id: I7f0fe341fef08358d71b13e646065b26f8a73951
Reviewed-on: https://gerrit.libreoffice.org/80114
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-03 13:44:15 +02:00
Noel Grandin
77e9216ca1 loplugin:unusedfields 
and filter out the weld fields, since we're not touching them yet

Change-Id: I3cc23c46d2650f13cb29c7d381687939d23e2882
Reviewed-on: https://gerrit.libreoffice.org/80104
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-03 12:16:38 +02:00
Caolán McNamara
81903d4431 merge msgbox and stdtext 
Change-Id: If95d78746eff3ae5343e7d4c6bb2433537ccb84d
Reviewed-on: https://gerrit.libreoffice.org/80099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-03 11:11:14 +02:00
Caolán McNamara
ee2e8d0c06 drop some unnecessary includes 
Change-Id: I656ed2e29988fe47e4db8fa2ea8edec022bd56c2
Reviewed-on: https://gerrit.libreoffice.org/80098
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-03 11:10:58 +02:00