Commit Graph

399050 Commits

Author SHA1 Message Date
Noel Grandin
1f7c5d2a55 loplugin:expandablemethodds in include/sfx2
Change-Id: I1ec3ae33a71d154276e213a68c735476daa606b9
2016-10-21 13:23:02 +02:00
Tor Lillqvist
3be8c4c2bb The badvectorinit plug-in probably can be retired
Let's hope it only catches false positives now.

noelgrandin agrees.

Change-Id: Ibd8310c31897aa6835bd6aaf90a49b5cd8f92948
2016-10-21 14:18:20 +03:00
Yousuf Philips
24b4487e50 tdf#103170 Heikobar: Add it to Impress
Change-Id: I6563ca2dd736c879c42ab93a509040909f74f884
Reviewed-on: https://gerrit.libreoffice.org/30113
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-21 10:32:14 +00:00
Yousuf Philips
c18e169ce8 tdf#90937 Adjust Note cell style border width and color
Change-Id: I1ce6d39738ef199c55d95737d7b12cd68af01ace
Reviewed-on: https://gerrit.libreoffice.org/30104
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-21 10:29:18 +00:00
Yousuf Philips
ac374ebf05 tdf#103223 custom palette label and a11y improvements
In the color section of the Area fill tab, i've added a custom palette
label above the add and delete buttons, moved the palette label and
control on the same line and improved the accessibility of various
controls by adding tooltips and associating labels.

Change-Id: I4a8c9963fd23312190ba343dbb1a0db587b13d1e
Reviewed-on: https://gerrit.libreoffice.org/29894
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-21 10:28:24 +00:00
Caolán McNamara
1473ce0303 implement CryptoAPI RC4+SHA1 encryption scheme for xls import
there might be other variants out there in practice, but this
works for default encrypted xls of excel 2013

Change-Id: I91c0e1d1d95fbd1c68966650e7ac7d23276bcbe3
2016-10-21 11:16:11 +01:00
Caolán McNamara
06916c839b split MSCodec_Std97 into a baseclass MSCodec97
Change-Id: Ia3c41a048169c78684800def94e53fc9f3201e30
2016-10-21 11:16:11 +01:00
Caolán McNamara
3fabbd0a22 rework things in light of now available documentation
Change-Id: If5f75e27191017a8c6a3929e2a70d21840f157c6
2016-10-21 11:16:11 +01:00
Caolán McNamara
fc514cbf30 move some useful header information to mscodec for reuse
Change-Id: Ic7adf3ed3c8279cc93a06975d6fb337210d1af87
2016-10-21 11:16:11 +01:00
Caolán McNamara
fcc846e8f2 hash len isn't going to change depending on who implements it
Change-Id: Iee585cba4acad74c11d083085153e2af96c8894f
2016-10-21 11:16:11 +01:00
Noel Grandin
5a5731cd05 loplugin:expandablemethodds in include/basic..comphelper
Change-Id: I1aa9c12e8839325a9fd98530abc89a3d586ff62e
Reviewed-on: https://gerrit.libreoffice.org/30120
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21 09:57:38 +00:00
Noel Grandin
d24bc6089c loplugin:expandablemethodds in include/vcl
Change-Id: I9ff378d9c7c9a221599c0a84df638b3acf8f069f
Reviewed-on: https://gerrit.libreoffice.org/30121
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21 09:08:39 +00:00
Miklos Vajna
5d8ba79849 CppunitTest_sc_ucalc: fix loplugin:cppunitassertequals warnings
Change-Id: Ie29cc49b98cb06f9b6a30b27d0c53f9393c28b67
Reviewed-on: https://gerrit.libreoffice.org/30119
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-21 08:52:50 +00:00
Maxim Monastirsky
78cdc47489 Arrow style dropdown was applying the wrong line ends
Regression of:

commit 2b68e03348
Date:   Mon Aug 15 09:19:35 2016 +0200

    tdf#100782 have XPropertyList hold unique_ptr

Change-Id: Ib2bb4c25f93de45823aba43aa7c04075283d4097
2016-10-21 11:15:03 +03:00
Maxim Monastirsky
199a449e2a Silence warning
warn:vcl.layout:32414:1:vcl/source/window/builder.cxx:3100:
unknown class

Change-Id: I8019f8568b33f5a67c0acedb962d991cc1c93a1a
2016-10-21 11:13:53 +03:00
Caolán McNamara
5c0265a78a coverity#1374090 Unintentional integer overflow
and

coverity#1374091 Unintentional integer overflow

Change-Id: Ia36b1feafc44e6ea65c55c9ffc661256276d9b29
2016-10-21 09:04:49 +01:00
Caolán McNamara
851703f2c5 coverity#1371270 Missing move assignment operator
Change-Id: I47438184a9a895b7aa9889ae1308fda29434a774
2016-10-21 08:59:05 +01:00
Caolán McNamara
0454c5717f coverity#1371301 Missing move assignment operator
Change-Id: Ic6f11b8e39bafd401f4b261fa8aad66d8782ebeb
2016-10-21 08:59:05 +01:00
Stephan Bergmann
18f1965834 Remove convertPropertyValue overload for OUString
...it never did anything different than the generic template overload.

Strictly speaking, removing that inline function overload could be considered an
API change, but it shouldn't cause any issues in practice even when recompiling
all code against the new include files.

Change-Id: Icb0942f56ee0888f09d3478f34d568d44651c838
2016-10-21 08:58:37 +02:00
Stephan Bergmann
2e7b806711 Some clean-up
Change-Id: I6a46af4e6ba42f1c104662e7a035b7ecfc404752
Reviewed-on: https://gerrit.libreoffice.org/30111
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-21 06:56:16 +00:00
Noel Grandin
5034914c7a loplugin:expandablemethodds in include/svtools
Change-Id: I679b7985861203496813782138d1cf965fbc427b
Reviewed-on: https://gerrit.libreoffice.org/30107
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21 06:18:40 +00:00
Noel Grandin
f0ae4082eb loplugin:expandablemethodds in include/xmloff
Change-Id: I6b1430220adaf240ef873ff908e3a767dfc278bf
Reviewed-on: https://gerrit.libreoffice.org/30106
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21 06:18:01 +00:00
Noel Grandin
ece0ff48fa loplugin:expandablemethodds in include/tools..unotools
Change-Id: I5607d4a2a81de1a3ae329acd1e90280a21522f06
Reviewed-on: https://gerrit.libreoffice.org/30097
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21 06:17:24 +00:00
Noel Grandin
1c42433322 loplugin:expandablemethodds in sw(part4)
Change-Id: Ifedc5be99775d00f09e03261c6bb446135ac796a
Reviewed-on: https://gerrit.libreoffice.org/30096
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21 06:16:29 +00:00
Miklos Vajna
81bbede18f cid#1374093 unreachable code
Change-Id: Ib34aa7af7bdba304fe1f212d39c3c6de24e87a2d
2016-10-21 08:13:06 +02:00
Pranav Kant
84bfe584e4 tdf#102511: Add (allow-none) for backward GI compatibility
(allow-none), though deprecated since GI 1.42, is required to
maintain the backward compatibility since (nullable), added in
GI 1.42, is not understood by GI tools < 1.42 preventing the
clients from passing a null parameter to various functions in the
widget.

We can remove this deprecated (allow-none) annotation once we
bump the GI version in LibreOffice to atleast 1.42

Change-Id: I98a1f3d2205ec5afd8060f16e69c5f938f229e26
2016-10-21 11:38:29 +05:30
Miklos Vajna
f7a6867d6a xmlsecurity: export description in PDF signature
Extract appendUnicodeTextString() from the PDF writer impl, and reuse it
in xmlsecurity, to share code.

Change-Id: Icdc2f89132cd29e07280001e30bad97e0a644654
Reviewed-on: https://gerrit.libreoffice.org/30110
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-21 06:05:13 +00:00
Khaled Hosny
da8357463c Add vim modeline to new files
Change-Id: I01cbd3b0698d458d8ba7267f2c70271db14f559f
2016-10-21 02:38:51 +02:00
Thorsten Behrens
8a796410ec vcl: remove redundant public
Change-Id: I8c05e884719dd434ac7fd929186da2a0e9f44e6c
2016-10-21 00:59:29 +02:00
Thorsten Behrens
ff84b8a242 coverity#1374089: Unchecked return value
Change-Id: Ied4e80db512000471b5aa215beeef1277121fe12
2016-10-21 00:54:46 +02:00
Maarten Bosmans
580cddc626 Convert ScConsData into using std::vector
This simplifies the ScReferenceList handling significantly.

Change-Id: I2204a4d56c98fdf7dcd593901dcf5cc0f7c52a62
Reviewed-on: https://gerrit.libreoffice.org/29530
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2016-10-20 22:53:47 +00:00
Mike Kaganski
acfe9c225a Incapsulate WinSalVirtualDevice better
Change-Id: I8de745e2318c69ccec2ffabb69df598a4bf60480
Reviewed-on: https://gerrit.libreoffice.org/30071
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-20 21:30:35 +00:00
Khaled Hosny
66c1ae50e4 Typo in commented-out code
Change-Id: I9f276a6de54dd3542249b47986d2ca6b3f27413d
2016-10-20 23:23:51 +02:00
Khaled Hosny
95c7871604 Vertical Mongolian and Phags-pa seem to work fine
The fonts are designed so that they are rotating 90° is all needed, so
we don’t to rotate them back, unlike CJK.

Change-Id: I0afa4b066257718a5a52eb2e93a18ce839aec2f0
2016-10-20 23:23:50 +02:00
Henry Castro
d7d07ade28 sc: check SID_EDIT_POSTIT parameters
Avoid crash when execute .uno:EditAnnotation with missing
arguments

Change-Id: Iaee8694b7481933f3672a3847264a49a6503b82e
Reviewed-on: https://gerrit.libreoffice.org/30116
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-10-20 21:19:26 +00:00
Noel Grandin
aba0f624c8 loplugin:expandablemethodds in sw(part3)
Change-Id: I7db01985a35407e4169709ede5324656c6629047
Reviewed-on: https://gerrit.libreoffice.org/30095
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20 17:55:36 +00:00
Noel Grandin
e8260df1d6 loplugin:expandablemethodds in sw(part2)
Change-Id: Idc2118899a8063099b66c0f5db40d8402db063d1
Reviewed-on: https://gerrit.libreoffice.org/30083
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20 17:55:01 +00:00
Giuseppe Castagno
52350c15b3 tdf#103274 (11): Add default XCommandEnvironment reference
Change-Id: I8145e167ef58d83666c2f18adf869a30c859ee8f
Reviewed-on: https://gerrit.libreoffice.org/30036
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-20 17:43:36 +00:00
Eike Rathke
27fcf60468 unit test for tdf#97968, Cut&Paste grouped references adjustment
Change-Id: Id644012454d992c01ebcce6fe35d1dcdd1bc4d53
2016-10-20 19:39:53 +02:00
Miklos Vajna
7f671122df xmlsecurity: show PDF signature right after adding it
Also:

- handle PDF in DocumentSignatureManager::write(), so the PDF file is
  not truncated when closing the document signatures dialog, and
- handle PDF in DigitalSignaturesDialog::canAddRemove()

Change-Id: I77c1fcdcbdcb079ce934f37546129d9d280e5d2e
2016-10-20 17:08:00 +02:00
Stephan Bergmann
c48cd497b2 Revert "Some clean-up"
This reverts commit 0b04e8f80e, shuffling the code
around started to cause some builds to complain with -Werror=maybe-uninitialized
in places where they did not before.  Needs a better fix.
2016-10-20 17:03:27 +02:00
Khaled Hosny
d5424208a5 Reuse the HarfBuzz buffer as much as possible
Less allocations in case we have many sub runs.

Change-Id: I50d4a57702c030c185fc7edef576c64d739a6194
2016-10-20 16:57:23 +02:00
Khaled Hosny
7854d35cd8 Use HarfBuzz shape plan for a bit more control
This way we control exactly what shapers we use in what order, and as an
extra we can now tell which shaper HarfBuzz ends up using.

Change-Id: Idd303b2a557e16ac86ada0c2006d3e2a052ac489
2016-10-20 16:57:23 +02:00
Miklos Vajna
22a2fa4633 vcl: add PDFWriter::Sign() Android stub
Change-Id: Ib8bc5e700a54135317359a130ceb2c06ff7af103
2016-10-20 16:50:47 +02:00
Stephan Bergmann
0b04e8f80e Some clean-up
Change-Id: Ifd36b0f364dd1d5d38095d32409f8587b0662ace
2016-10-20 16:46:50 +02:00
Takeshi Abe
5e4a2abde9 sw: Avoid inheritance from std::vector
Change-Id: I4ee09871ec0fa5c67a8d4c4c448229ec2deda4c2
Reviewed-on: https://gerrit.libreoffice.org/30075
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-20 14:22:05 +00:00
Andras Timar
373f3313a5 typo: imgage -> image
Change-Id: I5f650293719ad790eb5b4f5d5d448399356f386e
2016-10-20 16:09:51 +02:00
Stephan Bergmann
959bf16fb7 No need for an explicit specializtion of convertFastPropertyValue<bool>
Change-Id: I7b5799ed67b8d5da6cb3e6c4e7c76f05a2ec3853
2016-10-20 15:41:23 +02:00
Christian Lohmaier
b1b0a62181 bump product version to 5.3.0.0.alpha1+
Change-Id: I7dc5e6925962d948f8d61cd0c951331e78fcb08e
2016-10-20 15:26:10 +02:00
Giuseppe Castagno
6e261cb19e Revert "prep WinResTarget for WNT in testdir"
Still random failures in Gerrit Windows builds.

This reverts commit f5c54089b5.

Change-Id: Iec48d2388691577ccd675b9a73941cedceebd527
Reviewed-on: https://gerrit.libreoffice.org/30103
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-20 13:10:15 +00:00