Commit Graph

399050 Commits

Author SHA1 Message Date
Miklos Vajna
e9834a3eaf xmlsecurity: fix the PDF incremental update's cross-references table
The VCL pdf export writes a space after the in-use entry, and turns out
Adobe Acrobat starts to "repair" the file if there is no such space.
Which means the signature is validated against the repaired document,
resulting in a "The signature byte range is invalid" error message,
hiding the root cause.

Not that ISO-32000 7.5.4 "Cross-References Table" would mention the need
for such whitespace at the end of the lines.

Change-Id: I165b57809550f184f374c00f28426a3cd813c63f
2016-10-19 16:46:20 +02:00
Caolán McNamara
f7397024fe coverity#1371215 Missing move assignment operator
Change-Id: Icfea2ad2ba98d7537cf1963ad3832ade192c5fd4
2016-10-19 15:26:50 +01:00
Caolán McNamara
724f2b20d8 coverity#1373663 Untrusted loop bound
Change-Id: Iabad14f8fc35656015b98693dd327a41aeaf63c7
2016-10-19 15:07:14 +01:00
Yousuf Philips
0ae76ce8ba tdf#103317 remove single master simple gradient templates
Change-Id: Ifb0a1fc11a5cc497a90496ca8afc60e2271f9ec3
Reviewed-on: https://gerrit.libreoffice.org/30021
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-19 13:32:02 +00:00
Yousuf Philips
2f3f06461e tdf#102284 Allow footnote separator thickness of 0pt
Change-Id: I7a8543836b8747f9523a844f041b143d0d18d9c5
Reviewed-on: https://gerrit.libreoffice.org/29932
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-19 13:24:59 +00:00
Yousuf Philips
10b24e7fa8 tdf#103170 Heikobar: hide list buttons and add third column to insert
Change-Id: I4c34949a4ed1cbbab3ff3741fa0a0dd11d084fff
Reviewed-on: https://gerrit.libreoffice.org/30026
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-19 13:24:14 +00:00
Takeshi Abe
d24694fb1b sw: Avoid inheritance from std::list
Change-Id: Ifb45d20a1556db8d8ba01b65078b45df73bc8dcc
Reviewed-on: https://gerrit.libreoffice.org/30037
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-19 13:15:54 +00:00
Caolán McNamara
ef044f8245 Resolves: tdf#100841 use Popover instead of Tooltip for the fill series hint
Change-Id: Id84265d7c76869059144e28c1d9a735efa46fe29
2016-10-19 14:14:16 +01:00
Maxim Monastirsky
4a74c8af0b tdf#103264 Missing case for SID_SAVE_BACKGROUND
Regression of:

commit 93b4bf647a
Date:   Fri Jul 31 02:28:28 2015 +0530

    tdf#89466: Slide Background tab

Change-Id: I1c6d1d35c47e6e4400d65474c84b2c3ebeb0330f
2016-10-19 15:10:48 +03:00
Stephan Bergmann
d1c8e18464 Help old GCC versions
Change-Id: I17e05a0ca985241030c71e7d08b81c1290ef1bc9
2016-10-19 14:09:21 +02:00
Caolán McNamara
cd1c20ea54 make the 'Breeze_dark' name look less stupid in the icon theme dropdown list
Change-Id: I3e0be0f5f83e0191988c63c709c090ba4c936d61
2016-10-19 13:03:24 +01:00
Caolán McNamara
75544eb042 Resolves: tdf#102778 by default use breeze_dark when dark themes are requested
Under gtk3 if gtk-application-prefer-dark-theme is enabled or the requested
icon-theme name ends in [-|_]dark

Change-Id: Ia70ea3adc51ac0ec2b26d08fc960c1c7285c338b
2016-10-19 12:59:19 +01:00
Maxim Monastirsky
42e89217fb No need to check here if menu name is empty
We now do this on the ResourceMenuController side.

Change-Id: Ic249b6a687fe059393ccf55bbc4534242c08e30e
2016-10-19 14:01:32 +03:00
Michael Meeks
c00d8271ba vcl: assert solar mutex is held for various timer / scheduler ops.
Bringing paranoia to some source-code near you.

Change-Id: I92bc1e17480405a6388c2cbd1c7b559728539f67
Reviewed-on: https://gerrit.libreoffice.org/30024
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-19 10:58:13 +00:00
Armin Le Grand
0f5d4da2b4 profilesafe: Deeper integration with SafeMode
Added deeper integration by saving at SaveMode content of user dir
completely to a user/SafeMode dir, including the whole stack
of pack files. Repair happens in that safe directory, so that
the user dir is resetted to default when re-started in SafeMode.
All changes (including complete deletion) are played back to
the user config at first restart with disabled SafeMode

Change-Id: I5114c7d5d04582be62090707bc9b97afa55fc1f1
Reviewed-on: https://gerrit.libreoffice.org/30003
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-19 10:50:11 +00:00
Giuseppe Castagno
17b94a616d tdf#103274 (9): Add default XCommandEnvironment reference
Change-Id: If1b7bc913e392f511caf0684baa5bc3ce2c6933d
Reviewed-on: https://gerrit.libreoffice.org/30035
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-19 10:44:15 +00:00
Caolán McNamara
99ee085d43 two elements at the same packing position
if you use glade to edit the .ui files then this sort of
cockup which reeks of manual xml editing doesn't arise

Change-Id: Ic339953cad15078bc847a4c31c0c7592b071b454
2016-10-19 10:31:42 +01:00
Miklos Vajna
0c34cd41c6 CppunitTest_desktop_lib: fix stack-use-after-return
The LOK callback objects registered are on-stack objects, so we must be
sure that references no longer used after we return.

Process idle events, so that desktop::CallbackHandler::flush() won't try
to use the reference after return.

Change-Id: I65d324cb9cef4fd1776d0f610d8d096717e0e833
Reviewed-on: https://gerrit.libreoffice.org/30034
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-19 09:22:52 +00:00
Stephan Bergmann
d6ff3d49df Plugin::isInUnoIncludeFile should not cover WORKDIR
...that got in, for no apparent reason, when various, slightly different
implementations of isInUnoIncludeFile got consolidated into one.

Change-Id: I64a9eb62703d57a0b7b57720ec9f251ffa780691
2016-10-19 10:56:35 +02:00
Khaled Hosny
66b3aa76b1 Add missing icu_headers dependency
Apparently this was working before by accident since most people have
ICU headers in the system include path on Linux.

Should fix the failing tinderbox.

Change-Id: I796453e66c53b3c64e546c661007a54fa5d866ec
2016-10-19 10:52:37 +02:00
Ashod Nakashian
6b5b773488 tdf#103185 - Add VCL backend being used to About dialog
The VCL backend is now shown on the About dialog.

Change-Id: Ib4e6b33e9c2b3ec2fca229fed8f4533227a67ac6
Reviewed-on: https://gerrit.libreoffice.org/29798
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-19 08:44:05 +00:00
Noel Grandin
1690b84015 loplugin:expandablemethodds in reportdesign..sal
Change-Id: Idb133e442b881d263fcb83a4858c4a08b451c0f0
Reviewed-on: https://gerrit.libreoffice.org/30032
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 08:36:31 +00:00
Noel Grandin
6581152f03 loplugin:expandablemethodds in sc
Change-Id: Idda64b23ea91ec457b60279d851b7f01d8c02881
Reviewed-on: https://gerrit.libreoffice.org/30033
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 08:35:32 +00:00
Tomaž Vajngerl
94b6b4678b opengl: blit offscreen framebuffer instead of drawing
Change-Id: I3ab0da9cf83e0e85b8442b34ecd6eb91dd3d1bd3
Reviewed-on: https://gerrit.libreoffice.org/27875
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-19 08:08:51 +00:00
Noel Grandin
877774c057 loplugin:expandablemethodds in hwpfilter..linguistic
Change-Id: If20fd4a6cf8a8e005804dbb7caf41cce73d587a5
Reviewed-on: https://gerrit.libreoffice.org/30016
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 08:07:18 +00:00
Noel Grandin
f019ee7cf9 loplugin:expandablemethodds in basctl..chart2
Change-Id: I96f565a974fe3e316ae2ab04f8731b8bbfb87993
Reviewed-on: https://gerrit.libreoffice.org/29998
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 08:07:04 +00:00
Andras Timar
9e54e0708d Updated core
Project: translations  35a31ff71279807598c4ee4cd84d831e2c3270dd

Updated Slovenian translation

Change-Id: I5b14dba08f409bbedaca6100be56b1374a5328cf
2016-10-19 08:05:40 +00:00
Noel Grandin
f1693c5387 use early returns in View::OnEndPasteOrDrop
Change-Id: I37afbd64c4f4887aa6a0262ffc362ec8714cbf91
2016-10-19 10:01:45 +02:00
Miklos Vajna
10cfa2abee starmath: clean up redundant virtual keywords in unofilter
Change-Id: I97af23d22c0b4eb416172e9ebea9544541621cb0
Reviewed-on: https://gerrit.libreoffice.org/30031
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-19 08:00:17 +00:00
Noel Grandin
423936ffac loplugin:expandablemethodds in formula..framework
Change-Id: I6c8b1bb3b664faa92b2dc05955c30bfd35f6dfaa
Reviewed-on: https://gerrit.libreoffice.org/30015
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 07:57:11 +00:00
Noel Grandin
e7782a99a5 accidentally left the expandablemethods loplugin active
Change-Id: Ifadab184876163195ea3307ec32d2eed4ee00b92
2016-10-19 08:40:17 +02:00
Noel Grandin
e140e40c12 loplugin:expandablemethodds in lotuswordpro..package
Change-Id: Id33d88edc4be00f4238792d885e392cc08e72386
Reviewed-on: https://gerrit.libreoffice.org/30017
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:33:41 +00:00
Noel Grandin
0aa24916cb loplugin:expandablemethodds in filter..forms
Change-Id: Ic1f64f804acc10b1a48d82de9fc6a2b39af465a0
Reviewed-on: https://gerrit.libreoffice.org/30014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:32:58 +00:00
Miklos Vajna
365f2e9054 cid#1374076 uncaught exception
Change-Id: Ifdbfc9f905f2ed7778830a0f2cc114d27feb36da
2016-10-19 08:32:23 +02:00
Miklos Vajna
90717e7d36 cid#1374075 uncaught exception
Change-Id: I1c95efb37e62c5e600607d23e4e80bf430854cae
2016-10-19 08:32:23 +02:00
Miklos Vajna
6947962b08 cid#1374074 uncaught exception
Change-Id: Ibb734d394b49a032fab1dc1255376d6b7bb3632d
2016-10-19 08:32:23 +02:00
Noel Grandin
6f96e86dae loplugin:expandablemethodds in editeng..extensions
Change-Id: Ibe1929d74ff460955e39f2ccce3056b2051ddf08
Reviewed-on: https://gerrit.libreoffice.org/30013
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:31:43 +00:00
Noel Grandin
ef637a1c4e loplugin:expandablemethodds in dbaccess..drawinglayer
Change-Id: Iee9143999f5c94040dadd378006f2a429ca0edb5
Reviewed-on: https://gerrit.libreoffice.org/30012
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:30:48 +00:00
Luke Deller
834809dbbe Avoid AskConfig when setting font family
Avoid calling the expensive ImplFont::AskConfig from Font::SetFamily
as we are just going to overwrite the font family anyway.

It looks like this crept in accidentally in the recent refactor
commit e418d1a9c8

Change-Id: I12a9bde77ffcc81f03c37ce400c59ea3a9acac31
Reviewed-on: https://gerrit.libreoffice.org/28901
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-10-19 06:30:22 +00:00
Noel Grandin
dcb1fbef20 loplugin:expandablemethodds in cui
Change-Id: I7b2321d45171f9b73965efea32832a3789f0dee7
Reviewed-on: https://gerrit.libreoffice.org/30011
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:26:00 +00:00
Noel Grandin
98b77ad1e6 loplugin:expandablemethods in UnoControls..vbahelper
Change-Id: Iec2c5e13119d97c9ca87e083c0f7cb00227e5231
Reviewed-on: https://gerrit.libreoffice.org/29997
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:24:23 +00:00
Noel Grandin
7e48876799 tdf#103083 - EDITING: Cut and Paste changes bullet point formatting
The bug is that, on paste, the incorrect stylesheet is set on a paragraph
node, leading to the loss of bullet formatting information.

There are two copies of this style-resetting code, one in
   sd::View::OnEndPasteOrDrop
and the other in
    Outliner::ImplSetLevelDependendStyleSheet.

The first one was introduced by:
    commit 8aa3d1214b
    Author: Rüdiger Timm <rt@openoffice.org>
    Date:   Fri Jun 6 11:11:54 2008 +0000
    INTEGRATION: CWS impressodf12 (1.62.4); FILE MERGED

And the second one by:
   commit a6b3e8c149
   Author: Rüdiger Timm <rt@openoffice.org>
   Date:   Fri Jun 6 11:30:58 2008 +0000
   INTEGRATION: CWS impressodf12 (1.70.350); FILE MERGED

The second one appears to do the right thing, and fixes this bug,
so I am deleting the first one.

Change-Id: I5eede7fe7bd3aa24696b495e740d1a4df124bd3a
Reviewed-on: https://gerrit.libreoffice.org/30009
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:23:38 +00:00
Jochen Nitschke
930f0242a1 replace <<= with assign for <<= with rhs Any
queryAggregation and queryInterface return Any

Change-Id: Ib8e3e742bd66f7419cad583988b247bb628f7b4a
Reviewed-on: https://gerrit.libreoffice.org/29912
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-19 05:28:29 +00:00
Kohei Yoshida
42062d99f1 tdf#93894: Write a new test case for column and row labels combined.
Change-Id: I76e1f6f3c3aed9d940e4433026f752f3630f2373
2016-10-18 20:27:45 -04:00
Kohei Yoshida
2b32042294 tdf#93894: These assumptions no longer hold.
Since we've switched to not grouping formulas with column / row
labels.

Change-Id: I0097a5103b5dfaa5b021ee76545beb9f24ac7bd3
2016-10-18 20:27:36 -04:00
Kohei Yoshida
e944d95104 tdf#93894: Prohibit grouping when certain token types are present.
For instance, column / row label tokens don't work correctly in
grouped cells with the current implementation.

Change-Id: Idf86312ef15fbfd4382aa90ee6d131c671a80683
2016-10-18 20:27:16 -04:00
Tomaž Vajngerl
baeb3b43fb opencl: convert to C++11 for loop
Change-Id: Id96a3816eb7ef2241f5a6a57b164e1e366eb357a
Reviewed-on: https://gerrit.libreoffice.org/29693
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-18 22:13:24 +00:00
Krunoslav Šebetić
c01b15514e Update autocorrect for Croatian
Change-Id: I23254c546ddffc080a4239be103618c4b4514095
Reviewed-on: https://gerrit.libreoffice.org/29985
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-18 21:41:14 +00:00
Giuseppe Castagno
71dfc1113e tdf#103274 (8): Add default XCommandEnvironment reference
Change-Id: I583ed0714c0bf543c44c098613e1aab9d3b31452
Reviewed-on: https://gerrit.libreoffice.org/30007
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-18 19:36:16 +00:00
Jochen Nitschke
d1ea6ecda6 replace <<= with assign for <<= with rhs Any
found by deleting specialization of '<<=' template

Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c
Reviewed-on: https://gerrit.libreoffice.org/29956
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18 19:16:44 +00:00