399050 Commits

Author SHA1 Message Date
Eike Rathke
c857e5ef42 display matching search per selected category, tdf#67974 follow-up
Also select category All while typing in Search, and display the LRU list
independently.

Change-Id: I8a734cc202e017d3a10d8a6f89b1814073a77c81
2016-10-29 19:25:49 +02:00
Tamás Zolnai
24e522f723 tdf#103753: DOCX: Handle relative positions to left or right margin
Positioning relative to left or right margin in MS Word
works the same as the positioning relative to left or right
page border in LO Writer.

Change-Id: I476a5e9e76f766b7fb7f1c7f4a068af8bb3c8813
Reviewed-on: https://gerrit.libreoffice.org/30376
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-10-29 16:43:27 +00:00
Khaled Hosny
f351b3624d Add layout engine info to the About dialog
Change-Id: I6a87efa5e1072bac3588226df0e1351aa51c4d0d
Reviewed-on: https://gerrit.libreoffice.org/30108
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-29 16:34:31 +00:00
Mike Kaganski
1c708eee63 tdf#103473: Ensure positive rectangle size
Also remove conversion of both negative scales into rotation,
because it is handled by flip; use strict comparison instead of
approximate float less because it's correct here, and also because
basegfx::fTools::less ultimately uses rtl_math_approxEqual, which
description states: attention
approxEqual( value!=0.0, 0.0 ) _never_ yields true.

Unit test included.

Change-Id: Ia878fce360cf8aed539d95f2d4a1a3ad94379978
Reviewed-on: https://gerrit.libreoffice.org/30373
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-10-29 16:17:06 +00:00
Eike Rathke
8a0318e4f8 filter hidden functions also in search, tdf#67974 follow-up
Change-Id: Iaa23759e01d8f86bfc5c0bbd8b333cd331b7b8cd
2016-10-29 17:59:05 +02:00
Abhilash Singh
70e97ade2f tdf#67974 UI: Add a search box in function wizard in Spreadsheet
Change-Id: Idd243824a25ba99b2163f094c531dad7fe1153c8
Reviewed-on: https://gerrit.libreoffice.org/30118
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-10-29 15:32:51 +00:00
Caolán McNamara
b696781f03 crashtesting: piles of pdf import crashes
e.g. ooo112863-2.pdf

Change-Id: I359f7e50f416f0a756e16099cdf47be3b1c32d90
2016-10-29 15:36:59 +01:00
Khaled Hosny
930a3d462b tdf#33278: Enable UI for vertical left-to-right
Used mainly for traditional Mongolian. This has been disable since 2010
(shortly after the code was merged):

commit faf68cc7565cb2662d4ed5b5902ec52975d99865
Author: Mathias Bauer <mba@openoffice.org>
Date:   Fri Jun 25 11:10:43 2010 +0200

    CWS mongolianlayout: disable new direction until problems are fixed

No idea what the problems are, but lets enable it and see what happens
(the actual layout code have been enabled all the time and one can
always manually craft ODT files that use it anyway).

Change-Id: Id38d1735013d451f9fe116876483df3484dec051
Reviewed-on: https://gerrit.libreoffice.org/30364
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-29 13:18:57 +00:00
Justin Luth
bb615bc146 tdf#41542 rename variable to match LO5.4 terminology
Changing /Allow_*Spacing_*Without_*Borders/I
       to AllowPaddingWithoutBorders

related to tdf#103275 where "spacing to contents" is to be changed to
Padding. Rename this already in LO53 to simplify potential backports
and laying other groundwork for fixing this bug.

Also, I can easily see setting AllowPaddingWithoutBorders globally in 5.3
for the purpose of being able to share documents when
the UI in LO5.4 permits creation of padding without borders.
Otherwise older versions will display significantly different formatting.

Change-Id: I253173274f824a019ebc09a039c471d170c1be73
Reviewed-on: https://gerrit.libreoffice.org/30372
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
2016-10-29 12:17:28 +00:00
Tomaž Vajngerl
f19f88a0d4 vcl: move method to the appropriate file, some C++11-ification
Change-Id: If51d16673c8b241487cae5305e293f213b7db5cb
Reviewed-on: https://gerrit.libreoffice.org/30338
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-28 20:55:09 +00:00
Michael Stahl
87c518593d sc: remove antique reference counting hacks from ScDocumentPool
This attempt to prevent overflowing a 16-bit counter was obsoleted by
the conversion of SfxPoolItem's reference count to ULONG in 2001 or so.

Change-Id: Iafb6f151f68cbb84fda59bd134a7a4930f9a4d1f
2016-10-28 22:49:28 +02:00
Michael Stahl
85c38f1cf4 svl: change SfxPoolItem ref-count to sal_uInt32
Fixes the inconsistency between potentially 64-bit sal_uLong and
the max-value macros that are ~2^32.

Change-Id: I895c674819cf4766cb2c7441f670bc1305362a74
2016-10-28 22:49:28 +02:00
Michael Stahl
0117a5d34e svl: more SfxPoolItem asserts
Change-Id: Ic73fe09fc401359f043269fc8e5a1910fc8ddb02
2016-10-28 22:49:28 +02:00
Michael Stahl
855e69d37e svl: SfxPoolItem reference counting assertions
Change-Id: Ice2ec9a4592a1fad36913ae7d089aa8c63dfc669
2016-10-28 22:49:28 +02:00
Khaled Hosny
3d456dfa66 tdf#98879: Fix vertical text on Windows for the new layout
The DirectWrite rendering code wasn’t handling vertical text correctly
at least when used with CommonSalLayout. It has been fixed and now made
the default.

We are also doing all vertical text handling on our own, so loading
special vertical fonts on Windows is now disabled.

Change-Id: I10d150367fe59c77459bb1b813b6f31a0ff0c5d0
Reviewed-on: https://gerrit.libreoffice.org/30346
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-28 19:22:54 +00:00
Justin Luth
c0baab9aa8 reset border should clear all borders
If no borders were originally defined, the reset button was failing
to clear the last-selected border line.

Eg. page border, click on two of the borders, then hit reset. One border
remains defined, and didn't reset to the starting value of non-visible.
Because one border was still "selected", it became visible again as
SelStyleHdl_Impl reinitialized.

Change-Id: I2d20ae1e02816d5b30fe126572b54e7083114fc3
Reviewed-on: https://gerrit.libreoffice.org/30365
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-10-28 18:58:49 +00:00
Stephan Bergmann
25df5f2ac7 loplugin:unnecessaryoverride
Change-Id: I70ba8d3b03c56a597785f109f0cb687bd936bc64
2016-10-28 19:48:44 +02:00
Miklos Vajna
5c33253daf xmlsecurity PDF verify: start using offsets from xref streams
This is needed (but not enough) to verify PDF 1.5 signatures. What's
missing next is support for object streams.

Change-Id: I5afec0a77839ffabe0aaa07e367064210535a1a9
2016-10-28 18:34:14 +02:00
Miklos Vajna
56cc352d82 xmlsecurity PDF verify: initial support of cross-reference streams
This adds support for cross-reference streams (which can be used instead
of plain-text cross-reference tables) + also one stream predictor.

The actual parsed data is still not used, though.

Change-Id: Ia806abd8a97636a1bd25dfdafea377b088800f00
2016-10-28 18:20:20 +02:00
Justin Luth
b41e7b817e tdf#63846 assign macros after VBA project fully loaded.
fixes regression caused by d4743045a0b320449d07a957463a76bb8b13f939.

see the documentation for VbaMacroAttacherBase, which indicates that
the macros are to be attached after all objects are finished loading.

Made attachMacros() public so it could be called separately since so
many things are inter-dependent in the logic flow.

Change-Id: I11f7f4a1a75d6f77a97e12e3359d6ea8a995f518
Reviewed-on: https://gerrit.libreoffice.org/30337
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-28 16:12:27 +00:00
Zdeněk Crhonek
eef81dd68f add MAX test case
Change-Id: Ie32504b84e227cc3f33d89ec46bca1835e433844
Reviewed-on: https://gerrit.libreoffice.org/30352
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-28 16:08:59 +00:00
Stephan Bergmann
1ec08fe00b loplugin:unnecessaryoverride
Change-Id: Ib75f2c8c06c6219aa0f2a8b2b29d19fb95e09527
2016-10-28 18:02:32 +02:00
Tamás Zolnai
b927c1f4b3 tdf#103544: DOCX exp.: Image loss when have a frame anchored to the same para.
Regression from:
83d51e5e52688c4c9bc0ad70a511458bb06a242d

Partly revert the commit causes this regression.
I checked the related bugs (tdf#78590,tdf#80748)
intended to be fixed by this commit and reverting
this part does not bring back the corruption.
I guess something changed in frames' and text boxes'
import in the meantime, because this MergeMarks::IGNORE
is useless now.

Change-Id: If17776e8628561961c7ce2a2994e3fc609f75639
Reviewed-on: https://gerrit.libreoffice.org/30351
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-10-28 14:10:41 +00:00
Noel Grandin
8a22bc93e0 update unnecessaryoverride plugin to find pure forwarding methods
which can be replaced with using declarations.

Is there a more efficient way to code the search? Seems to slow the
build down a little.

Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f
Reviewed-on: https://gerrit.libreoffice.org/30157
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 12:56:17 +00:00
Rohan Kumar
99fbcffa3d tdf#89329: use unique_ptr for pImpl in fpicker/
Change-Id: I4a5db5ceafe509bffc32a8800ab3d678f41244f7
Reviewed-on: https://gerrit.libreoffice.org/30309
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 12:26:09 +00:00
Caolán McNamara
03c7cfb6a6 note yet another color selector
Change-Id: I781da1ec218148dcb723db04dfe6ef3eacffe293
2016-10-28 13:15:34 +01:00
Caolán McNamara
d3e33f7ba8 ImplInitMenuButtonData can be folded into ctor now
because theres no ResId loader anymore

Change-Id: Id90786d710fe75e47c162fd00ad7fd672b9cee30
2016-10-28 13:03:45 +01:00
Caolán McNamara
624ff6633c only draw menubutton separator when two sides do something different
Change-Id: If6e3b72eacef2325f9f30770bbed32c627bc035c
2016-10-28 12:37:05 +01:00
Caolán McNamara
b1271fc9ba the case without a separator is as a Toolbox item
Change-Id: I948a63ab9741aa89738b5e44b0ec0e078d0faaa0
2016-10-28 12:26:12 +01:00
Caolán McNamara
94af3da7e1 rename and explain the MENUBUTTON_MENUMODE_TIMED stuff
Change-Id: Ifc6ddfb0cc249e537c01f28bab84b42c6b1577d9
2016-10-28 12:22:52 +01:00
Caolán McNamara
6dc8f25ecf these need to be VclPtrs
Change-Id: I83616728289e398c97e50f33b5dd1de404deaa27
2016-10-28 10:56:20 +01:00
Caolán McNamara
ec06f95d91 fix leak
Change-Id: I5bc8efa8a9de6d7a2be99f6c816e3dfca4f2b390
2016-10-28 10:56:20 +01:00
Caolán McNamara
cd3edd369b can do this in one step
Change-Id: Iab4798b34018a272a68d3d1a206dfbeef6ff19ca
2016-10-28 10:56:20 +01:00
Caolán McNamara
77d5d9f9af these usings are unnecessary
Change-Id: Ieeb753b700631958ad101354406b13863b3bab03
2016-10-28 10:56:20 +01:00
Stephan Bergmann
36f637f7f2 tdf#103507 quickfix: Automatic selection of Oracle Java runtime on Windows
...which had been broken since 5e9a2e9b0f33ab50aa3a84728db75383aede19d9 "Check
each potential JRE location only once", as jfw_findAndSelectJRE calls
jfw_plugin_getAllJavaInfos on each vendor in turn, but that now only operates on
any items newly added by addAllJREInfos, so the first call to
jfw_plugin_getAllJavaInfos (with sVendor being "Sun Microsystems Inc."
unsuccesfully operated on all items, and the next call (with sVendor being
"Oracle Corporation") didn't see any further items to operate on.

So the quickfix (at least for any Java runtimes by Oracle) is to reorder the
vendors in javavendors_wnt.xml.  The proper fix will be to reorder the code so
it obtains the list of all Java runtimes only once, and then matches that list
against the known vendors.

(Other plaforms appear not to be affected by this issue.  Some
jvmfwk/distributions/OpenOfficeorg/javavendors_*.xml already sort Oracle first,
anyway.  And e.g. on Linux, jfw_findAndSelectJRE typically already succeeds with
calling jfw_plugin_getJavaInfosFromPath and so doesn't reach the problematic
code.

Change-Id: Ied571ae1d4745d53ce0c8697d0f1b268e1aac407
2016-10-28 11:17:10 +02:00
Miklos Vajna
ddb4600cd0 sd: fix loplugin:cppunitassertequals warnings
Change-Id: Id2dc5762668b7c3f78f0a0a1ede97d4ac63fab5d
2016-10-28 11:14:07 +02:00
Caolán McNamara
807151aa13 coverity#1371275 Missing move assignment operator
Change-Id: I6c47c797d2654506bdc95c35b2558ce812f4070d
2016-10-28 10:09:32 +01:00
Caolán McNamara
5aa43c380a coverity#1371262 Missing move assignment operator
Change-Id: Ibb430a683f818add50facc23ac2893b558bff70c
2016-10-28 10:09:32 +01:00
Caolán McNamara
117fc49c97 ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivatives
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2
Reviewed-on: https://gerrit.libreoffice.org/30344
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-28 09:08:50 +00:00
Khaled Hosny
8f0f5e0c70 tdf#103514: Always ignore bitmap fonts on Windows
We should never see any bitmap fonts now, so all the Courier stuff can
go away.

Since we never list the bitmap fonts in the first place, the old code
for replacing some of them with scalable equivalents never kicks in. We
instead implement PreMatchFontSubstitution hook for the same effect.

Change-Id: I54f3c068bcd64554ed3498f4ba5b0f76bbd38589
Reviewed-on: https://gerrit.libreoffice.org/30345
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-28 08:40:20 +00:00
Ulrich Gemkow
7a2a29d0b8 tdf#98587 Inconsistency menu/shortcut for layer visibility
Changed author, patch was received by htietze.

Change-Id: I1962930c5c9c6eea4731a83147a7705d24c20b8e
Reviewed-on: https://gerrit.libreoffice.org/30322
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-28 08:28:38 +00:00
Noel Grandin
09cb920969 convert std::unique_ptr<VclAbstractDialog> to VclPtr
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-28 09:12:27 +02:00
Noel Grandin
89687d651e loplugin:expandablemethods in sd
Change-Id: I87a537928bdf42285448bba7cb50c497f2637c3c
Reviewed-on: https://gerrit.libreoffice.org/30330
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 07:08:47 +00:00
Noel Grandin
24360897c0 loplugin:expandablemethods in scaddins..scripting
Change-Id: I6a39184e526c9a41155565e798a7f1f2542985f2
Reviewed-on: https://gerrit.libreoffice.org/30331
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 06:59:41 +00:00
Stephan Bergmann
c0b3531919 Use SAL_DLLPRIVATE instead of extra TUBES_DLLPRIVATE
Change-Id: I188bf325e6eb6db0250a58d9354860733950e887
2016-10-28 08:52:47 +02:00
Stephan Bergmann
226383e690 loplugin:reservedid
Change-Id: I49e0e53b4ff17170e8aa8247b5428b6f1209d93c
2016-10-28 08:52:47 +02:00
Stephan Bergmann
f479e6878e Move internal include files from include/tubes/ to tubes/source/
Change-Id: I2fa9334721c203d4d977f0638a9030e8e74efc06
2016-10-28 08:52:46 +02:00
Stephan Bergmann
97c28ad74f Various loplugin warnings in --enable-telepathy
Change-Id: I4c437491466c3029f2a9c93fb630c7b5a8d2ff21
2016-10-28 08:52:46 +02:00
Stephan Bergmann
0274bc0569 Missing dependency (--enable-telepathy)
Change-Id: I13578505fc0d5de164d0dacbbf31821ea79233ab
2016-10-28 08:52:45 +02:00
Stephan Bergmann
3b4a32972e Use OUString ctor instead of rtl_uString_newFromAscii
Change-Id: I84ea23c4de5c631fe7d0104944b0b8f0f13abb26
2016-10-28 08:52:45 +02:00