mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
400,013 Commits 1 Branch 0 Tags
8b718e3774f1ffb69f9aad565216556c798e95f4
Commit Graph

400013 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Stephan Bergmann
8b718e3774 Handle cases where last-used palette disappeared 
...so PaletteManager::SetPalette(LISTBOX_ENTRY_NOTFOUND) would set
PaletteManager::mnCurrentPalette to 65535, and
PaletteManager::GetSelectedPalettePath would do out-of-bounds access into
PaletteManage::m_Palettes.

That the last-used palette (as stored under in the configuration under
/org.openoffice.Office.Common/UserColors/PaletteName) may become more common
with pending changes like <https://gerrit.libreoffice.org/#/c/31199/>
"tdf#104047 Remove dispensable palettes".

Change-Id: I5641bae04f50fea8aa69027a75de08c22394c281
 2016-11-25 17:29:09 +01:00
Michael Stahl
086631af59 configure: fix harfbuzz build on WNT 
The graphite library is always built static, so the graphite headers must
be included with the GRAPHITE2_STATIC macro, so that the functions are
not marked __declspec(dllimport) on WNT.

Add GRAPHITE2_STATIC to GRAPHITE_CFLAGS so harfbuzz picks it up.

It's a mystery why vcl even links currently without this.

Change-Id: I80d87fe76afa2d05a5697d56dfaf8cbe97d9f977
 2016-11-25 17:07:10 +01:00
Yossi Zahn
20254e8581 Add 2 extra number formats for Hebrew locale 
Change-Id: I55fc91b49d38f155f6a42b7395b4b44bf6a8f1cf
Reviewed-on: https://gerrit.libreoffice.org/31180
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2016-11-25 15:57:30 +00:00
Stephan Bergmann
1800862c70 loplugin:stringconstant: look into 'char const * const var = "..."' 
Change-Id: I52a97b8ec273509131c2200e47527221cb62d7ee
 2016-11-25 16:42:23 +01:00
Stephan Bergmann
b33b441341 Use string literal directly, instead of going via createFromAscii 
Change-Id: I2099575ef0041c818424a85a0ef6daa2cc3fdf72
 2016-11-25 16:31:17 +01:00
Jan-Marek Glogowski
c3da6e3844 KAB loplugin:datamembershadow 
Change-Id: I1962ab1d131cf714f8bd540b589e793c4389cfb2
 2016-11-25 16:27:07 +01:00
Jan-Marek Glogowski
0b0e43d26a MM UNO always print single files to printer 
Fix a missing hunk from e0ad036eed,
which causes assertion, if MM is used via UNO.

Thanks to Alex Kempshall, finding the assertion when testing MM.

Change-Id: Ia0cd6053838adc6f0a4ce93902f06423849bf851
 2016-11-25 16:27:07 +01:00
Jan-Marek Glogowski
bbf246e40c tdf#102010 Never overwrite MM files via UNO 
Fixes the regression introduced by
  commit e637b6743a

This commit removed the crazy bSubjectIsFilename handling,
where I didn't understood the case of bSubjectIsFilename
and a user supplied prefix.

Mail merge to files never overwrites an existing document,
but there is the special case, when a user selects a target
filename in the MM dialog for single file MM.

Should be fixed by a successive commmit, reverting this and
removing an existing file before starting the MM job.

Change-Id: Idda487023e6984de9c1e701fc088a6b7f92e9847
 2016-11-25 16:27:06 +01:00
Jan-Marek Glogowski
660159a68a MM allow easier manipulation of MM test arguments 
Keep the beans::NamedValue vector around and convert it to a
uno::Sequence just before executing the mail merge job.

Change-Id: Ib2b4863337af20fb4423cc1b4ea4223d66d63ae5
 2016-11-25 16:27:06 +01:00
Eike Rathke
f780deb1e3 replace meaningless OSL_FAIL with DBG_UNHANDLED_EXCEPTION_WHEN 
Change-Id: I8aceb106339d879455bd96b2f84b54306f13d062
 2016-11-25 16:26:42 +01:00
Eike Rathke
6c60aa313c introduce DBG_UNHANDLED_EXCEPTION_WHEN for calls with an explanatory message 
Change-Id: Ic80f2ed2c0fdff20d1ee1968bec2840bf914fb5e
 2016-11-25 16:26:42 +01:00
Ashod Nakashian
9d2f30911d Lok: invalidate Writer comments correctly 
Because notifications to all views were disabled
(to avoid moving the cursors of everyone when someone
adds a comment) invalidation was also broken. The
issue was observed when a comment crossed tile
boundaries, the other tile was not redrawn.

This forces invalidation so tiles are rendered
correctly, fixing this regression.

One small issue remains in that invalidating a
comment only invalidates the text-area and not the
complete PostIt (specifically, the author and date
are not invalidated). This means that they can
still get trimmed when crossing tile boundaries.
That will be addressed separately, as it was an
existing issue before the regression this patch
fixes.

Change-Id: Ic8173e4873d58836883b897f735fc627bb0572ee
Reviewed-on: https://gerrit.libreoffice.org/31091
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-11-25 14:02:35 +00:00
Takeshi Abe
3f20d98131 starmath: Prefix members of SmBinDiagonalNode etc. 
Change-Id: Icd863b23cfca635f901a0aea65fa26dace0aa8f9
Reviewed-on: https://gerrit.libreoffice.org/31188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2016-11-25 13:11:04 +00:00
Stephan Bergmann
c6bc45880c Make sure there's a single global RTTI for pdfio::PDFElement and derived 
...as otherwise dynamic_cast<xmlsecurity::pdfio::PDFNameElement*>(...) in
xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx will fail at least on macOS,
causing CppunitTest_xmlsecurity_pdfsigning to fail.

Change-Id: I7c41c994a1e6145b4740a97ffe47d0c42c4e3ca0
 2016-11-25 14:09:06 +01:00
Tor Lillqvist
0ddcff2053 No need for this local function to be externally visible 
Change-Id: Idb2e716cdc4933c2691de2df21a4ee7afda9e597
 2016-11-25 15:02:45 +02:00
Mark Page
ca48cb1dfa Modify pFilterConfigItem to a smart pointer 
Change-Id: Ie964f064f4f5d3735878c2a6b4f6d4b801a8e8e9
Reviewed-on: https://gerrit.libreoffice.org/31195
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-25 12:46:13 +00:00
Eike Rathke
9b1d370710 show next free formatindex hint for errors 
Change-Id: I4252a572c1cef02ff5e7de0ecc78d84ddc806919
 2016-11-25 13:42:42 +01:00
Noel Grandin
f32a75c25b convert LF constants to o3tl::typed_flags 
Change-Id: I4fa3a62e53eb02fe60c9ca0675709b76e56a7912
 2016-11-25 13:47:32 +02:00
Noel Grandin
413e63c301 convert FILTERCFG constants to o3tl::typed_flags 
Change-Id: I01a4df6bb9b90177ce72c61fd0d611a63559166e
 2016-11-25 13:47:32 +02:00
yossizahn
d39bb268ea Correct spelling of "kislev" for he_IL locale data 
See e.g. https://he.wikipedia.org/wiki/%D7%9B%D7%A1%D7%9C%D7%95

Change-Id: I3bf935db50037ff418f269d81004bce4e7388097
Reviewed-on: https://gerrit.libreoffice.org/31178
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2016-11-25 11:40:30 +00:00
Stephan Bergmann
f1eb0bf752 Clean up CLANG_VERSION check 
Change-Id: Idfdffd73e9029216775d2a6ad46293ee1a4f1308
 2016-11-25 11:24:12 +01:00
Stephan Bergmann
bf53daa49a Clean up PPCallbacks compatiblity fix 
Change-Id: I91f1db18b7876c4ecc30f7f97283e0ef0369eba5
 2016-11-25 11:22:14 +01:00
Noel Grandin
d63f42bd2a declaration of nAllFlags shadows a member of 'this' [-Werror=shadow] 
Change-Id: Ifb5adba642e777e5d515c6088c128d31778ecaff
 2016-11-25 12:11:24 +02:00
Noel Grandin
b19e712313 convert ENABLE flags to o3tl::typed_flags 
Change-Id: I47cb052c7437e127c237beee0f2d95948b7c3ad1
 2016-11-25 12:02:34 +02:00
Noel Grandin
8cd2334da9 convert SW_CREATE to scoped enum 
Change-Id: I003785715df7e72cbf398902aabb5c3fe900a2d7
 2016-11-25 12:02:34 +02:00
Noel Grandin
678041c48f convert HTML_FRM_OPTS to o3tl::typed_flags 
Change-Id: I3d8ac978ff626f792e3cff6e2b12a7680addf303
 2016-11-25 12:02:34 +02:00
Noel Grandin
e027b1d1d6 convert CSS1_SCRIPT to o3tl::typed_flags 
Change-Id: I4c721cca5eb9bc63c93888e9c214de339552a301
 2016-11-25 12:02:34 +02:00
Noel Grandin
adf1a2ba16 convert SUBCOL constants to o3tl::typed_flags 
Change-Id: Ia772e168ac6bf286244712cebb471e869212e86e
 2016-11-25 12:02:34 +02:00
Noel Grandin
d9c8738998 convert HTML constants to scoped enums and typed_flags 
Change-Id: Iaaede23c95d08016023fc419c83725f437eda080
 2016-11-25 12:02:34 +02:00
Michael Meeks
ab45b41efe osl::Condition - add deprecated markup. Use std::condition_variable. 
Change-Id: Id3488a46b12d41bada2711b135ca955259d6e448
Reviewed-on: https://gerrit.libreoffice.org/31176
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2016-11-25 09:23:43 +00:00
Michael Meeks
17320183bd sw: avoid busy loop waiting for OLE objects to load. 
Change-Id: I7f26a88d3dcdb47260eb95f7803702d55f4a9119
Reviewed-on: https://gerrit.libreoffice.org/31164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2016-11-25 09:23:31 +00:00
Bjoern Michaelsen
93399570a8 fix around cornercases with cxxobjects 
Change-Id: Ibd5dad8ca69fa952e4751af961ad957017fbbe40
Reviewed-on: https://gerrit.libreoffice.org/31181
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2016-11-25 08:54:28 +00:00
Noel Grandin
8b511fa1fb warning C4701: potentially uninitialized local variable 
Change-Id: I8f68531f2ffa419f7a1fd5b4cda1b43988de6b68
 2016-11-25 10:03:27 +02:00
Miklos Vajna
5cb580144c CppunitTest_xmlsecurity_pdfsigning: add PAdES testcase 
Assert the two user-visible changes: SHA-256 hashes and the SubFilter of the
signature.

Change-Id: I12a2355e2ddfc368bed4430a7b5ad244b5778afe
Reviewed-on: https://gerrit.libreoffice.org/31173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2016-11-25 07:12:48 +00:00
Miklos Vajna
426495cb44 CppunitTest_xmlsecurity_signing: add XAdES testcase 
Assert the two user-visible changes: SHA-256 hashes and the digest of
the signing certificate.

Change-Id: I0f931ef06f9bfc4be4eaa02a7530d57a414430c1
Reviewed-on: https://gerrit.libreoffice.org/31172
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-11-25 07:12:30 +00:00
Noel Grandin
ca83b1fa13 convert CSS1_FRMSIZE constants to o3tl::typed_flags 
Change-Id: I273166513253a2108c11a9cbae027bde7ca82b99
 2016-11-25 09:07:48 +02:00
Noel Grandin
1f03d97e1d convert CSS1_BACKGROUND constants to scoped enum 
Change-Id: Ice20f26e9104126b572446250c94b90ab9dd3da7
 2016-11-25 09:07:48 +02:00
Noel Grandin
9b1fdb2e46 convert SWXML constants to o3tl::typed_flags 
and remove some dead code

Change-Id: Ibda8c4a93e2f1d58b57bfa506eabb6bd29643f74
 2016-11-25 09:07:48 +02:00
Noel Grandin
025604bbfa replace URLLOAD constants with o3tl::typed_flags 
Change-Id: Ief6cb3dfc53da8cbae0feded9e215905c7a8459c
 2016-11-25 09:07:48 +02:00
Noel Grandin
11980815c7 convert FRM_VALID constants to o3tl::typed_flags 
Change-Id: I9a84e0ec9c4319ca2edc8dfcc72bfdb08229ecef
 2016-11-25 09:07:48 +02:00
Noel Grandin
ead32fe3fd convert MODIFY constants to o3tl::typed_flags 
Change-Id: I230469605b1b3a2a639f51917c23f1a82ec519b5
 2016-11-25 09:07:48 +02:00
Noel Grandin
1c3cb6bb41 convert HTMLCFG constants to o3tl::typed_flags 
Change-Id: I0859fdc3e737ab0714e994f1326123e93e93affb
 2016-11-25 09:07:48 +02:00
Noel Grandin
2d3dc65dba convert FOUND constants to o3tl::typed_flags 
Change-Id: Ia167ed1abc10188d89e1bd43d7a2b884cb0bf52d
 2016-11-25 09:07:48 +02:00
Noel Grandin
bd7c9afb8b convert VAR constants to o3tl::typed_flags 
and drop the unused EXTENDABLE

Change-Id: Iddb2d4c1f3a3f76e4687ad002c0c4b9f7e6ca055
 2016-11-25 09:07:48 +02:00
Noel Grandin
a0ee31da5c convert FLAG constants to o3tl::typed_flags 
Change-Id: I3b51321c425b8e0039932b5d4b48d35c3bf14378
 2016-11-25 09:05:10 +02:00
Noel Grandin
c2775560ab convert STRING_TYP to scoped enum 
Change-Id: If0bcc6e13864fd534eb65eda06b1bc2b5498cee9
 2016-11-25 09:05:10 +02:00
Noel Grandin
63a6de2cab convert MODKEY constants to o3tl::typed_flags 
Change-Id: I53a6f6f6b12e0fb299e7d76e8e8f354ef3afbbb3
Reviewed-on: https://gerrit.libreoffice.org/31152
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-25 07:03:08 +00:00
Bjoern Michaelsen
daf9156c76 rename foo target to something more meaningful 
- also use gb_Helper_MISCDUMMY were possible (this might fix the
  'circular deps' warnings

Change-Id: I419f39973b5c785c1d8ccba9f8ed75a77f08ffa2
Reviewed-on: https://gerrit.libreoffice.org/31117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2016-11-25 02:08:58 +00:00
Bjoern Michaelsen
65541cfaa1 store makefile for targets in json too 
Change-Id: Iae2f497da5d0ee4f8961a5655573e45a562dd76d
Reviewed-on: https://gerrit.libreoffice.org/31116
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2016-11-25 02:06:16 +00:00
Bjoern Michaelsen
e62fc464f2 use gbuild prefix for tempdirs 
Change-Id: Icc262c51fd70ae35b44722be8d4ab767b69ae2a8
Reviewed-on: https://gerrit.libreoffice.org/31094
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2016-11-25 02:05:34 +00:00