mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
423,210 Commits 1 Branch 0 Tags
923cf26dd0653c5ec1c32b7fec6952b9305e355c
Commit Graph

423210 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Caolán McNamara
1a3deaa7f7 coverity#705646 Resource leak 
Change-Id: I709b16f720cf97c05207cfb22d0c0ea15622367a
Reviewed-on: https://gerrit.libreoffice.org/54139
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 22:09:00 +02:00
Caolán McNamara
850995b2c2 weld SdPhotoAlbumDialog 
Change-Id: I46cca94bb43e1b1cd9757b22baad9bb3f61bc15d
Reviewed-on: https://gerrit.libreoffice.org/54132
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 22:08:26 +02:00
Caolán McNamara
96998e0f4c Resolves: tdf#117475 page properties change triggers page reorder event 
and page reorder remove and re-inserts the slide in the slide sorter, so the
selected page property is removed when the page doesn't really get removed. So
then there's no selection to apply the later master page property to.

Change-Id: I4a32958542da1bf2f5041dde0294a772645e30ad
Reviewed-on: https://gerrit.libreoffice.org/54126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 22:03:48 +02:00
Kshitij Pathania
3fc6ba164b [GSoC]Notebookbar: Hamburger icon is now well aligned 
Change-Id: I3c850113049bd5d36e024b2207777e63eaf05b2d
Reviewed-on: https://gerrit.libreoffice.org/54111
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2018-05-11 22:03:03 +02:00
Caolán McNamara
49a92a1407 rename create_btn to ok to get desired button ordering 
and help is missing a RET_HELP response id

Change-Id: Ibb816f9a3d03ceef4edde023725bebd29f9160d2
Reviewed-on: https://gerrit.libreoffice.org/54128
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 22:02:38 +02:00
Caolán McNamara
3490bdc221 silence Werror=class-memaccess 
Change-Id: I069bc38195d168512183335eb798ba541d1d2050
Reviewed-on: https://gerrit.libreoffice.org/54135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 22:02:16 +02:00
Caolán McNamara
9e11fb7c46 coverity#1435548 rework to avoid Dereference after null check warning 
Change-Id: Ifb0d6af999e4935009669a7f85a77e640ce0eddc
Reviewed-on: https://gerrit.libreoffice.org/54138
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 22:01:52 +02:00
Abhyudaya Sharma
95d5fc76de tdf#96099 Remove trivial StringVector typedef 
Change-Id: I2924447a61f592f2c4da1c5b2e4940d30f4a1307
Reviewed-on: https://gerrit.libreoffice.org/54125
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-05-11 19:25:40 +02:00
Michael Stahl
b0551b1d00 sw: rename SwTextNode::IsSymbol() to reduce overloading 
Change-Id: I440de45908af8ee1b722ddefb54cd0ba60d1e363
 2018-05-11 17:11:16 +02:00
Mike Kaganski
92af70732b Revert "Set SAL_USE_VCLPLUGIN=svp on all platforms to define headless mode" 
This reverts commit c0965754df
since its reason was fixed in commits
e57462cd7b and
752a1e2724.

Change-Id: I7b41888a9192c842b7df151be0ed3c6cf92d6322
Reviewed-on: https://gerrit.libreoffice.org/54123
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-05-11 17:06:55 +02:00
Michael Stahl
caeda2233e sw: fix invalid 16-bit downcast in SwTextIter::TruncLines() 
Change-Id: I0a19e730d58c01b55a9de926aaaadb8ef4022317
 2018-05-11 16:58:54 +02:00
Michael Stahl
5bc362cb96 sw: remove pointless indirection to SwTextSizeInfo::HasHint_ 
Change-Id: I0a6f329c2bc2d10fb993d42e07e71a7b5c5fd5e2
 2018-05-11 16:58:54 +02:00
Michael Stahl
bb7700d844 sw: cosmetics 
Change-Id: Ieed3c8251ab61d7c47314137f5f67cb736b1b158
 2018-05-11 16:58:54 +02:00
Michael Stahl
37c21f3cc4 SwRedlineItr: prefix members 
Change-Id: If4e0dde34004766862240c10c41643c2919a6b18
 2018-05-11 16:58:54 +02:00
Michael Stahl
4b049a6115 sw: fix copypasta assertions 
Change-Id: Ic064a738f5f17e006cc5ada125a5143e7cf57d32
Reviewed-on: https://gerrit.libreoffice.org/54120
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2018-05-11 16:53:59 +02:00
Michael Stahl
55ad38a420 SwExtend: prefix members 
Change-Id: Ia1b539a9017b1b9f5be09d367bc77eeb08bcd619
Reviewed-on: https://gerrit.libreoffice.org/54118
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2018-05-11 16:53:20 +02:00
Michael Stahl
24874732ca SwAttrIter: replace USHRT_MAX with COMPLETE_STRING for para index 
Change-Id: I62698f92190e9d763e559ff26297ac87f120fc80
Reviewed-on: https://gerrit.libreoffice.org/54116
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2018-05-11 16:52:53 +02:00
Caolán McNamara
3aa01898e5 tdf#117549 crash with focus setting during disposing 
Change-Id: I1ab492a4c6fab89debac90224a5f78102d33d664
Reviewed-on: https://gerrit.libreoffice.org/54122
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 16:25:42 +02:00
Olivier Hallot
ce5cd1c1c5 Updated core 
Project: help  1b94db073c7f918ff11d005cfb150da1ddd5cf8c

Fixes in <alt> contents of images

Change-Id: I9d964da3a86fcc2ff48bde5ac577659204cefe5e
Reviewed-on: https://gerrit.libreoffice.org/54130
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
 2018-05-11 14:09:27 +02:00
Gabor Kelemen
d9370a1406 Replace ScGlobal::GetRscString with simple ScResId calls 
After the gettext migration there is no point to have two
APIs for reading the same .mo file.

This patch is for sc/source/core/data for easier review.

Change-Id: Id26cf9c38c8ed76448f615b775423a3f5dbc5ef4
Reviewed-on: https://gerrit.libreoffice.org/54100
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-05-11 14:00:23 +02:00
Miklos Vajna
6a069bea17 Related: tdf#109180 xmlsec nss: backport ecdsa fix 
Change-Id: Id977be090e09eefcb4196078682694443718c2fd
Reviewed-on: https://gerrit.libreoffice.org/54103
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-05-11 13:53:16 +02:00
Tor Lillqvist
2ff121f298 Avoid gengal hanging in an --enable-dbgutil build on Windows 
With a newer C++ debug runtime (in an --enable-dbgutil build), passing
an invalid locale name causes an attempt to display an error
dialog. Which does not even show up, at least for me, but instead the
process (gengal, at least) just hangs. Which is far from ideal.

Passing a POSIX-style locale name to the std::locale constructor on
Windows is a bit odd, but apparently in the normal C++ runtime it
"just" causes an exception to be thrown, that boost catches (see the
loadable(std::string name) in boost's libs\locale\src\std\std_backend.cpp),
and then instead uses the Windows style locale name it knows how to
construct. (Why it even tries the POSIX style name on Windows I can't
understand.)

Actually it isn't just the locale name part "en_US" of a locale like
"en_US.UTF-8" that is problematic, but also the encoding part,
"UTF-8". The Microsoft C/C++ library does not support UTF-8
locales. The error message that our own report hook catches says:
"f:\dd\vctools\crt\crtw32\stdcpp\xmbtowc.c(89) : Assertion failed:
ploc->_Mbcurmax == 1 || ploc->_Mbcurmax == 2". Clearly in a UTF-8
locale (perhaps one that boost internally constructs?) the maximum
bytes per character will be more than 2.

With a debug C++ runtime, we need to avoid the error dialog, and just
ignore the error. So we install an own CRT error report hook that
ignores the error for the duration of the locale construcion.

Change-Id: Ia2ca994f03d1ce94ce7e9d7607f204c320ab8f2d
Reviewed-on: https://gerrit.libreoffice.org/54110
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-05-11 13:45:24 +02:00
Sophia Schröder
f619c9b48a Updated core 
Project: help  25c9d4abf6ce26ab213782723ee17f286e77b3b0

Try to fix critical errors in Pootle.

Plus some minor improvements

Change-Id: I8cb1d1cf4faaf083fd0dda3d1a2197cdf4c32dc9
Reviewed-on: https://gerrit.libreoffice.org/54003
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
 2018-05-11 13:41:52 +02:00
Caolán McNamara
e1830e7c85 Related: ofz#8226 + valgrind: uninitialized value 
Change-Id: I63dea876dffe2d9e17b506dbd8515da2d97fbf08
Reviewed-on: https://gerrit.libreoffice.org/54113
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 13:00:04 +02:00
Stephan Bergmann
2de80f9a21 Fix typo 
...introduce with 476ed0aed1 "weld
SdStartPresentationDlg"

Change-Id: If7132905ae81ff6c38646bf47a14596421a13eb5
 2018-05-11 11:13:52 +02:00
Armin Le Grand
9ddbd8e2bc tdf#116993 corrected FontWork to use correct SdrModel 
Had to adapt FontWorkGalleryDialog::insertSelectedFontwork()
to use the correct target-SdrModel when cloning the FontWork
SdrObject. This is due to FontWorkGalleryDialog being used
differently from Calc - it calls SetSdrObjectRef to set an
exceptional SdrModel as target which I took as the always
to-be-used target SdrModel - due to it's name 'mpDestModel'.

Change-Id: Ia4860283082f041711b8c31952fd2c398eeac30e
Reviewed-on: https://gerrit.libreoffice.org/54045
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-05-11 11:12:28 +02:00
Rene Engelhard
752a1e2724 (try to) fix dbaccess firebird-related tests 
after 1c5c9b84df

Move headless check into test and add missing component file for firebird...
Also check for ENABLE_FIREBIRD_SDBC...

Change-Id: I27ea9fb08ebcce701a54686a8986e5071a8bcf96
Reviewed-on: https://gerrit.libreoffice.org/53940
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2018-05-11 10:15:44 +02:00
Michael Stahl
e57462cd7b test: force EnableHeadlessMode() for PythonTest 
Clearly this should be on, but we can't easily pass in a command line
argument like is done in CppunitTest because that doesn't end up in
rtl_getAppCommandArg(), which is empty since it's the python.bin process,
so we'd have to find a way to get the argv from python first...

Change-Id: I9321a9f933f388a659643898e0dc38f295f2068c
Reviewed-on: https://gerrit.libreoffice.org/54083
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2018-05-11 10:15:05 +02:00
Caolán McNamara
36a688255f weld SdInsertPasteDlg 
Change-Id: I999e7ff88afd7dd82b368ede83d004e309e7dd3e
Reviewed-on: https://gerrit.libreoffice.org/54102
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 09:56:41 +02:00
Caolán McNamara
6c6982e789 AbstractSdInsertPasteDlg is unused 
Change-Id: I7b660a49d3d54a5de1443815c7fd661d32572971
Reviewed-on: https://gerrit.libreoffice.org/54101
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 09:55:37 +02:00
Caolán McNamara
6776a3ba00 draw has a sidebar, so impress/draw can use same table properties pane 
Change-Id: I6f2178bf005fea4885af1359ce07722f17e87ba8
Reviewed-on: https://gerrit.libreoffice.org/54099
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 09:54:09 +02:00
Caolán McNamara
94aa2e5013 drop metric connect_changed, use connect_value_changed 
Change-Id: Ic89b4185ee76567af807b3e6a56eca691b707a3f
Reviewed-on: https://gerrit.libreoffice.org/54094
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 09:53:05 +02:00
Caolán McNamara
c82438da68 weld SdDesignNameDlg 
Change-Id: Ie8f7a62d55aabb520c234c995b01d85bf9f432b6
Reviewed-on: https://gerrit.libreoffice.org/54093
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-11 09:52:49 +02:00
Noel Grandin
3ef9353041 loplugin:datamembershadow in ScVbaStyles 
member already present in superclass InheritedHelperInterfaceImpl

Change-Id: I52a8178f95ad65dc0780ba0f82d6322cea039ba4
Reviewed-on: https://gerrit.libreoffice.org/54109
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-11 09:47:54 +02:00
Noel Grandin
1ae25f4895 loplugin:datamembershadow in SdrOutliner 
and make the superclass field private too

Change-Id: Ibfe030859d2d81b1cb5b7f47c1292210b16ae42c
Reviewed-on: https://gerrit.libreoffice.org/54108
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-11 09:47:38 +02:00
Noel Grandin
c26351ee51 loplugin:datamembershadow in FrameView 
Change-Id: I968bde3533682943c30587c74fbfc8a9260feebf
Reviewed-on: https://gerrit.libreoffice.org/54107
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-11 09:19:26 +02:00
Noel Grandin
1b0b0f3c64 loplugin:datamembershadow in SdGenericDrawPage 
Change-Id: I0c7a08206b6480ba954464be1782d4577483b15e
Reviewed-on: https://gerrit.libreoffice.org/54106
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-11 09:19:10 +02:00
Miklos Vajna
7758d6609d tdf#117245 sw layout: extend TabOverMargin compat mode 
This layout compatibility flag is supposed to mimic Word behavior, but
in both cases we failed to lay out the text as Word does.

Change-Id: Ic6fb2eb16ce3670d23aeb9f17bd7043f55164883
Reviewed-on: https://gerrit.libreoffice.org/54087
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-05-11 09:03:19 +02:00
Noel Grandin
026077340d loplugin:datamembershadow in SvxMacroTabPage_ 
Change-Id: I8cd1a4fef6bd0966620692c316a40ea47dd14d7d
Reviewed-on: https://gerrit.libreoffice.org/54105
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-11 08:44:36 +02:00
Noel Grandin
19156dccf7 loplugin:datamembershadow in DXF filter 
depending on which version of the DXF file format you look at, elevation
can be either group code 30 or group code 38. But since neither of these
fields is actually in use, lets just remove both until someone has an
actual use-case for them and can test against real data.

Change-Id: I4355b37c4b8513e8f9704272b269b2fe3f1c659f
Reviewed-on: https://gerrit.libreoffice.org/54104
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-11 08:44:21 +02:00
Noel Grandin
a111a7ba40 tdf#117522 Calc Column Width after Insert Columns 
regression from
    commit d6fb5ca566
    dyncolcontainer: use ScCompressedArray for pColWidth

Change-Id: I65d1197c0c638216e063f74def4efb98bfbb9aad
Reviewed-on: https://gerrit.libreoffice.org/54067
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-11 08:44:04 +02:00
Samuel Mehrbrodt
29deb66577 Only write mime-type attribute if ODF version > 1.2 
Change-Id: I88ae821e969a2c45161f59eb2e667f645f1afdac
Reviewed-on: https://gerrit.libreoffice.org/54075
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-05-11 08:24:36 +02:00
Zdeněk Crhonek
4374f8b621 uitest for bug tdf#88999 
Change-Id: I442704bb54490bdb37a5c3bf7dd0c123cfb89ee6
Reviewed-on: https://gerrit.libreoffice.org/54088
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
 2018-05-11 07:22:15 +02:00
Tor Lillqvist
fc00041df8 Also for SDK 10.0.17134 the winsdklibsubdir needs to have a .0 tacked on 
Also remove questionable old "Hack needed at least by tml".

Change-Id: I478358ea114cee2f8a181b98cb3433447b3ed560
Reviewed-on: https://gerrit.libreoffice.org/54081
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2018-05-11 00:42:13 +02:00
Khaled Hosny
a909afbc21 Fold CommonSalLayout into GenericSalLayout 
Now the crazy constructors of CommonSalLayout are gone, we can merge
the two and drop one level of indirection.

Change-Id: I166e4ed2c9d22c1ce75246d486f7526c4928f652
Reviewed-on: https://gerrit.libreoffice.org/54077
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
 2018-05-11 00:16:39 +02:00
Rene Engelhard
e37135d413 move Java from config_features to already existing config_java 
Change-Id: I085fab2bcdc5910d1386fc20768fe7063ce3e28e
Reviewed-on: https://gerrit.libreoffice.org/54071
Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>
 2018-05-10 22:44:37 +02:00
Caolán McNamara
a4d35e9ed6 weld SdVectorizeDlg 
Change-Id: I15469be36807bcfca9882d04dd5d55933692abf7
Reviewed-on: https://gerrit.libreoffice.org/54092
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-10 21:57:53 +02:00
Caolán McNamara
8154d17893 ofz#8206 fix rework as OUStringBuffer 
Change-Id: Ie9ef508c9db730c4d273d7258c052d074b6ef088
Reviewed-on: https://gerrit.libreoffice.org/54082
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-10 18:06:42 +02:00
Thorsten Behrens
c4380ced32 sal: log windows traces to debugger console, take two 
This reverts most of commit 4c5b475278
and just keeps the OutputDebugStringA() call unconditionally.

Change-Id: Ia838052b3147ca2d66c7d28b04eadd9700244669
Reviewed-on: https://gerrit.libreoffice.org/54029
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-05-10 17:17:01 +02:00
Zdeněk Crhonek
8f799c4565 uitest / Calc autofill 
Change-Id: I91f9c5eb69059eceedc190f1578c3d08a722409a
Reviewed-on: https://gerrit.libreoffice.org/52595
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
 2018-05-10 16:52:42 +02:00