Commit Graph

423210 Commits

Author SHA1 Message Date
Caolán McNamara
e89350cc1e ofz#8252 fallout from rework as OUStringBuffer
Change-Id: Ide3732627eb145e191061608ac0325df0fcceff0
Reviewed-on: https://gerrit.libreoffice.org/54198
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14 09:52:48 +02:00
Justin Luth
36839898fa writerfilter NFC: save ConvertedParaStyleName, not WW8Name
and rename m_sCurrentParaStyleId -> m_sCurrentParaStyleName

This is prep work for tdf#117504, where the value
saved in m_sCurrentParaStyleId is not accurate. Since the
actual value saved inside the paragraph properties is the
ConvertStyleName(), lets use the LO-version of the
style name, so that FindStyleSheetByConvertedStyleName()
can be used for either the paragraph's PropertyValue or
m_pImpl->m_sCurrentParaStyleName.

Change-Id: I8aed80094417ea91f2515e666dc05ecbb021a128
Reviewed-on: https://gerrit.libreoffice.org/54084
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-14 09:28:25 +02:00
Miklos Vajna
04042e42cf vcl opengl Windows: only log non-success wglMakeCurrent() failure reason
The rendering result on this Intel card is acceptable, but the console
is flooded with warnings saying wglMakeCurrent() failed with reason
"success", which makes it hard to see any other more important message.

I assume the root cause here is a broken driver.

Change-Id: I112279e9d669b804baeb47383b8357f1a1b7fde5
Reviewed-on: https://gerrit.libreoffice.org/54124
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-14 09:28:00 +02:00
Tamas Bunth
4f043c0a26 tdf#117092 dbahsql: handle multiple primary keys
Set primary keys at the end of the sql statement instead of putting it
right after the column definition. This way multiple primary keys can be
defined.

Change-Id: I7956a536b0516fd8a773d4aa64ccb930ae5c715d
Reviewed-on: https://gerrit.libreoffice.org/54204
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-05-14 09:21:44 +02:00
Gabor Kelemen
d9c2523b0c Drop module-specific defines of DELETEZ
The one in tools/solar.h is the only one needed.

Change-Id: I7a4e041694fb61329d16f300be4f986eb8d4ec48
Reviewed-on: https://gerrit.libreoffice.org/54202
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-14 08:00:18 +02:00
Andrea Gelmini
d07f9e4d4a Fix typo
Change-Id: I87fce20463564fe9b32912fcbaf691c1c2839e2b
Reviewed-on: https://gerrit.libreoffice.org/54201
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
2018-05-14 07:05:40 +02:00
Caolán McNamara
96337c845c Updated core
Project: help  88fef6367411f87b870369389ac79ce43bcf0d7b

update helpids

Change-Id: I32fcc7514ed75fcf9c5a140d1a9f70e70001c3d1
2018-05-13 22:22:18 +02:00
Caolán McNamara
4a1cdfef80 weld SwMMResultSaveDialog
and set a proper parent for it

Change-Id: Ia03e549e9fdde5925d85af3332d63253d9fbe911
Reviewed-on: https://gerrit.libreoffice.org/54199
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-13 21:49:09 +02:00
Caolán McNamara
9f55cc13d6 weld SwNewGlosNameDlg
Change-Id: Ie1c320958813bfb602da46738782b9e1e9fe5a9e
Reviewed-on: https://gerrit.libreoffice.org/54196
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-13 21:44:24 +02:00
Caolán McNamara
1bbc741c07 weld SdModifyFieldDlg
Change-Id: I7e84f09b854d30474d37dfb3ce47a8a739dd5543
Reviewed-on: https://gerrit.libreoffice.org/54148
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-13 18:44:32 +02:00
Johnny_M
b8a51074ae Translate German comments
Change-Id: I6a03e921b28da5ac26235f32f547f36e00a47e46
Reviewed-on: https://gerrit.libreoffice.org/54079
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-13 17:37:57 +02:00
Tomaž Vajngerl
72ce1de3e3 o3tl: add some comments to sorted_vector test
Change-Id: Iebedbb5afb45a92e52a8a390b9b7f6daae2337eb
Reviewed-on: https://gerrit.libreoffice.org/54192
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-13 15:28:48 +02:00
Tomaž Vajngerl
7e6dac4edc svgio: fix rendering when the width/height isn't present in SVG
The general size of the image should be the same when width/height
attributes are present. It is very wrong to assume the size of the
image is the area covered by all the primitives in the image.

Change-Id: I56f241e84dee37796f9804ce2569c4eb416e83a0
Reviewed-on: https://gerrit.libreoffice.org/54191
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-13 15:28:27 +02:00
Jean-Pierre Ledure
32cad25f94 Access2Base - FIX Sql errors when apostrophe in table names
Correct replacement of square brackets by quoting string
2018-05-13 15:06:55 +02:00
Gabor Kelemen
8010f473c7 Drop newly unused ScGlobal::GetRscString
Change-Id: I744b069542007d7ed965ef229a263c09a27181ce
Reviewed-on: https://gerrit.libreoffice.org/54187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-13 13:27:25 +02:00
Bjoern Michaelsen
439f17c5cf dont use SwClient/SwModify in unocore: HeadFootText
Change-Id: Icf0fa7ec07c8c52981c50bc03a34ae0fa9683fcf
Reviewed-on: https://gerrit.libreoffice.org/54184
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-05-13 12:04:26 +02:00
heiko tietze
8bdd059a1d Icon themes clean-up
Industrial and Oxygen removed because of no maintainer,
limited coverage, outdated design, and no SVG support
Legacy themes will be available as extension

Change-Id: I8f9c7bff6a180e3c151404b644a514eae4efcba8
Reviewed-on: https://gerrit.libreoffice.org/54158
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-13 08:37:15 +02:00
Chris Sherlock
1f6af5c409 vcl: move Bitmap::MakeMonochrome() to BitmapMonochromeFilter
Change-Id: Iefe5be4349475a4aa0138534cf6bfe87ff7df245
Reviewed-on: https://gerrit.libreoffice.org/53280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-13 08:28:43 +02:00
Adolfo Jayme Barrientos
48cf194a1b Updated core
Project: help  d6cf5222fb6188eed6bad6cb3e0f5ee9bdafb5d2

Grammar: subject–verb agreement

We don’t suffix “-s/-es” to verbs that refer to a subject in the
third-person plural.

Change-Id: I6fd90814bd63d618c8af4e625d38c6ee9895f919
2018-05-13 03:52:46 +02:00
Adolfo Jayme Barrientos
8162520f25 tdf#117496 Drop “Microsoft”/“MS” in more filters that I forgot about
Change-Id: I42c4dd2a81ce2d2e0f0f8c3be19a92587b9b1ba1
Reviewed-on: https://gerrit.libreoffice.org/53994
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-05-13 01:54:08 +02:00
Bjoern Michaelsen
877242c09e dont use SwClient/SwModify in unocore: TextMarkup
Change-Id: I160ca544122609a5c35b6bf2739581769cd46295
Reviewed-on: https://gerrit.libreoffice.org/54157
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-05-12 23:20:31 +02:00
Andrea Gelmini
4b6dcbbd4f Fix typos
Change-Id: Ic1234560cf9bf646e5499f3192fb37f1d36a6010
Reviewed-on: https://gerrit.libreoffice.org/54165
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-12 23:08:51 +02:00
Andrea Gelmini
33e6b7d06c Updated core
Project: help  14c6e5b03eb0b2787812bb5420297e7fcc7dda42

Fix typo

Change-Id: I576f1b7de38b5ffd94b1c5d85469026c2a357c9e
Reviewed-on: https://gerrit.libreoffice.org/54164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-12 23:07:03 +02:00
Gabor Kelemen
fabbeb7a8d Replace ScGlobal::GetRscString with simple ScResId calls
After the gettext migration there is no point to have two
APIs for reading the same .mo file.

This patch is for sc/source/filter/ for easier review.

Change-Id: I77adc446e66623535a9d4c871ac1403e88efff78
Reviewed-on: https://gerrit.libreoffice.org/54183
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-12 22:53:17 +02:00
Chris Sherlock
d2bed9999e tools: test for FRound
Change-Id: Ifcf0472892fbd37622a1a0505cbf5140cac281f4
Reviewed-on: https://gerrit.libreoffice.org/53718
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-12 20:16:26 +02:00
Khaled Hosny
e8d48dd75a Fixup 23c5125148
It was asserting for me at startup on Windows.

Change-Id: I81d7b0dd58fd912c5fc255c3a7fa0878e841737e
Reviewed-on: https://gerrit.libreoffice.org/54160
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-12 20:00:26 +02:00
Khaled Hosny
ab03a09745 Add more more dependencies to VCL makefiles
Hopefully fixes broken tinderboxes.

Change-Id: I2297e5df9f18a444801ec2dc6dbbb098ed4d90c9
Reviewed-on: https://gerrit.libreoffice.org/54163
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-12 19:59:40 +02:00
Khaled Hosny
4ad07c563e Make SalLayout overrides final
We really don’t want anyone to subclass these classes and introduce new
text layout inconsistencies.

Change-Id: I38d046dc2fab602fd262dc43ac86b55fb0c59db2
Reviewed-on: https://gerrit.libreoffice.org/54153
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-12 19:59:10 +02:00
Noel Grandin
203e3099c1 make Bitmap/BitmapEx constructors explicit
and add
BitmapEx::operator=(Bitmap const &)
Image::Image(Bitmap const &)
to lessen the fallout

Change-Id: Iff5fab88d167a7be739c370c9933d36c297bc61c
Reviewed-on: https://gerrit.libreoffice.org/54162
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-12 19:00:00 +02:00
Noel Grandin
f4932d61e5 make AlphaMask constructors explicit
to reduce surprises in some changes I'm planning

Change-Id: I61cb58d51ab77f57e55159017c7bece5bd99953f
Reviewed-on: https://gerrit.libreoffice.org/54161
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-12 18:59:45 +02:00
Caolán McNamara
6e2a017049 coverity#1430057 rework warning code to use nonwarning pattern
Change-Id: I1e41e81a88825a7c91ffb9603eb9d769bd41822a
Reviewed-on: https://gerrit.libreoffice.org/54143
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-12 18:16:28 +02:00
Caolán McNamara
a4ca3023e2 unnecessary duplicate SetImage
Change-Id: Ie337eeae3c8295c4d7e62401f438c50d5bfc9693
Reviewed-on: https://gerrit.libreoffice.org/54159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-12 18:16:16 +02:00
Khaled Hosny
5af60152d6 SalLayout::CalcAsianKerning() can be made local
Change-Id: Ieff9fda888112e98236d846aa6cf9140be8b355a
Reviewed-on: https://gerrit.libreoffice.org/54152
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-12 16:41:43 +02:00
Khaled Hosny
4680ce8790 Drop trivial, used only once, functions
Change-Id: I387dd91464b211eb892dd4a3adc0b8dae6f84fa2
Reviewed-on: https://gerrit.libreoffice.org/54097
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-12 15:29:33 +02:00
Gabor Kelemen
a17c2018a4 Replace ScGlobal::GetRscString with simple ScResId calls
After the gettext migration there is no point to have two
APIs for reading the same .mo file.

This patch is for sc/source/core/tool for easier review.

Change-Id: I4722c8a9ce11ae073389ec8395401f3d11ef0d5b
Reviewed-on: https://gerrit.libreoffice.org/54133
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-12 13:59:56 +02:00
Gabor Kelemen
9356e0efb1 Replace ScGlobal::GetRscString with simple ScResId calls
After the gettext migration there is no point to have two
APIs for reading the same .mo file.

This patch is for sc/source/ui/view/ for easier review.

Change-Id: Ic07f7e924236d29f3cafd69c5ee634ae92105459
Reviewed-on: https://gerrit.libreoffice.org/54137
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-12 13:59:39 +02:00
Gabor Kelemen
4145a85779 Replace ScGlobal::GetRscString with simple ScResId calls
After the gettext migration there is no point to have two
APIs for reading the same .mo file.

This patch is for sc/source/ui/[a-d]* for easier review.

Change-Id: If268fb87ab09ca430a5bdb5cdd53a233e9158bfe
Reviewed-on: https://gerrit.libreoffice.org/54134
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-12 13:58:53 +02:00
Gabor Kelemen
aa0cd609d3 Replace ScGlobal::GetRscString with simple ScResId calls
After the gettext migration there is no point to have two
APIs for reading the same .mo file.

This patch is for sc/source/ui/[m-u]* for easier review.

Change-Id: I326902a89b8c65e32a42c3ebb55bea3609d32db6
Reviewed-on: https://gerrit.libreoffice.org/54136
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-12 13:43:11 +02:00
Caolán McNamara
2bc1758239 coverity#1430087 Division by zero
Change-Id: Ie29773a3f0a3fcadd633f09e6355b801945933c2
Reviewed-on: https://gerrit.libreoffice.org/54140
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-12 13:33:15 +02:00
Caolán McNamara
ce8b63ed20 silence Werror=class-memaccess
Change-Id: I2deac7b7df8d6b099a52b4e9e82ee0dd0c390c16
Reviewed-on: https://gerrit.libreoffice.org/54149
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-12 13:32:38 +02:00
Caolán McNamara
2d296ee940 silence coverity#1401328 Uncaught exception
Change-Id: I0bc55d1dd8fb909388508f2a1f74f846060fed17
Reviewed-on: https://gerrit.libreoffice.org/54142
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-12 13:31:39 +02:00
Caolán McNamara
86d7984cac coverity#1430102 Division by zero
Change-Id: Iae44c89c4af70e3e5b19137ee08ca566c7a04fb7
Reviewed-on: https://gerrit.libreoffice.org/54141
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-12 13:30:57 +02:00
Gabor Kelemen
6cbb674e63 Replace ScGlobal::GetRscString with simple ScResId calls
After the gettext migration there is no point to have two
APIs for reading the same .mo file.

This patch is for sc/qa for easier review.

Change-Id: Ifd773700654565ad31424dfe854bee8486a2330b
Reviewed-on: https://gerrit.libreoffice.org/54095
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-12 12:43:33 +02:00
Andrea Gelmini
15032b197c Fix typo
Change-Id: I1686ce5eeb5503bbcf43f8a071824ab1045dad13
Reviewed-on: https://gerrit.libreoffice.org/54146
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-12 11:29:24 +02:00
Christian Lohmaier
46885986e3 Revert "Enable CppunitTest_sw_odfexport for MACOSX"
This reverts commit fe192a7b74.

The mac-mini jenkins buildslaves get stuck on the sw_odfexporttest and
ultimately get killed by the build-timeout. Revert to not tempt people
into bypassing jenkins alltogether.

Change-Id: I6c08657a1957455161882443b88b5d581c888bcf
Reviewed-on: https://gerrit.libreoffice.org/54155
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-12 11:21:43 +02:00
Tamas Bunth
1932f4b04a tdf#117301 dbahsql: add FLOAT type
Change-Id: I2a7227c40d8df6347c014cf720369384b92e3970
Reviewed-on: https://gerrit.libreoffice.org/53898
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-05-12 10:28:50 +02:00
Bjoern Michaelsen
74b0602a82 dont use SwClient/SwModify in unocore: Section
Change-Id: Ic594c5129664b309ce1b6ddd0c715a17df5a3265
Reviewed-on: https://gerrit.libreoffice.org/54091
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-05-12 10:17:33 +02:00
Tomaž Vajngerl
8484e52675 tdf#117427 missing API for determining and loading linked graphic
This adds 2 properties to GraphicDescriptor:
"Linked" - to indicate if the graphic is a linked one
"OriginURL" - the URL of the location from where the graphic was
or will be loaded (and is linked to)

Additionally GraphicProvider was extended with a "LoadAsLink"
(media)property, which can be passed using queryGraphic method.
If "LoadAsLink" is set to true, then the Graphic will be created
as a linked one.

In addition the tests for this API was added to VCL (home of this
API implementors).

Change-Id: Ibdabe5e7780d1b372d1e66c3e19b18779fee2c9a
Reviewed-on: https://gerrit.libreoffice.org/54090
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-12 10:07:09 +02:00
Adolfo Jayme Barrientos
3e2fdcf480 Updated core
Project: help  5f14059e0d87ac3552b02436405b129c1c3257e1

Helponline: Only add extra <p> margin for main body text

Change-Id: Ia6413bbe4e16ee39dbd01ba48fa307514f517fbe
2018-05-12 09:31:35 +02:00
Khaled Hosny
23c5125148 Use HarfBuzz to get Kashida width
One less platform-specific piece of code.

Change-Id: Ib04c5f1434046e26ead2aaedace67127a5513e55
Reviewed-on: https://gerrit.libreoffice.org/54098
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-12 02:08:59 +02:00