5400 Commits

Author SHA1 Message Date
Stephan Bergmann
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
Caolán McNamara
cbfaf0c794 coverity#1219805 Uninitialized scalar field
Change-Id: Id6b15e8515d73cb5bdf4bc6d02d235ebc7e282da
2014-07-01 10:56:16 +01:00
Caolán McNamara
e5d60c4754 coverity#1213562 Uninitialized scalar field
Change-Id: I9a40cee6e807599e8e3d9f3df52186fd6226f7e1
2014-07-01 10:56:16 +01:00
Caolán McNamara
1271ac20d4 coverity#706266 Uncaught exception
Change-Id: Iba3d2b8cddcd9e0f228d5b9fef1ce3290047c8b0
2014-07-01 10:56:16 +01:00
Caolán McNamara
5ace3f3b4f clang scan-build: various warnings
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
Miklos Vajna
e123226d87 CreationWizard already inherits boost::noncopyable via OutputDevice
Change-Id: Ie155742ea9fc29b5b1adfa219c0bc6fdd78cb637
2014-06-30 19:53:12 +02:00
Kohei Yoshida
483a4b546c Flush modified data to the model when pressing OK in the data table dialog.
This dialog used to have no OK / Cancel buttons, and the data would get
flushed when the dialog got dismissed.  This behavior got lost during the
dialog conversion.

Also, SaveModified() does check whether or not the data table is modified.
No need to call IsModified() before calling SaveModified().

Change-Id: I5cea88cb52127cc5c7c1be67a5a592d87df92d0c
2014-06-27 11:35:11 -04:00
Stephan Bergmann
af70a45633 Missing include dir
Change-Id: Id1d1ed3639548b335dff2d9fa5689b90f1ae5f61
2014-06-27 15:08:54 +02:00
Markus Mohrhard
355c3cbb16 fix invalid memory access in chart tests
Change-Id: I056101d146c939ff958c83efc57fd110e8d52509
2014-06-27 10:05:45 +02:00
Kohei Yoshida
ecde8155fe fdo#79151: No need to offset column index by category labels.
In fact, doing so would lead to a corrupt internal data table.  The
internal data stores category labels separately from the column data, so
there is no reason why we need to offset for category labels here.

Change-Id: I29dd99e53837cba7a1e28d2a1ef39a5384378805
2014-06-26 22:49:35 -04:00
Kohei Yoshida
822d0e9db6 Use new GridPrinter instance for each table.
resize() sometimes leads to a crash.  Need to debug later.

Change-Id: Ia3809eb4f171369a58b84d5b44001692be1453a1
2014-06-26 22:33:55 -04:00
Kohei Yoshida
c6da184295 Track all uses of ErrorBarX and ErrorBarY UNO property names.
Change-Id: I994424c98d977c3a8f9138cccc17348de813a9d7
2014-06-26 19:36:46 -04:00
Kohei Yoshida
95272e7e5b Prevent a crash while dumping internal data content.
Change-Id: I0938b955b460d8c91607e6df0b9d9e1a4a971013
2014-06-26 18:58:41 -04:00
Kohei Yoshida
aa6495b6fa Better way to dump the content of InternalData.
Row levels are currently not dumped, but that may change later.

Change-Id: I849f8b65d6f419bc4d97e2af2d456e73c7e9a355
2014-06-26 14:26:50 -04:00
Caolán McNamara
2daceb87b9 clang: Uninitialized argument value
Change-Id: Id65c5815185cf022171e3523c6ad92545830104c
2014-06-26 16:29:13 +01:00
Kohei Yoshida
8192df3887 Clarify the code a little more.
Change-Id: Idc0ff4913695ade9543cd30511aff61d24e7c495
2014-06-26 11:26:15 -04:00
Kohei Yoshida
60e94d8982 Move the category level removal code into its own method.
Change-Id: I4f0cfb4b15bc145b7a5c3491a7acbff13999bf5d
2014-06-26 11:26:15 -04:00
Kohei Yoshida
a532e2bba1 Remove these pesky ::com::sun::star ....
Change-Id: I5c8e1418cc7e01426b67233e48289497a92868d3
2014-06-25 20:24:09 -04:00
Kohei Yoshida
94c56f6a76 Tuck this anonymous namespace inside chart namespace.
This way we can eliminate those explicit '::chart' qualifications.

Change-Id: I764e0ca57c8e10f7eac47f48a4cabf28d0562113
2014-06-25 20:12:46 -04:00
Kohei Yoshida
78751ce780 Add class descriptions. These two classes' roles were not very clear.
Change-Id: Ib45c9037f2c4b3ee5bfed79f3c93e5020bac477b
2014-06-25 20:12:46 -04:00
Kohei Yoshida
9af5c13851 Re-use DataSeriesHelper::getRole().
Change-Id: Ia880bc03400d4cbf4c3033e01affafccc0a384fb
2014-06-24 22:05:20 -04:00
Kohei Yoshida
3f9275bd26 Annotate the code a little more, to make it easier to follow.
Change-Id: Iefc61fdc132a18e73b0136f0248d69ab9e07a5e8
2014-06-24 21:07:43 -04:00
Kohei Yoshida
1e0c38bb54 Unwind this logic a bit.
Change-Id: I320b28fb319b42eeae7cada31b6f27f9e342db15
2014-06-24 21:07:38 -04:00
Kohei Yoshida
3a7f55924b Reduce indentation levels.
Change-Id: I5de3dea88a1e6f36c995697ba648ce6b82f4e8ae
2014-06-24 19:03:14 -04:00
Kohei Yoshida
349132616d Let's remove these lcl_ fetish.
These are not even static local functions anyway, which was what
lcl_ prefix was originally used for.

Change-Id: I0e6b6cebbcf7cdfb449cf17320fb362fc73d92a8
2014-06-24 18:46:46 -04:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
Joren De Cuyper
171efcb7ac fdo#76203 - use consistent titlecase for UI title labels
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9
Reviewed-on: https://gerrit.libreoffice.org/9858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23 09:01:25 +00:00
Markus Mohrhard
bdd87b2acd XY chart needs to set the X value property
Change-Id: Ib17b564c187dfec8abb7a17b2602f814362dd34f
2014-06-23 02:32:31 +02:00
Joren De Cuyper
7e6b31d155 fdo#80295 - Mismatched icons in Chart Data Table dialog
Change-Id: I31d9ea145e8c01a0e81507534e2cf6c584174048
Reviewed-on: https://gerrit.libreoffice.org/9843
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2014-06-22 09:32:22 +00:00
Markus Mohrhard
113866583c add test case for fdo#78080
Change-Id: If676eb03f5bd19f8abf13d1d7826d500d51e542e
2014-06-22 05:05:01 +02:00
Markus Mohrhard
c97424f82a remove now unused dialog
Change-Id: I42c340a6aee016e37ee558d46a8eab101837e9c5
2014-06-22 05:05:00 +02:00
Markus Mohrhard
77cec206e3 show the property mapping sequences by default
Change-Id: I32417ed53e491a66f700e77ae0fff2154fa5441c
2014-06-22 05:05:00 +02:00
Markus Mohrhard
086d93f130 extract common code
Change-Id: I9327f232f1edb9ef052eb7868ac60774f3b6e4cf
2014-06-22 05:05:00 +02:00
Markus Mohrhard
a1d2c88124 add test case for property mapping
Change-Id: Ib8630d15f40b00c8620eeb1c79d5d9f00d07ef49
2014-06-22 05:05:00 +02:00
Markus Mohrhard
d005413c2e don't try to set property mapping if there is no value
Change-Id: I422d651e303553e2ce30895b44b8d96664418c19
2014-06-22 05:05:00 +02:00
Markus Mohrhard
b6e49ad5dd avoid truncation double to float warning
Change-Id: I7f5c5f025954120c06fcce2c14915a8138843374
2014-06-21 04:48:48 +02:00
Markus Mohrhard
fb06300b73 fix windows build
Change-Id: I0de216a8c6259ba6ec825f85f52e2f48b97510d7
2014-06-21 04:46:14 +02:00
Markus Mohrhard
ac0989d5ea avoid manual OpenGL extension checking
Change-Id: I75faa82fc2eef7f3bfd3546d64f47dee6a0b7d08
2014-06-21 04:21:41 +02:00
Markus Mohrhard
00272efc1c I don't see a good reason for marking private methods with SAL_CALL
Change-Id: I9b73b6b6073b3249317f4e1124d840930cbe558f
2014-06-21 04:21:41 +02:00
Markus Mohrhard
374160d659 volatile does not make any sense here
Change-Id: I337d845e05007efb29f1c1fa39cdcc046b156281
2014-06-21 04:21:41 +02:00
Markus Mohrhard
7fd1fd1dea remove unneeded code for 3D charts in controller
Change-Id: I5c1f624cc05a90878f717abc8ffb0b2220ce94d5
2014-06-21 04:21:41 +02:00
weigao
6ef4565efe add code to call batch texture render
Includes warning fixes from Markus Mohrhard.

Conflicts:
	chart2/source/view/inc/GL3DRenderer.hxx
	chart2/source/view/main/GL3DRenderer.cxx

Change-Id: I09da7c49eb11da9ea2bc18a5e13f2fd2c0d6bd8f
2014-06-21 04:21:41 +02:00
Markus Mohrhard
50a5739cee small whitespace changes
Change-Id: I10aa08268bf148eb792440f13bcf044b350d6937
2014-06-21 04:21:41 +02:00
weigao
016467d8a5 add batch render texture shaders
Change-Id: I922d24bc63ed7c1f16318c25da0b6b3401d24b6f
2014-06-21 04:21:40 +02:00
weigao
87e23f425f use shader to calculate alpha channel
Conflicts:
	chart2/source/view/main/GL3DRenderer.cxx

Change-Id: I3cf9636b36ffd47589dd3ab61278802ca73644ce
2014-06-21 04:21:40 +02:00
weigao
f4436dcb95 add global scale matrix
Conflicts:
	chart2/source/view/main/GL3DRenderer.cxx

Change-Id: I23b9929dd3f0f1b0a070091ed9c1fe920edfcbf9
2014-06-21 04:21:40 +02:00
weigao
4444e6cf79 fix the using 3.0 version bug
Change-Id: Ie197d0156a2d8b54fe6b08a905d82a63d31513f2
2014-06-21 04:21:40 +02:00
Markus Mohrhard
c7d390bf21 remove old comment
Change-Id: I427b408f898b4f4697f460a61fc306f65d68e12a
2014-06-21 04:21:40 +02:00
Markus Mohrhard
d3e15ac8df add disabled code for square bars
Change-Id: I4b315d9a4a6fb384eaec4d58c53291e473fb6d85
2014-06-21 04:21:39 +02:00
Stanislav Horacek
55f47e58de mark numbers as untranslatable
Change-Id: Iaa592297e8a946c121b9eaedbbab136db7593316
Reviewed-on: https://gerrit.libreoffice.org/9838
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-20 16:16:55 +00:00