mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

6674 Commits

Author SHA1 Message Date
Stephan Bergmann
9263b101c3 Activate the "suspicious cast to sal_Bool" parts of loplugin:salbool 
Change-Id: I78a368ef2899b2462251b45a327fc7b1f31fe764
 2014-07-01 17:49:10 +02:00
Caolán McNamara
968f633b24 coverity#706382 Uncaught exception 
and

coverity#706377
coverity#706378
coverity#706382

Change-Id: I17f672e31867b1be77c16a8a6e121a8f67df7c90
 2014-07-01 16:43:05 +01:00
Stephan Bergmann
e50ef195bc New loplugin:stringconcat 
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
 2014-07-01 15:45:52 +02:00
Caolán McNamara
6d45e2a4fc coverity#1224302 Uncaught exception 
Change-Id: I622a7c41c9083f2deec21dc8c37572f978874127
 2014-07-01 10:56:14 +01:00
Julien Nabet
430484932e Typo: beeing->being 
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
 2014-06-29 13:15:51 +02:00
Norbert Thiebaud
d979903273 odbc driver: let's not allocate the buffer twice for nothing 
Change-Id: If5db845c856a9fb3adf8c4fcb883607e1cb9446e
 2014-06-28 17:22:11 +02:00
Norbert Thiebaud
715ecfe361 firebird driver: shutdown explicitely firebird on dispose of driver. 
Change-Id: Ia44f7e01a3a01da57e4d9382f41511aa6f987b43
 2014-06-28 16:56:24 +02:00
Norbert Thiebaud
9015333ebd firebird: release driver on dispose rather than destroy. 
Change-Id: I5ffeaf818c1eb4985bdd150830f089f03fe42ceb
 2014-06-28 16:56:24 +02:00
Norbert Thiebaud
ae6551b43d firebird driver, abandon ref to about to be disposed embedded storage. 
Change-Id: I6bfce155151b79cd0a1707744e79298b45d8752b
 2014-06-28 16:56:23 +02:00
David Tardon
6af3926609 WaE: null argument where non-null required (argument 2) 
Change-Id: I3eb71120aed85a4ec2c697d149006bce063d983e
 2014-06-28 07:22:23 +02:00
Norbert Thiebaud
f7453024e1 fdo#80574 firebird memory management issues 
Change-Id: I37438cd3f9c8e197e5a3aa3d9cbcc5bf3681d792
 2014-06-27 23:37:51 +02:00
Stephan Bergmann
939ce4afbb Blind fix for OPreparedStatement::setParameter's useWChar case 
...after 0181a13904daef160bee543e9806b23a835f79c8 "odbc properly support
platform with sizeof(SQLWCHAR) = 4" introduced usage of RTL_TEXTENCODING_UCS2/4
there, which do not make sense in combination with converting between OString
and OUString.

OTools::getStringValue will need a corresponding fix, too, in the other
direction (where the OUString(sal_uInt32 const * codePoints,
sal_Int32 codPointCount) ctor will be useful).

Change-Id: Ia94cd0deec46d269b6ee43362f4849837bb011c5
 2014-06-27 23:07:00 +02:00
Norbert Thiebaud
0181a13904 odbc properly support platform with sizeof(SQLWCHAR) = 4 
Change-Id: I06d5a6c93817d2623fac3962b82c1319caf13276
 2014-06-27 17:08:04 +02:00
Stephan Bergmann
e48a233960 loplugin:unreffun: also warn about redundant redeclarations 
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
 2014-06-27 15:27:39 +02:00
Michael Stahl
0de1e3a015 remove spurious com::sun:⭐:chaos 
Apparently some time before inital CVS import a global
search-and-replace went horribly wrong and added spurious namespace
prefixes everywhere.

Change-Id: I4009bc3ab4b1d4c80412f75ad0e4628a382f99f0
 2014-06-25 15:04:46 +02:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref 
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
 2014-06-24 11:34:21 +02:00
Julien Nabet
75ae6c9105 Typo: kjnow->know 
Change-Id: Ib30aa4e8f430131f5f073169d694e53a3bcd6960
 2014-06-18 22:56:12 +02:00
Julien Nabet
75df2983cb Typo: perharps->perhaps 
Change-Id: Ibc1580d04d896a953edc15fb6cc9381914230e32
 2014-06-18 22:55:24 +02:00
Lionel Elie Mamane
4c6a27aaad Use rtl::Reference to make code clearer & exception-safe 
Change-Id: I8cfdf792541b351a19e16f95d4e6f7127e3d33b2
 2014-06-18 22:46:53 +02:00
Lionel Elie Mamane
2504ffccd0 fdo#80084 file driver PreparedStatement: close previous ResultSet on reexec 
This partially reverts commit d87c2c59c9c1d5f5825f355c9eb941fdf95b42f6
"sdbc file driver (Prepared)Statement: created ResultSet owned by *caller*"

From that commit, we keep the part about not reusing the same
ResultSet on reexecution (client code may have disposed it or closed
it), but we revert the part about not closing / disposing the previous
ResultSet on reexecution.

Change-Id: I4946207f9740484b2f5fbc3575a5708fe39f357c
 2014-06-18 16:17:32 +02:00
Stephan Bergmann
03a1c42143 rtl::Reference fits just fine here 
Change-Id: Ib48999c7fe532b2a8bf5222ef27d8d4929937e3b
 2014-06-18 11:26:33 +02:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Julien Nabet
488f312000 Resolves: fdo#80025 Crash with Thunderbird/Icedove address book 
There's no property USEBOOKMARKS for mork/moz

(regression from 0fadbdbbdbd55cf60f9a202f1cf7b1d60517078c)

Change-Id: If81f063fad2d702c9d8b0bb4147757655cb016cf
 2014-06-15 07:02:11 +02:00
Stephan Bergmann
75838570c3 loplugin:staticcall 
Change-Id: I7f22aa5576ca3c62fa363971f4fa5992b7711563
 2014-06-13 17:54:24 +02:00
Caolán McNamara
1beabeb55c coverity#706304 Uncaught exception 
also

coverity#706301

Change-Id: Ie6eba530c9a2f822226fbd1b1a6aa49deaf99659
 2014-06-13 13:38:26 +01:00
Julien Nabet
0acd0ed3a5 Related fdo#79714 OSX-crash opening query or table in embedded Firebird ODB 
See https://bugs.freedesktop.org/attachment.cgi?id=100839 and other comments

Change-Id: I1187b171caf54997f5e8850ade4a3fb35ad9ec29
 2014-06-11 19:24:03 +02:00
Caolán McNamara
88cf5c115d coverity#1213468 Uncaught exception 
Change-Id: I451b13be6b72925e4cfa0e66c5690eca22c54dad
 2014-06-10 16:08:03 +01:00
Thomas Arnhold
c2034f3993 fixincludeguards: fix include guards 
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-06-06 19:16:40 +00:00
Caolán McNamara
231ae9c77c coverity#1158175 Missing break in switch, assuming its intentional 
Change-Id: Ia0f1951f1e3edcd858a37ea091550feb2b9fd451
 2014-06-05 13:35:54 +01:00
Noel Grandin
11383f56fb connectivity: remove SAL_THROW macro 
Change-Id: Id3bbb7a0d39a41b7106303f42d55ba4968235b63
 2014-06-05 08:17:47 +02:00
Thomas Arnhold
a2db194ea0 connectivity: fix includes 
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
 2014-06-04 21:18:39 +02:00
Caolán McNamara
332a67afdc coverity#736759 Dereference before null check 
Change-Id: Ia36e192d32c46a5c1129eca050b2863ec1213bb4
 2014-06-04 12:34:14 +01:00
Julien Nabet
d7dd4bbf0a Resolves: fdo#79493 Refresh Tables option fails with Firebird 
Comparing with hsqldb part, sdbcx::OCollection link wasn't present in Tables constructor
Also include Catalog.hxx to be able to call "refreshTables" method

Change-Id: I1d8f2b0b361f8fd90f3065c07b3224894a3700d6
 2014-06-01 00:24:15 +02:00
Lionel Elie Mamane
d2d2136f3f fdo#73352 firebird don't claim to support interfaces one doesn't 
and then throw an exception when the interface is used

Change-Id: Id5e2c852323d49f51ab55cf46ab54223cf8ccf03
Reviewed-on: https://gerrit.libreoffice.org/9590
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
 2014-05-31 03:57:26 +00:00
Julien Nabet
6cc359f8d7 Replace "compareToAscii" by != 
See http://nabble.documentfoundation.org/Strange-part-in-connectivity-source-drivers-jdbc-tools-cxx-td4110680.html

Change-Id: I1ed37671e6c248ada7a972dba00e0fe98b565e75
 2014-05-30 22:17:41 +02:00
Stephan Bergmann
317306710d Fix memory leak 
Change-Id: I64a74ea23d9a2410ebff0c42c54601fd0b0190f0
 2014-05-30 16:16:19 +02:00
Stephan Bergmann
773881d49e Fix memory leak 
Change-Id: I30ab0dcf47d236c8ebda3a2d1da0aaa4f0cd7477
 2014-05-30 16:16:02 +02:00
Stephan Bergmann
f33dc92572 Fix memory leak 
Change-Id: Ia9176826b89b947408230bf65db26a83f269c845
 2014-05-30 15:55:01 +02:00
Stephan Bergmann
c9f5e9b709 Fix memory leak 
Change-Id: I70522657f968ed4f84e9447dd999d8be746fc973
 2014-05-30 15:55:00 +02:00
Stephan Bergmann
63405c0500 Fix memory leak 
Change-Id: I0e5c3af0504f3090a5db7692c6bfb1d33b3aa81f
 2014-05-30 15:55:00 +02:00
Jens Carl
54b85bf51e fdo#68849: Add header guards to all include files 
Added header guards to files in directories avmedia/, basegfx/, chart2/, and
connectivity/

Change-Id: I94ec438ec918ccef1c518edfd9ab4944e9e2961b
Reviewed-on: https://gerrit.libreoffice.org/9555
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-05-30 01:43:33 -05:00
Lionel Elie Mamane
db681394e0 Update comment to reality... many properties now, not one. 
Change-Id: Icc81d3067969d1d61182865d36ecabec4e7f85b7
Reviewed-on: https://gerrit.libreoffice.org/9551
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
 2014-05-29 10:52:16 -05:00
Julien Nabet
74393875bc To avoid some confusion for people like me :) 
Thank you Lionel and Tor!
(see http://nabble.documentfoundation.org/Strange-part-in-connectivity-source-drivers-jdbc-tools-cxx-td4110680.html)

Change-Id: Ibbe68b8b3d12e4dfacf7f66bb3adbc2fd831d1a5
 2014-05-29 12:45:20 +02:00
Noel Grandin
624a116d14 use OUString::startsWith() 
Change-Id: I0fc77b50792e48be175ab7cc151509e097676849
 2014-05-29 09:01:40 +02:00
Noel Grandin
ebc0a15515 remove more unnecesary OUString constructor use 
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
 2014-05-29 09:01:40 +02:00
Noel Grandin
f0ae48b684 remove unnecessary NULL parameter passed to UNO Exception 
.. now that we have a default value for that parameter

Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
 2014-05-29 09:01:40 +02:00
Caolán McNamara
55029129aa coverity#982631 Missing break in switch 
Change-Id: I1c21dfb48f4ecdcc3c599d69fe76bde006a85313
 2014-05-26 10:18:27 +01:00
Caolán McNamara
56abf72c45 coverity#983622 Uncaught exception 
Change-Id: I3b63a42444a116afe7d88e2f806b17a709651e34
 2014-05-24 16:11:01 +01:00
Caolán McNamara
90b4c3a888 coverity#1103737 Uncaught exception 
Change-Id: I53aab00dfad0310a7846fdf7185c50036329343c
 2014-05-23 20:37:36 +01:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00