.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.
Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.
Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.
Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
This is the actual re-write.
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
(*this) << 1;
Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
This populates "object" member variable.
The "createStatement" calls were removed in:
commit b9392a36645d8632b97ad79240f483b3a1683b61
Author: Ivo Hinkelmann <ihi@openoffice.org>
Date: Thu Apr 23 10:42:05 2009 +0000
CWS-TOOLING: integrate CWS dbaperf1
This was most probably in error since the call is not removed from the
other modified member functions in this commit and/or failed to
aaccount for the scenario of no parameter (and thus no setXXX call
before execute).
Change-Id: Ic0e7b7b64ea496791f32c1416aa7d4416f909616
from
sal_Int32 nIndex = sSystemPath.lastIndexOf('.');
so
OUString sConnPartURL = sSystemPath.copy( 0, ::std::max< sal_Int32 >( nIndex, sSystemPath.getLength() )
is equivalent to
OUString sConnPartURL = sSystemPath.copy( 0, sSystemPath.getLength() )
which is
OUString sConnPartURL = sSystemPath;
so drop sConnPartURL and replace with sSystemPath
Change-Id: I3fc8e88a4b3e474c3dccd08cf356e4663503ae02
...for internal loader="com.sun.star.loader.SharedLibrary" components, instead
of exported component_getImplementationEnvironmen (or implicit
CPPU_CURRENT_LANGUAGE_BINDING_NAME). Adapted a few .component files as proof-
of-concept, more to follow.
Change-Id: I82332e0a48e6fc1da245990bb72265fe6e58447e
!pSchemaPat->isEmpty() checked twice where line before we test if aPKQ is empty
so it seemed quite logical to test aPKO here
Change-Id: I79d7ec89f7ae67520492bbd4121a4a86918f2fbf
dd0990db74a4a5c3a129a7ff0ed2a739cd74a381 "fdo#72463 RowSet: on execute when not
dirty, rebuild cache" had temporarily introduced a bug that caused m_pParseTree
to be null here during JunitTest_dbaccess_unoapi, but Lionel states that it
cannot legitimately be null, even though the computation of m_bIsCount in the
ctor takes potentially null m_pParseTree into account.
Change-Id: If95f076a4c80f80cd58bba83521633fe8bb71f5d
That is the only choice that makes sense, since the
(Prepared)Statement could die (go out of scope) before the ResultSet.
User code could do that, if it does not "need" the (Prepared)Statement
anymore. Also, it is only natural for user code to dispose a ResultSet
that it does not need anymore.
So we need to create a fresh ResultSet each time.
The "luck" here is that the sdbc file driver does not implement
the XMultipleResults interface; things get more hairy then.
Change-Id: Ibf2cb5e5b7ca90432a289c185a6b4fe32d1ba565
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3
"convert equalsAsciiL calls to startWith calls where possible"
I incorrectly converted equalsAsciiL calls to startsWith calls.
This commit fixes those places to use the == OUString operator.
Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
