11329 Commits

Author SHA1 Message Date
Noel Grandin
d454834895 Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295.

I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
2013-11-20 16:38:28 +02:00
Noel Grandin
acebbee971 remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls
Convert code like:
    if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aByteStr.startsWith("rem"))

Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-20 13:56:08 +02:00
Noel Grandin
5112f6a6c6 remove RTL_CONSTASCII_STRINGPARAM in OString constructor
Convert code like:
    OString aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX"));
to:
    OString aKeyName("NDX");
which compiles down to the same code

Change-Id: I1780264cae4484fc78f0586b0750c09f2dce135f
2013-11-20 13:56:07 +02:00
Noel Grandin
363cc39717 convert equalsAsciiL calls to startWith calls where possible
Simplify code like:
    aStr.equalsAsciiL( "%", 1 )
to
    aStr.startsWith( "%" )

Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19 12:49:29 +02:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
Andras Timar
aecc0d723f missing translatable="yes" attributes
Change-Id: I138c8f245e4bfb2f23dd4cd8a629d8e5e3aac56b
2013-11-17 10:55:50 +01:00
Bjoern Michaelsen
04dead1c6b make l10n buildable separately
- this renames the 'almost' module target to non-l10n
- and adds a l10n target which is intended to only build l10n parts of
  the product
- packagers should then be able to build l10n and non-l10n parts of the
  product independently, thus:
   - enable quicker rebuilds
   - distribution of load
   - updates to l10n without a full rebuild
   - security fixes to binaries without rebuilding all l10n
- the new targets are called build-l10n-only and build-non-l10n-only
- note this is not intended to move a concept of split packages
  upstream -- while this exsists in distros, the number of test
  scenarios for this would explode upstream

Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863

Conflicts:
	filter/Module_filter.mk
2013-11-14 16:45:02 +01:00
Stephan Bergmann
24cad6a649 Move MediaDescriptor from comphelper to unotools
...so it will be able to use SvtSecurityOptions internally.

Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14 11:13:24 +01:00
Stephan Bergmann
a6cf7fb281 -Werror,-Wunused-member-function
Change-Id: I9cfbb66dbfac02faa478a4f38982962b0c6f3c3d
2013-11-14 10:15:04 +01:00
Stephan Bergmann
ecc060715a -Werror,-Wunused-member-function
Change-Id: If7618661da2b6c919ec05abace03723cb961c741
2013-11-14 10:15:04 +01:00
Stephan Bergmann
f7450d0266 -Werror,-Wunused-member-function
Change-Id: I6b4b3f8c272dcd5663920310e40647d7730c54d5
2013-11-14 10:15:03 +01:00
Noel Grandin
d9648d3567 remove unnecessary sal_Unicode casts in DBACCESS module
Change-Id: I4c4ab5d672e994b1e8e3beac027d3f4e8f700714
2013-11-14 08:17:30 +02:00
Andrzej J.R. Hunt
a3eece5a88 Pass Document directly to Driver for embedded databases.
Change-Id: I346a8ef07c5d695b3aa879f5c25cc4af97e25b99
Reviewed-on: https://gerrit.libreoffice.org/6627
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-11-13 14:38:40 +00:00
Noel Grandin
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
Noel Grandin
ef90021abe convert OUString !compareToAscii to equalsAscii
Convert code like
   if( ! aStr.compareToAscii("XXX") )
to
   if( aStr.equalsAscii("XXX") )
which is both clearer and faster.

Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
2013-11-11 12:58:12 +02:00
Noel Grandin
0a9ef5a18e convert OUString 0==compareToAscii to equalsAscii
Convert code like:
   0 == aStr.compareToAscii("XXX")
to
   aStr.equalsAscii("XXX")
which is both clearer and faster.

Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11 12:58:12 +02:00
Noel Grandin
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
Noel Grandin
3ef88d370e remove unnecessary use of OUString constructor in DBACCESS module
Change-Id: I831a6506211be30c5b743c20724904c903c5b3c0
2013-11-11 11:21:24 +02:00
Lionel Elie Mamane
1b85ffca7d factorise code; make DBTestBase a UnoApiTest
Change-Id: I29c131f60caa36c464d99b9b86a59e2e16ce94e3
2013-11-09 22:34:14 +01:00
Lionel Elie Mamane
516f9b013f indentation
Change-Id: Idec97e6b9269cb481428bef8b95aa112197fe866
2013-11-09 18:40:10 +01:00
Lionel Elie Mamane
7b9a9a4986 make firebird-sdbc an experimental feature
Change-Id: I0f2453e23d18597cfe1ad2a4cd4902b15f0a8f7d
2013-11-09 18:39:18 +01:00
Lionel Elie Mamane
43caf4fe9b fixup the fixup to dbaccess macros_test
Change-Id: I7cc8b6bd3778158e7c93545bbdcf35cccf986188
2013-11-09 07:01:28 +01:00
Lionel Elie Mamane
9a0a4fddc5 fixup dbaccess macros_test
Change-Id: Iefb12d8b6fe8b5c9795220f8c7ff90f6ecc92576
2013-11-09 06:52:55 +01:00
Lionel Elie Mamane
f630c021ed nitpicks
Change-Id: I190a629a8c76f98b54295eebcf712b4c5b26ecff
2013-11-09 06:36:51 +01:00
Lionel Elie Mamane
bf967a4f15 deliver can use hardlink
Change-Id: Ia04eedc6375748505c954e2315a0c5af7afae84f
2013-11-09 06:36:50 +01:00
Lionel Elie Mamane
4c64b8851b fixup and enable dbaccess macros_test
Change-Id: Ic5599df7a2ad7f2f3a9f2794b16ef0a4ab698b06
2013-11-09 06:36:46 +01:00
Lionel Elie Mamane
a071a29d4f UnoApiTest don't require Calc
There is no reason for the generic UnoApiTest to require Calc
specifically. Calc tests can/should instantiate a Calc instance.
We can create a CalcUnoApiTest for that that inherits from
UnoApiTest; however this does not seem necessary, "make sc.clean"
succeeds.

Anyway, the ScGlobals::ensure mentioned in the comment does not
seem to exist.

This allows us to eliminate some code duplication in tests
that were reimplementing UnoApiTest minus the Calc instantiation.

Change-Id: I37bea9df41e3960df0458fe689cf6c046a243617
2013-11-09 06:36:45 +01:00
Lionel Elie Mamane
e937995ca3 dbaccess DialogSaveTest not a UnoApiTest
It overrides everything that UnoApiTest does anyway.

Change-Id: I531b2245626cbfd8d13a48a710d409e30ba2d20a
2013-11-09 06:35:56 +01:00
Andrzej J.R. Hunt
117b24dbbd Add "New Database" button for Firebird file driver dialog.
Firebird is able to create new databases from within LO hence we need
to add a new property to database configration files.

This allows use of a db creation dialog (which is opened
by using the "New Database" button) in order to allow creating new
dialogs (in addition to being able to open existing databases using
the "Browse" button).

Conflicts:
	dbaccess/source/ui/dlg/ConnectionHelper.hxx

Change-Id: I6174f3b7d9032c48286b49b5ddf125cd3b428303
2013-11-07 08:15:27 +00:00
Stephan Bergmann
107c2c7c7b Remove #ifdef TIMELOG'ed SAL_INFOs
...the code doesn't make much sense that way.

Change-Id: I506e37b44924701255431f6d20d4610f7f52287d
2013-11-06 20:55:58 +01:00
Noel Grandin
296329a926 convert xub_StrLen to sal_Int32
convert for loops using xub_StrLen to use sal_Int32

Change-Id: I5f635ca078966fefe938dbc7e8dea7c8d0d0b554
2013-11-06 08:51:22 +02:00
Lionel Elie Mamane
730c6bfce5 fill in nNumPrecRadix
Wrongfully removed by commit 808052a13947c9841ce5c9e40860c48bbfbf3434
Date: Tue Jun 20 02:21:13 2006 +0000
which only wanted to make the code warning-free...

But also disallow radix 1 (which does not make much sense)

Change-Id: Id8e313301fa6d5e9643d76865a62cc933999a63e
2013-11-05 19:14:24 +01:00
Noel Grandin
3d65dfa3c9 convert xub_StrLen to sal_Int32
Converts code that calls comphelper::string::getTokenCount() to
use sal_Int32 to store the return value.

Change-Id: I439605a39d29b1309649e30f3ff40dfa412efcde
2013-11-05 13:18:14 +02:00
Thomas Arnhold
3a29756723 update pch
Change-Id: I10f3dbd9513052b3bbe30ddc6523cd231f26ded3
2013-11-05 09:28:55 +01:00
Thomas Arnhold
fed3c2bf20 dbaccess: cleanup
* remove an external guard
* fix some include guards

Change-Id: I4e5b5fc5c50acfd81321377e7956e33c838edeba
2013-11-05 09:28:54 +01:00
Thomas Arnhold
bfbe8c0b5b fixincludeguards.sh: dbaccess
Change-Id: Iadd4326d58a5df5761a0ed5ce7fd5fb01fb87d11
2013-11-05 09:28:52 +01:00
Noel Grandin
5285beeaa4 remove redundant calls to OUString constructor in if expression
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04 10:11:08 +02:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
Michael Stahl
8e602afd1e stop looking for Jar files in solver
Change-Id: I4d2a93fa7395354fbf2893df9e254ab39fa365af
2013-10-25 11:42:40 +02:00
Noel Grandin
7a06928bcf convert code to use OUString::endsWith
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-23 08:29:15 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
Caolán McNamara
ef23018f6f missing header
Change-Id: I84aebf0e107add76dfb293b3a34a30705fd0b3a6
2013-10-22 13:53:55 +01:00
Michael Stahl
dd28837249 vcl: mark more Image constructors as "explicit"
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22 14:42:17 +02:00
Caolán McNamara
91e181ea58 remove uses of COMPARE_*
Change-Id: Icdc36b4b24d2f399f481065df3200feb98025135
2013-10-21 14:26:32 +01:00
Caolán McNamara
45e366eadb drop unnecessary tools/string includes
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
Marcos Paulo de Souza
b538fc543e fdo#60698: Move fileaccess module to ucb
Change-Id: I4c688a4aeedcae56ed6404574bd1bb392d4190cb
Reviewed-on: https://gerrit.libreoffice.org/6311
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-18 12:25:11 +00:00
Marcos Paulo de Souza
3d3293144b fdo#54938: Adapt svtools and comphelper module ...
to  use cppu::supportsService and other pieces.

Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-17 14:43:28 +02:00
Lionel Elie Mamane
d9eac2ceb8 make sure value passed to updateBoolean is treated as a boolean
Change-Id: I69549fd8ab95cf92ccb06fd9aed1b9dba2935d7d
2013-10-16 18:45:21 +02:00