This can happen when proportional line spacing is less than 100%
and "FontIndependentLineSpacing" is set, so just keep the height
of the very first line in case of IsFixedCellHeight() too.
Change-Id: Id231fc1f2373645e5420f877e8c2568ce8a1f099
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
This reverts commit 339e5d44a2afa0f5309a970f1ff11968103e336a
and commit d1987a3eaccfc3add35e6b9f8307ede857c5468e
"fix sd_import_tests after e42c05c1f96832572e525d85d89590f56f5a29dd".
It would need more work and understanding, so just revert.
Also, the problem with bnc#882631 is somewhere else, though this helped too.
i.e. with French dictionary available, open test case of fdo#80140, open
spell checking dialog and choose "correct" on the first example.
Every version of LibreOffice crashes on this, so its an old bug.
As can be seen from the following bt, if a11y is enabled then on calling
ImpEditEngine::ImpInsertText from ImpEditEngine::ImpDeleteSelection then
FormatDoc may be called and throw away all the old portions so the following
ParaPortion* pPortion = FindParaPortion(aStartPaM.GetNode()) will get the new
ParaPortion, not the old one, and so the MarkInvalid that uses the old
ParaPortion invalid range is not correct anymore.
Seeing as the only caller of ImpRemoveChars is ImpDeleteSelection and
ImpDeleteSelection calls TextModified after ImpRemoveChars and after the use of
MarkInvalid, it seems safe and logical to remove the TextModified from
ImpRemoveChars and rely on the ImpDeleteSelection TextModified.
#0 TextPortion::TextPortion (this=0x30bd020, nL=5) at /home/caolan/LibreOffice/core/editeng/source/editeng/editdoc.hxx:401
#1 0x00007fffd93f4d5a in ImpEditEngine::CreateTextPortions (this=0x3f42700, pParaPortion=0x3584930, rStart=@0x7fffffffa234: 0)
at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit3.cxx:2372
#2 0x00007fffd93ed087 in ImpEditEngine::CreateLines (this=0x3f42700, nPara=0, nStartPosY=0)
at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit3.cxx:687
#3 0x00007fffd93ebb3b in ImpEditEngine::FormatDoc (this=0x3f42700)
at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit3.cxx:394
#4 0x00007fffd93fd239 in ImpEditEngine::FormatAndUpdate (this=0x3f42700, pCurView=0x0)
at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit3.cxx:4156
#5 0x00007fffd937c3f4 in EditEngine::GetDocPosTopLeft (this=0x3f42690, nParagraph=0)
at /home/caolan/LibreOffice/core/editeng/source/editeng/editeng.cxx:1920
#6 0x00007fffd94d298a in Outliner::GetDocPosTopLeft (this=0x3f42390, nParagraph=0)
at /home/caolan/LibreOffice/core/editeng/source/outliner/outlin2.cxx:429
#7 0x00007fffd951c2d3 in SvxOutlinerForwarder::GetParaBounds (this=0x36015a0, nPara=0)
at /home/caolan/LibreOffice/core/editeng/source/uno/unoforou.cxx:344
#8 0x00007fffd950efe5 in SvxAccessibleTextAdapter::GetParaBounds (this=0x3394e88, nPara=0)
at /home/caolan/LibreOffice/core/editeng/source/uno/unoedprx.cxx:798
#9 0x00007fffd9aa25b5 in accessibility::AccessibleTextHelper_Impl::UpdateVisibleChildren (this=0x3394e00, bBroadcastEvents=true)
at /home/caolan/LibreOffice/core/svx/source/accessibility/AccessibleTextHelper.cxx:851
#10 0x00007fffd9aa38b3 in accessibility::AccessibleTextHelper_Impl::ProcessQueue (this=0x3394e00)
at /home/caolan/LibreOffice/core/svx/source/accessibility/AccessibleTextHelper.cxx:1332
#11 0x00007fffd9aa400c in accessibility::AccessibleTextHelper_Impl::Notify (this=0x3394e00, rHint=...)
at /home/caolan/LibreOffice/core/svx/source/accessibility/AccessibleTextHelper.cxx:1482
#12 0x00007ffff548c6ba in SfxBroadcaster::Broadcast (this=0x3394ac0, rHint=...)
at /home/caolan/LibreOffice/core/svl/source/notify/brdcst.cxx:43
#13 0x00007fffd895ce27 in SvxTextEditSourceImpl::NotifyHdl (this=0x3394a50, aNotify=0x7fffffffb4c0)
at /home/caolan/LibreOffice/core/svx/source/unodraw/unoshtxt.cxx:1030
#14 0x00007fffd895cd61 in SvxTextEditSourceImpl::LinkStubNotifyHdl (pThis=0x3394a50, pCaller=0x7fffffffb4c0)
at /home/caolan/LibreOffice/core/svx/source/unodraw/unoshtxt.cxx:1023
#15 0x00007fffd936252a in Link::Call (this=0x3f426a8, pCaller=0x7fffffffb4c0)
at /home/caolan/LibreOffice/core/include/tools/link.hxx:123
#16 0x00007fffd94db186 in Outliner::EditEngineNotifyHdl (this=0x3f42390, pNotify=0x7fffffffb4c0)
at /home/caolan/LibreOffice/core/editeng/source/outliner/outliner.cxx:2041
#17 0x00007fffd94db149 in Outliner::LinkStubEditEngineNotifyHdl (pThis=0x3f42390, pCaller=0x7fffffffb4c0)
at /home/caolan/LibreOffice/core/editeng/source/outliner/outliner.cxx:2038
#18 0x00007fffd936252a in Link::Call (this=0x7fffffffb490, pCaller=0x7fffffffb4c0)
at /home/caolan/LibreOffice/core/include/tools/link.hxx:123
#19 0x00007fffd93e0155 in ImpEditEngine::CallNotify (this=0x3f42700, rNotify=...)
at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit2.cxx:4339
#20 0x00007fffd93cf462 in ImpEditEngine::TextModified (this=0x3f42700)
at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit2.cxx:707
#21 0x00007fffd93d5a73 in ImpEditEngine::ImpRemoveChars (this=0x3f42700, rPaM=..., nChars=8, pCurUndo=0x0)
at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit2.cxx:2064
#22 0x00007fffd93d77bd in ImpEditEngine::ImpDeleteSelection (this=0x3f42700, rCurSel=...)
at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit2.cxx:2424
#23 0x00007fffd93d89f6 in ImpEditEngine::ImpInsertText (this=0x3f42700, aCurSel=..., rStr="Smoothie")
at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit2.cxx:2645
#24 0x00007fffd94139f7 in ImpEditEngine::ApplyChangedSentence (this=0x3f42700, rEditView=...,
rNewPortions=std::__debug::vector of length 2, capacity 2 = {...}, bRecheck=false)
at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit4.cxx:2172
#25 0x00007fffd937d0f1 in EditEngine::ApplyChangedSentence (this=0x3f42690, rEditView=...,
rNewPortions=std::__debug::vector of length 2, capacity 2 = {...}, bRecheck=false)
Change-Id: I6d0a96c8875858d8a25455f0dd1408f07e1f6e14
If line height is smaller than text height, we still want to see whole first
line, so add the difference where necessary.
This also helps to see paragraphs as separate to each other.
Change-Id: I51a87edf0cc03d5b5e130290c90347099a581d4e
...the non-mutex'ed access to the static LinguMgr members from other functions
makes it look like those are all assumed to be called with SolarMutex locked;
but that does not hold for calls to LinguMgrAppExitLstnr::disposing.
Change-Id: I225a9f7ace65774460502a4aa510abddd48d12ca
This required some changes to the framework:
* Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but
once per CppunitTest invocation in a new vclbootstrapprotector (similarly to
the exisiting unobootstrapprotector). CppunitTests that need VCL now need to
declare gb_CppunitTest_use_vcl.
* For things to work properly, the UNO component context needs to be disposed
from within DeInitVCL (cf. Desktop's Application::DeInit called from
DeInitVCL). The easiest solution was to introduce an
Application::setDeInitHook (where the hook is called from DeInitVCL)
specifically for vclbootstrapprotector to call.
* PythonTests don't (yet) call DeInitVCL; they still hook into
BootstrapFixture's original test_init functionality (to call InitVCL), and do
not make use of the vclbootstrapprotector.
Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
The editengine RTF export produces this:
{\colortbl\red255\green255\blue255;;}
... and then it proceeds to map COL_AUTO to \cf0 i.e. the "white" entry
that is the result of erroneously writing out the 0th entry regardless
of whether it is COL_AUTO or not.
Fix the color table export to always put COL_AUTO first (as the Writer
RTF export already does), and simplify the code a bit.
Change-Id: Ia8ce19f387e3627a1b4a26bcc723edcf5b1ffdf8
