Commit Graph

1642 Commits

Author SHA1 Message Date
Tor Lillqvist
494f930408 Fix fallout from 3137258e34
WaE: expression which evaluates to zero treated as a null pointer
constant of type 'OutputDevice *'.

In this case, I think the code would have worked despite the scary
warning. (By luck, as the sal_False got passed as a NULL OutputDevice
pointer, and the following sal_Boolean parameter, which the sal_False
presumably was intended to mean, has the default value of sal_False.)
But better to make it more explicit which overload of Paint() is
intended.

But seriously, what good is supposed to come from the overloading of
the function name Paint() here? Would it really be so horribly
old-fashioned and C-like to use two different function names for the
slightly different use cases?

Change-Id: Ib397c8c1785320d3a9c0579a24f2c28ee4d22796
2013-03-11 12:14:44 +02:00
Armin Le Grand
3137258e34 Resolves: #i118905# Changed EditEngine to be able to paint to overlay directly
i.e. paint to VirtualDevice as well, not only to Window.
Removed the no longer needed switch between buffered and unbuffered overlay,
this removes the flickering white block.

(cherry picked from commit 5ab32faf2426fa60f975d0b544cfd671cdc7983b)

Conflicts:
	editeng/inc/editeng/outliner.hxx
	editeng/source/editeng/impedit.hxx
	editeng/source/editeng/impedit3.cxx
	editeng/source/editeng/impedit4.cxx
	svx/inc/svx/sdr/overlay/overlaymanager.hxx
	svx/inc/svx/sdr/overlay/overlaymanagerbuffered.hxx
	svx/inc/svx/sdrpaintwindow.hxx
	svx/inc/svx/svdpagv.hxx
	svx/source/sdr/overlay/overlaymanager.cxx
	svx/source/svdraw/sdrpaintwindow.cxx
	svx/source/svdraw/svdedxv.cxx
	svx/source/svdraw/svdpagv.cxx

Change-Id: Ibf4fcba77b120187fbae2454d136d2acd74be119
2013-03-11 07:50:32 +00:00
Jian Fang Zhang
65a10fffc7 Resolves: #i120667#, pBound member obj in TextRanger is not freed
Found by: zhangjf
Patch by: zhangjf

Change-Id: Ifa4c49cd3f7f576c9c86e0269fe9e7ae69a9b325
2013-03-09 19:10:35 +00:00
Ivan Timofeev
c487fa125e const-correctness
Change-Id: I15033051cfa4baafde4736abf366ca8c03778b88
2013-03-09 22:03:59 +04:00
Ivan Timofeev
66b86df573 related to fdo#47018: fix DBG_ASSERT in EditEngine::QuickMarkInvalid
regression from 2a6abe21ca

Change-Id: I007c54d5b6d28bfbf0bf21c4b85d408181731fd2
2013-03-09 19:35:13 +04:00
Julien Nabet
85429fbe77 Remove unused EditTextObjectImpl::RemoveParaAttribs
Change-Id: I3849cbac0e3d08686004775fbe7f749af0bfad62
2013-03-09 01:56:48 +01:00
Borim
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
Thomas Arnhold
6583305dd7 simplify compareTo (now correct)
Change-Id: Ia4fd2f54d0bda71d472f46949500c0b23ff8e1b7
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-03-08 13:04:13 +01:00
Stephan Bergmann
3d4723f80a Revert "simplify some compareTo"
This reverts commit 19020191cb,

  s1.compareTo(s2, length-of-s2)

is *not* equivalent to

  s1 == s2
2013-03-08 09:03:10 +01:00
Thomas Arnhold
19020191cb simplify some compareTo
Change-Id: Ib63cfac8b5f129f31534020fd634750e846e3b98
2013-03-08 05:42:05 +01:00
nccuong
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
Takeshi Abe
ce33f85ffd sal_Bool to bool
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
2013-03-04 23:14:41 +09:00
Thomas Arnhold
33d6a7b2d7 doubled namespaces
Change-Id: I0f6a34a459c1492a69afa3ef6bcbaa8ed7639a22
2013-03-04 13:58:40 +01:00
Thomas Arnhold
26e37ca4c7 doubled includes
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
Thomas Arnhold
5b04c9063c remove unused and commented out code
This code gets never called.

Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-03-04 11:34:07 +00:00
Thomas Arnhold
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
Gregg King
db7a441342 Typo fix: informations -> information and a few other adjacent typos.
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-02 02:45:55 +00:00
Caolán McNamara
a526370737 Related: fdo#55693 add regression tests for autocorrection
Change-Id: Ie9bbeb38ec9cc2fa0377709e75abb0338b20bab5
2013-03-01 12:20:24 +00:00
Caolán McNamara
b458e734fd vector::at on guaranteed in-bounds values
Change-Id: I6ca8ec182e4c68f4cc29c7669168b513cdf148bd
2013-03-01 12:20:23 +00:00
Christopher Copits
ea7d6d0702 fdo#55693 Two initial capitalized letters corrected in compound words
What changes I made:

1. In svxacorr.cxx SvxAutoCorrect::IsAutoCorrectChar, I added '-' as a character.
2. In svxacorr.cxx SvxAutoCorrect::FnCptlSttWrd, I added code to iterate through each AutoCorrectChar in a compound word to determine if capitalization needs fixing.

Change-Id: I4e7de33fceccdea5edd84e83bacc7ae690135d76
Reviewed-on: https://gerrit.libreoffice.org/2351
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-28 23:08:36 +00:00
Michael Stahl
b768611724 remove all d.lst
Change-Id: Icba4218c5f9fe89d183d25ea82a8eae52881f885
2013-02-28 18:40:06 +01:00
Tor Lillqvist
04df3cb2b9 Remove dead voice command code
I don't see voice input commands being generated anywhere. Nobody seems to
know what this code has been used for.

Change-Id: I4e4221dd4dff76086d0268be286c3605e669bae7
Reviewed-on: https://gerrit.libreoffice.org/2452
Reviewed-by: Niko Rönkkö <ronkko@iki.fi>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-28 14:42:37 +00:00
Jean-Noël Rouvignac
875c997c7d fdo#39446 - Bloat Removal. Removing uncallable code with callcatcher
Removed several unused methods.

Could not remove ScVbaFormat<ooo::vba::excel::XStyle>::getAddIndent() and ScVbaFormat<ooo::vba::excel::XStyle>::setAddIndent(com::sun::uno::Any const&) because it breaks compilation (they are implementing pure virtual methods).
Should Test::test1Table1Page() really be removed? (test class)

Conflicts:
        unusedcode.easy

Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
2013-02-27 15:40:16 +01:00
Jean-Noël Rouvignac
465dbaecf9 fdo#38838 Replaced some use of (Xub)String with OUString.
Change-Id: I5a8f2d1a5762c20d21d31b04778a9e2cac8df9cb
Reviewed-on: https://gerrit.libreoffice.org/2364
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-26 15:51:23 +00:00
Armin Le Grand
b57cb53267 Fix i#119756 Safer take care of empty paragraphs in EditEngine layouting
This fixes fdo#59629 on our side.

Conflicts:
	editeng/source/editeng/impedit3.cxx
	and moved sal_uInt16 nIndex back up in scope.

Change-Id: Ie2b5dac48b10ff8c031f481f0a7ddde644694975
2013-02-25 20:56:37 +01:00
Thorsten Behrens
455836cd81 Rename loop variable in ImpEditEngine::Paint
This had nothing to do with y coordinates.

Change-Id: I36baf05cd4c4a67b24574f6651b1c3f1eb12e22e
2013-02-25 20:56:15 +01:00
Thomas Arnhold
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
Thomas Arnhold
e39c551c61 remove duplicate line
This looks wrong. Compared to ThesDummy_Impl::getLocales() it seems
sane to remove the duplicate.

Change-Id: I494b22039846da4d4e84d7f289e501d1315075bd
2013-02-25 17:59:39 +01:00
Jan Holesovsky
804f47a893 fdo#55931, fdo#57956: Fix both autofit and stretched width.
This rewrites commit fa694a21b8 (fix of
fdo#55931), and fixes it a better way.

Change-Id: I9ac0c78294e6a9c510c12b22547564b736416131
2013-02-25 15:08:05 +01:00
sadam36
93a9744212 fdo#60724 - change 'charcter' to 'character'
Changed all occurrences of 'charcter' found by git grep. All of them
were used in comments only, so it should not break anything.

Change-Id: Ief2c00d929ae7972c55a4920fc0eaa8d6b18ab82
Reviewed-on: https://gerrit.libreoffice.org/2372
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2013-02-25 13:19:12 +00:00
navin
2738fa9fdc fix fdo#38951, use paragraph’s writing direction.
In case of RTL, we want bullet text e.g. “1. ,1)” to be reversed
e.g. “.1,(1”, so we need to check only paragraph’s writing direction
and pass that direction to DrawingText().
and fix drawing position calculation logic.

Change-Id: I303dc1b04ae5e66b1b5d25a40794be308f36668b
Reviewed-on: https://gerrit.libreoffice.org/2348
Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
2013-02-25 10:51:35 +00:00
navin patidar
6708ad7f1b fix fdo#60533, Set TEXT_LAYOUT_BIDI_STRONG flag.
Stop ImplLayoutArgs::ImplLayoutArgs() to perform
ubidi algo on text by setting TEXT_LAYOUT_BIDI_STRONG flag.

Change-Id: I7222517c1db6649eef0c0d9c11cbbbed1fc6bb04
Reviewed-on: https://gerrit.libreoffice.org/2076
Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa>
2013-02-25 08:19:34 +00:00
Thomas Arnhold
89003e9bd8 loplugin: unused variables
Change-Id: I63553a09eec81e5ae28aa79ee1d3281053b23d06
2013-02-25 03:14:01 +01:00
Jean-Noël Rouvignac
63b0ce97ba fdo#38838 searched, replaced and removed String::CreateFromInt32().
I ran the following code replace:
    s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/

And finally removed String::CreateFromInt32().

Change-Id: I53b26a59c68511ae09f0ee82cfade210d0de3fa5
Reviewed-on: https://gerrit.libreoffice.org/2279
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-24 12:59:02 +00:00
Julien Nabet
eb7185a168 Fix typo begining/beginning.
Change-Id: I9fff386181a2be0bc83787c8b5aec9c1cb4db9c3
2013-02-23 19:17:03 +01:00
Julien Nabet
7c7755473e Fix typo "teh" -> "the"
Change-Id: Iacfeb4a0c2bff254e5bcc8d58582994cd0f3993a
2013-02-23 15:28:55 +01:00
Caolán McNamara
805f1ed598 fix editeng and basctl build
Change-Id: I0d70449ad9b42219969c82e2054694c4a5830dcf
2013-02-22 10:40:16 +00:00
Julien Nabet
1443a9f7ab [Uu]sefull -> [Uu]seful
Change-Id: I5dad83789ff9b6815561208679a5e19821041e1f
2013-02-22 11:12:33 +01:00
Tor Lillqvist
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
Tor Lillqvist
2926bd4d6b s/whith/with/
Change-Id: I23da81c182ad30faf871d98e55820295418207d0
2013-02-22 09:39:11 +02:00
Tor Lillqvist
0c317af38a s/childrens/children/
Change-Id: I1731710811506383d29c835a613b07506e7232f0
2013-02-22 09:32:10 +02:00
Caolán McNamara
5c31e17e46 sync two translations of the same fundamental comment
Change-Id: I4da6683489c87fe06d45474dfc20351cb31ed000
2013-02-15 13:57:25 +00:00
Kohei Yoshida
1aaf9a9b36 Renamed hard-to-remember 8-char headers in editeng.
Change-Id: If255802082890e1b1b4c5197a791fa79a011773e
2013-02-12 15:15:06 -05:00
Noel Grandin
53ec703c14 fdo#46808, Adapt linguistic2::DictionaryList UNO service to new style
Change-Id: Iaf81a38063411b8a003b78f7eb7d6aab6c9df292
2013-02-12 10:14:43 +02:00
Noel Grandin
a6a8a8707b fdo#46808, convert xmloff module code to use XComponentContext
with lots of repurcussions in other modules

Change-Id: I6982671eecc701b06cf85d93533e1fe618044fea
2013-02-12 10:14:43 +02:00
Noel Grandin
790b0c4d53 fdo#46808, convert i18n::OrdinalSuffix to new-style
Change-Id: I62d0d3455d81bf9a2ea485b74faa5f1ecd417d87
2013-02-12 10:14:42 +02:00
Noel Grandin
e2ab5539a4 fdo#46808, convert i18n::InputSequenceChecker to new-style
Change-Id: I29678d74ae3c6dc38d3d09e2cf4a0d4f28f789a1
2013-02-12 10:14:41 +02:00
Kohei Yoshida
ec3e84c89e Add Dump() method to dump content of EditTextObject.
Useful during debugging.  Turned off in the default build.

Change-Id: Ia0b280337707f762b90d1d80c04671f2e8c21b01
2013-02-11 22:33:34 -05:00
Caolán McNamara
324709b6e3 only wanted completion as tip by default
Change-Id: I5885f277051c2b8780e4813ce4713b0c9e8bd8ea
2013-02-11 12:22:07 +00:00
Samuel Mehrbrodt
992f3ce067 Better default values for Word completion feature
http://nabble.documentfoundation.org/Libreoffice-ux-advise-Word-completion-default-value-td4031168.html

Change-Id: Ifef07653c2155b3c26d65d41cae1164b44fbd04f
Reviewed-on: https://gerrit.libreoffice.org/1937
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-11 11:13:16 +00:00