mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

5513 Commits

Author SHA1 Message Date
Stephan Bergmann
e50ef195bc New loplugin:stringconcat 
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
 2014-07-01 15:45:52 +02:00
Norbert Thiebaud
1f7a67083d coverity#703955 Unchecked return value 
Change-Id: If10c9643474620855e21caaa1fdcbbc4b7fd07ac
 2014-07-01 12:44:04 +02:00
Caolán McNamara
5ace3f3b4f clang scan-build: various warnings 
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
 2014-07-01 10:56:14 +01:00
Michael Stahl
83d00917f2 extensions: MSVC tinderbox wants its InternetGetConnectedStateEx 
Change-Id: Ie5486e910ba562954ef38c83b2fa673511a9e931
 2014-06-30 16:14:33 +02:00
Stephan Bergmann
fd6d9b9dc3 Allow CppunitTest_extensions_test_update direct access to UpdateCheck class 
Change-Id: Ifa1dafe838e0e9c5bfa4525eaa744d4851551fc8
 2014-06-30 14:16:50 +02:00
Julien Nabet
430484932e Typo: beeing->being 
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
 2014-06-29 13:15:51 +02:00
Norbert Thiebaud
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp() 
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
 2014-06-27 17:08:04 +02:00
Stephan Bergmann
9a741fcad4 loplugin:unreffun: also warn about unused function templates 
Change-Id: I4a6280f47ca3c4a77b4e42fe05d79ded7fc30ef1
 2014-06-27 07:51:51 +02:00
Caolán McNamara
daa6898578 clang: Dead initialization 
Change-Id: Ieae5303e55f21044ef8e91e63c4896696cfad51c
 2014-06-26 16:29:15 +01:00
Noel Grandin
bcfc61a49f more mac build fix 
Change-Id: I4d0f1c21aed9bbcc97f432b0f1872c508853708c
 2014-06-24 13:19:25 +02:00
Noel Grandin
4d93f2263d fix mac build 
after my commit e2080e7 "new compilerplugin returnbyref"

Change-Id: Iec1663507ddda009903c31aa3ceedfe5380c1962
 2014-06-24 13:13:05 +02:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref 
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
 2014-06-24 11:34:21 +02:00
Joren De Cuyper
171efcb7ac fdo#76203 - use consistent titlecase for UI title labels 
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9
Reviewed-on: https://gerrit.libreoffice.org/9858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-23 09:01:25 +00:00
Caolán McNamara
c12a299784 coverity#706525 Uncaught exception 
Change-Id: I2b48e88a1041823f825f4c7e00db74285aaae39d
 2014-06-19 10:26:51 +01:00
Caolán McNamara
aecbffc5f1 coverity#705999 Unintended sign extension 
also

coverity#706000
coverity#706001
coverity#706002

Change-Id: Ib970a4956fcf8362b8e3f9ae859c374c5fc8a545
 2014-06-17 13:59:38 +01:00
Caolán McNamara
629bb797b9 coverity#1223093 Uninitialized scalar field 
Change-Id: I5519b552507ab81e51f81996835467d353277a18
 2014-06-17 10:57:56 +01:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Caolán McNamara
38ee77e52c we can't use untranslatable strings here 
and drop the now unused helpid

Change-Id: I38fb93e50e7715e05f21e08c2e8714a1a52305b8
 2014-06-14 16:10:27 +01:00
Caolán McNamara
ad5f307424 we can now easily re-orient the ok/cancel/help buttons 
Change-Id: Ifc379008f545ba0c44e8c3bb18a43fc2a633dc64
 2014-06-14 16:04:55 +01:00
Palenik Mihály
c1008429d1 Convert RID_DLG_MAPPING to .ui 
Change-Id: I92a5778a2f4f69beb73885c2f7c78a43045986c0
Reviewed-on: https://gerrit.libreoffice.org/9779
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-14 15:02:05 +00:00
Stephan Bergmann
2c4494df10 loplugin:staticcall 
Change-Id: Ib8bbba8d6e3364f7474643ddb60a469497437616
 2014-06-13 17:54:26 +02:00
Caolán McNamara
a7e184e81e coverity#706514 Uncaught exception 
also
coverity#706515
coverity#706516
coverity#706517
coverity#706528
coverity#706529

Change-Id: I5beb753d5cc8ed976b3c11319cc36415adebd1e6
 2014-06-13 13:38:26 +01:00
Stephan Bergmann
8b8311a867 loplugin:unreffun 
Change-Id: Ia4eda7adc7685809b69a248f664b6a38dc3ea0e6
 2014-06-12 15:05:37 +02:00
Caolán McNamara
5c53bb8a99 scn resource file is empty now post ui-ification 
Change-Id: Id8a6d6c4faf3101b13d84de180f8db7cab2cb16f
 2014-06-12 13:54:15 +01:00
Caolán McNamara
84e1368bd8 more the png into the .ui so it isn't garbage collected 
Change-Id: If0d3829bfc14c602a0167967cbe215782c75f549
 2014-06-12 13:54:15 +01:00
Caolán McNamara
0cab72b819 extract gamma grid drawing to standalone widget 
so the dialog stops scribbling on itself, and instead
uses a real widget for that

This has to be one of our weirdest dialogs, why expend so much effort to create
this dialog for the most obscure of issues.

Change-Id: Ia25e6c67fb278528c6c68a1d6db74de59915fd34
 2014-06-12 13:54:14 +01:00
Caolán McNamara
99b1b4d475 don't use raw english string 
Change-Id: I5f34889520afb2149ba480f56d59f14d75ee50c0
 2014-06-12 13:54:14 +01:00
Palenik Mihály
3137acbe78 Convert GRID_DIALOG to .ui 
Change-Id: I4476559cc2e6a90b65d5bdc8169b256929f07f7e
Reviewed-on: https://gerrit.libreoffice.org/9734
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-12 12:53:44 +00:00
Stephan Bergmann
81f7aa81bc Resurrect SaneResId in the place where it is still used 
Change-Id: I20f751f6b9fdf683566544aed4ca2ad877abc253
 2014-06-11 18:05:24 +02:00
Stephan Bergmann
58d6e4fdc5 loplugin:unreffun 
Change-Id: Iffc5a864954e106e1b20a86c8caddf4257ff139e
 2014-06-11 17:50:13 +02:00
Caolán McNamara
14560264be Reset preview boundaries on a new scanner 
Change-Id: Id2830727216fa25ca5935406a74f4237276d56db
 2014-06-11 15:07:44 +01:00
Caolán McNamara
ab713ba1ff Changing scanners has no effect 
I guess no-one ever tested with multiple scanners but it just happens that my
laptops webcam is presented as a (non-functional) scanner alongside the real
one

Change-Id: Ie36651cfc867027ef19e272dbabe46de6c4261ee
 2014-06-11 14:52:11 +01:00
Caolán McNamara
d6eeb8a489 extract Scan Preview code into a preview widget 
instead of scribbling over the parent dialog directly. Doing is this way allows
the .ui-ification to work right.

Change-Id: Ia0c33eae4cd5a4c94896436fe5a5afad8d60a577
 2014-06-11 14:27:54 +01:00
Palenik Mihály
f188c982d5 Convert RID_SANE_DIALOG to .ui 
Change-Id: I1f08493cdc18f4c0691a8436368432fe4e94dec3
Reviewed-on: https://gerrit.libreoffice.org/9696
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-11 13:27:30 +00:00
Stephan Bergmann
bb761be472 Change SfxTabPage ctor SfxItemSet param from ref to pointer 
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions.  There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.

Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
 2014-06-11 14:39:04 +02:00
Baptiste Daroussin
a5a17ccdbc Filter out OS not needing -ldl 
Change-Id: I5863de6d8b1f0fe2419ea7419b1ff90087bb513d
Reviewed-on: https://gerrit.libreoffice.org/9715
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2014-06-10 17:25:04 +00:00
Michael Stahl
c55af68ac2 extensions: tweak quoting for Win32 make 
Change-Id: I6e3524ab98ec6ffdea24be808a718b2798e44f95
 2014-06-09 17:05:52 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Thomas Arnhold
c2034f3993 fixincludeguards: fix include guards 
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-06-06 19:16:40 +00:00
Noel Grandin
62258d9c8f extensions: remove SAL_THROW macro 
Change-Id: I12b5b46d31d5189adb21804a818ce591f2c19cbf
 2014-06-05 08:17:50 +02:00
Caolán McNamara
fcac0aef46 coverity#705376 Inferred misuse of enum 
Change-Id: Ie0e44c872d5d99d15508f8abedb51450a0e36ad0
 2014-06-04 12:34:15 +01:00
Caolán McNamara
8ca0f9854d coverity#705375 Mixing enum types 
Change-Id: Ic7cb53d8fe427b4c28b890b64fa4437846b5b493
 2014-06-04 12:34:15 +01:00
Noel Grandin
adc20c3937 compareToAscii -> equalsAscii 
convert places using compareToAscii that should be using equalsAscii

Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
 2014-06-04 11:52:31 +02:00
Stephan Bergmann
369d95931f DeInitVCL at end of tests 
This required some changes to the framework:

* Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but
  once per CppunitTest invocation in a new vclbootstrapprotector (similarly to
  the exisiting unobootstrapprotector).  CppunitTests that need VCL now need to
  declare gb_CppunitTest_use_vcl.

* For things to work properly, the UNO component context needs to be disposed
  from within DeInitVCL (cf. Desktop's Application::DeInit called from
  DeInitVCL).  The easiest solution was to introduce an
  Application::setDeInitHook (where the hook is called from DeInitVCL)
  specifically for vclbootstrapprotector to call.

* PythonTests don't (yet) call DeInitVCL; they still hook into
  BootstrapFixture's original test_init functionality (to call InitVCL), and do
  not make use of the vclbootstrapprotector.

Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
 2014-06-04 08:55:12 +02:00
Caolán McNamara
c979b886e2 define->endif 
Change-Id: I3b97d4473b1a1000a1de1fdc96525333948f73d5
 2014-05-29 15:01:39 +01:00
Jens Carl
49a0d8eedf fdo#68849: Add header guards to all include files 
Added header guards to files in directory extensions/*

Change-Id: If6a1642d726732fa05735c721f31b6fc7c405608
Reviewed-on: https://gerrit.libreoffice.org/9537
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-05-29 07:39:58 -05:00
Noel Grandin
ebc0a15515 remove more unnecesary OUString constructor use 
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
 2014-05-29 09:01:40 +02:00
Noel Grandin
f0ae48b684 remove unnecessary NULL parameter passed to UNO Exception 
.. now that we have a default value for that parameter

Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
 2014-05-29 09:01:40 +02:00
Noel Grandin
9af0abebfd remove unnecessary use of Reference constructor in throw 
Convert code like this:
  throw IOException("xx",
     Reference< XInterface >(static_cast<OWeakObject*>(this)) );
to this:
  throw IOException("xx",
     static_cast<OWeakObject*>(this) );

Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
 2014-05-27 08:20:11 +02:00
Peter Senna Tschudin
3b24dcc8a8 Remove unnecessary semicolons 
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p

@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
    cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>

Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-05-27 01:19:00 -05:00