5513 Commits

Author SHA1 Message Date
Caolán McNamara
e4d8872d07 coverity#704631 Dereference after null check
Change-Id: Id74b7073b6e9075003a98172e85696274a8c1924
2014-02-23 14:22:42 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Stephan Bergmann
9377e44cf8 -Werror,-Wunused-function
Change-Id: Ic792930c291bae1cf18ffd65548908e910c69c45
2014-02-21 23:47:23 +01:00
Stephan Bergmann
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
Noel Grandin
32ef676504 editeng: sal_Bool->bool
Change-Id: I1b215ef78bcade675a2f80def0d6d5afe0ff3d2c
2014-02-21 12:19:23 +02:00
Takeshi Abe
5f17e5eaad Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
2014-02-21 14:35:52 +09:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
Stephan Bergmann
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
Caolán McNamara
e9f924ece2 coverity#984087 Uninitialized scalar field
Change-Id: Ib88a068ea49955d48a0945b28b1016e0cccaf437
2014-02-18 15:18:07 +00:00
Caolán McNamara
11f9439a1c coverity#984089 Uninitialized scalar field
Change-Id: I299cfbe1f53af20f16dc02d3616d284a34da870d
2014-02-18 15:18:06 +00:00
Takeshi Abe
d548b250db Drop unnecessary #include
Change-Id: Ib9ab63cdf21f54b1611de37c5538a300a1b39ba6
2014-02-18 13:24:11 +09:00
Stephan Bergmann
05f742d28b comphelper: sal_Bool -> bool
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
Caolán McNamara
f03e95da68 convert biblio choose data source dialog to .ui
Change-Id: Ia94c417be95f5cd8c1d694a61c5004b0e8486416
2014-02-17 09:51:39 +00:00
Caolán McNamara
5adc8214e5 coverity#737107 Uncaught exception
Change-Id: Ia0906af52b217506e63138565cc0eb08842aaef1
2014-02-13 14:56:20 +00:00
Caolán McNamara
65e5ce2c31 coverity#737105 Uncaught exception
Change-Id: I44acb57da7539a63562d9723ee5d6f83f1dcbbb6
2014-02-13 14:56:20 +00:00
Noel Grandin
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
Michael Stahl
5c0e6d86a8 normalize values of SYSTEM_CAIRO
Change-Id: I7ba86a2606d585b7b4351bc1fcd6d8ceebca5fd7
2014-02-12 09:53:09 +01:00
Caolán McNamara
1f22e2f954 coverity#735424 Logically dead code
Change-Id: Ibd58c1660edca27141c27f7607f426f9df8d6b79
2014-02-11 20:21:49 +00:00
Stephan Bergmann
627cf7e91a Do not use this in ctor
Change-Id: If2177d309626ef599c7c15f6195151dc0d0a8e30
2014-02-10 15:58:39 +01:00
Stephan Bergmann
ed0101dfaa auto_ptr -> scoped_ptr
Change-Id: I16d457d2981b7b3f60c150d362b8b51f6a2700fd
2014-02-10 15:58:38 +01:00
Stephan Bergmann
10be54247d Remove unnecessary abstract base class IByNameAccess
Change-Id: I55e8ff25f4a56a1666d49185236ee5cd5c4ed392
2014-02-10 15:58:38 +01:00
Julien Nabet
5ead05c352 Typo: pasword -> password
Change-Id: I612bf6bb620a76f9fa3542145e942969b9365d98
2014-02-06 21:49:21 +01:00
Caolán McNamara
eb07ab05c3 coverity#707771 coverity gold, Uninitialized m_refCount
Change-Id: I98398a3cd7a86a5f31c711f7f1cff0d467a1d2e5
2014-02-06 15:11:59 +00:00
Caolán McNamara
92d0dabd50 coverity#707770 Uninitialized scalar field
Change-Id: Ie324197ac0069d8c534cee7a2bae524f9d7f2207
2014-02-06 15:11:56 +00:00
Caolán McNamara
57a989babf drop unused aURLST
Change-Id: Id009e6c372a5586be2eb84882d3feec8af78e30d
2014-02-02 00:36:20 +00:00
Julien Nabet
896899b843 cppcheck: redundant assignment
Change-Id: I62fbbe97c24deb45d8a79463e463a6783201ba98
2014-02-01 22:13:48 +01:00
Stephan Bergmann
9e77c2fb7c Remove UNOIDL "array" and "union" vaporware remnants
...and deprecate what cannot be removed for compatibility.

Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-31 10:15:47 +01:00
Caolán McNamara
5257cee53a reset Stati is presumably to reset state
Change-Id: Ib448d4e43178dedea6bdaebfc78d850b07aebe3e
2014-01-30 11:36:12 +00:00
Sven Wehner
2c932dcd77 fdo#39468 Translate German comments
Also remove ASCII art, and fix minor typos.
Note: I left the unknown word "Stati" as is.
This could be an incorrect plural for "status".

Change-Id: Ic19407c0ebb3aba3ebba4940b2511ba5b8dc825e
Reviewed-on: https://gerrit.libreoffice.org/7716
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30 11:35:38 +00:00
Stephan Bergmann
dfe30f1e3b Remove some redundant casts
Change-Id: I03317f55f5e08b131302190f34169054bacbeb28
2014-01-29 15:42:37 +01:00
Stephan Bergmann
612dac063a bool improvements
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-29 11:08:32 +01:00
Stephan Bergmann
a29cdd540c bool improvements
Change-Id: If3402725c9cbff5df45043bd2ecd22dd6241c052
2014-01-28 20:26:28 +01:00
Caolán McNamara
b78b5b1da5 coverity#705810 Dereference before null check
Change-Id: I2fab51f08c461faaf4b88b4b7c0b887ba877226c
2014-01-28 14:30:43 +00:00
Caolán McNamara
40a8fecb58 coverity#705811 Dereference before null check
Change-Id: I275739819715f1537e80d621b19a88a6fdbab95b
2014-01-28 14:30:42 +00:00
Stephan Bergmann
65191cda81 bool improvements
Change-Id: I757e19313576d2c3d13af1cb720f182f0de91613
2014-01-27 10:47:32 +01:00
Alexandre Vicenzi
8ef77fc61e fdo#54938 Convert extensions to cppu::supportsService
Change-Id: If3675c28a204168d7385b1421dbb70b2a9b719e2
Reviewed-on: https://gerrit.libreoffice.org/7648
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-01-26 11:33:27 +00:00
Stephan Bergmann
e3133ae237 Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).

Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-23 18:43:53 +01:00
Caolán McNamara
ebf5e613a5 SfxNoLayoutSingleTabDialog not needed anymore
all single tab dialogs are .ui enabled now.

So now we can remove SfxNoLayoutSingleTabDialog and merge SfxSingleTabDialog
and ~SfxNoLayoutSingleTabDialogBase together

Change-Id: If0acc792d85b7d399572257d7e9b0e12993ba3fe
2014-01-23 16:02:10 +00:00
Noel Grandin
16a2e90335 remove SvStream::operator<< methods
.. and convert the last few places still using those methods.

Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:47 +00:00
Stephan Bergmann
bbd9668d5f bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22 15:00:54 +01:00
Stephan Bergmann
a3f32769fc Fix bogus mass-conversion equalsAsciiL -> startsWith
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.

Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-21 15:54:52 +01:00
Caolán McNamara
fdf9406792 misuse of OUString::boolean on sal_uInt8 values
regression since 64b993e046f23baaacaff1572b7d2a816588b5ef

Change-Id: Ifc907a34430c36a64318fc42342e630e2b84ad13
2014-01-20 12:32:25 +00:00
Stephan Bergmann
602c87b425 Window::PreNotify should return bool
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
Stephan Bergmann
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
Stephan Bergmann
62951cdd17 Introduce com.sun.star.frame.theGlobalEventBroadcaster singleton
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance
service.

Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
2014-01-16 18:40:05 +01:00
Tor Lillqvist
62d8fea76e Fix indentation
Change-Id: I93309674ef50e8ca7438874378fb01484bb7f9f3
2014-01-14 14:51:56 +02:00
Tor Lillqvist
c0796dfe21 Avoid use of nonexistent variable evem in commented-out code
Change-Id: Icc9def55a814fc1309ce143a84effc140a90a92b
2014-01-14 14:51:56 +02:00
Tor Lillqvist
9e56955434 fdo#47689: Avoid crashing mdworker: Don't use uninitialized variable
It's the isCustom field that should be checked to see whether the
customAttribute field has been assigned or not.

Change-Id: I5d2af26b675ab0cbc0e1844eb98ebaf5145eb73d
2014-01-14 14:51:55 +02:00
Caolán McNamara
32e0518a98 GetCharPos returns EDIT_NOLIMIT on failure
Change-Id: Ie65526e66a71561aa64ed3517097d1274ffe7db4
2014-01-13 20:35:20 +00:00
Stephan Bergmann
302898d09c Remove odd code that does not make any sense
For one, NPPrint.mode must be either NP_FULL or NP_EMBED, so assigning TRUE is
odd.  And for another, the value of printInfo->mode is read again in the next
line, so assigning anything to it here looks like an error anyway.

Change-Id: Icd5a7ceabd07ed8b716e2fc90b214b7da5301451
2014-01-10 17:11:45 +01:00