5513 Commits

Author SHA1 Message Date
Noel Grandin
1d1825db86 fdo#46808, Convert awt::UnoControlDialog to new style
Change-Id: I9a5256c8dbacda60167403b4e26900588943a9b2
2013-05-28 08:10:22 +02:00
Stephan Bergmann
e36f83d81c Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654.  As discussed at
<http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re:
fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd
change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get
CreateUnoDialog() work again" appears to fix things again:

  The problem is that the implementation of the css.awt.UnoControlDialogModel
  involves UNO aggregation
  (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in
  toolkit/soruce/helper/registerservices.cxx creating a
  OGeometryControlModel<UnoControlDialogModel> instance that aggregates a
  UnoControlDialogModel instance).  That means that queryInterface can return a
  reference to something that is technically a different object, and that's
  what's happening here, and explains why calling setPropertyValue in two
  different ways on what logically appears to be a single object can end up
  calling two different implementations (of two different physical objects).
  (UNO aggregation is known to be broken and should not be used.  Nevertheless,
  there's still code that does---code that is a horrible mess and hard to clean
  up.)

  That all this worked as intended in the past is just sheer luck, but any
  way of substantially touching it is asking for trouble.  I'm going to
  revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again.

I wasn't able to revert without also reverting
be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert
awt::XUnoControlDialog to new style," as the two were tightly dependant.  Also
reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431
"-Werror,-Wuninitialized" (sans the const-ness fix in
UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452
"Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix
awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086
"scripting: get CreateUnoDialog() work again."

Conflicts:
	basctl/source/dlged/dlged.cxx
	filter/source/t602/t602filter.cxx
	xmlscript/test/imexp.cxx

Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
2013-05-25 11:45:47 +02:00
Ariel Constenla-Haile
1bfbe4963d Fix build breaker
(cherry picked from commit 4f7c31cdcf7ba9558e59bc345b3925f6b3d2695c)

Change-Id: Iccb1de40dc66d94128d4db2ca08b05b7e4c567f5
2013-05-23 15:19:12 +01:00
Ricardo Montania
b7df3446c3 AppendAscii cleanup
Change-Id: I7398272de0bd340ebfb5f31b314d32fcff007eec
Reviewed-on: https://gerrit.libreoffice.org/3974
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-22 21:03:56 +00:00
Noel Grandin
6a043e9c0a Use the new type-checking Reference constructor to reduce code noise
Also create a Clang compiler plugin to detect such cases.

Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-22 10:44:29 +00:00
Stephan Bergmann
cb4b6dde8f -Werror,-Wuninitialized
Bogus

  uno::Reference< awt::XControlModel > xControlModel = xControlModel;

introduced with 6c61b20a8d4a6dcac28801cde82a211fb7e30654 "fdo#46808, Convert
awt::UnoControlDialogModel to new style."  Correct fix involves adding missing
"const" in declaration of UpdateHandler::insertControlModel, so implicit
Reference up-cast works.

Change-Id: I8f6d679a38d99188eb893366e9b552974b3c1bf2
2013-05-21 16:29:31 +02:00
Noel Grandin
6bf00f0f94 fix for linking
caused by my commit
863d38fbfa4fb4861e476828c46410602100919e "move DBG_UNHANDLED_EXCEPTION out of line"

Change-Id: Idfd84d987ba9151ba476ce0516a9e5fbdb2003ec
2013-05-21 13:53:21 +02:00
Noel Grandin
be50ad28f5 fdo#46808, Convert awt::XUnoControlDialog to new style
Change-Id: I40d2e2ddd92186a2ba22ebfbdda8367391e8d355
2013-05-21 08:23:59 +02:00
Noel Grandin
6c61b20a8d fdo#46808, Convert awt::UnoControlDialogModel to new style
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-21 08:23:58 +02:00
Tor Lillqvist
026001cd5a Avoid linker warning LNK4222
These symbols should not be assigned an ordinal as they are always
located by name, using GetProcAddress(), says MSDN.

Change-Id: I46caf7da634b1379a5baf5de631571335c6134ca
2013-05-20 12:45:11 +03:00
Tor Lillqvist
07976ee1de Don't export a variable called PATH_SEPARATOR
It used to be mis-spelled PATH_SEPERATOR. Now, after correcting the spelling,
it breaks the build of 3rd-party libraries using autoconfigury on Windows. The
value of PATH_SEPARATOR is ";" on Windows, and the configure scripts of those
libs run in Cygwin and assume that a PATH_SEPARATOR environment variable
should be correct for Cygwin. Which ";" isn't.

Rename the variable to LIBO_PATH_SEPARATOR.

Change-Id: Iff0eb93bf11d9f844a28be7ea4456e4c0ae10844
2013-05-15 14:23:39 +03:00
Tor Lillqvist
cb6d67c21f Spelling "separate" (etc) correctly is hard 2013-05-15 11:14:28 +03:00
Ariel Constenla-Haile
b9d460f18b Related: #i120413# document helpful precalculated CheckInterval vals
(cherry picked from commit 1045898eb4be2f19d8435e86ff600f4d9541abf9)

Conflicts:
	extensions/source/update/check/Jobs.xcu

Change-Id: Iddf1ba34bd6a48ae64c3b7b104d2e942f39df244
2013-05-11 21:11:35 +01:00
Michael Stahl
09373d4583 soltools: remove Package_inc and empty unistd.h nonsense
Change-Id: Ic05de69951b28b9cc8d62f0a534b507c424e6b25
2013-05-10 17:56:24 +02:00
Andras Timar
e1a5110bd9 support MS Office and Flat ODF file types in Mozilla Plug-in
Change-Id: I9bb3b67551dc14fd74e02defa0404e1f83359f2b
2013-05-08 22:07:33 +02:00
Julien Nabet
9d85fe82bc coverity#982973: Resource leak
Change-Id: I1ea51b29c3ad05016f42c215b71877cd8c3f92f4
Reviewed-on: https://gerrit.libreoffice.org/3821
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-05-08 08:47:57 +00:00
Stephan Bergmann
7ef1aa6876 -Werror=unused-macros
Change-Id: I9fd616930eb0b336ce89e97bc333f19d4cf449ae
2013-05-07 11:53:56 +02:00
Michael Stahl
96907bfb02 np_sdk: remove both Package_inc and Package_npapi
This is a bit of a mess, apparently there are some headers here that may
come from the system and others that are always internal?

Change-Id: Ifbf486d3016bc87849e2593d83b3d48dae3aeca0
2013-05-07 01:41:25 +02:00
Michael Stahl
674e791119 twain: remove Package_inc
Change-Id: I67d0801d8d353951f9c9b1ca7f08b23de9b34067
2013-05-07 01:41:24 +02:00
Philipp Riemer
2ce25faffd fix typos (wich instead of which) 2013-05-06 20:07:23 +02:00
Luboš Luňák
e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
Andras Timar
376f85f04d build fix s/$(BUILD)/$(LIBO_VERSION_PATCH)/
Change-Id: I4573f77418b3631a2f324aac29e225698da53ba6
2013-05-02 12:01:28 -07:00
Andras Timar
e8177f9900 remove unsupported binfilter types from npsoplugin
Change-Id: Ifd12d4d1f4dab0a6bea4701d0a1b9ab4f3763ce7
2013-05-02 19:04:59 +02:00
Andras Timar
248eea0629 remove defines from npsoplugin resource, that are defined elsewhere
Change-Id: I745944202a25a348f36e79d28f03740a28b70eee
2013-05-02 19:02:36 +02:00
Andras Timar
3b356ea977 remove unsupported binfilter types from npsoplugin
Change-Id: Ifb23e61b265697272e54df225719e006319e79af
2013-05-02 19:00:35 +02:00
Andras Timar
ae3f7b70a8 fdo#54087 link the correct resource file to npsoplugin.dll
I had to add a new function to gbuild system: set_nativeres,
because the trick in extensions/Library_npsoplugin.mk did not work.
It linked the default.res, and that made the plugin unusable under
Windows. Also, one export was missing compared to LibreOffice 3.5.

Conflicts:

	extensions/Library_npsoplugin.mk
	extensions/WinResTarget_npsoplugin.mk

Change-Id: Ib91fa2a3b72b15912587f22becccb0aebc2aa390
2013-05-02 18:58:36 +02:00
David Tardon
8e31b90052 install SpotlightImporter bundle using filelists
Change-Id: I01ea506b76356ce62688350d096ff77c2cddcbdf
2013-04-30 17:49:07 +02:00
Michael Meeks
72e5d0c8fb Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-30 13:34:06 +01:00
Stephan Bergmann
1c2862e8d1 Remove residue of undocumented "edition" feature
...whereby some branding could be orverridden with information from a program/edition/
directory.

Change-Id: I7f9324678b09bc8069775dfcbda97be8e0618a91
2013-04-29 10:27:29 +02:00
Luboš Luňák
dabe10eb94 workaround race condition with mixing internal/system cairo libs
http://lists.freedesktop.org/archives/libreoffice/2013-April/051026.html

Change-Id: I81031d8290efcc4f343af7bdffb4762411f4f107
2013-04-25 15:35:38 +02:00
Noel Grandin
73adc9b6e2 fdo#46808, Convert form::ControlFontDialog to new style
Change-Id: I83487cddbd6b3fce1fdcdfa48623b63a0e026d90
2013-04-25 08:56:38 +02:00
Michael Stahl
7dc8c952be extensions: rename WinResTarget target to match source file
Change-Id: I8e528f76d08f7a0d7acec05dcf306cd78b95a885
2013-04-24 17:37:45 +02:00
Noel Grandin
0c37eeebb0 Java cleanup, use generic containers where possible
Change-Id: Icd830004de3e121f5b96393e7d7b447775833419
Reviewed-on: https://gerrit.libreoffice.org/3569
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-24 08:57:57 +00:00
David Tardon
1cc9bbfd57 gbuild: drop empty use_packages calls
Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f
Reviewed-on: https://gerrit.libreoffice.org/3503
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24 05:18:15 +00:00
David Tardon
c042cd05e9 gbuild: drop uses of removed packages
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac
Reviewed-on: https://gerrit.libreoffice.org/3502
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24 05:18:03 +00:00
David Tardon
6c7659b584 move URE headers to include/
Change-Id: Ib48a12e902f2311c295b2007f08f44dee28f431d
Reviewed-on: https://gerrit.libreoffice.org/3499
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24 05:17:10 +00:00
Lionel Elie Mamane
d645a6a17c Data-aware ListBox: can have a BoundColumn even without bound database column
It defines what goes into the ValueList property, what getCurrentValue() returns, and what an external value binding gets.

Change-Id: I9242d3a6040ec98c22b1d4350942dfa0e7aa6c5b
2013-04-22 17:54:39 +02:00
Michael Meeks
62badf3828 Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-22 09:37:38 +01:00
Stephan Bergmann
e8ff469da5 Remove any remaining remnants of unused component_canUnload feature
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
2013-04-19 16:52:03 +02:00
Matúš Kukan
eeaa2ecd1e remove unused component_canUnload functions
Change-Id: Id3f41e2a620c47bb848718d0fc994739be2d64fc
2013-04-19 16:52:03 +02:00
Noel Grandin
d62425cc27 Java cleanup, remove unnecessary casts
Change-Id: Id12089bc7df16631737e6acaee0973fb91dd953f
Reviewed-on: https://gerrit.libreoffice.org/3431
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-19 07:51:41 +00:00
Lionel Elie Mamane
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
Stephan Bergmann
8e08a41620 -Werror=int-to-pointer-cast (MinGW, extensions)
Change-Id: I16db60c861ef7ac0a2a9076fde1996a7b7b0e991
2013-04-17 11:51:15 +02:00
Stephan Bergmann
438f5b9f90 -Werror=unused-variable (MinGW, extensions)
Change-Id: I43c2ad4a601ffe20f471d81ed7697b89c496fa6f
2013-04-17 11:51:15 +02:00
Stephan Bergmann
fbba4781b7 -Werror=write-strings (MinGW, extensions)
Change-Id: I0761af5d2a6af23dbef67e4aadf4e6d21df1e58f
2013-04-17 11:51:14 +02:00
Stephan Bergmann
1eda84de6a -Werror=unused-macros (MinGW, extensions)
Change-Id: I208b5f1a8f3faabd03961bd58e2f09bb8338c790
2013-04-17 11:51:14 +02:00
Stephan Bergmann
463ca2cb29 -Werror=shadow (MinGW, extensions)
...and aStr, aStr2 are not necessary, anyway.

Change-Id: I04fbd1fb3c7375015168e866e8b77eebfb62f648
2013-04-17 11:51:13 +02:00
Stephan Bergmann
a394a6f912 -Werror=unknown-pragmas (MinGW, extensions)
Change-Id: I3eeb8864ddf931361f6504c04b8bfa787115cfd1
2013-04-17 11:51:13 +02:00
Stephan Bergmann
be9e5c5ade -Werror=unused-variable (MinGW, extensions)
Change-Id: I88113be8ff3f4dfe641463267754ee8129bc767a
2013-04-17 11:51:11 +02:00
Stephan Bergmann
10daf844f5 -Werror=unused-macros (MinGW, _WINDOWS)
...hopefully unused anyway?  In there "since the beginning."

Change-Id: Ibe61ad133dc8a546a2c70626faa5f8d2ca951150
2013-04-17 11:51:11 +02:00