361 Commits

Author SHA1 Message Date
Caolán McNamara
0e09134a4a callcatcher: update unused code
Change-Id: Ia25c686dac799707cae3f6112c731f8cd3f686c2
2014-06-19 10:26:48 +01:00
Caolán McNamara
8309bf5886 remove helpids that are unused or go nowhere
Change-Id: I5af0b84ff4a85e72f5068d450a04d01df0592d3b
2014-06-17 21:13:15 +01:00
Caolán McNamara
73e4a5d091 give refedit in formula wizard an initial size
Change-Id: I8e19c29c47dea2f7cff754e81ef51fc9898fdee8
2014-06-17 21:03:46 +01:00
Caolán McNamara
c842486ab0 restore these for the moment, still in use in sc
Change-Id: I6967a3c871338d1801d913d9bb54eba50a7660ca
2014-06-17 20:49:14 +01:00
Caolán McNamara
b15230153c I could fight with ValWnd to fix it, or I could replace it
it's not handling resizing and redrawing well, so just drop
it in favour of a read-only edit

Change-Id: I5e6f85cf9326b908bf1bf835d8da0c49ca9209c9
2014-06-17 20:42:35 +01:00
Szymon Kłos
0cf14968aa RID_FORMULADLG_FORMULA conversion to .ui
Change-Id: I098c9ee9d22ac0401faf7fc6d65e91bf5b4b2bf8
Reviewed-on: https://gerrit.libreoffice.org/9797
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-17 19:42:15 +00:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Eike Rathke
c9d037e5e8 resolved fdo#79957 propagate ForceArray through jump tokens
ForceArray parameters weren't propagated and enforced to array arguments
on svJump tokens (FormulaJumpToken), namely IF, CHOOSE, IFERROR and
IFNA.

Change-Id: Icf9074f11b826655a52858d778d9a0122d207aa4
2014-06-13 14:21:34 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
Markus Mohrhard
e44e09c400 whitespace clean-up
Change-Id: I10bdfc3356bda66fefa59fa2c9f63f9231d8728e
2014-05-23 02:50:43 +02:00
Noel Grandin
f824604b5c fix spelling
Change-Id: I1a4d66a78549ea49649a6bed92acb44dbd8b13e2
2014-05-21 13:14:11 +02:00
Eike Rathke
636581bf87 most certainly == was meant
Change-Id: I1b0833daa576cd8603421e1036b8773badc8c775
2014-05-21 12:45:24 +02:00
Michael Meeks
c07b8dedf7 ODS load perf: transfer ownership of the ScTokenArray to save cycles.
Add API to wnsure we don't end up allocating 32k bytes of tokens
for each ScFormulaToken, as happens when you Add a token to a new
empty ScTokenArray.

Change-Id: Ib12a3065eb513243a2146ebb009fbaa650385dd9
2014-05-21 10:03:36 +01:00
Thomas Arnhold
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
Markus Mohrhard
dd0f844728 add COLOR function
This function makes property mapping in charts more user friendly.

Change-Id: I01cfb31edd749ee474d5078042fa5c4b4a270f86
2014-05-19 08:13:37 +02:00
Kohei Yoshida
b6b0b95bae Bail out of group calculation in case the array fetching fails.
Change-Id: Ibb7575eeb025fc025d05b147629113796185c5d3
2014-05-14 16:25:38 -04:00
Kohei Yoshida
a921d38ad4 No more SetCompileForFAP(). Use respective flag setting methods instead.
Change-Id: Ib2256ebac8a7e63e7e24fb35d13d47b811bd8e19
2014-05-14 13:15:11 -04:00
Kohei Yoshida
69a7e7440c Use "stop on error" concept rather than "ignore error if true".
Just to keep the pattern of "true" -> "action", "false" -> "no action".

Change-Id: I6303bc779cd7048eef2fdc3c2abba8be8f15da6d
2014-05-14 13:15:11 -04:00
Kohei Yoshida
5db9391c06 Introduce a new boolean flag and use it in lieu of bCompileForFAP.
To make it sound more general than "compile for FAP".

Change-Id: Ia6916b6f3579a290be7d5074f809666be2bd2473
2014-05-14 13:15:10 -04:00
Caolán McNamara
ee636db4dd coverity#1169835 Improper use of negative value
Change-Id: I1857f5c712f9407c8a4b69f30044e8bb444afad2
2014-05-11 21:05:54 +01:00
Caolán McNamara
90c644a862 coverity#707866 Uninitialized pointer field
Change-Id: Ia80922b1819d41e4963689fda87750f0f507fd57
2014-05-10 21:13:04 +01:00
Kohei Yoshida
50d100f4ac Make a separate method to detemine if an opcode is a jump command.
Jump to make it a bit more pleasant to follow the code...

Change-Id: Ie9bef122e8bb63a2d8cc54acc9c8ddc9ac9a2e8a
2014-05-01 15:29:24 -04:00
Winfried Donkers
29c9712b04 fdo#73148 (partial patch) Add Excel 2010 function AGGREGATE
Change-Id: If8fc8608699a14e573456af2e1180342be942dd1
Reviewed-on: https://gerrit.libreoffice.org/8475
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-25 09:39:31 +00:00
Noel Grandin
32efd885e5 formula: sal_Bool->bool
Change-Id: I3280b4d4b02e6a6fa22bc250e56a3c6ae77fc675
2014-04-23 11:10:08 +02:00
Thomas Arnhold
0882cc6675 fixincludeguards.sh: formula 2014-04-19 11:10:06 +02:00
Takeshi Abe
eb4c43aa61 Avoid possible memory leaks in case of exceptions
Change-Id: Ie07c6c9989da444eb6052691696e95b808c23fb0
2014-04-15 16:12:31 +09:00
Kohei Yoshida
625c595fc3 fdo#76294: Intern strings in AddFormulaToken() as well.
And a whole bunch of changes needed to make that happen.

Change-Id: Idd98fbc99322c0d72fb0a7848d89cb1a6abc88b6
2014-04-14 18:34:20 -04:00
Kohei Yoshida
b09426b83c fdo#76294: Properly intern string literals in formula on xls import.
Change-Id: Ib3a442cbb68c23294762561f2911101a087a795e
2014-04-14 17:00:40 -04:00
Stephan Bergmann
712d2793ec Remove unused code
Change-Id: I1355317d6baeb180417cb5f1f34038925c1299cf
2014-04-14 12:49:20 +02:00
Winfried Donkers
56deaabb32 fdo#73149 add Excel 2010 functions ERF.PRECISE and ERFC.PRECISE
Change-Id: I3199470ec92923e8cc12156f21dd397d870cc1e0
Reviewed-on: https://gerrit.libreoffice.org/8930
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-11 13:43:14 +00:00
Tor Lillqvist
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
Kohei Yoshida
355baf5734 fdo#75741: Re-implement CompileNameFormula for formula groups.
Change-Id: I57e1e464ac5f7abc10ce5ea5752e036ddb6cf6d7
2014-04-07 14:43:16 -04:00
Winfried Donkers
f07bdba6c5 fdo#71720 fix transalate strings
Change-Id: I8758e2407f1d3d1e09324b4fe5cc0442f8dda34d
Reviewed-on: https://gerrit.libreoffice.org/8819
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-02 18:43:14 +00:00
Winfried Donkers
22dac22fe2 fdo#73147 add Excel2010 functions NETWORKDAYS.INTL and WORKDAY.INTL
Change-Id: I3ab9dde5c421a3a3e6022a27be37f23547197317
Reviewed-on: https://gerrit.libreoffice.org/8772
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-04-02 14:01:28 +00:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
Stephan Bergmann
4b060ce51a Remove remaining DBG_CTOR etc. remnants from formula
Change-Id: I36740cd276d2047552298606f24b2696ed61b36b
2014-03-28 15:34:01 +01:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
Noel Grandin
436cd90095 svtools: sal_Bool->bool
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25 14:32:56 +02:00
Caolán McNamara
8a0d8f4c0b coverity#738657 Uninitialized pointer field
Change-Id: I37c946d37a7f3add6b6798b15f5fb6ab4b7274ff
2014-03-22 20:18:46 +00:00
Eike Rathke
d4cc603a5f ISO.CEILING without _xlfn. prefix, it is defined in OOXML, fdo#71720 follow-up
Change-Id: I486261d34d62bc5eda0a202cbb1dcb875ffcf39b
2014-03-10 16:14:50 +01:00
Winfried Donkers
ed77823837 fdo#71720 Add Excel 2010 functions
CEILING.PRECISE, ISO.CEILING, FLOOR.PRECISE

Change-Id: I047b65ca3adafb89fce9b6493948aa851ddca765
Reviewed-on: https://gerrit.libreoffice.org/8488
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-10 08:14:14 -05:00
Kohei Yoshida
0ca7ab6ea0 Make these non inline.
Change-Id: Ib139850380b039382565e3de3666eebb5750f32d
2014-03-06 20:50:02 -05:00
Eike Rathke
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
Winfried Donkers
e4def6edaa fdo#72197 Add Excel 2010 functions
MODE.SNGL, MODE.MULT, NEGBINOM.DIST, Z.TEST

Change-Id: I55eb05e1ebdb9dbc3ce9ae84e3cdacfdfa112091
Reviewed-on: https://gerrit.libreoffice.org/7776
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 05:53:24 -06:00
Noel Grandin
cf5ac4dd3c remove unused code formula::FormulaDlg::CheckMatrix()
Change-Id: If7b09d032d0155a38b5d5e8aa1832c86a8f7cec1
2014-03-05 09:17:42 +02:00
Noel Grandin
41f5dda746 remove unused code in formula/FormulaTokenArray
formula::FormulaTokenArray::AddString(unsigned short const*)

Change-Id: I6c014f6ada3b75398112e81f9c8e7de7dd776c7d
2014-03-05 09:17:42 +02:00
Noel Grandin
d7f1f91b19 remove unused code in formula/vectortoken
Remove these methods:.
formula::DoubleVectorRefToken::GetRequestedArrayLength()
formula::SingleVectorRefToken::GetRequestedArrayLength()
formula::SingleVectorRefToken::SingleVectorRefToken(
    double const*, unsigned long, unsigned long)

and optimise some accessor methods.

Change-Id: I04f53593894a59dbefdd1cbc9505c6eb7cd8610b
2014-03-05 09:17:42 +02:00
Kohei Yoshida
6ef6dd0122 Store the length of originally requested array size prior to trimming.
This change adds GetRequestedArrayLength() method to both single and double
vector ref tokens, which returns the length of the requested array size prior
to trimming of the trailing empty cell region.

Change-Id: Iaba96fa2ea4ff3c8bccb0bc86fa4f1525e2f45fb
2014-02-27 21:19:36 -05:00
Alexander Wilms
224f6c17f7 Remove visual noise from formula
Change-Id: Ie7503623ad9bec1806345f65b435c7bd94a08c2b
Reviewed-on: https://gerrit.libreoffice.org/8263
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 14:50:17 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00