361 Commits

Author SHA1 Message Date
Luboš Luňák
e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
Kohei Yoshida
e38d20c1e1 Handle range references for group calculation. This is still untested.
Change-Id: I1eb1c217db66615028faa85720838579056dc150
2013-04-30 13:10:44 -04:00
Kohei Yoshida
dfc3f290b5 Let's not use VectorArray struct. There is no use for it.
Change-Id: Ic011143206c13fcbc1b3403bf5b7df46c6934899
2013-04-30 13:10:43 -04:00
Kohei Yoshida
ee289aaf45 Let's not forget to check this in...
Curse the sc / formula split...

Change-Id: Ib8d17ba63d05eb4df7e6918e0034d91dd82869e3
2013-04-30 13:10:42 -04:00
Kohei Yoshida
20d4db0fe3 Add method to allow fetching of double array, and store it in token.
Change-Id: If094dbf139e18ad23c73d6cf5a78ac4844132b14
2013-04-30 13:10:41 -04:00
Kohei Yoshida
7fb73a8475 Initial cut on vector formula ref tokens. Not used yet.
Change-Id: I4b28c269759bc01bfc94cfdd6a1c651d03d829c7
2013-04-30 13:10:41 -04:00
Caolán McNamara
02179ab7e7 stash the label widget for shrink mode in the edit, not the button
because we always have we a refedit, but sometimes not a refbutton, so set the
label widget to use for the dialog shrink mode on the refedit instead of the
refbutton. This way we get the shrunken dialog title bar updated with the label
contents regardless of using the shrink button or clicking in the editbox and
dragging the mouse around the spreadsheet triggering the shrink mode

Change-Id: Ifdff01a30d5c65aa964d4bf544017a2927757d67
2013-04-17 10:25:10 +01:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Eike Rathke
5be14df244 ResMgr with LanguageTag
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-29 14:09:01 +01:00
Stephan Bergmann
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
Kohei Yoshida
292ffa80bc First cut on checking the token array on whether we could do vectorization.
Not tested yet.

Change-Id: I87f8a8595229d8d8e83526dc0334891d253cf2c7
2013-03-19 13:40:24 -04:00
Kohei Yoshida
3a09e0078a Use initializer in ctor.
Change-Id: I2721c083e26654f5ce5cc636d652cb4d50a158ad
2013-03-19 13:40:24 -04:00
Kohei Yoshida
0a0deec6f1 Fix indentation.
Change-Id: Ia277ac4e9eeb34a2b0244ebb5f09c428f5cf2b64
2013-03-19 13:40:24 -04:00
Kohei Yoshida
198a722974 Move GetHash() from FormulaTokenArray to ScTokenArray.
To allow access to reference tokens.

Change-Id: I3e2d2653722005c04b6d26e1a4ddfce0a459ef37
2013-03-19 13:40:23 -04:00
Kohei Yoshida
6433ab29af Implement (partially?) and test formula token array hash function.
For now, we don't factor in any differences in reference tokens in the
generated hash values.

Change-Id: Ie9836228eaad9c74edd884c3e8c4b273979760fd
2013-03-19 13:40:22 -04:00
Kohei Yoshida
fa81354d0e Skeleton for generating a hash value from an array of token.
To be implemented...

Change-Id: I4704f06b50dcc9dd5e1af9c3531ecd498015811c
2013-03-19 13:40:21 -04:00
Thomas Arnhold
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
Borim
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
Caolán McNamara
213524cf5a make link RefButton and widget for shrunk dialog title explicit
Change-Id: Ia6dd6cc4cf89b067310639bc3da72abbc6fa1ad2
2013-03-08 13:42:32 +00:00
Caolán McNamara
4e0c6a0ac7 Resolves: fdo#58630 crash with refEdit button in SfxTabDialog
Change-Id: I11d6a0f1d4852aab1fe08671fd9c2a0dac0825a7
2013-03-08 13:42:32 +00:00
nccuong
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
Caolán McNamara
a9b33fc304 make formula refButton and refEdit loadable from .ui
Change-Id: I2ad13cd8de2c0f8f5672a30c3c1117708368b05f
2013-03-05 14:28:41 +00:00
Caolán McNamara
edef1887ff make RefButton quick help toggle saying shrink/expand
Change-Id: Id5b5518a0cb3982ebc398e57499c5c240ee7d683
2013-03-05 12:35:29 +00:00
Markus Mohrhard
a11f944b4c ocMacro and ocExternal need to be recalculated on load, fdo#60977
Change-Id: I9e69ca2feae44bc645e8a49e349557f0933a23eb
2013-02-25 08:16:31 +01:00
Thomas Arnhold
89003e9bd8 loplugin: unused variables
Change-Id: I63553a09eec81e5ae28aa79ee1d3281053b23d06
2013-02-25 03:14:01 +01:00
Thomas Arnhold
d5caf6898b loplugin: unused variables
Change-Id: I7fc203900256839e679bf73b717d121fedc42087
2013-02-24 17:44:31 +01:00
Eike Rathke
61c72ef4be ocColumn and ocRow do not need recalc on load, fdo#60645 related
Change-Id: I34fc7af10aca3484d30b443c6b0257451a218ed5
2013-02-15 14:16:14 +01:00
Eike Rathke
a60712be0e renamed SetRecalcMode...() to SetExclusiveRecalcMode...()
To emphasize exclusiveness of the four basic recalc modes renamed the
corresponding methods.

Change-Id: If6f99d2c84e4a042a3a3e3640cf416d306a2d0c5
2013-02-15 13:57:27 +01:00
Eike Rathke
ff319d0526 use AddRecalcMode(RECALCMODE_ONLOAD), fdo#60645 related
Instead of SetRecalcModeOnLoad() which sets the exclusive bit overriding
RECALCMODE_ALWAYS use AddRecalcMode() that handles these cases.

Change-Id: Ieeeff67d4dda1493e8c48f231b870513f655839a
2013-02-15 13:57:27 +01:00
Markus Mohrhard
9c55eab030 CELL needs to be recalculated during import as well, fdo#60645
Change-Id: If981199f01d4b33270d82c65fb033fa51222fb62
2013-02-14 21:50:27 +01:00
Winfried Donkers
df931a5b0f fdo#60322 add calc function SKEWP as in ODFF v1.2
Change-Id: I4851df1473fc7788af1ac642bb0fb527ec872821
Reviewed-on: https://gerrit.libreoffice.org/2020
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-02-08 09:50:20 +00:00
Markus Mohrhard
63e3d8671e make it possible to update DDE links after loading, fdo#59032
Change-Id: Iba49bec62cb9081cdcd9410215f269b59c1be304
2013-01-30 22:10:05 +01:00
Eike Rathke
8f9cb3dddd ODFF: write RRI as RRI, not ZGZ
ODF OpenFormula defines the function RRI, the legacy OOo XML format
stored that as ZGZ but that was not changed for the ODFF implementation.
Correctly read/write RRI now but still accept ZGZ to be able to load
existing documents.

See also
http://docs.oasis-open.org/office/v1.2/cs01/OpenDocument-v1.2-cs01-part2.html#RRI

Change-Id: I617eaa37ff483e9a02a218e8432ba918f54bd61a
2013-01-30 01:49:31 +01:00
Caolán McNamara
08706f3773 restore the helpid for impress animation dialog after initialization
Document and centralize the uses of undoing the helpid clear after
helpid->uniqueid hack

Change-Id: I4e651235407a0eca26dc0acfc089ef8f8ce57b13
2013-01-24 16:10:30 +00:00
Jean-Noël Rouvignac
e13a3d566e fdo#38838 Some removal/replacement of the String/UniString with OUString
Also used the new OUString::number(...) methods.

Change-Id: I3174c43d56d1ae359901bb8a13fe0096f2c74808
Reviewed-on: https://gerrit.libreoffice.org/1766
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-22 14:25:15 +00:00
Chr. Rossmanith
e3f11c10d8 Changed SetText() / GetText() to take/return OUString
replaced lots of Len() with isEmpty()

Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0
Reviewed-on: https://gerrit.libreoffice.org/1795
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-21 20:48:35 +00:00
Eike Rathke
0dce7abb56 fdo#56124 IFERROR IFNA Excel import/export
Change-Id: I796e99f8893cb48fa2351f7799bb247a3488ce69
2013-01-12 17:31:29 +01:00
Eike Rathke
3201c72db7 fdo#56124 IFERROR IFNA function names were swapped
Change-Id: I3d13ab04b126a3268352df93a7ed4a35d7a085f2
2013-01-11 21:49:07 +01:00
Eike Rathke
3914d00c32 fdo#56124 changes to "add functions IFERROR and IFNA"
* reimplemented actual ScIfError() function for matrix cases and simpler
  pop/push of non-error values
* various smaller adaptions, see also inline comments of
  https://gerrit.libreoffice.org/1522

Change-Id: I80a8235a2cbb548c0ef993862e76741af46e30d2
2013-01-11 17:01:44 +01:00
Winfried Donkers
5fd9feafa5 fdo#56124 add functions IFERROR and IFNA to calc as in ODFF1.2
Change-Id: I6403b51ac8c710ad3b8d2625e1482971f50e6b1d
2013-01-11 17:01:23 +01:00
Kohei Yoshida
b6fbc86429 fdo#58539: Correctly set cached matrix formula result.
During the import, a cached matrix value only has an empty matrix
of correct geometry, plus the token type of the top-left cell.  The
rest of the elements are imported as hybrid values.  For now, this
seems to do the trick.

In the future we may want to change it to fully populate the matrix
cache value during the import, and skip setting the hybrid values for
the non-top-left elements.

This commit also make several other trivial changes:

* Mark pRawToken mutable so that we can mark those IsFoo() methods
  const.

* Move the ScCompiler instance from static instance to member of
  ScXMLImport. Since we don't need the instance to persist once the
  import is over, this is more appropriate.

Change-Id: I1abde03c0fcd91b02ef4dbf8b5526f7965eaf19c
2013-01-09 11:29:50 -05:00
Julien Nabet
c0997ff4c8 Some cppcheck cleaning in formula
Change-Id: I410ab7bbd74b616fcb0a3ed3b0c917cebeac23c6
2012-12-22 00:02:30 +01:00
Eike Rathke
2a8470dca4 tabs to spaces
Change-Id: Id832383518af0dd77e401e40512a890265b5d83e
2012-12-15 21:42:41 +01:00
Marina Plakalovic
07df025a73 calcishmakkica: #i114428# merge some XOR related code
Merged from Apache OO with adaptions, parts of
http://svn.apache.org/viewvc?rev=1381446&view=rev
Original Apache OO committer: Andrew Rist <arist@apache.org>

Original Author: Marina Plakalovic <makkica@openoffice.org>
Original Committer: Eike Rathke [er] <eike.rathke@oracle.com>

 # HG changeset patch
 # User Eike Rathke [er] <eike.rathke@oracle.com>
 # Date 1284060031 -7200
 # Node ID 528da6bfd0daed4355d745590d5ac3a319b08fb4
 # Parent  237cb91dd986ff11eb100cc631206cda102e91f7

Change-Id: If456792f23429a80582a48b022d268e6179316a1
2012-12-15 21:42:40 +01:00
Marina Plakalovic
f2cb873631 calcishmakkica: #i90269# #i95144# #i101466# implement SUMIFS, AVERAGEIFS, COUNTIFS
Merged from Apache OO with adaptions.
http://svn.apache.org/viewvc?rev=1381447&view=rev
Original Apache OO committer: Andrew Rist <arist@apache.org>

Original Author: Marina Plakalovic <makkica@openoffice.org>
Original Committer: Eike Rathke [er] <eike.rathke@oracle.com>

 # HG changeset patch
 # User Eike Rathke [er] <eike.rathke@oracle.com>
 # Date 1288810126 -3600
 # Node ID 02cf226fcde498f6fd926d45df497e9fb412fe0f
 # Parent  528da6bfd0daed4355d745590d5ac3a319b08fb4

Change-Id: I08754653cd2ff20536ad3e9f260f747cb127ccdd
2012-12-15 21:42:39 +01:00
Marina Plakalovic
fff5031898 calcishmakkica: #i101466# implement AVERAGEIF
Merged from Apache OO with adaptions.
http://svn.apache.org/viewvc?rev=1381445&view=rev
Original Apache OO committer: Andrew Rist <arist@apache.org>

Original Author: Marina Plakalovic <makkica@openoffice.org>
Original Author: Eike Rathke [er] <eike.rathke@oracle.com>
Original Committer: Eike Rathke [er] <eike.rathke@oracle.com>

slightly reworked patch by <makkica>

 # HG changeset patch
 # User Eike Rathke [er] <eike.rathke@oracle.com>
 # Date 1284055400 -7200
 # Node ID 237cb91dd986ff11eb100cc631206cda102e91f7
 # Parent  1c32319bb02fdf173de6a609fca9f2e9c9f4c73a

Change-Id: Id168462272dc8d618513319ebab41fde5c728b08
2012-12-15 21:42:39 +01:00
Kohei Yoshida
a67906259a fdo#58149: Recalculate HYPERLINK formula cells on load.
The current implementation of HYPERLINK relies on its result being
1x2 matrix while only the first element is displayed visibly.  The
second element stores the URL which is only used when querying for
the URL (tooltip or launch URL event).

Starting with 4.0 we load cached formula results to avoid full
recalculation on load.  That unfortuntely ended up breaking the
HYPERLINK because the result was a simple string value rather than
a matrix; hence the need to recalculate it on load.

But unlike volatile formula cells, cells with HYPERLINK don't need
to be recalculated on every cell input change; only once when the file
is loaded.

P.S. This commit also reverses the logic of bNoProgressBar flag for
CalcFormulaTree(), to make it easier for human brain to process what
it means.

Change-Id: I7a24d96d225910b88071a8fe6320f59bf7a47163
2012-12-11 15:55:58 -05:00
Eike Rathke
9955dbebbd AllSettings with LanguageTag
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22 12:34:59 +01:00
Kohei Yoshida
43cd14d317 Fix the Windows build breakage by reorganizing svtools headers.
Also removed a fair amount of implicit inline methods to promote use
of more forward declaration.

Change-Id: I5ad21f0d7abc85281708b7e87f1036b02a053627
2012-11-16 16:18:37 -05:00
Marcos Paulo de Souza
4e0b79b546 Remove unused method in formula module
Change-Id: I67259c5a3894be406b2d38900368a3f8aac86921
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2012-11-01 14:22:03 +00:00