5719 Commits

Author SHA1 Message Date
Stephan Bergmann
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
Julien Nabet
b232607e45 Typo: easiear->easier
Change-Id: I4e10f74e46ef79c3a56dcfb3d1e1bb90d8b5aecf
2014-06-29 00:11:19 +02:00
Caolán McNamara
5b621a30cc clang: Dead assignment
Change-Id: Ifcbfe29f116d43cc4e65641e24a302e4cdd71129
2014-06-26 16:29:15 +01:00
Noel Grandin
533c6cb6ba fixes for up-casting to Reference<XInterface>
Fix regressions introduced with
6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking
Reference constructor to reduce code noise"

Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-25 17:10:43 +02:00
Caolán McNamara
1dac3254d5 allow a frame to go from init state to close
without an intermediate working stage so it can be disposed after creation, but
without a prior initialization like CppunitTest_services does

Change-Id: If2679fd0ce3657e727e34cfb0752501fc82df936
2014-06-24 16:05:50 +01:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Stephan Bergmann
06b51293f6 loplugin:staticcall
Change-Id: I6301c6d01b62540d0a765b78323a46ee3a4965c8
2014-06-13 17:54:28 +02:00
Stephan Bergmann
da8bfce257 Fix memory leak
Change-Id: Ib0a2d8d69f5bd43872c949d79c685f71657dc9db
2014-06-13 17:42:58 +02:00
Stephan Bergmann
dd90d9b6d7 -Werror,-Wtautological-undefined-compare
Change-Id: Ibd738b91d35a1b82e1e7b078ef73c6f6076dc08a
2014-06-10 11:41:08 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
Bjoern Michaelsen
eda624641b lp#1296715: refresh invalidated menus
- so we need to be a StatusListener in framework after all
- we ware updating all menus for now, instead of just one
- this would have a hugh performance hit when there is much change to the menu
- thus we just invalidate the menu and update with all changes after 100ms once

Change-Id: I48cda968cf0ae1eae0421b3424bb3e5830817e84
2014-06-05 11:10:57 +02:00
Noel Grandin
0e507ae031 various: remove SAL_THROW macro
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
Thomas Arnhold
b312a38797 update_pch: add a bunch of pch files
desktop:    1m51s ->   54s
 framework:  1m55s -> 1m04s
 package:      32s ->   16s
 sdext:      1m31s ->   47s
 svgio:        32s ->   15s
 uui:          49s ->   20s
 vbahelper:  1m44s ->   27s
 xmlscript:    15s ->   10s
 xmlsecurity:  45s ->   23s

Change-Id: Ia437969c091bf877983ababc5ea2d044bbc0bee0
2014-06-04 21:18:37 +02:00
Noel Grandin
cc25f70ef1 compareTo -> equals
convert OUString::compareTo usage to equals to startsWith where it
is more appropriate

Change-Id: I6f5b5b7942429c0099ad082ba4984fd18e422121
2014-06-04 11:52:34 +02:00
Caolán McNamara
1d2993df98 coverity#737167 Uncaught exception
Change-Id: I9ac3ffbecf8c9efc0b69ad4606c61dbf8fa5a0e9
2014-06-04 09:38:12 +01:00
Markus Mohrhard
f634cda2a2 avoid problems with poppler's and vcl's FontInfo during runtime
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8
2014-06-04 07:49:15 +02:00
Caolán McNamara
229abf40ac coverity#1219794 Uncaught exception
Change-Id: Icc9e5faf9ef15840c359b7766112278094d52dea
2014-06-03 20:10:17 +01:00
Caolán McNamara
0301abbbc3 coverity#1219801 Uncaught exception
Change-Id: I372c1891e41510c24daf256d00f3ca98e8a374a9
2014-06-03 20:10:17 +01:00
Caolán McNamara
d9e7a359ef coverity#1219797 Uncaught exception
Change-Id: I597fb90d677e7cade71bf6cbf7f7bce9d3bd05f6
2014-06-02 16:59:57 +01:00
Caolán McNamara
4957262473 coverity#1219799 Uncaught exception
Change-Id: Id1903def4869bccef18f8a1132521d4f24fed551
2014-06-02 16:59:57 +01:00
Andrzej Hunt
1ae89d1892 fdo79368 Don't process overflow menu items twice.
We reuse the toolbox overflow menu for toolbarmanager's context
menu -- toolbarmanger previously added its menu listener to the
toolboxes menu permanently, meaning that it would try to handle
overflow menu items (in addition to the context menu items which
it should handle), instead we should only add the listener when
we are actually using the menu as a context menu.

Perhaps it would be better in the long run to actually use fully separate
menus instead, and ask toolbox to specifically add its items to that
rather than trying to hack the context menu on top of the overflow menu?

Change-Id: Iecface2c6eae9ab79dbcdb25ffdbaf446e2885ea
2014-06-01 08:42:46 +01:00
Noel Grandin
ebc0a15515 remove more unnecesary OUString constructor use
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29 09:01:40 +02:00
Thomas Arnhold
5e62d30fa2 update_pch
Change-Id: I5316693452427ed76a7738b090de023b110caa40
2014-05-28 15:53:10 +02:00
Noel Grandin
ec651eaead cid#706551 Uncaught exception
Change-Id: I83cb2abe19e72c13ac00ecd8c6ec58ffbfbcb659
2014-05-28 10:00:56 +02:00
Noel Grandin
ecd00991fd cid#706552 Uncaught exception
Change-Id: I93c41521a7687ca5a451f8107971d1b8fabfd489
2014-05-28 10:00:56 +02:00
Noel Grandin
0a87f4ad1a cid#706553 Uncaught exception
Change-Id: Ib3014a8f7916d8d3b9b21ddb7d2ba29108c5cd27
2014-05-28 10:00:56 +02:00
Noel Grandin
4b8e95bf8d cid#706558 Uncaught exception
Change-Id: I23b4d4de0772a45b57730921ef0fd191c53c4763
2014-05-28 10:00:55 +02:00
Thomas Arnhold
92b447876d css already means ::com::sun::star
Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
2014-05-27 14:00:28 +02:00
Stephan Bergmann
898b7643e4 loplugin:sallogareas
Change-Id: I7fe1350e55bea2eead2c7fedf432da594aa6bd9c
2014-05-27 13:29:50 +02:00
Thomas Arnhold
ea491d056d OSL_TRACE -> SAL_INFO
Change-Id: Ib9e1ed6119b5286871ac10136f7fcbefffe7aebe
2014-05-27 12:34:30 +02:00
Noel Grandin
0f2824b117 remove more unnecessary use of OUString constructor
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
2014-05-27 08:20:12 +02:00
Noel Grandin
9af0abebfd remove unnecessary use of Reference constructor in throw
Convert code like this:
  throw IOException("xx",
     Reference< XInterface >(static_cast<OWeakObject*>(this)) );
to this:
  throw IOException("xx",
     static_cast<OWeakObject*>(this) );

Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27 08:20:11 +02:00
Peter Senna Tschudin
3b24dcc8a8 Remove unnecessary semicolons
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p

@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
    cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>

Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27 01:19:00 -05:00
Caolán McNamara
637bb5adf7 Resolves: fdo#79178 Crash when opening a form created with a previous version
A regression from c2c530da69152ff9192b9726aa95961803ce9b29 I think. Rework
this to follow the same ctor + init pattern as the others

move the fillCache out of the ctor to acquire the obj first, then
call the extra init before returning it

Change-Id: Ia0dc878654780294a4935f07ac70c4358ca51dfc
2014-05-25 15:28:39 +01:00
Caolán McNamara
3467112fbd coverity#983680 Uncaught exception
Change-Id: I62baf5b8809d915a4fe6a32788868072d55258e0
2014-05-24 16:11:00 +01:00
Julien Nabet
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
Caolán McNamara
c6f72b6a7c coverity#1215320 Uncaught exception
Change-Id: Icbc9f370573eda2a79c04825b00db77d1bf1924f
2014-05-23 20:37:32 +01:00
Caolán McNamara
afe26bb894 coverity#705818 Dereference before null check
Change-Id: Ie34e0df8ce38c58f5397942e53c55f6cc091b69d
2014-05-23 14:16:10 +01:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
Caolán McNamara
4cf56e0584 coverity#1215383 Uncaught exception
Change-Id: I568ba1a942acd622611fb53210e303147b77601f
2014-05-23 08:54:36 +01:00
Caolán McNamara
6cda7d5793 coverity#1215384 Uncaught exception
Change-Id: I833b8b9532c61f666755ed5e92135da3aeb55f27
2014-05-23 08:54:36 +01:00
Caolán McNamara
fab0e8b40d coverity#1215385 Uncaught exception
Change-Id: I765dd9bab26e3736c6b18a291cfd108342644e8e
2014-05-23 08:54:36 +01:00
Caolán McNamara
3166336e53 coverity#1215386 Uncaught exception
Change-Id: I2eb374a9209cf4bbf9e2b533ec2522bc1efe6468
2014-05-23 08:54:35 +01:00
Thomas Arnhold
06ee6336ab fix-includes.pl: framework
Change-Id: I360d2124ece10ca939a45b9307daf760aaefc557
2014-05-19 20:04:27 +02:00
Tsutomu Uchino
61ce018658 Resolves: #i86528# use the module manager to identify the context...
for addons menu merging

(cherry picked from commit 2aac0070dbef6c1ad7eeccf7d4015cdcbffe067e)

Conflicts:
	framework/source/classes/menumanager.cxx
	framework/source/fwe/classes/addonmenu.cxx
	framework/source/uielement/menubarmanager.cxx
	include/framework/addonmenu.hxx

Change-Id: I3b606671db3a4c6ba8ed2b850e01e1ac91db7581
2014-05-19 13:28:17 +01:00
Hussian Alamri
b1e29a6ac5 Single line between methods 2014-05-17 21:14:06 +01:00
Chris Laplante
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way.
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17 12:38:38 +00:00
Julien Nabet
68741d0055 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part13
Change-Id: Ieecfd7ccb10c75ac639d0ba8e7cb588607097c2a
2014-05-15 22:52:22 +02:00
Thomas Arnhold
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
Caolán McNamara
bb7dad11e1 coverity#1213242 Dereference null return value
Change-Id: I23ce35dbeadca1eea4c67d7d70acbf5ce3a82ac8
2014-05-15 10:21:26 +01:00