5719 Commits

Author SHA1 Message Date
Stephan Bergmann
4198039441 Remove unused functions
Change-Id: I0f305ef5b9f13e3516b3bbf45d405fad5115521a
2014-04-09 14:21:42 +02:00
Noel Grandin
a6287e21f1 framework: sal_Bool->bool
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
2014-04-07 13:53:49 +02:00
Caolán McNamara
d816acd0e2 coverity#706548 Uncaught exception
Change-Id: Ie3be6d503b50cfa86be8fff162d01a72c6b47bf7
2014-04-07 10:14:50 +01:00
Tor Lillqvist
d9701f0ebc Typo: s/ouer/our
Change-Id: I0179678c6c5dd6a05b1d7d5038a901e7bf2af3de
2014-04-06 20:27:21 +03:00
Tor Lillqvist
e32e7946aa Bin empty @seealso, @param, @return etc metacomments
Change-Id: I9582afceb5daf5993bfca1445370d8a60030c3c5
2014-04-06 20:02:08 +03:00
Tor Lillqvist
f4e8d2ad0e Bin empty @seealso, @param, @return and @onerror metacomments
Change-Id: I30a761a21a98419816c4b67258664becd79e2db1
2014-04-06 19:37:48 +03:00
Tor Lillqvist
ee3945bd98 Kill superfluous spacing before semicolons
Change-Id: I53689e78221f3fe074e47d6b47f1a2c3fef96222
2014-04-06 19:37:48 +03:00
Tor Lillqvist
951ed199f1 Kill superfluous vertical whitespace
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
2014-04-06 19:37:48 +03:00
Stephan Bergmann
0c50756b5e Remove redundant pure overrides
Change-Id: Ic5e50643d41c08900377a34676c2ff17977643c0
2014-04-03 15:38:23 +02:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
Caolán McNamara
9dc923b146 coverity#738544 Uninitialized scalar variable
Change-Id: Idbf32e20ce81e6b726f32183c6f5e1bf0657b5ba
2014-04-01 10:38:26 +01:00
Caolán McNamara
2d737cc401 coverity#707886 Uninitialized scalar field
Change-Id: Iefcdcf992f5e25643030ab94e64bd06f9fe7c7e7
2014-04-01 10:38:25 +01:00
Caolán McNamara
3156772937 coverity#707881 Uninitialized scalar field
Change-Id: I709bb47bc2cf083805cd8b058b94a763af2ab7ee
2014-04-01 10:38:25 +01:00
Caolán McNamara
e6ff457de6 callcatcher: update unused code
Change-Id: I9d8601eb66a460702530e013bf573c6482c49c0b
2014-03-31 09:22:44 +01:00
Caolán McNamara
1978655c32 coverity#1194897 Logically dead code
Change-Id: I4cf8d63822c4a68b7cdc126a8d76c1ce7b064655
2014-03-30 21:21:28 +01:00
Thomas Arnhold
680139fe7d typo: opend -> opened 2014-03-29 19:16:33 +01:00
Noel Grandin
65c3e11ea9 framework: sal_Bool->bool
Change-Id: If3276f184c63e85762fe54ce19655c30e00aeb15
2014-03-27 13:45:07 +02:00
Stephan Bergmann
190085dd4d Work around MSC "'override' cannot be used with 'inline'" bug
Change-Id: I35170712b8f0c83ab35cb5ef7115a6dc434a7a4f
2014-03-26 17:46:10 +01:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Caolán McNamara
65f8ce6d94 coverity#1187652 Dead default in switch
Change-Id: Ieedec800955c0785b73caf52ff242b54246b653f
2014-03-25 12:33:18 +00:00
Caolán McNamara
1f1a0af795 coverity#707872 Uninitialized scalar field
Change-Id: I1dda581122caff16ab6d00a5f241d032cd021499
2014-03-22 20:43:05 +00:00
Caolán McNamara
7ac3a62379 coverity#738659 Uninitialized pointer field
Change-Id: I5d3ebc066f36f9cdcfb031a58ecb9c64ddea26c3
2014-03-22 19:27:03 +00:00
Stephan Bergmann
c8239a1dd4 Remove newly unused framework::LockHelper class
...and make LockHelper::getGlobalLock() FWI_DLLPUBLIC again (so there's a single
such lock, not one per library).

Change-Id: I0aed77333dc93cdf1c7dd7b96620fb7a8eb3dd64
2014-03-20 17:30:03 +01:00
Stephan Bergmann
250a4e8875 Remove newly unused framework::Guard
Change-Id: I49650bfd036c5df22f81c3e8cf30bc0795154a30
2014-03-20 17:30:02 +01:00
Stephan Bergmann
8b2c798333 Remove unused function declaration
Change-Id: I82ac945e5d1fba82047a7902782893d01eda34e3
2014-03-20 17:30:02 +01:00
Stephan Bergmann
4ddb43bcf1 Turn odd framework::LockHelper::getGlobalLock() into an osl::Mutex
...and extract it to framework::GlobalLock::get().

The old lock was actually effectively two different locks,
LockHelper::getGloblaLock() and
LockHelper::getGlobalLock().getShareableOslMutex(), and both were used in
different places.  These places all use the same single osl::Mutex instance now,
but hopefully that does not lead to problems (which it shouldn't, given the
documentation of LockHelper::getShareableOslMutex: "Sometimes we need a osl-
mutex for sharing with our uno helper ... What can we do? We must use a
different mutex member :-( I HOPE IT WORKS!").

Of course, the "TODO: This presumable should return the SolarMutex" still
applies.

Change-Id: I7caea3241d1b70a00272fe1f2214c071ef22cf2c
2014-03-20 17:30:02 +01:00
Stephan Bergmann
03fc5edba3 Remove newly unused framework::ThreadHelpBase
Change-Id: I75e7cfc8aa1f4e4e50a2e21c5f7596363594e179
2014-03-20 15:15:11 +01:00
Stephan Bergmann
c641f300f0 Use an osl::Mutex directly
Change-Id: If8ff4fc256e530f6b79cc97cf1f47880c93864bf
2014-03-20 15:15:10 +01:00
Stephan Bergmann
aae139a391 Remove unused ThreadHelpBase base
Change-Id: I8ab2c53566c9e62a1e03bc6010e2e13413be2c5f
2014-03-20 15:04:15 +01:00
Stephan Bergmann
4155b75632 Remove unused ThreadHelpBase base
Change-Id: Ia60e0af495b2141b7ea2e906d94c15c55865eea2
2014-03-20 15:04:15 +01:00
Stephan Bergmann
7e88a21a41 Remove dead code
Change-Id: Ib148ca5cb8fce0a4d4b15fbb16d6f008dd62671f
2014-03-20 15:04:14 +01:00
Stephan Bergmann
be1df5d2f1 Remove unused includes
Change-Id: Ia3b3ce4e9e3504e3b9e4a623879893755dcd1ba9
2014-03-20 15:04:14 +01:00
Stephan Bergmann
e3848f6d3f Remove unused ThreadHelpBase base
Change-Id: Id08d2c937a5d41c74852bb14ac726d87853dfc7e
2014-03-20 15:04:14 +01:00
Stephan Bergmann
6147424302 Access safe members directly
Change-Id: Ie76f2219c5bce609a23a0bc70d6da43f527ce12d
2014-03-20 15:04:14 +01:00
Stephan Bergmann
d8910d12b8 Use an osl::Mutex directly
Change-Id: I4adad36de95c022a7945b61a44bb6166ad87a8a7
2014-03-20 15:04:14 +01:00
Stephan Bergmann
8114055880 Use an osl::Mutex directly
Change-Id: I37264f25b5ad89f72d25f78808ff796f581536c4
2014-03-20 15:04:13 +01:00
Stephan Bergmann
f9c73e458f Use an osl::Mutex directly
Change-Id: I2ec909c81faabd896310b29b0d7149b0f7744b35
2014-03-20 15:04:13 +01:00
Stephan Bergmann
dd7b477e9d Access safe members directly
Change-Id: Ib1195f4704de845448e280fabbe40580de46a97d
2014-03-20 15:04:13 +01:00
Stephan Bergmann
4f843f2bc8 Use an osl::Mutex directly
Change-Id: Icb655df89fcb3c9dac0f25d0fdb5383d24914877
2014-03-20 15:04:13 +01:00
Stephan Bergmann
ed15977626 Access safe members directly
Change-Id: I184f6450dc436b37fefe6c6ca35f61296ec10dd6
2014-03-20 15:04:13 +01:00
Stephan Bergmann
9a110fff7d Use an osl::Mutex directly
Change-Id: I4f483efd13c099348f06094573c499858a8431ba
2014-03-20 15:04:12 +01:00
Stephan Bergmann
3d07d18a18 Use an osl::Mutex directly
Change-Id: I49b88214bca33add9f9ea3d81870d54e40c5255b
2014-03-20 15:04:12 +01:00
Stephan Bergmann
3f1d1539f6 Use an osl::Mutex directly
Change-Id: I3df1bcd733637db8d967809e9abb0d2775d58efb
2014-03-20 15:04:12 +01:00
Stephan Bergmann
9baa3cf73e Use an osl::Mutex directly
Change-Id: I22d6d17bbd6886733df645e4d217c6fd1d995929
2014-03-20 15:04:12 +01:00
Stephan Bergmann
3a94a46fc2 Access safe members directly
Change-Id: I8d145fcf3dbcb2436392ee01740255a460c610a6
2014-03-20 15:04:11 +01:00
Stephan Bergmann
85f7ed1c74 Use an osl::Mutex directly
Change-Id: I2e2a7c380ca593ad957c3b0085d01971c843f172
2014-03-20 10:49:40 +01:00
Stephan Bergmann
8781cdcc5b Use an osl::Mutex directly
Change-Id: I5dc6e56bcbec5055da629d4dfda608f266191ef9
2014-03-20 10:49:40 +01:00
Stephan Bergmann
35c495fd78 Use an osl::Mutex directly
Change-Id: I4db0fa34e00364e38ae015d079fee551be7319b3
2014-03-20 10:49:39 +01:00
Stephan Bergmann
7f0a6e262f Use an osl::Mutex directly
Change-Id: I7131abdc2202f80f0e9600d04633bbd6078700bf
2014-03-20 10:49:39 +01:00