14850 Commits

Author SHA1 Message Date
Caolán McNamara
a921f41a26 coverity#1219795 Uncaught exception
Change-Id: I24f5abd0e0b28c11c22c7871e10f42abb9908775
2014-06-02 16:59:57 +01:00
Jens Carl
8f0160a10d fdo#68849: Add header guards to all include files
Added header guards to files in directories sc/, sd/, slideshow/, and solenv/

Change-Id: Ib4577761644fe72f5ddb3c5060e629bf94d6e6e2
Reviewed-on: https://gerrit.libreoffice.org/9583
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-01 16:08:25 +00:00
Julien Nabet
ea15c9dc4d Revert "cppcheck: zerodiv"
This reverts commit c46cc5751b5af4ce180fca63f998fe7eb405f93c.

See http://nabble.documentfoundation.org/avoiding-cppunit-zerodiv-correction-td4110788.html
for more details
2014-05-30 22:39:35 +02:00
Caolán McNamara
eaa89db886 tweak massively complicated html export wizard a bit
Change-Id: I1d15780d0128204f063a816df9df251b05ab93d2
2014-05-30 15:54:58 +01:00
Palenik Mihály
df903c3e20 Convert DLG_PUBLISHING to .ui
Change-Id: I0e15b6f7610c7b262a037d6a9ea482112a5bb8b4
Reviewed-on: https://gerrit.libreoffice.org/9532
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-30 09:53:41 -05:00
Caolán McNamara
7b75f9a144 coverity#705222 Missing break in switch
Change-Id: Ie127c5238fd2f69f52fb3cbe4090929eb23566f4
2014-05-30 14:19:10 +01:00
Caolán McNamara
8ce36c3736 coverity#705223 Missing break in switch
Change-Id: I7b6f64fccc0fc16dff2d060c035fbad0ebb73335
2014-05-30 14:19:10 +01:00
Zolnai Tamás
e20876b37d fdo#76953: cannot start show at selected slide
It was worked only in slide sorter view properly.
It seems it leads undefined behaviour when a menu item
is in the menubar.xml but has no definition in *.sdi file.
I experienced that on windows menu item was disabled
on linux it was enabled.

Change-Id: Iba4dd1cbac60a3b3350604d64d60d10d050a4e2b
2014-05-30 13:56:10 +02:00
Zolnai Tamás
53c376d35b bnc#870237: wrong text position in grouped list
In grouped list text area does not cover the whole
shape but just a part of it at the top.
To get the same visual effect modify text distance
attribute.

Change-Id: I32f30d0afbc1975f940c4562ec65f46596e97060
2014-05-30 13:45:36 +02:00
Caolán McNamara
1f0b7e5dc4 coverity#704728 Unchecked dynamic_cast
Change-Id: I2db2d6ffdca1775f21969b523ede56b3fb3fd682
2014-05-30 11:48:59 +01:00
Caolán McNamara
502f059b1f coverity#705871 Dereference before null check
Change-Id: I5e52347ce5cee26dffb4d47fc8d320567a0fea31
2014-05-30 11:48:59 +01:00
Caolán McNamara
faf8d79ef6 coverity#705870 Dereference before null check
Change-Id: Ie4588f8cb0f11b831d091b0f478b78d0472af160
2014-05-30 11:48:58 +01:00
Caolán McNamara
6a8e7fde50 coverity#705861 Dereference before null check
Change-Id: Ia027a5990769413dff323ff0e0b6fd66633b9339
2014-05-30 11:48:58 +01:00
Caolán McNamara
7a211e834f Resolves: fdo#79360 impress hangs on using sidebar new style
because those styles are "pseudo-styles" and a new one cannot be
added. The possibility is supposed to be disabled, and it is
disabled in the floating stylelist. The old code assumes there
can only be one of these stylelists and when a stylelist
queries if the "new" should be disabled the callback asks
the stylelist what family is selected, but only asks the floating one.

So, floating closed, sidebar open, the new is not disabled.
Implement the ancient TODO now that we have to. Instead of asking
the stylelist what family is selected, query the frame for what
is the current SID_STYLE_FAMILY as set by whatever is the active
stylelist.

What's disturbing is the SID_STYLE_FAMILY values are not SfxStyleFamily, but
indexes that have to be mapped to SfxStyleFamily. I bet there are a pile of
bugs around that, especially with little islands of different conversion
codesites

Change-Id: I85c8032d7c26ae6eea245685748f89b2a860e767
2014-05-30 11:38:04 +01:00
Julien Nabet
c46cc5751b cppcheck: zerodiv
Change-Id: I09e1c86bdda301c11700ffe05d4a3d83b7a1104d
2014-05-29 20:46:29 +02:00
Noel Grandin
f0ae48b684 remove unnecessary NULL parameter passed to UNO Exception
.. now that we have a default value for that parameter

Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-29 09:01:40 +02:00
Thomas Arnhold
5e62d30fa2 update_pch
Change-Id: I5316693452427ed76a7738b090de023b110caa40
2014-05-28 15:53:10 +02:00
Caolán McNamara
a0a724d57c coverity#707105 Uncaught exception
Change-Id: Ice8f9633a9dddd492ce8c5d1d88961ecbed59216
2014-05-28 13:49:51 +01:00
Caolán McNamara
05e2fd162e Related: fdo#79142 make SetName default to Reindexing
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5
2014-05-28 13:25:12 +01:00
Caolán McNamara
f3395a6585 coverity#1209951 Uncaught exception
Change-Id: I11bdec73ea12e189cca41f5f275616a138cf5793
2014-05-27 21:08:36 +01:00
Caolán McNamara
92814c6fe4 coverity#1209953 Uncaught exception
Change-Id: Ia167c532afc8ba900629b3f056021deed45185ea
2014-05-27 21:08:35 +01:00
Takeshi Abe
f46d9c7d4d Avoid possible memory leaks in case of exceptions
Change-Id: Id75c459cfa59fe2adfc0f748dc33d0bc9e271507
2014-05-27 23:29:02 +09:00
Noel Grandin
035c6fbe36 cid#707134 Uncaught exception
Change-Id: I5f4f71df60defe2a2849b40a4eddeb48bfe3a2c9
2014-05-27 10:50:05 +02:00
Noel Grandin
74ccf05ef6 cid#707135 Uncaught exception
Change-Id: I49d85f11bfe3a7cfdf3fd6cf252473a3f25bebe3
2014-05-27 10:50:04 +02:00
Noel Grandin
9b6b260bcc cid#707139 Uncaught exception
Change-Id: I4d821c576fef09ca7935a931b1632238ae550df9
2014-05-27 10:50:04 +02:00
Noel Grandin
9af0abebfd remove unnecessary use of Reference constructor in throw
Convert code like this:
  throw IOException("xx",
     Reference< XInterface >(static_cast<OWeakObject*>(this)) );
to this:
  throw IOException("xx",
     static_cast<OWeakObject*>(this) );

Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27 08:20:11 +02:00
Peter Senna Tschudin
3b24dcc8a8 Remove unnecessary semicolons
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p

@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
    cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>

Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27 01:19:00 -05:00
Caolán McNamara
91e8185802 coverity#983778 Uncaught exception
Change-Id: I27ebb40f21a15c7e1696217a53d8c07e1d1161ad
2014-05-26 15:51:54 +01:00
Caolán McNamara
5c5bbe9d01 coverity#707122 Uncaught exception
Change-Id: I4a2da7874493169ad60b81be59d14269418aae96
2014-05-26 15:51:54 +01:00
Takeshi Abe
ac1f7774b7 Avoid possible memory leaks in case of exceptions
Change-Id: I185e957da57f4da7dbd2b95496bcd5349fc7d039
2014-05-26 22:14:51 +09:00
Caolán McNamara
41ce668f90 coverity#1209647 Missing break in switch
Change-Id: I1942735bd2c8922abc95e927a249fd82ecdb31c5
2014-05-26 10:18:27 +01:00
Caolán McNamara
51d6b42e4c coverity#705221 Missing break in switch
Change-Id: Ib798371f42dff6fcc67ea16c3f0ddf579160a87e
2014-05-26 10:18:24 +01:00
Matteo Casalin
957ad07e6b Remove redundant checks
Change-Id: I4357e425e0459c9cc8873eba8a8ed1c5a34e9327
2014-05-24 22:09:08 +02:00
Matteo Casalin
f4166f967b sal_uInt16 to size_t
Change-Id: I46d85e82376a3135408ab77ad31b76a5edbe9ce7
2014-05-24 22:09:08 +02:00
Caolán McNamara
aca217b5fd coverity#983801 Uncaught exception
Change-Id: Ib47f77fbd5ab03a04d40e95fa8338af238531a3b
2014-05-24 16:11:00 +01:00
Caolán McNamara
94cf259457 coverity#983802 Uncaught exception
Change-Id: I06be01500a767e600a7f391a3e74a92d05b6d73f
2014-05-24 16:10:59 +01:00
Caolán McNamara
c51fe1cf11 coverity#1000603 Unchecked dynamic_cast
Change-Id: Ia750c9cc1c6a4182d220ad22013ac1450c498539
2014-05-24 13:03:48 +01:00
Caolán McNamara
eb410d6ddd coverity#1027647 Unchecked dynamic_cast
Change-Id: I89a4cf7a8146205bc5c70e8e34111ff54afc5cf3
2014-05-24 13:03:47 +01:00
Zolnai Tamás
dd1f8ac357 CustomAnimationCreateDialog: select previously set misc animation
Regression from 9695f38ca4ab26b40524f2eade98c45f0360131d.

Change-Id: I8777fd8fa3e31c67b6645044d262fd4c5f645634
2014-05-23 22:07:54 +02:00
Caolán McNamara
2fc3b4173f coverity#1078582 Dereference after null check
Change-Id: I3b972510871f36a3c7877b38d3a012aa88acf4c5
2014-05-23 14:16:13 +01:00
Caolán McNamara
7ebbd60b14 coverity#705475 Dereference null return value
Change-Id: I75c4525bf6e04ac25c0d9ab2f926faf40b82739b
2014-05-23 14:16:12 +01:00
Caolán McNamara
6ae8ade641 coverity#705865 Dereference before null check
Change-Id: Ib7b57da47d891725cd33073a8e7ed2f4baba74e9
2014-05-23 14:16:11 +01:00
Caolán McNamara
71d21de098 coverity#705860 Dereference before null check
Change-Id: I05f23c5d1581f6673660d59f7fe7e5f89d7d0919
2014-05-23 14:16:11 +01:00
Caolán McNamara
c5d6aab137 coverity#1215279 Explicit null dereferenced
Change-Id: I543cde8225a78be9a9cefeaa7ebf6a5674caf9d0
2014-05-23 14:16:01 +01:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
Takeshi Abe
57320f34b5 Avoid possible memory leaks in case of exceptions
Change-Id: Ifd98e11380bf00f6126e4c81bcd0cbaf5b22f70d
2014-05-23 17:23:45 +09:00
Matúš Kukan
5c2ab70cc2 cp#1000077: Set 'modified' document property more consistently.
Update document info at one place, so that it works for other formats
like .doc, .docx, ... too.

Change-Id: If71799b491d2210f0d3bdbdb05f91f26c986a260
2014-05-22 13:55:53 +02:00
Thomas Arnhold
9ec96de555 cppcheck: Function parameter 'aBox' should be passed by reference
Change-Id: I60fc65799e2fd8402a8bdb1e2850b9b34cd38a27
2014-05-22 12:50:51 +02:00
Takeshi Abe
2c61edfdf5 Avoid possible memory leaks in case of exceptions
Change-Id: Ic88b22895c2eb4144d31f22a0f7bc98971873262
2014-05-22 09:44:11 +09:00
Caolán McNamara
bbfa7a65cf crash because iterator position wasn't changed in stl conversion
regression from e0284f4bba59912e1c49cb36936e041e891a5833

Here's the original code using the pre stl iterators.

if( !pPara && nDepth > 0 &&  rSet.GetItemState( EE_PARA_NUMBULLET ) == SFX_ITEM_ON &&
    pOutliner->GetDepth( (sal_uInt16) pOutliner->GetAbsPos( (Paragraph*) pList->First() ) ) > 0 )
	pPara = pOutliner->GetParagraph( 0 );  // Put NumBulletItem in outline level 1

Hidden in there is a pList->First() which only gets called if the prior
conditions are true.  pList->First() resets the index of the internal pList
iterator position of pList to 0 i.e. the next call to pList->Prev will now return 0.

The equivalent in the post-stl-conversion code is to jump the reverse_iterator
iter to the last position in the reverse view.

Create a level 10 entry in master view, select level 10, and use the bullets
and numbering dropdown from the side panel to see this crash

Change-Id: I52c22ea52020feb0fb75924f63ebe225be462071
2014-05-21 16:26:33 +01:00