14850 Commits

Author SHA1 Message Date
Stephan Bergmann
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
Norbert Thiebaud
611b419562 coverity#704299 Dead code
Change-Id: I41d4c99216cc19302f2d65db1471cb49016a784a
2014-07-01 12:44:05 +02:00
Caolán McNamara
5ace3f3b4f clang scan-build: various warnings
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
matteocam
22f244ae45 Background color in defaults for named presentation layout
Change-Id: I0f65476a545cdd080768e00161ab4a7682acc359
(cherry picked from commit 3ae8a7302c2c145867ae2072f3ba477ba1b3e0a4)
2014-06-30 22:54:41 +02:00
Caolán McNamara
4523dd0544 Called C++ object pointer is null
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6
2014-06-30 09:46:16 +01:00
Andrzej Hunt
679b1ed865 More -WaE: nested template problems.
Change-Id: I896773bd37d855b83e9dfc260cae293a6f92100a
2014-06-30 09:16:24 +02:00
Andrzej Hunt
fb597ee98f -WaE: nested template problems.
warning: ">>" operator will be treated as two right angle brackets in C++0x
error: ">>" should be "> >" within a nested template argument list

and

Change-Id: Id3f555d606887fb60db016ab14fb0541ccfd0d7a
error: "<::" cannot begin a template-argument list
note: "<:" is an alternate spelling for "[". Insert whitespace between "<" and "::"
2014-06-30 08:27:10 +02:00
Andrzej Hunt
e65ba1ad3e -WaE: variable bNewEntryInserted set but not used.
Is a direct result of a4620e23cec01169995ec7bc056c51295a4f9907
(although that didn't actually really "use" the result either...).

Change-Id: Ic21eb9a5cdfa86cab257afe66a89953b144b171c
2014-06-30 08:11:35 +02:00
Andrzej Hunt
a4decedeb6 Impress Remote Dialog: avoid flickering when device selected.
Changing visibility of items (i.e. the pin box / deauthorise button)
whilst painting the ClientBox can cause extra Paint request to be fired,
essentially resulting in an infinite loop (although slightly slowed
down by going through a VCL timer). These repeated paints (and repeated
hide/showing) of items resulted in a rather ugly flickering, which
is now gone.

Change-Id: Ib6b22dd1b08f3be5d1f543cfbb27a1ed782b5720
2014-06-30 07:45:23 +02:00
Andrzej Hunt
580b1890d8 Allow removal of remotes even if Server not running.
This is purely config manipulation so shouldn't rely on having
the Server actually running (e.g. if disabled, and/or if network
setup failed).

Change-Id: Ifc6e5639ba6842a18eb0be99387a5f8dd871da06
2014-06-30 07:45:23 +02:00
Andrzej Hunt
d61468314b fdo#63378 Enable Impress Remote Dialog menu item for all view shells.
Change-Id: I47f040c1463b4be648d411c2f7f0070b8aed3e9c
2014-06-30 07:45:23 +02:00
Andrzej Hunt
eba630ca16 Remote Dialog: give focus to pin entry when item selected.
Change-Id: I5718a5b881a32ecf4cebdbd6a682097119c26837
2014-06-30 07:45:22 +02:00
Andrzej Hunt
a17737ef45 Remote Dialog: make sure pin box is empty.
The only way to do this seems to be setting an empty string --
using clear, or setting 0, results in a 0 being shown, which is
rather ugly and unintuitive.

Change-Id: Ic641c4fcecd634b7fff397989ee0b079239ea44c
2014-06-30 07:45:22 +02:00
Andrzej Hunt
3c5223b232 Make sure pin box and deauth button hidden when no items selected.
Change-Id: I650191b9b092a3562c7bfcdfe40ac4968d18ae36
2014-06-30 07:45:21 +02:00
Andrzej Hunt
a4620e23ce Kill some unused/commented code.
These are various remainders of the extension dialog that this
dialog was originall based on.

Change-Id: I564dd371b7d58322cc3ef03c7401151f3098f333
2014-06-30 07:45:19 +02:00
Andrzej Hunt
6216eee4b9 Impress Remote: allow removal of authorised remotes.
Previously authorising a device meant that it would have access
forever -- we now list previously authorised remotes in the remote
dialog, along with controls to allow removal of such remotes.

Change-Id: I4179739f3a2ba0a8fe19c2a0cd0cbbece9cb4352
2014-06-30 07:45:17 +02:00
Andrzej Hunt
f82c524f76 Move ClientInfo to shared_ptrs.
I don't think these ever get deleted anywhere? This changes will also
help in the management of existing clients (separate commit).

Change-Id: I339916439f6b798524fac33e91688f81c03a3ca5
2014-06-30 07:45:16 +02:00
Julien Nabet
430484932e Typo: beeing->being
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
Norbert Thiebaud
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
Stephan Bergmann
e48a233960 loplugin:unreffun: also warn about redundant redeclarations
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-27 15:27:39 +02:00
Caolán McNamara
daa6898578 clang: Dead initialization
Change-Id: Ieae5303e55f21044ef8e91e63c4896696cfad51c
2014-06-26 16:29:15 +01:00
Noel Grandin
533c6cb6ba fixes for up-casting to Reference<XInterface>
Fix regressions introduced with
6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking
Reference constructor to reduce code noise"

Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-25 17:10:43 +02:00
Matúš Kukan
a3b68ba2de loplugin:unreffun
Change-Id: If67f953bb0d1842ff75482fdb878acf4b1bf87cb
2014-06-25 11:20:47 +02:00
Markus Mohrhard
ed6b8a100c remove whitespaces
Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
2014-06-25 05:41:09 +02:00
Markus Mohrhard
78f6407978 fix build after rebase
Conflicts:
	sd/source/ui/slidesorter/view/SlideSorterView.cxx
	sd/source/ui/slidesorter/view/SlsPageObjectLayouter.cxx
	sd/source/ui/slidesorter/view/SlsPageObjectPainter.cxx

Change-Id: Id014a49dbbb33123d2d04f9f33954b77575f2e9e
2014-06-25 05:41:08 +02:00
Michael Meeks
de61b52619 slidesorter - cleanup redundant caches and notifications.
Change-Id: Ibe8106a77899f141d1e3722bcae615ab905b2568
2014-06-25 05:41:08 +02:00
Michael Meeks
0036ced049 slide-sorter: re-factor to improve bbox calcuation
Always use a SlsPageDescriptor to calculate bbox, so we can
adapt it to merge slides attributes where possible.

Change-Id: Id71945bbbb9adb069654ab712e22ea79fea96c1f
2014-06-25 05:41:07 +02:00
Matúš Kukan
9388c45c02 bnc#882631: Do not hide top of the first row when editing text in table cells.
This can happen when proportional line spacing is less than 100%
and "FontIndependentLineSpacing" is set, so just keep the height
of the very first line in case of IsFixedCellHeight() too.

Change-Id: Id231fc1f2373645e5420f877e8c2568ce8a1f099
2014-06-24 20:39:24 +02:00
Armin Le Grand
a595879302 Resolves: #i124816# use correct layer for new object when converting
(cherry picked from commit c0f03c75c71dde47e210ca23eefe3c879b89d97c)

Change-Id: Iaf6f9e040553482f5b7d9522ea640dcea0fdd8cc
2014-06-24 16:26:04 +01:00
Steve Yin
229b8f9122 Resolves: #i125090# The values of upper and lower spacing...
for default paragraph did the complete opposite.

(cherry picked from commit 75f191b09f25e4dd357f42fdf80c2b0252d1c410)

Conflicts:
	sd/source/core/stlpool.cxx

Change-Id: Idd44f7f1e4ad6acbde2733240fd357e628ac1f28
2014-06-24 10:52:20 +01:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
Caolán McNamara
43b0a48596 can't have bare english strings in .cxx
Change-Id: I1a14e37f3362c082bc460895ffd0b949c636b8ea
2014-06-23 14:12:43 +01:00
Palenik Mihály
9701a7ca98 Convert DLG_ASS to .ui
Change-Id: I29ee55654391f24399aea24fc02c49c430c4e839
Reviewed-on: https://gerrit.libreoffice.org/9834
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23 12:14:14 +00:00
Joren De Cuyper
171efcb7ac fdo#76203 - use consistent titlecase for UI title labels
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9
Reviewed-on: https://gerrit.libreoffice.org/9858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23 09:01:25 +00:00
Matúš Kukan
fc577e4f41 Revert "bnc#882631: keep line visible if proportional line spacing is < 100%."
This reverts commit 339e5d44a2afa0f5309a970f1ff11968103e336a
and commit d1987a3eaccfc3add35e6b9f8307ede857c5468e
"fix sd_import_tests after e42c05c1f96832572e525d85d89590f56f5a29dd".

It would need more work and understanding, so just revert.
Also, the problem with bnc#882631 is somewhere else, though this helped too.
2014-06-21 09:40:04 +02:00
Armin Le Grand
553f88e3d6 Resolves: #i121410# Secured usage of pTextGroup
(cherry picked from commit 966c38038352a347f25d690f18a2059d6f78b9fa)

Change-Id: Ibbd68e8c102f2d80ea5b7610b9a97704a282e6ea
2014-06-20 16:57:17 +01:00
Kohei Yoshida
1d38cb3655 fdo#71076, fdo#71767: Preserve number formats when charts are copied.
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
Caolán McNamara
cf309ee274 coverity#704771 Explicit null dereferenced
Change-Id: I653866006a54f5bc73dae4614b0b9c8ddfeb4989
2014-06-19 10:26:54 +01:00
Caolán McNamara
0766b83a2b coverity#735837 Explicit null dereferenced
Change-Id: Idaf39928e4f48f8cf823de22e2ded995046624fc
2014-06-19 10:26:50 +01:00
Caolán McNamara
32294e11a0 coverity#706052 Unintended sign extension
Change-Id: I5e9b8a8809f9736038f20493d1a24bbbd8846dbd
2014-06-19 10:26:47 +01:00
Caolán McNamara
f53e88d14d Resolves: fdo#80140 inverted spell-check continue logic
regression from 57779aa0195d77239b339c6dbe17209b3f0cc4ee
"editeng: sal_Bool->bool"

Change-Id: I6042830f5ba1822b1ba59326895080f3375cd701
2014-06-18 11:12:11 +01:00
Stephan Bergmann
f66eec4623 rtl::Reference fits just fine here
Change-Id: I80fd6b112134ab2b0e4a592f60a21c7c177b4b01
2014-06-17 15:51:53 +02:00
Matúš Kukan
5158f5e9fd fix sd_import_tests after e42c05c1f96832572e525d85d89590f56f5a29dd
Change-Id: Ife852a6c7c360c66a7d7d5b144f18898398505dd
2014-06-17 12:49:14 +02:00
Caolán McNamara
f829d088a6 coverity#707138 Uncaught exception
Change-Id: Ifd9a8ea49b48e81cdff859d2659fbd4d828afa90
2014-06-17 10:57:59 +01:00
Caolán McNamara
4598bbe41d coverity#1223089 Dereference before null check
Change-Id: I790a7bed0a2ac77c452638349008f4a34fd4ad0c
2014-06-17 10:57:59 +01:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Zolnai Tamás
b7f2cad987 Revert "Make glTF support an experimental feature"
Actually make it experimental mode was unecessary on master.

This reverts commit 653bac184f579524bc25a9f40281763a736ae6fd.

Conflicts:
	sd/qa/unit/import-tests.cxx
	xmloff/source/draw/ximpshap.cxx

Change-Id: Ie8747745a9a89ce4d6500a35d15a98e28bda840a
2014-06-16 18:59:25 +02:00
Zolnai Tamás
e38acfa15b Reduce test doc size, use a simpler gltf model
Change-Id: I5bd78343728f8a4d68610397a7be328826a0334c
2014-06-16 14:12:39 +02:00
Zolnai Tamás
04b7b2c72f Fix gltf export: close plugin element before export fallback
Change-Id: I2e1f27e535ee45259f7bdf783ea5224b2ad559ef
2014-06-16 13:55:40 +02:00
Zolnai Tamás
4d8c4e7fe3 glTF import/export: fallback must be the second one inside the frame
The previous solution was good because older LO versions
import the fallback image without changing their code, but
it came out it does not fit to ODF standard so export
fallback image as the second object after the glTF model.

Change-Id: Ib9b2044b1f36b32d980cb79f6dac8dcf94d6209b
2014-06-16 12:59:19 +02:00