8100 Commits

Author SHA1 Message Date
Noel Grandin
d812b78431 remove unused code -SvtLanguageTable::AddLanguageTag
Change-Id: Ibb0dda4b48c711e72574c3f5aec9e3d1186d1526
2014-05-13 12:00:28 +02:00
Markus Mohrhard
86dcfe908f whitespace cleanup
Change-Id: I511412f8b6d8ac2fcbac738d1ef5e6d5cd9928bb
2014-05-12 03:28:31 +02:00
Thomas Arnhold
a325ce63db fix-includes.pl: svtools
Change-Id: I509299306ab6cd97c96e9a26d4674f983bbffbec
2014-05-11 01:55:40 +02:00
Caolán McNamara
828fcdd270 coverity#708306 Uninitialized pointer field
Change-Id: Ia249608d5166273bb6be7b52185d48dffbc918d9
2014-05-10 21:12:58 +01:00
Caolán McNamara
2ab8d88ca9 coverity#708336 Uninitialized scalar field
Change-Id: Ie4b6ea734d8ab77060848cd813b44d0727eb47c4
2014-05-10 21:12:58 +01:00
Eike Rathke
07481fd864 add on-the-fly language tags to the language table
Change-Id: I5ca9e212374821de425729863c82f7b4699487a7
2014-05-10 00:39:45 +02:00
Eike Rathke
1564b0fe7c added SvtLanguageTable::AddLanguageTag()
Change-Id: Ic8be508bff3767f2f8ab1146447b3fe4bffff3b3
2014-05-10 00:39:44 +02:00
Jan Holesovsky
261b1ad80a '!= false' is redundant, and confusing - kill it.
Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
2014-05-09 22:28:44 +02:00
Caolán McNamara
940ac1e52e WaE: -Werror=maybe-uninitialized
Change-Id: I8f63bc51c48d69eaa81bf080b05747c026871f08
2014-05-08 16:18:15 +01:00
Noel Grandin
bf30c8b16d use new VCL IsValueChangedFromSaved method
follow to commit ff1a7a59434f5f793d4044aad615bcf78148e963
"RFC: add IsValueChangedFromSaved to VCL button and listbox"

Change-Id: If2e6d9e7c18590dc4abbc90362d7897ca2557dd6
2014-05-08 14:55:12 +02:00
Noel Grandin
b7d30cb50e svtools: sal_Bool->bool
Change-Id: Idd9a3ccf0eb6d14cec158daa17a6b2da625f7ffa
2014-05-08 11:48:13 +02:00
Stephan Bergmann
93f5d5a919 The opaque PostUserEvent IDs are actually pointers
...so declare them as such.  This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.

While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent.  And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.

Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-07 11:49:46 +02:00
Eike Rathke
d80490e938 move ResArray into SvtLanguageTableImpl
Change-Id: I0921fcef306f1ca60196fc9dfa2652e91db63004
2014-05-06 19:58:07 +01:00
Eike Rathke
a9ff01648a provide static GetLanguageEntryCount() and GetLanguageTypeAtIndex()
Change-Id: I89dc5d25b37169ebc1581ebf957d33dd7b0e204c
2014-05-06 14:22:13 +01:00
Tor Lillqvist
9124f7e8bc Move headers included only in svtools to svtools
Change-Id: I66e443b5b641aaf16e1918f139a6b6a173ef7d4c
2014-05-06 15:30:05 +03:00
Thomas Arnhold
5d0272772a consistent percent sign in comments
Change-Id: I9906b4e58fd8672e51f6aa2e56ec68bb28772500
2014-05-06 07:19:08 +02:00
Noel Grandin
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
Luboš Luňák
893fe88469 handle brightness+contrast from msoffice (bnc#875713)
This is the same like 1139d618b8bc6ab823a96184bd0f0257980aad24, for docx.

Change-Id: I1ef4e18444e8c60e9ae8f67249bcef1053f0d62d
2014-04-30 23:40:26 +02:00
Caolán McNamara
cbb9efa642 Related: fdo#72142 lighter ruler default color
Change-Id: Iadb8bb134e3ecda974b8a9d8589fdc5ed02907f0
2014-04-30 17:11:31 +01:00
Kohei Yoshida
0b03f7ed57 fdo#75058: Optimize autofilter item filling for non-tree items. 2014-04-29 21:30:54 -04:00
Caolán McNamara
68075a61c2 Resolves: fdo#72142 darker default workspace color
Change-Id: I7fec37c5edd42d974bddb4abbecb0d2b3dd86f14
2014-04-29 15:24:28 +01:00
Caolán McNamara
62b0eaf37c Related: fdo#50697 reset the cache timeout on GetGraphic
so the graphic gets swapped out Xms after the last use and not Xms after
initial creation regardless of if it got used a moment earlier.

Change-Id: I1458f307d090ecd8d8d031b545f23e78bf1bcb67
2014-04-29 15:24:27 +01:00
Tor Lillqvist
6f59894afc WaE: implicit conversion from bool to 'long'
Change-Id: Ibe8bf3070fb64b447315b280c7c06a7851f7a7ed
2014-04-28 19:13:26 +03:00
Noel Grandin
2554d0ab4e remove unused code from TabBar
Change-Id: I9f975d99893135b414c749c4fe86912362375c4e
Reviewed-on: https://gerrit.libreoffice.org/9162
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-28 12:01:04 +00:00
Noel Grandin
883481fd20 Improve TabBar return types
DeactivatePage() goes from returning long to returning bool.
StartRenaming goes from returning long to returning bool.
AllowRenaming goes from returning long to returning a
constant from a new enum.

Change-Id: Ib87e8d7ceb4e23846547257b358ca4dfd41eb6ca
Reviewed-on: https://gerrit.libreoffice.org/9161
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-28 11:37:37 +00:00
Chris Sherlock
e474c95cde VCL: Renamed two functions
Renamed functions:

+ supportsOperation -> SupportsOperation
    For consistency

+ DrawAlphaBitmap -> DrawDeviceAlphaBitmap
    I want to make it more clear that these are the functions that call
    on mpGraphics to actually draw on the graphics device

Change-Id: Ic4951bfcc0ac0c09fe5b6908dfdf1f699a634265
2014-04-28 00:14:56 +10:00
Andrzej Hunt
b8315b1c2f fdo#72006 Populate "Load URL" dropdown from picklist.
f7feb4227d83f4f095597a44826277aaae2bc0df stopped any newly opened documents
from being added to the "History" list (and instead adds them to the picklist),
since the history list is not used anywhere else, and since the picklist performs
an equivalent function, it makes most sense just to use the picklist to populate
the list of URLs.

Change-Id: I5a06e7fefe3dc1fbe266f3191de4fbac03601858
Reviewed-on: https://gerrit.libreoffice.org/9104
Tested-by: Andrzej Hunt <andrzej.hunt@collabora.com>
Reviewed-by: Andrzej Hunt <andrzej.hunt@collabora.com>
2014-04-26 07:42:37 +00:00
Noel Grandin
532acfde02 make SvDetachedEventDescriptor::hasByName return bool
Also, since this is a utility method, and it does not override
a method from an UNO interface, it does not need to be virtual.

Change-Id: I2dd90331e8ff49572bdfcb6ea2e2e3ed2fd95051
2014-04-24 14:17:24 +02:00
Thomas Arnhold
371046c6a3 add missing modelines to cxx and hxx files
some of them have no copyright header

Change-Id: I9c2c0c859dabe231cb29af29290847e7b4aa46a3
2014-04-24 11:58:15 +02:00
Thomas Arnhold
0b7f82d7cb add missing modelines to hrc and src files
Change-Id: I82d9727c4f991c606a19b9eba27732e7e2397db6
2014-04-24 11:58:14 +02:00
Thomas Arnhold
702f9c5176 huge hrc and src file cleanup
* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-23 22:49:57 +00:00
Caolán McNamara
3a374a50a2 coverity#707218 Uncaught exception
Change-Id: Ia7ed41a0d0bfa24a64f6d140922c095de5dd9c0c
2014-04-23 09:40:02 +01:00
Caolán McNamara
aa555c725b stray comma
Change-Id: I7771fbb76fe83ba605cb6b86824396c2b1414253
2014-04-22 11:43:00 +01:00
Caolán McNamara
10382948e6 coverity#708335 Uninitialized scalar field
Change-Id: I14ce77fe16acdf6491ce49cdbe7550ef303f0ff9
2014-04-22 11:39:22 +01:00
Caolán McNamara
bbe00527f0 coverity#708334 Uninitialized scalar field
Change-Id: I01e8a8b18d07e035a57fbc731b4666c98148c102
2014-04-22 11:39:21 +01:00
Caolán McNamara
8a5dbd8c75 coverity#708324 Uninitialized m_refCount
Change-Id: I1a8e548605570eb18ed455282d8f329a3f026409
2014-04-22 11:39:21 +01:00
Caolán McNamara
7b659719b0 coverity#708323 Uninitialized scalar field
Change-Id: Iea430ce93ac1add2be76222b8ee9ae6c0da53ff6
2014-04-22 11:39:21 +01:00
Thomas Arnhold
9d2977d0a3 remove some more bloat
Change-Id: I7b6c04d99c41360ff49be774afcb4447a829d31c
2014-04-21 09:39:35 +02:00
Tor Lillqvist
53f5865c07 Bin the now non-existent dtor from the class definition too
Change-Id: I25bfba14fdc8b1c77217082922d13fad6c9bc41a
2014-04-19 10:43:22 +03:00
Tor Lillqvist
b1b11e3272 If it has been "not recommended currently" since 2007 it can go away
Change-Id: I03f2822f1bad8f5d4128c5b0bd7e26b7ab968815
2014-04-19 10:29:33 +03:00
Tor Lillqvist
c654ff4042 WaE: unused variable 's_pAccessibleFactoryFunc'
Change-Id: I7654c7d88b9d4a84368551972ab945be3508f0e3
2014-04-19 10:26:25 +03:00
Jan Holesovsky
a7ee8316f7 non-desktop: Avoid accessibility.
When using the tiled rendering, LibreOffice provides only the content, so no
need to instantiate accessibility.

Change-Id: Ibc0ff672aa960409fa660a750f8f02c9261041be
2014-04-18 22:51:07 +02:00
Tomaž Vajngerl
9ea483e8a9 svtools: valueset.cxx - use scoped_ptr and clean-up
Change-Id: I91528f55af39faccfe1bf95999ac29669ead0aad
2014-04-18 21:07:02 +02:00
Tomaž Vajngerl
6b6bf85661 Cleanup valueset.cxx
Change-Id: Ib0a27d8d3a3e974f73e7873ad8baae4721f6fb87
2014-04-18 21:07:01 +02:00
Caolán McNamara
902cafe656 coverity#1202783 Division or modulo by zero
Change-Id: I183416ad3db39108e52c1e69b60fb547448b21a8
2014-04-18 12:21:43 +01:00
Eike Rathke
e84331b4fd introduce second static GetLanguageString() with explicit bool parameter
Change-Id: Ief79b8871701cc2e39e421145370feb246ce5e20
2014-04-17 23:54:08 +02:00
Eike Rathke
a97c2268a5 introduce static SvtLanguageTable::GetLanguageType()
Change-Id: I096f8b5a08452df9b1731f2e764d7561dd3e5dd4
2014-04-17 23:45:54 +02:00
Eike Rathke
709b4e653c have a "better" static
Change-Id: Ib978d24b5188482242101d3a352f29d604b36c90
2014-04-17 23:45:54 +02:00
Caolán McNamara
516a22afa5 coverity#704807 Dereference after null check
Change-Id: Ifbfdbc016cde790a2027a0036294b3be9e37a85c
2014-04-17 18:33:37 +01:00
Noel Grandin
cfddda092b sal_Bool to bool in SvtRulerAccessible
Change-Id: Ib5f451fadb9eedc49d6bded0cbd92cfbbde71bae
2014-04-15 09:02:32 +02:00