16795 Commits

Author SHA1 Message Date
Caolán McNamara
7dda48d56f Related: fdo#80633 cache optimal size
Change-Id: Ic2c3aefebd3061d294f339c6d262a3c3e381fbe4
2014-07-01 16:43:05 +01:00
Stephan Bergmann
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
Armin Le Grand
7d9bb549d4 Related: #i124638# Second step of DrawingLayer FillAttributes...
for Writer objects, now added support for Paragraph and PageStyle (including
Header and Footer) for direct attributes and style attributes

(cherry picked from commit cc25c58f7052827bfebdc9fbeec668c8fa29ed1b)

Conflicts:
	cui/source/factory/dlgfact.cxx
	cui/source/factory/dlgfact.hxx
	cui/source/inc/bbdlg.hxx
	cui/source/inc/cuires.hrc
	cui/source/tabpages/bbdlg.cxx
	cui/source/tabpages/bbdlg.src
	cui/source/tabpages/page.cxx
	cui/source/tabpages/tparea.cxx
	include/svx/pagectrl.hxx
	include/svx/svxdlg.hxx
	include/svx/svxids.hrc
	include/xmloff/PageMasterStyleMap.hxx
	include/xmloff/prstylei.hxx
	include/xmloff/txtprmap.hxx
	svx/Package_inc.mk
	svx/inc/svx/hdft.hxx
	svx/source/dialog/hdft.cxx
	svx/source/dialog/pagectrl.cxx
	svx/source/tbxctrls/tbxcolorupdate.cxx
	svx/source/unodraw/unobrushitemhelper.cxx
	sw/Library_sw.mk
	sw/inc/fillattributes.hxx
	sw/inc/format.hxx
	sw/inc/frmatr.hxx
	sw/inc/frmfmt.hxx
	sw/inc/hintids.hxx
	sw/inc/hints.hxx
	sw/inc/ndtxt.hxx
	sw/inc/node.hxx
	sw/inc/swunohelper.hxx
	sw/inc/unobrushitemhelper.hxx
	sw/inc/unoprnms.hxx
	sw/source/core/attr/format.cxx
	sw/source/core/attr/hints.cxx
	sw/source/core/doc/docdesc.cxx
	sw/source/core/doc/docdraw.cxx
	sw/source/core/doc/docfmt.cxx
	sw/source/core/doc/docnew.cxx
	sw/source/core/doc/docredln.cxx
	sw/source/core/doc/poolfmt.cxx
	sw/source/core/doc/visiturl.cxx
	sw/source/core/docnode/node.cxx
	sw/source/core/inc/frame.hxx
	sw/source/core/inc/frmtool.hxx
	sw/source/core/inc/rolbck.hxx
	sw/source/core/layout/atrfrm.cxx
	sw/source/core/layout/fillattributes.cxx
	sw/source/core/layout/findfrm.cxx
	sw/source/core/layout/paintfrm.cxx
	sw/source/core/txtnode/ndtxt.cxx
	sw/source/core/txtnode/thints.cxx
	sw/source/core/txtnode/txtedt.cxx
	sw/source/core/undo/rolbck.cxx
	sw/source/core/unocore/swunohelper.cxx
	sw/source/core/unocore/unoframe.cxx
	sw/source/core/unocore/unomap.cxx
	sw/source/core/unocore/unoparagraph.cxx
	sw/source/core/unocore/unoprnms.cxx
	sw/source/core/unocore/unostyle.cxx
	sw/source/ui/chrdlg/paradlg.src
	sw/source/ui/chrdlg/pardlg.cxx
	sw/source/ui/fmtui/tmpdlg.cxx
	sw/source/ui/fmtui/tmpdlg.src
	sw/source/uibase/app/docst.cxx
	sw/source/uibase/app/docstyle.cxx
	sw/source/uibase/frmdlg/colex.cxx
	sw/source/uibase/shells/basesh.cxx
	sw/source/uibase/shells/textsh1.cxx
	sw/source/uibase/uiview/viewstat.cxx
	sw/source/uibase/utlui/uitool.cxx
	xmloff/inc/PageMasterImportContext.hxx
	xmloff/inc/xmloff/XMLShapeStyleContext.hxx
	xmloff/source/draw/XMLShapeStyleContext.cxx
	xmloff/source/draw/sdpropls.hxx
	xmloff/source/style/PageMasterExportPropMapper.cxx
	xmloff/source/style/PageMasterImportContext.cxx
	xmloff/source/style/PageMasterPropHdlFactory.cxx
	xmloff/source/style/PageMasterStyleMap.cxx
	xmloff/source/style/prstylei.cxx
	xmloff/source/text/txtexppr.cxx
	xmloff/source/text/txtprhdl.cxx
	xmloff/source/text/txtprmap.cxx
	xmloff/source/text/txtstyli.cxx

Conflicts:
	svx/source/dialog/hdft.cxx
	sw/source/core/doc/visiturl.cxx
	sw/source/core/txtnode/thints.cxx
	sw/source/core/txtnode/txtatr2.cxx
	sw/source/core/unocore/unostyle.cxx

Change-Id: I7e8779db6c0cbd1e242b63eab888f468f2de509a
2014-07-01 13:30:09 +02:00
Caolán McNamara
5ace3f3b4f clang scan-build: various warnings
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
matteocam
59a2e1b9fa Cleanup: removed comments and debugging output
Change-Id: I41f13d33da641153784725344f5bd526ca69542b
2014-06-30 22:54:44 +02:00
matteocam
ae915ba34f More debugging; fixed Font::IsTransparent
Change-Id: Idcb54408dd3cf6561b78eb28fdb409d2e31df541
(cherry picked from commit d84dba8b01c1f240f22b774c951ebf206d5a3ac9)
2014-06-30 22:54:42 +02:00
matteocam
2f54ab7089 Minor changes.
Change-Id: I3b8c51690eb14601435653e9a2255a5c6ed4fd7e
(cherry picked from commit 0b8fe9834b398db7550f30718b3cb63860c6165d)
2014-06-30 22:54:40 +02:00
matteocam
f7f4059805 Debugging output in OutputDevice::SetTextFillColor
Change-Id: I78a75a94e4012eded1a4a5b4c36d8b399a4dda6c
(cherry picked from commit 1441ae75b005b4ff1ae2683755a12c5813a3a6b3)
2014-06-30 22:54:40 +02:00
matteocam
6d658b15b8 Debugging output
Change-Id: I4e9418746ad50e1bdb1336459c00a4cf614e2350
(cherry picked from commit 4b2d62f02a386013d0004058a02fed80eb8df675)
2014-06-30 22:54:40 +02:00
matteocam
a74e588518 Setting SetTextFillColor from Attrs. Experiment with line color
Change-Id: If34f000d6c5ef6ec38f7f735ada194b8fff4f56d
(cherry picked from commit 7fb0e8c9a659417607c85f9b0e8245e4af4552dc)
2014-06-30 22:54:39 +02:00
matteocam
7b59e44925 Cleaned up code from tranparency in vcl. Trying setfillcolor from edit attrs
Change-Id: I263012332e43573f260ac8c54612576eb21a11a1
(cherry picked from commit 02385eb4d8de3c5a57511d8bae3c42a523470838)
2014-06-30 22:54:39 +02:00
matteocam
be34ea6f62 Cleaned up code from operations in vcl
Change-Id: Ica5194f0cf6e30ec099974ae8b794fb2bc5e654a
(cherry picked from commit 4445f361aa2730b61fdd339dcdd7014b266e5c42)
2014-06-30 22:54:38 +02:00
matteocam
dbff42a078 SetTextFillColor immediately before DrawTransparent. DrawTextRect commented
Change-Id: Id283624484dfcda91546fd4965bc0b6b92614f55
(cherry picked from commit ebc7be61df384120f1d0420d3e4dc5e3ac5599f4)
2014-06-30 22:54:38 +02:00
matteocam
44f6d7a2c5 Transparency with DrawTransparent in addition to DrawRect
Change-Id: I9e8221652b74a3004857ef4b12c6b45563a373b5
(cherry picked from commit 2f8660008ddd32c8f24825d5ba3e751bc65d6d3e)
2014-06-30 22:54:38 +02:00
matteocam
6b490f6be9 Transparency by replacing DrawRect
Change-Id: I5ba220df841cbe650c910c1c7bc1815900f13c53
(cherry picked from commit 6ec2a1a6922d22fa5efb25982b0b51cef7a97499)
2014-06-30 22:54:38 +02:00
matteocam
f850bbb4cb Changed SetFillColor to SetTextFillColor
Change-Id: I3c19ac80318733ccae1e8829e3269ec8c716869e
(cherry picked from commit 33384f3d23958b62e1ec9f72f2a0e6424313a177)
2014-06-30 22:54:38 +02:00
matteocam
23cd36d876 Fixed color problem
Change-Id: I7e9340ebab26d3c979571155a3e9d051c41c58f4
(cherry picked from commit aa7d40399758c7f2270dfb0b71f4bcc39d0e24ea)
2014-06-30 22:54:37 +02:00
matteocam
be085bf523 Moved Text Filling Color in OutDev. Text Filling occurs in ImplDrawText
Change-Id: I9c75066a8dea32721757d0511a2af58c68408438
(cherry picked from commit b09cf493611f2521e66159287b88acc3c05d6d33)
2014-06-30 22:54:37 +02:00
matteocam
039599e9d5 Put text filling in SvxFont
Change-Id: I290fff0cb66fc07122b976d977dff24ac491e108
(cherry picked from commit ea56441757a34082b9ffc5f28936413fcb55e31a)
2014-06-30 22:54:37 +02:00
matteocam
d097bc8e15 HasBkg method to Font.HasBkg iff HasSingleUnderline.SetBkgColor in OutputDev
Change-Id: I10e6e1b916df0c78d26596a37944e8b57b2897e7
(cherry picked from commit 181266201b5e6aaad1dcd9cbc2dd4db44ecf3dc5)
2014-06-30 22:54:37 +02:00
Caolán McNamara
eb8c56127a rework resize into a custom widget
so that the order of resizing will happen in the right sequence
to work correctly every time

Change-Id: I1adffe276db3fb80eb34ca74c2ceb51a6ee28526
2014-06-30 16:31:48 +01:00
Stephan Bergmann
f8e34ea78a ...and ~SystemWindow can recursively destroy its child windows
...so when the pMyParent vs. pMySysWin typos in the asserts (thanks Matteo and
Micheal for spotting) were fixed, they would fire in such scenarios.  So just
hope that it is fine to effectively skip those safety checks in these cases,
too.

Change-Id: Ib925e57b68643c75a5d4db67fd64692015482179
2014-06-30 16:42:43 +02:00
Stephan Bergmann
0223eb2c64 Once ~SystemWindow calls ~Window, this is no longer a SystemWindow
...and hopefully it is just as fine to start this safety check at the paren,
anyway.

Change-Id: Ie3d7a1e233b9e3076a6603f2c6312d57b42b0f77
2014-06-30 14:57:57 +02:00
Stephan Bergmann
5f50d9593d Mark WindowImpl as noncopyable
Change-Id: I80f981216067a03578cfc812b006e6b68b77068e
2014-06-30 14:57:57 +02:00
Norbert Thiebaud
c403286de5 use VCL_HIDE_WINDOWS env on Mac to 'simulate' headless mode on Mac
Building, and running the unit/subsequent test on Mac cause massive amount
of flashing windows creation/destruction that make building with test
very annoying on a box used for other purposes.
This patch prevent the windows to be actually displayed hence mitigating
the problem

Change-Id: Ied2a36699b50856e0c4e6b618212481796ec99d3
2014-06-30 11:14:12 +01:00
Caolán McNamara
4523dd0544 Called C++ object pointer is null
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6
2014-06-30 09:46:16 +01:00
Peter Senna Tschudin
f8018266cc Remove double assignment
The semantic match that finds this problem is follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
expression i,f;
position p1,p2;
@@
(
(<+...i++...+>) = ...;
|
(<+...++i...+>) = ...;
|
(<+...i--...+>) = ...;
|
(<+...--i...+>) = ...;
|
i = <+...f(...)...+>;
|
i@p1 = ...;
(
i = <+...i...+>;
|
i = <+...f(...)...+>;
|
i@p2 = ...;
)
)

@@
expression i;
position r.p1,r.p2;
@@

* i@p1 = ...;
i@p2 = ...;
// </smpl>

Change-Id: Ifacb878d58486f2645560592484ce24b2bc0bd6f
Reviewed-on: https://gerrit.libreoffice.org/9968
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-06-30 07:06:29 +00:00
Michael Meeks
546c7baec7 vcl: don't do expensive desktop probing in headless mode.
Change-Id: I10d6493997b4f3bfab769340c990c01a26f3da20
2014-06-28 14:37:24 +01:00
Michael Meeks
115fd951e9 Avoid loading persona images in headless mode.
Change-Id: Ie3bb69d93b97deab0830c2b45ba3428a8931a949
2014-06-28 14:37:21 +01:00
Stephan Bergmann
852c8e53d7 create_SalInstance does not need an oslModule parameter
Change-Id: I658974102f544185bf27f985bc920d8d54b40656
2014-06-27 18:15:55 +02:00
Stephan Bergmann
4c6e54a194 loplugin:unreffun: redundant function redeclaration
Change-Id: I6c9b85ab587f6fb9f585c9714c3a1076f627c7d3
2014-06-27 18:08:25 +02:00
Caolán McNamara
641154c259 Resolves: fdo#65634 improve wheel-scrolling sidebar panels
Change-Id: I213d85a1e2bbd2377f6f0326433ddd57dc346721
2014-06-27 14:42:19 +01:00
Caolán McNamara
2b9ad2ef6b do what I mean, not what I say
Change-Id: I1c86ff5713401771d6002de0a26bad4430d271fd
2014-06-27 13:31:58 +01:00
Caolán McNamara
d1a185f3af send wheel scroll events of disabled widgets to its enabled parent first
on scrolling with the wheel scroll if the pointer ends up over a disabled
widget then the event doesn't go to its parent and so the scrolling
halts unless the window happens to be the focus window

Change-Id: I57566b5c6e395e0f62d6b928f28e47a0c3486d65
2014-06-27 13:24:38 +01:00
Caolán McNamara
d781e874e0 bah, const issue
Change-Id: If7fd95287ba1a28e7b5f5440776859b912d6ad6e
2014-06-27 09:05:53 +01:00
Caolán McNamara
986c0451d0 Resolves: fdo#80160 PNG with 1-bit colormap only show black and white
Change-Id: If0c9950c18e6091fafea47954a4654db436a3a44
2014-06-27 08:55:57 +01:00
Caolán McNamara
7af733d9ef tweak assert so comment appears in abort message
Change-Id: Ibf78e5cd1620f0b61cae030e3870be4a6f87e71d
2014-06-27 08:55:56 +01:00
Stephan Bergmann
03d4d4b3f2 loplugin:unreffun
Change-Id: I2afc1cd5ed813f768f06ad0db651fb9e8e81d844
2014-06-27 09:13:00 +02:00
Caolán McNamara
587f178ba4 clang: Value stored to 'nSumG' is never read
yikes, well that was a worthwhile exercise

Change-Id: I454c16ce8b307abfdd2db3d2e38f4d36fba429fa
2014-06-26 16:29:16 +01:00
Caolán McNamara
daa6898578 clang: Dead initialization
Change-Id: Ieae5303e55f21044ef8e91e63c4896696cfad51c
2014-06-26 16:29:15 +01:00
Caolán McNamara
4079089d0a clang: Dead increment
Change-Id: I231218ab7a7984943470b62339e34801fb5fb9e3
2014-06-26 16:29:15 +01:00
Caolán McNamara
cd29cab883 check for self-assign
Change-Id: I6ffaaa36f2e594a2e8155589a4d7000db21ab30b
2014-06-26 16:29:13 +01:00
Caolán McNamara
be9d65bb5f Related: fdo#33455 retain color on scaling of 1 bit depth pngs
Change-Id: I445ce672742ddb6d6592ef419bf5e14c5f09a5b5
2014-06-26 16:29:11 +01:00
Herbert Dürr
aeeb125c4d Related: #i122471# make the Mac lookup feature handle the correct word
(cherry picked from commit 0a4564b42de0fc61253ae4e69039860c09e53eba)

Conflicts:
	vcl/osx/a11ytextattributeswrapper.mm

Change-Id: I786815feb847a2a340d2e3d24c9a8a01bb7ace7c
2014-06-26 16:29:11 +01:00
Michael Stahl
0bb6fd2f3a vcl: MSVC can't link inline ITiledRenderable dtor
Change-Id: Idbb776de489e0c6e6ae14cb65907ac75cfca3851
2014-06-25 17:19:36 +02:00
Andrzej Hunt
cd1f3480a6 Fill the alpha channel by default for vcl 32-bit bitmaps too.
Otherwise the alpha channel for bitmaps created directly is empty,
indicating a transparent bitmap (although we don't actually handle
transparency). This complements hardcoding of the alpha channel
in basebmp. VCL bitmaps can be copied bit-for-bit directly into
a basebmp bitmap, hence it's important to make sure we fill the
alpha channel in vcl too.

Conflicts:
	include/vcl/salbtype.hxx

Change-Id: Icb2fa417db6625a6ffa6bd82eb5773ff75be5a3c
2014-06-25 13:04:30 +01:00
Andrzej Hunt
56fea375b9 Allow passing in external buffers to svp's VirtualDevice.
We also want to be able to set whether or not the buffers
should be painted to top down, so add that parameter
as necessary (default seems to be false, however e.g. gtk
requires this to be true, i.e. needed for tiled rendering).

Change-Id: Id98882e4c7f62508ae5a976c0d8df743460a4ab2
2014-06-25 13:04:29 +01:00
Andrzej Hunt
e82d491263 svp: deduplicate bitcount->colourspace mapping and allow overriding.
Although svp defaults to BGR, we might want to use alternative
formats (e.g. for tiled rendering to bitmap buffers which are
to be used in e.g. gtk), it is probably safest to keep the current
defaults but allow the user to change to whatever format they may
require. (This currently only makes sense for the 32-bit
RGBA/ARGB/etc. formats. However the 23 bit formats could potentially
be expanded to allow a similar RGB/BGR choice.)

Change-Id: I70bd3d6e7d297faef163b910f576655efee4cb3f
2014-06-25 13:04:29 +01:00
Andrzej Hunt
0434043aed Return a bitmap buffer for tiled rendering from LibLO.
We still need some way of managing the buffers properly rather
than just keeping a static reference to the last buffer
that was rendered.

Change-Id: I17940c758948aa9418f4e0216ecd253d128cd04f
2014-06-25 13:04:28 +01:00
Noel Grandin
290b7e0632 remove use of register keyword in C files
C compilers have been ignoring it for the last decade

Change-Id: I42918263121dd189bab9d27077798b779b9e8da1
Reviewed-on: https://gerrit.libreoffice.org/9873
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-24 15:30:16 +00:00