mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

16795 Commits

Author SHA1 Message Date
Noel Grandin
e2080e70fe new compilerplugin returnbyref 
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
 2014-06-24 11:34:21 +02:00
Joren De Cuyper
171efcb7ac fdo#76203 - use consistent titlecase for UI title labels 
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9
Reviewed-on: https://gerrit.libreoffice.org/9858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-23 09:01:25 +00:00
Herbert Dürr
5232d01ee5 Resolves: #i124970# fix DocumentFocusListener::notifyEvent's... 
handling of IndexOutOfBoundsException

the DocumentFocusListener::notifyEvent() throw list only allows a RuntimeException to
propagate. The methods called in notifyEvent() allow IndexOutOfBoundsException though,
so it must be handled in all cases to prevent C++ from invoking its unexpected() abort
mechanisms. Ceterum censeo, non-empty throw lists should be removed altogether...

(cherry picked from commit 4da0e442f0fd4838e93e7316c24cfeef9289207d)

Conflicts:
	vcl/osx/documentfocuslistener.cxx
	vcl/unx/gtk/a11y/atkutil.cxx

Change-Id: Ie0b783832314ee5ec376a0c3c2cd67e4a70e218b
 2014-06-23 09:56:57 +01:00
Stephan Bergmann
0b350e841d Avoid overflow 
Change-Id: Iedcde3411a1bfeb1eb0207f572c8befe2071f54c
 2014-06-19 18:16:11 +02:00
Stephan Bergmann
47088ac9a0 Missing SolarMutexGuards 
...as can be seen e.g. with CppunitTest_dbaccess_dialog_save:

vcl::DisplayConnection::start
Application::GetDisplayConnection
Window::GetDragSource
Window::GetDropTarget
(anonymous namespace)::VCLXToolkit::getDropTarget
(anonymous namespace)::Frame::implts_startWindowListening
(anonymous namespace)::Frame::initialize
(anonymous namespace)::TaskCreatorService::implts_createFrame
(anonymous namespace)::TaskCreatorService::createInstanceWithArguments
framework::TaskCreator::createTask
framework::Desktop::findFrame
framework::LoadEnv::impl_loadContent
framework::LoadEnv::startLoading
framework::LoadEnv::loadComponentFromURL
framework::Desktop::loadComponentFromURL
unotest::MacrosTest::loadFromDesktop
DialogSaveTest::test
...

Change-Id: I9523ea47cab23d1f23f73a37d2d44453aa7d56a3
 2014-06-18 15:51:27 +02:00
Douglas Mencken
47b520024a fix 'NSWindow' may not respond to '+windowNumbersWithOptions' 
conditionally reverts 1b89f986f0e7e6303c4e44cb1ca5d42a5c78c8d4

Change-Id: I13aa24286dab52c9e4af798c8b6d9bf407bb7069
Reviewed-on: https://gerrit.libreoffice.org/9760
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-18 12:40:39 +00:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Caolán McNamara
fc2a0de936 turn the no-space edit widgets into a editwidget feature 
especially because most of them don't handle intercepting text getting *pasted*
into them right, so start with the one which does that right.

Change-Id: If6770798872ed3c72c469656ebf0d4fd76d2171d
 2014-06-16 16:59:09 +01:00
Douglas Mencken
a2ee38ef7a fix keyboard input on OS X < 10.6 
Since commit e4dc93f5, LibreOffice just beeps on any key press:
it's impossible to add symbols by using keyboard. This patch
fixes that.

conditionally reverts e4dc93f5d8d0df50f1a8b4594220d0c57703e03d

Change-ID: Id30e30775c0d0224954b8a1f05fd0d8d5f39cd4e
Reviewed-on: https://gerrit.libreoffice.org/9793
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-16 12:30:38 +00:00
Matúš Kukan
97dae845c2 Use proper name also when libmerged is used. 
gb_Library__get_name was forgotten in
1817366cb5f61337b34b5284615d3d4e0a8aa68a

Change-Id: I42592d70455b9c695879d7fa20881c77a1ca2066
 2014-06-16 10:33:42 +02:00
Caolán McNamara
8d373129e9 callcatcher: update unused code 
and strip away some stuff in rsc that should now be dead

Change-Id: I6411e706c50dff299099680f1f942bf61c4e79f2
 2014-06-15 20:30:39 +01:00
Douglas Mencken
4af1b78954 workaround for kCTForegroundColorFromContextAttributeName unavailability 
fixes "error: ‘kCTForegroundColorFromContextAttributeName’ was not declared in this scope"

see commits:
  5bc5387669bca8a0b410e295b0992fd2424a1536

Change-Id: Ifdf69ab2f9a6437d18a6d3e3f5d756beeed3ba5c
Reviewed-on: https://gerrit.libreoffice.org/9758
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-14 14:52:32 +00:00
Tor Lillqvist
b8bee05dbf Don't use the CoreUI private framework when sandboxed (i.e., for App Store) 
This conditionally reverts 0c7e6080519014f1fb345ed25e2f12c9a043b3ae.

Change-Id: I462016cd43c489fced7fb3739aa98c521d52f78e
 2014-06-13 21:07:58 +03:00
Stephan Bergmann
66d40a1fcc loplugin:staticcall 
Change-Id: Id5c17212031b6710f38413c833c0df2b33f42475
 2014-06-13 18:41:45 +02:00
Stephan Bergmann
17b1cf0a03 loplugin:staticcall 
Change-Id: I16195f2278ae67f17db55e02bb38fe3c5cd063be
 2014-06-13 17:54:36 +02:00
Douglas Mencken
e509b9303b fix build error "error: NSPrintJobSavingURL was not declared in this scope" 
see commits:
  c5c317ed20933c6508b35c34039df31669943f1c

Change-Id: I3a886bde11dc3620cffeb3e2e579c7b37285d9c5
Reviewed-on: https://gerrit.libreoffice.org/9759
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-13 08:54:06 +00:00
rbuj
7b832d545a 'NSNoUnderlineStyle' & ‘NSSingleUnderlineStyle’: Deprecated in OS X 10.9 
Change-Id: If18df0c06a1bdec5ea54307f9c452a1edf533e15
Reviewed-on: https://gerrit.libreoffice.org/9740
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-12 13:06:49 +00:00
Stephan Bergmann
9885c35ddb Avoid undefined left shift of negative value 
Change-Id: I6496a16c4d6791af43a67dae57b9ee218c3444fe
 2014-06-12 08:31:01 +02:00
Palenik Mihály
f188c982d5 Convert RID_SANE_DIALOG to .ui 
Change-Id: I1f08493cdc18f4c0691a8436368432fe4e94dec3
Reviewed-on: https://gerrit.libreoffice.org/9696
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-11 13:27:30 +00:00
Caolán McNamara
c8d8bcf3fd callcatcher: update unused code 
Change-Id: Iee19af81c648cb82074d8cabc13716b0d38c7ff6
 2014-06-11 10:47:30 +01:00
Jan Holesovsky
2a649539b7 MetafileXmlDump: No need to specify the stream, simplify the API. 
Change-Id: Ia08f67e359bbd26cefdba8661f0b0c4ae2147382
 2014-06-10 19:33:12 +02:00
Baptiste Daroussin
a5a17ccdbc Filter out OS not needing -ldl 
Change-Id: I5863de6d8b1f0fe2419ea7419b1ff90087bb513d
Reviewed-on: https://gerrit.libreoffice.org/9715
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2014-06-10 17:25:04 +00:00
Caolán McNamara
59e9619ef9 coverity#1222225 Division or modulo by zero 
Change-Id: I9a60114833c22d498dbb6258fcb2ceac22c72751
 2014-06-10 16:08:02 +01:00
Caolán McNamara
10eceebd22 coverity#1222226 Division or modulo by zero 
Change-Id: I45cbb8dbf2b9e7be6e8dda8603c2ef5f88507d04
 2014-06-10 16:08:01 +01:00
Caolán McNamara
2fbacba254 coverity#1222227 Division or modulo by zero 
Change-Id: I96b74d164a582cac13c419267879619e6986d71f
 2014-06-10 16:08:01 +01:00
Caolán McNamara
07dc4bc71b coverity#1222228 Division or modulo by zero 
Change-Id: Icc2bc53a14503f723977dc62252f23327de2dc0d
 2014-06-10 16:08:01 +01:00
Caolán McNamara
434546a28d coverity#1222229 Division or modulo by zero 
Change-Id: I97fd23d19a96665b91154ed260c677f0f76fee47
 2014-06-10 16:08:01 +01:00
Caolán McNamara
f658532d2c coverity#1222230 Division or modulo by zero 
Change-Id: I98ccd214be79f3d95c023fd5134d09c1cff3ee32
 2014-06-10 16:08:00 +01:00
Caolán McNamara
c7661d5af5 coverity#1222231 Division or modulo by zero 
Change-Id: Id914167a72782741e67ba97683445aec6151fdd6
 2014-06-10 16:08:00 +01:00
Caolán McNamara
da62285f6b coverity#1222232 Division or modulo by zero 
Change-Id: I4a3921df8e6510a37702ae8bd4856ba43c98213a
 2014-06-10 16:08:00 +01:00
Caolán McNamara
aaaf24322e coverity#1222233 Division or modulo by zero 
Change-Id: I699dc60b67d9417a8ac3848c03d7352f9f8ff12d
 2014-06-10 16:08:00 +01:00
Caolán McNamara
b311aab85f coverity#1222234 Division or modulo by zero 
Change-Id: I2832f99c1b4117d1c6d4621f25339e5921d26cb1
 2014-06-10 16:07:59 +01:00
weigao
29eceedd7b Modified the depth bit to 24 
Change-Id: I57387f9250c0c62c3cab7a75571d001fef99fdb4
 2014-06-10 15:58:25 +02:00
Caolán McNamara
d7cd613067 titchy tweak 
Change-Id: Ia28447cf35ceb550778297dc515746e93c7d86e4
 2014-06-10 10:48:43 +01:00
Caolán McNamara
e77a2cb2f8 coverity#1222236 Resource leak 
Change-Id: Iadd6621cebe9426c7c54c81f584b9c6766157f56
 2014-06-10 10:48:40 +01:00
Michael Stahl
f5111df1f4 libabw,libfreehand,libvisio: avoid some quoting issues 
With Win32 make there are problems with the sed expression.

Change-Id: I6d7fe52a233ef88a43ee1b6e3378fcb7b0792d07
 2014-06-09 17:05:51 +02:00
Michael Stahl
1817366cb5 gbuild: remove config_libraries.h and gb_Helper_generate_config_libraries 
This much ugly complexity, generating a header on every gbuild startup
etc. is really not warranted for 6 callers of the generated macros.
Also, the Win32 make has problems with the quoting.

Change-Id: If945e09c1730e52174a6084677842dc611d66b2f
 2014-06-09 17:05:50 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Markus Mohrhard
baf7b38e38 fix Werror 2014-06-07 07:14:39 +02:00
Markus Mohrhard
af8ebb607c remove debug output 
Change-Id: I7c56adf0cd91f6474145708d91988c974e1ea854
 2014-06-07 04:48:16 +02:00
Thomas Arnhold
c2034f3993 fixincludeguards: fix include guards 
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-06-06 19:16:40 +00:00
Oliver-Rainer Wittmann
adb1bb21f8 Resolves: #i125000# check last status of newly created... 
<Gdiplus::Bitmap> instance before using it.

(cherry picked from commit b127235917610b9c68e19df29bb39af496906569)

Change-Id: I97364cf963424b0e8d0b52b3c995bd4defdca067
 2014-06-06 16:40:17 +01:00
Caolán McNamara
4d33acbfbd coverity#708896 Unused pointer value 
Change-Id: I8cb1d720a8fb22ba2153c5f556e4bd538f5ea8af
 2014-06-06 14:11:12 +01:00
Caolán McNamara
4c4901893f coverity#708898 Unused pointer value 
Change-Id: Ida87450bda99260d9e153bb9e48d8867f53d42ca
 2014-06-06 14:11:12 +01:00
Caolán McNamara
6407a1bd80 coverity#708901 Unused pointer value 
Change-Id: Idb9be9f594b9ab3d1837c003d4a748f9693f5ceb
 2014-06-06 14:11:11 +01:00
Caolán McNamara
8c94cd4451 coverity#1213364 Untrusted pointer write 
Change-Id: I63c670e6f2196f8e8743923b0a0bf676fb476ed7
 2014-06-06 10:15:25 +01:00
Caolán McNamara
44f4220487 use sfntLen in DumpSfnts to do some sanity checking 
Change-Id: Ic3b196f925a1699f02ad9a5c1183ea767e3e91cf
 2014-06-06 10:07:26 +01:00
Caolán McNamara
623b4e3e10 improve this sanity check 
Change-Id: If202723412b2bf7acf7dcd2709886f89df9d7940
 2014-06-06 10:00:21 +01:00
Caolán McNamara
b4a0104849 pass sfntLen to DumpSfnts etc so sfntP reads can be checked 
Change-Id: I5d8092eceb31ba251e75fe2c51b87890b8adcbf2
 2014-06-06 09:45:57 +01:00
Stephan Bergmann
f3758b71d9 If no bounds can be determined, assume some reasonable defaults 
(instead of the twisted huge values with which aBound got initialized)

Change-Id: Ic6fe08639287eb7b5a0520aef8d2a0d43d61c035
 2014-06-05 18:32:30 +02:00