Drag'n'Drop is handled in a second thread, which tries to "yield
the display" while the main Qt thread probably is already
yielding. Both need the YieldMutex, which freezes the application
until the D'n'D thread times out.
Trying to yield the display throught the application yield
results in a recursive loop.
So this catches and breaks the recursion, but just inside the Qt
thread, so other processes can "yield on the display", instead
of simply disabling the Display::Yield.
Change-Id: Ifba91aa89fe5b0a89cc94820935dc996a065112f
Reviewed-on: https://gerrit.libreoffice.org/6750
Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
The "2" part was a temporary measure so an older version of the file,
that is long gone, can coexist.
Change-Id: I3a22b287bfb1351bb73e9dabbfa67100fe17bb97
It is unclear why the modified flag should ever be blindly overwritten hence
we no longer touch the modified flag here. (This change appears to have no
undesired side-effects.)
Change-Id: I246eb7d84249794fa4d52fcd9b008d8340bbc82d
Reviewed-on: https://gerrit.libreoffice.org/6632
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
Commit 840a8573c8 (Fix fdo#70220
Superscript not imported from pptx., 2013-10-07) made it possible to set
CharEscapementHeight even if moBaseline is not set, but this causes
problems in the docx importer + not necessary, according to the bugdoc;
so just don't do that.
Change-Id: Ib95ac449bd8fdf6376261ddc86108f0d23f2200e
TDF has been shipping a CoreText-using LO since 4.1 and the sky hasn't
fallen. Getting rid of the ATSUI code will make other needed
refactoring easier.
Change-Id: I494096c3988ea26fa2b336621857d32b64b040f0
This is similar to commit d5c934d150
(n#792778 DOCX import: parse group shapes in oox only, 2012-12-14),
except that was for the VML importer.
The only difference is that in case of drawingML,
OOXMLFastContextHandlerShape::lcl_createFastChildContext() is only
called for the children of the group shape, not for the element itself,
so compare against the start token, not the current element.
Change-Id: Iddeabb20bbd5f0153e2fc4e6df463830126fdd37
The new Writer template was supposed to use the Liberation fonts: http://nabble.documentfoundation.org/Default-Writer-Template-td4076271.html
So I changed the defaults to prefer them over their MS equivalents. When they are not available, they will be substituted as used.
This should not cause problems since the Liberation Fonts have the same metrics as Times, Arial and Courier New.
Change-Id: I00dc14db2aee3b6f57eec7b6f93b69fcf8e5c2cc
Reviewed-on: https://gerrit.libreoffice.org/6886
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
They were used to build metrics for printer built in fonts, which was
dropped in the previous commit.
Change-Id: Id9fb3108facec61eb6de0a2d16546f1187465e50
Reviewed-on: https://gerrit.libreoffice.org/6861
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This was only used for printer built in fonts, which was dropped in the
previous commit.
Change-Id: Iff62786284470ff3873c8d4b0aae0614bf69c7f3
Reviewed-on: https://gerrit.libreoffice.org/6859
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
The so called printer resident fonts is a relic of a bygone era, when
life was simple and there was only ASCII and Type1 fonts.
It is just broken by design these days, offers nothing useful and can go
wrong in many ways. Since 1f3a91cf2a this
"feature" is disabled by default anyway, so scrap this code to make room
for some long due cleanup.
Change-Id: Id124b2cad1a484099701a885c4d96e6a12af8d9a
Reviewed-on: https://gerrit.libreoffice.org/6858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
They are used at same conditions, and hatchwindowfactory just have
four files, so we don'y have any reason to keep them separated.
Change-Id: Iae3bb26ab1e95a309bf0d83c4ef17a0bf0261179
Reviewed-on: https://gerrit.libreoffice.org/6811
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
...where it is correct and 336353a87e "Related
rhbz#867808: More apparently bogus 'throw new ...' in C++ code" had changed it
by accident.
Change-Id: Id7fc1adf8c0068a3b59794d156b21f68b5ac7e72
Regression from 02bfed8a53 (convert
sw/source/filter/ww8/*.cxx from String to OUString, 2013-10-14), check
for string length before invoking OUString::operator[].
This can be reproduced if copy&pasting some text inside a Writer doc
from normal text to rectangle shapes inside group shapes.
Change-Id: Ia8f774b27ca63773792e6af913dfe7e493bea4b8
The original commit was eb56848029
"convert SwInterHyphInfo from xub_StrLen->sal_Int32"
My first attempt at fixing the commit was
a073e81c3a.
This is the second attempt.
Change-Id: I030c0a3107e1321006744473efe3ca3341251ad4
from old, probably dead code. Completely untested. But at
least it's not in my grep results anymore.
Change-Id: I9d917d0558bcab25a48fa36140beaa92150b62c9
The SharedString stored at ScQueryEntry::Item was constructed from an
OUString passed from ScMatrixValue::GetString() so
rItem.maString.getDataIgnoreCase() in QueryEvaluator::compareByString()
was NULL and never evaluated equal. Made ScMatrixValue::GetString()
return a SharedString instead.
Change-Id: I473d5724dfb97707fea58e6b72b1396c049b79c8
... to keep the count updated, which actually silences the dbgutil
warning of ScDocument::RemoveFromFormulaTree() when loading .ods
Change-Id: I8453d688ca673a47fee15c84478262e1da53e408
