399369 Commits

Author SHA1 Message Date
Caolán McNamara
98fd6fa45f micro opt
Change-Id: I4ef86a56780cf9ea8fe244a5347a79099bc05979
2016-11-10 16:15:45 +00:00
Maxim Monastirsky
749fe62b32 tdf#103826 Missing master page pane context menus in Draw
Change-Id: I355e9507692e770063a91d05efd3ebc3e2671d57
2016-11-10 17:59:09 +02:00
Tor Lillqvist
59547a5495 More work in progress on XAdES compliant ODF signing
Pass an XAdES flag to a couple more functions and adapt to that.

Factor out writeDigestMethod() and writeSignedProperties() from
OOXMLSecExporter::Impl to DocumentSignatureHelper and use them in an
additional place.

Write xd:UnsignedProperties with EncapsulatedX509Certificate. Probably
much more work needed.

Change-Id: I2a0cd1db6dd487b9c7ba256ad29473de3d271cd8
2016-11-10 17:52:01 +02:00
Stephan Bergmann
2d2160bbbd Adapt sd.screenshot
to b1164b07f9fdcd06a77dbdd74d45245a7c42c93e "loplugin:constantparam in sd"

Change-Id: I5e03c9ab19af630cdc536fddcb2f39815084b714
2016-11-10 16:12:50 +01:00
Dennis Francis
06d3294502 Refactor ScAttrArray for tdf#50916
For a default column, now ScAttrArray does not store the default
format. So the case of default pattern from 0 to MAXROW is represented
as nCount = 0 and pData = nullptr in ScAttrArray.

A new ScAttrArray object (aNextColAttrArray) is introduced as a member
of ScTable. This is used to store the formatting of *unallocated*
columns (whose indices are from aCol.size() to MAXCOL).

In next patches for this bug, I plan to refactor table*.cxx functions
related to formatting such that :

1) In formatting setter functions, if colspan of the input range
   spans the colrange(aCol.size() to MAXCOL) then instead of
   allocating columns, apply that formatting to aNextColAttrArray.

2) In formatting getter (const) functions, if requested colspan has some
   intersection with the colrange(aCol.size() to MAXCOL) then use the
   formatting info stored in aNextColAttrArray to calculate the formatting
   of the input range.

3) In general setter (non-const) functions if we really need to allocate
   new columns (example, when data is entered), use the formatting info
   stored in aNextColAttrArray to create pAttrArray of the new column.

Change-Id: Ieb56f853209b396d92fdb2c27e39361703576423
Reviewed-on: https://gerrit.libreoffice.org/27828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-11-10 15:11:28 +00:00
Marina Latini
5e416099f0 Windows 8 driver blacklist
Blacklisted intel driver for graphics card Intel(R) HD Graphics 4000 for Windows 8.
With this card LibreOffice won't start.

Change-Id: I3f4e04da7b4d61bddb1e755771b6a9538b596c51
Signed-off-by: Marina Latini <marina@studiostorti.com>
Reviewed-on: https://gerrit.libreoffice.org/30754
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-10 14:54:03 +00:00
David Tardon
bae1e2467e WaE: unused variable
Change-Id: I44fcadbf34677887853324e15cc46388f6f55448
2016-11-10 09:36:16 -05:00
Caolán McNamara
ec6fc7a606 Resolves: rhbz#1342828 toolbars jumping around while moved under X
because the start move by wm conflicts with the manual efforts
to position the toolbar.

the move by wm was done to get wayland to move the toolbars, but
(gnome#768128) supporting docking toolbars under wayland is futile
as far as I can see

Change-Id: I502d4617efaf1eb686469e100224e56104ad650d
Reviewed-on: https://gerrit.libreoffice.org/30751
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-10 14:27:39 +00:00
Justin Luth
70f41634d0 tdf#67379 - sw: treat clicking h/f-fly the same as any other
Why should clicking on a frame/image in a header act any differently from
a one insde the text body?

(The only time frames (or any kind of fly) required a double click occured
when switching from inside a header to a body-fly or from inside the body
to a h/f-fly. This patch removes that oddball corner-case.)

Now all frames are handled with a single click and there will not be
an impact on double-clicking anymore.

regression caused by 7e2f98d0a0c4a0f36a94353a256e7cc5caa3113b and its
prior commit which say:
> Header/Footer: fixed click on frames over the header/footer area.
> The main problem here was due to the click to show the separator when
> there is no header or footer under the frame. That code was just exiting
> MouseButtonDown too early, which isn't good.

> Now, double-click actually selects a frame anchored in header/footer.

confirmed that single-clicking on frames over the header/footer section
still shows the header blue-line.
Change-Id: I4770cfe7898202929742743931e22de8bf233b03
Reviewed-on: https://gerrit.libreoffice.org/30693
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-10 14:24:35 +00:00
Miklos Vajna
bec9e673ad xmlsecurity PDF verify: fix reading multiple subsections from an xref stream
This is especially needed, as we don't bother compressing updated
objects into sections on signing, we simply use a separate section for
each updated object.

Work towards supporting xref streams and incremental updates at the same
time.

Change-Id: Ie9759edbba816991615fafc6602cdd440141b989
2016-11-10 15:09:27 +01:00
Christian Lohmaier
7cde8def93 re-apply "use material style selection handles""
and account for the libreofficekit changes

This reverts commit 50e9065cbbb2c62fa925cf5b561a85c715a0eb1e.
that did in turn revert 4ae8c3c20bd4a10ba141a32f01e23ac63636f9c3.

Change-Id: Ie02d8743b3608120ed63bfe2a014fa4139577b01
2016-11-10 15:01:03 +01:00
Caolán McNamara
53bd86e096 Resolves: tdf#103815 Revert "use same GtkInstance::AnyInput impl"
cause of the reported regression, it seems extradinary that this
would cause that, but it seems to be the case and I have no interest
in debugging the undebuggable scheduler.

This reverts commit 180a0eac238ce456771ff20b8d3274b43408f54c.
2016-11-10 12:44:20 +00:00
Eike Rathke
1fed7ec4e4 clarify class documentation
Change-Id: I282a438159b9862034ba9fe4acdf87bf859b0465
2016-11-10 13:30:13 +01:00
Kohei Yoshida
6eb3d90aeb Avoid writing to the log for the same group twice.
This can happen when the group calculation is disabled and falls
back to non-group calculations.  And we only care about the first
entry in case of non-group calculation of grouped cells.

Change-Id: I545980acf8e35b4d0504aa2a77f86bdc85799e29
Reviewed-on: https://gerrit.libreoffice.org/30738
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-10 12:17:12 +00:00
Christian Lohmaier
50e9065cbb temporarily revert "use material style selection handles"
the linux build / libreofficekit also uses those and needs to be told
about this change as well.

This reverts commit 4ae8c3c20bd4a10ba141a32f01e23ac63636f9c3.
2016-11-10 12:21:19 +01:00
Christian Lohmaier
6e8b08f530 bump gradle/gradle-plugin to instant-run compatible versions
Change-Id: Ib0d2dac42814c9daf752f0421922fb093507eb7c
2016-11-10 12:15:50 +01:00
Mirek Mazel
f7b60a3819 refresh app icons to flat/material style
Change-Id: I0c0a8a540eccc022c405659f53da73bd87eced18
2016-11-10 12:09:23 +01:00
Mirek Mazel
4ae8c3c20b use material style selection handles
Change-Id: If42bf5757e2010fccc7061ccffda76048b2e0dda
2016-11-10 12:05:37 +01:00
Christian Lohmaier
3e522fcbaa demote "unknown android ndk" to warning only (and add 13.1 as known)
android studio/sdk manager doesn't provide a default way to install
multiple versions of the NDK, so typically only the latest one will be
available. Don't make configure error out in this case, but print a
warning instead.

Change-Id: I6af9a3f088daf7d12ebd9910286d7f44d264014a
2016-11-10 12:00:42 +01:00
Jean-Pierre Ledure
61f760d2c4 Access2Base - Code cleanup
Replace double code by function calls (dialog libraries handling)

Change-Id: I17fc700e47a258b281214fe29e075bc782fb6acd
2016-11-10 11:59:36 +01:00
Miklos Vajna
a1e40c3f85 Updated core
Project: help  02139162f541bb56ddbaf0a2d6142256a0454372

digital signatures: briefly document OOXML/PDF signing effort

It may be unexpected for users to see that OOXML files are always only
partially signed.

Change-Id: Ie7c6c553580a4eb38ed72c8a50b75f4b7902613f
2016-11-10 10:55:43 +00:00
Takeshi Abe
c024344c2f Wrap pointer to dialog with VclPtr
Change-Id: Ifaf0f45b12d983d556ca4c7e0b4a57c47ff38597
Reviewed-on: https://gerrit.libreoffice.org/30737
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10 10:51:59 +00:00
Stephan Bergmann
25edea0637 loplugin:staticmethods
Change-Id: Id7d7bb572466bcc803ac424cd8ddb64205a1c273
2016-11-10 11:50:02 +01:00
Stephan Bergmann
be8d620464 loplugin:stringconstant
Change-Id: I0eb2b9986840b1bd5bc892da23c56205047bc120
2016-11-10 11:48:04 +01:00
Stephan Bergmann
14544da21e loplugin:cstylecast
Change-Id: I6ec274c6c546f60c23fe639002d751f0a9f11d33
2016-11-10 11:38:27 +01:00
Jean-Pierre Ledure
bfbde8b418 Access2Base - Comments review
Change-Id: If7fb37a3656b55f7820698a59b8f1d8d8b14d594
2016-11-10 11:24:40 +01:00
Stephan Bergmann
6f180d095e Don't let multiple JunitTests operate in parallel on ScDDELinksObj.ods
...seen a failure of JunitTest_sc_unoapi_3 with

> checking: [sc.ScDDELinkObj::com::sun::util::XRefreshable] is iface: [com.sun.star.util.XRefreshable] testcode: [ifc.util._XRefreshable]
> LOG> Execute: refresh()
> LOG> starting required method: addRefreshListener()
> LOG> Execute: addRefreshListener()
> Method addRefreshListener() finished with state OK
> LOG> addRefreshListener(): COMPLETED.OK
> warn:unotools.misc:30768:84:unotools/source/misc/mediadescriptor.cxx:690: caught Exception "" while opening <file:///data/lo/core/sc/qa/unoapi/testdocuments/ScDDELinksObj.ods>
> warn:filter.config:30768:84:filter/source/config/cache/typedetection.cxx:455: caught Exception "Could not open stream for <file:///data/lo/core/sc/qa/unoapi/testdocuments/ScDDELinksObj.ods>" while querying type of <file:///data/lo/core/sc/qa/unoapi/testdocuments/ScDDELinksObj.ods>
> Method refresh() finished with state FAILED

and it appears that all of sc.ScDDELinkObj, sc.ScDDELinksObj, and
sc.ScIndexEnumeration_DDELinksEnumeration try to open that file (necessarily for
writing?), and the first two are in JunitTest_sc_unoapi_3 (so are executed
sequentially), but the last one is in JunitTest_sc_unoapi_4 (so may be executed
in parallel with the others), so that may be the reason for such sporadic
failure.  Easiest workaround appears to be to move the third test into the same
JunitTest as the other two...

Change-Id: Iefb94cf657bdc9c1eac92dd49ee6257eb5e80905
2016-11-10 11:13:33 +01:00
Wastack
21cc1826c7 WiP tdf#74172 use DECIMAL and NUMERIC data types
Change-Id: I917cdf6e8d3ebfa7c9e4a52ca61adc5b8707ecfc
Reviewed-on: https://gerrit.libreoffice.org/30447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-11-10 09:37:12 +00:00
Miklos Vajna
9357e99450 xmlsecurity PDF sign: use a predictor when compressing the xref stream
With this our xref stream output is close enough to Acrobat so that the
existing signature verifier runs without any problems.

Change-Id: I6eca7966890365759c269b465e4bf4d86d335219
2016-11-10 10:29:14 +01:00
David Tardon
7983c94622 start with a defined state
Change-Id: I7e77fcf2d120845b436b7d6220025fd5b339aafa
2016-11-10 10:24:08 +01:00
Stephan Bergmann
e2b62889c8 Don't let MODULE.all depend on MODULE.screenshot
...as that, somewhat surprisingly, causes 'make MODULE.all' do additional
targets that a plain top-level 'make' would never do.  See discussion in mail
thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2016-November/075797.html>
"[Libreoffice-commits] core.git: Branch 'feature/dialog-screenshots' [...]".

Change-Id: I460f3c91cf00d3398c61833fdcd5eaebdc87fbf2
2016-11-10 10:01:06 +01:00
Miklos Vajna
c67b55db4a writerfilter: remove never read m_xTableRange
Its last user was
writerfilter::dmapper::DomainMapperTableHandler::getTable(), removed in
commit 6ea66657ebca5b3ec63f93b496b812888e0d53c9 (loplugin:unusedmethods
writerfilter, 2015-07-20).

Change-Id: Ibaf536d4dd8f01f4413c3cec033db7438501e58c
2016-11-10 09:12:38 +01:00
Jean-Pierre Ledure
acfe27b404 Access2Base - Call GetLocale() only once
and not for each individual label

Change-Id: I7014be30569a275fa20faaa2ba9255d3968b70dd
2016-11-10 09:06:38 +01:00
Noel Grandin
ee0e713b53 make comphelper::sequenceToContainer a little smarter
so we don't have to specify the source type

Change-Id: I4106705a39874a8043f0f294a11374404d6cfc3a
Reviewed-on: https://gerrit.libreoffice.org/30713
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10 06:52:26 +00:00
Noel Grandin
5c2c2d8dc4 loplugin:expandablemethods in comphelper..cppuhelper
Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d
Reviewed-on: https://gerrit.libreoffice.org/30717
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10 06:51:53 +00:00
Noel Grandin
76c8336eec loplugin:expandablemethods in cui
Change-Id: I3dae1d142874c767ec1e32401acba0bbca95df5f
Reviewed-on: https://gerrit.libreoffice.org/30716
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10 06:51:17 +00:00
Gabor Kelemen
029a936aec Updated core
Project: help  9b126a4ef3798df131b29e064e9decabea812b5c

Remove the definition of plug-in

Change-Id: Iaa6501d50430a0a27c4535791b9e65ceaf75ec7b
Reviewed-on: https://gerrit.libreoffice.org/30735
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-11-10 06:22:58 +00:00
Gabor Kelemen
5fabbf5349 Updated core
Project: help  368c92d82e25d61746808d38afd3d5049f9bfe84

Remove one more dead plug-in menu item description

Change-Id: I5be88980aa527e5d03d4fcfd54dfd520a0b7b162
Reviewed-on: https://gerrit.libreoffice.org/30736
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-11-10 06:22:48 +00:00
Gabor Kelemen
bf0a230318 Updated core
Project: help  9f5f37dfe07c69e090d7b1cacfd56de91689834e

Remove embeds of the description of the Edit - Plug-in menu item

Change-Id: I57c83a56de0fe124f168adbcb7c4a3fdbd45d60d
Reviewed-on: https://gerrit.libreoffice.org/30734
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-11-10 06:22:02 +00:00
Gabor Kelemen
d5d6c92fb1 Updated core
Project: help  e91a6393a3b573906bd3184cafb5b94bb391af7e

Edit - Plug-in menu item was removed in 5.2

Change-Id: Ie3df8491c8002abf871c4ed311ef654d5d0b5849
Reviewed-on: https://gerrit.libreoffice.org/30733
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-11-10 06:21:47 +00:00
Gabor Kelemen
64e599d472 Updated core
Project: help  42dcc36e303f8b7a5d534fb3163e5c2a647560a3

Remove a page about plug-ins

This feature was dropped from 5.2

Change-Id: Ia2721ac34c816e11c1ce3982c604bb7af01c6da4
Reviewed-on: https://gerrit.libreoffice.org/30732
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-11-10 06:21:28 +00:00
Adolfo Jayme Barrientos
9d3d893f92 Updated core
Project: help  e4ffa2f2f3a457054e75ce9a41029b94b018d2d1

Another dead URL

Change-Id: Id313b2e262db1d699a52c1bdec9850587e3a5d83
2016-11-10 04:58:21 +00:00
Khaled Hosny
66bd5ef022 Use hb_script_t directly
Change-Id: I58c41ce2052371e20c8c84492124c5a687695ca6
2016-11-10 03:59:28 +02:00
Khaled Hosny
f6391d9696 Who would think sal_Int32 is not the same as int32_t
Change-Id: I107cf27ea36e092ba3be45d255cc8622eb1c726f
2016-11-10 01:48:29 +02:00
Khaled Hosny
f26df72f6e Typo
No idea how this ever compiled for me!

Change-Id: I7bfe5df755594448fbe6892873a7cedb2b235d98
2016-11-10 01:33:48 +02:00
Khaled Hosny
73b9b72cf1 tdf#103718: Correctly set vertical direction
Follow UTR#50 and set vertical direction based on character orientation,
not the resolved script.

Change-Id: I54f047e1720e8e4de14ce16a57e5d2d3f6cd2ca2
2016-11-10 01:01:55 +02:00
Khaled Hosny
f95018880f Add code to get Vertical_Orientation property
See http://unicode.org/reports/tr50/#vo

ICU does not support getting this property yet, so I stole some (heavily
redacted) Perl script from Mozilla that reads the data file and
generates property tables. The original Mozilla script:
https://dxr.mozilla.org/mozilla-central/source/intl/unicharutil/tools/genUnicodePropertyData.pl

Change-Id: I2800711c3db3564515139227bdbd3b4d732917eb
2016-11-10 01:01:55 +02:00
Khaled Hosny
58d149f3b4 Minor cleanup
Drop useless typedef and use more general nomenclature as I’m going to
extend this in the next commits.

Change-Id: I12aa01fe9f5a6c9aca67f850f36b81661ee14913
2016-11-10 01:01:55 +02:00
Tomaž Vajngerl
7446faec4e vcl: non-symetric image to test JPEG import
Previously we used a symetric image to test JPEG import. This has
the flaw that we doesn't warn if the orientation of the JPEG
image was not correct. This commit fixes this flaw by making all
test images non-symetrical.

Change-Id: If87d257ae44d85b6a9042d09d62ba785ffc5c426
Reviewed-on: https://gerrit.libreoffice.org/30709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-11-09 20:33:38 +00:00
Tor Lillqvist
db877a15d9 These functions don't even need to be XMLSECURITY_DLLPUBLIC
Change-Id: I8f2963c9b6b1c8717ea4d19453815fffa6e68484
2016-11-09 21:27:25 +02:00