Commit Graph

345981 Commits

Author SHA1 Message Date
Caolán McNamara
9a8a4b81b6 coverity#737502 Uncaught exception
Change-Id: I5f5b7244db311501af6ded863b4b1fa46e5a547a
2014-02-24 13:33:21 +00:00
Herbert Dürr
42837a066b Resolves: #i123840# prefer NSZero* constants over open coded alternatives
(cherry picked from commit a8c471a7003fdac7d5e1c97e903f669da6bcf0c7)

Conflicts:
	vcl/osx/salframe.cxx
	vcl/osx/salframeview.mm
	vcl/osx/salnsmenu.mm
	vcl/osx/salobj.cxx

Change-Id: I379d80355d741dd28aad2e6119a8b82ac10159f5
2014-02-24 13:17:37 +00:00
Caolán McNamara
93f3f72d18 coverity#737499 Uncaught exception
Change-Id: If4599fa76914b472ee6734f48941898f420519c3
2014-02-24 13:17:36 +00:00
Caolán McNamara
1a48456f8b coverity#737497 Uncaught exception
Change-Id: I1dc0acda818f1b520f74c282bdd17a195591e860
2014-02-24 13:17:35 +00:00
Caolán McNamara
146a5e95ad coverity#737495 Uncaught exception
Change-Id: I8a5e7111a0ddf1e651c25bd52c6af462d9075f93
2014-02-24 13:17:33 +00:00
Caolán McNamara
a3a227b5b8 coverity#737469 Uncaught exception
Change-Id: Ic090878483f2fbfc000bfc248bb52764e4e9727e
2014-02-24 13:17:32 +00:00
Caolán McNamara
6bc58bbd2a coverity#737458 Uncaught exception
Change-Id: Ida42725016395d9629bb97bd8cf0b660195c4f1c
2014-02-24 12:56:18 +00:00
Caolán McNamara
0a3526f61f coverity#737430 Uncaught exception
Change-Id: I1db24114b331970d75b01c0869708b1656be3836
2014-02-24 12:55:01 +00:00
Caolán McNamara
8fca5e299c coverity#737424 Uncaught exception
Change-Id: I8779bf79dd2342f183643767c4c424e7a5500cca
2014-02-24 12:53:51 +00:00
Caolán McNamara
6e0bdf04ad sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it
which means that icons suddenly reappeared in the menus when the gtk
theme had disabled them

ref e8f8f24c84

Change-Id: Ia9aef5ca39bda2ddf6d7c4ebc2bddc01d470d09b
2014-02-24 12:53:14 +00:00
Caolán McNamara
a8fad94ef2 coverity#737422 Uncaught exception
Change-Id: Ieca32131ad7b1019338af8042ab6905e3ba152d6
2014-02-24 12:53:14 +00:00
Caolán McNamara
4e2db965f9 coverity#737388 Uncaught exception
Change-Id: I55fd2311d6439a6f8616f9c21fa1e7222efde794
2014-02-24 12:53:14 +00:00
Caolán McNamara
b10fee9d8d coverity#737363 Uncaught exception
Change-Id: I29717d8379a69eede5ef44b57934c2fe70c04248
2014-02-24 12:53:13 +00:00
Caolán McNamara
e2abad8add coverity#737355 Uncaught exception
Change-Id: Ib6b54de2a02fedd42fa28155762b4d3c25957607
2014-02-24 12:53:13 +00:00
Caolán McNamara
687f46d608 coverity#737354 Uncaught exception
Change-Id: Iedbff972ef4fba9b0fa877db76a1e9b099223279
2014-02-24 12:53:13 +00:00
Caolán McNamara
4e95a50d8b coverity#737343 Uncaught exception
Change-Id: I5097c5c98580619d066ea928f1970cc6e7160783
2014-02-24 12:53:13 +00:00
Caolán McNamara
7d2d7b5e59 coverity#737340 Uncaught exception
Change-Id: I1549368658a5918fb16b58b614c2c789be94060e
2014-02-24 12:53:12 +00:00
Caolán McNamara
2e9d267c2b coverity#737278 Uncaught exception
Change-Id: I8b9c02d5e87433cb48a7cee37b696d36e453dd52
2014-02-24 12:53:12 +00:00
Caolán McNamara
484af8f1d2 coverity#737277 Uncaught exception
Change-Id: I4bb6964fb585a027ade3540456bf71bdf70d7662
2014-02-24 12:53:12 +00:00
Caolán McNamara
9ee8026d8b coverity#737274 Uncaught exception
Change-Id: I33a22974a9485e4556ed44f990d6d13a8901c511
2014-02-24 12:53:11 +00:00
Caolán McNamara
3907ef9e47 coverity#737273 Uncaught exception
Change-Id: Ib1e7ee8903c9b3e276c9244a6e4b67499f22c661
2014-02-24 12:53:11 +00:00
Caolán McNamara
50ffcf3bd5 coverity#737272 Uncaught exception
Change-Id: Ibab84222db96181b175f58625105af1237e48136
2014-02-24 12:53:11 +00:00
Caolán McNamara
5eb9477445 coverity#737271 Uncaught exception
Change-Id: I3275220925cc81ce5dbf507793e0d74cb88e2ab4
2014-02-24 12:53:11 +00:00
Caolán McNamara
f78dbca682 coverity#737270 Uncaught exception
Change-Id: I7f129c868034df3d56060cc870c335b36a1a6d4a
2014-02-24 12:53:10 +00:00
Caolán McNamara
3d5f2d13df coverity#737269 Uncaught exception
Change-Id: Ib6240c818c6f17df63693aa4fc4a4ca207df27b6
2014-02-24 12:53:10 +00:00
Caolán McNamara
9cbc3a2aa7 coverity#707304 Uncaught exception
Change-Id: I4384b87566d595ce47dd934e35c8bb9267d6cb1b
2014-02-24 12:53:10 +00:00
Caolán McNamara
e72f739393 coverity#707318 Uncaught exception
Change-Id: I65bfcbe4ab6fceed3ae474dcb3225df197ddaa2b
2014-02-24 12:53:09 +00:00
Caolán McNamara
662283db76 coverity#735810 Dereference after null check
Change-Id: I005ae6bf505fd2131c06e889f9fc3c12dae23c64
2014-02-24 12:53:09 +00:00
Caolán McNamara
e40a7f2e59 coverity#735808 Dereference after null check
Change-Id: Idd8ff57f5c970d15e199831bb1b1251ced32eeec
2014-02-24 12:53:09 +00:00
Caolán McNamara
b854cb787e coverity#735747 Dereference after null check
also

coverity#736774 Dereference before null check

Change-Id: Ic2e2a341565af0609ec748b40ac7848a46c9e3af
2014-02-24 12:53:09 +00:00
Caolán McNamara
819cc64318 coverity#735751 Dereference after null check
Change-Id: Id7e11fefec40d11c509bde01533122ca68db7402
2014-02-24 12:53:08 +00:00
Caolán McNamara
21cea08139 coverity#735801 Dereference after null check
Change-Id: I4a403098388bdb7f4f09242fcd71a50d38fc630e
2014-02-24 12:53:08 +00:00
Stephan Bergmann
13afdc0b14 warning C4805: '==' : unsafe mix of type 'sal_Bool' and type 'bool'
Change-Id: I3719401a0eb68ba9204be19c2dd4f93617bf097c
2014-02-24 13:32:44 +01:00
Jacobo Aragunde Pérez
9fab183d4d sw: Unit test for spreadsheets embedded in docx
Change-Id: I0a91ea0ca36d57320c3495a5cedba7924d3a7ea7
2014-02-24 13:26:58 +01:00
Jacobo Aragunde Pérez
1428ec6f4e sw: Preserve embedded spreadsheets in docx
Embedded spreadsheets consist on two files:

* The spreadsheet found in word/embeddings/ directory.
* A preview image found in word/media/ directory.

This patch saves these two files and writes the proper XML to the
document. It looks like this:

    <w:object>
      <v:shape id="ole_rId2"
      style="width:362.55pt;height:145.7pt" o:ole="">
        <v:imagedata r:id="rId3" />
      </v:shape>
      <o:OLEObject Type="Embed" ProgID="Excel.Sheet.12"
      ShapeID="ole_rId2" DrawAspect="Content"
      ObjectID="_227653443" r:id="rId2" />
    </w:object>

Some simplifications were done in comparison with the XML generated
by Word; the lines above seem to be the minimum working code.

Similarly to drawings, charts, etc. our code postpones the actual
process of the OLE objects until the rPr tag is closed.

TODO:
* Unit tests.
* Add information about xlsx extension to [Content_Types].xml
  * Without that, Word doesn't detect the OLE as an spreadsheet.

Change-Id: Ia0c797b72cd6e99ca9ad7fa11897b62ab3867a5e
2014-02-24 13:26:40 +01:00
Jacobo Aragunde Pérez
ad7fdc4e0f filter: Code reduction, prevents crash.
Not all shape types have the full com.sun.star. prefix, for example
FrameShape. The existing code would crash in that case, but the new
code doesn't.

Change-Id: I9aa3d0f20f48ab91a6770e8409a8da2028816504
2014-02-24 13:24:53 +01:00
Jacobo Aragunde Pérez
c69ae9f8f8 comphelper: EmbeddedObjectContainer::GetObjectStream methods
These methods were added to provide access to the stream to the
embedded object itself.

Change-Id: I0a47a54852cddbd5ddd0a6599bba21999afd96ba
2014-02-24 13:24:52 +01:00
Jacobo Aragunde Pérez
20a174ac12 comphelper: code refactor
Change-Id: Ica71d0691cf02aeaa03b6570015d9828cd7daeed
2014-02-24 13:24:51 +01:00
Douglas Mencken
d2a4872861 nss: continue delivering libsqlite on Mac OS X 10.5
Change-Id: Ibfd47071c73fc5f6c48d268a1f00d7f52762d0f2
Reviewed-on: https://gerrit.libreoffice.org/8204
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-24 11:40:21 +00:00
Douglas Mencken
407db3d915 Restore abandoned lines in bridges/Library_cpp_uno.mk
Fixes build error:
    bridges/Module_bridges.mk:29: *** no bridge selected for build: bailing out. Stop.

Change-Id: I1d173e75ade45878e53ed07758783bdb5a7370c8
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-02-24 12:33:41 +01:00
Douglas Mencken
8bf34faa1e Yet another one undefined comparison of 'const' and a 'non-const' iterators
Fixes:
    no match for ‘operator!=’ in ‘i != std::vector<_Tp, _Alloc>::rend() [with _Tp = rtl::OUString, _Alloc = std::allocator<rtl::OUString>]()’

Change-Id: I7b4ba07ebe51c73893a3d6b77dcf5681b7638efb
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-02-24 12:32:43 +01:00
Stephan Bergmann
130a2baa83 error: enumeral and non-enumeral type in conditional expression
Change-Id: I30293ac22fb26e0f7c9bfd335ccaa9a2d263d02f
2014-02-24 12:28:18 +01:00
Stephan Bergmann
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
Miklos Vajna
43d7f4e364 offapi: document the 4 new properties which are no longer read-only
Change-Id: Ia2844af91159bf4a512fcb70883fc6a1eddfce35
2014-02-24 12:16:14 +01:00
Miklos Vajna
7b9aa420d3 SwXShape: implement reading the Relative*Relation properties
Change-Id: I1e99a2ff08c83ac361ab001e90047d9b8d5524fc
2014-02-24 12:16:14 +01:00
Miklos Vajna
9fadea73d3 SwXShape: implement reading the RelativeWidth property
Change-Id: I40d451c170699ed7616c1159a354bd93444743c0
2014-02-24 12:16:14 +01:00
Miklos Vajna
4e0f9a35fa SwXShape: implement reading of the RelativeHeight property
Change-Id: I479eabcd45b741a633d7d00b2bdcbd3d0dcbf0ff
2014-02-24 12:16:14 +01:00
Stephan Bergmann
146c7c5c89 toolkit: sal_Bool -> bool
Change-Id: I5153c4413004d1b50cc503b3e70657bc831a5793
2014-02-24 11:13:42 +01:00
Tor Lillqvist
569756aaf4 Re-introduce code to try to get GDI metafile replacement image
The code was commented out in 2009 in CWS metropatch01_DEV300, with
any reasoning behind it lost in history, and then cleaned away in
2010. Re-introduce the bit that tries FORMAT_GDIMETAFILE. Seems to
work for data that produces a reasonably sized metafile. (For data
from an Excel "Select All" followed by "Copy", that puts a million
rows on the clipboard, good luck... Unfortunately when doing that in
Excel, sometimes you get a million rows, sometimes just the non-empty
relevant part of the worksheet.)

Change-Id: Ib5f1a989b65ad0a30194a1ed23f8b94dd3822cac
2014-02-24 12:11:48 +02:00
Jan Holesovsky
a13622923a Here the line made sense, bring it back.
Change-Id: Iba1c798edfe1b0eb5edcba904ceacec9174cacc6
2014-02-24 10:56:56 +01:00