This is used in parsing of meta Contexts across different
modules. This also involved moving to XFastParser for
parsing xml filters in sw, sd, starmath.
Change-Id: Ic663aaac6cb20ee8ce5b97cae87c93220f5a2929
Reviewed-on: https://gerrit.libreoffice.org/42989
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
...in efcb9a7078 "use sw::WriterMultiListener
instead of SwDepend in SwPageDesc", causing
> /sw/source/core/layout/pagedesc.cxx:198:74: runtime error: upcast of misaligned address 0xbebebebebebebebe for type 'SwTextFormatColl', which requires 8 byte alignment
> 0xbebebebebebebebe: note: pointer points here
> <memory cannot be printed>
> #0 0x2b06bea9116b in SwPageDesc::GetRegisterFormatColl() const /sw/source/core/layout/pagedesc.cxx:198:74
during e.g. CppunitTest_sw_odfimport of ASan+UBSan builds.
Change-Id: If50a920ca5dafdce6c1a3e2fbf540488685e641a
Previous fix 25cd843664 like any
other before it have some regressions, so reverted.
The root of most problems: fix for tdf#104141
d148340bab, where mask drawing
was implemented in bitmap drawing code.
So instead of guessing for type of bitmap, mask is drawn with
DrawBitmapEx resolving all known problems (tdf#114726, tdf#115297,
tdf#113918 and tdf#104141).
Change-Id: Ie00f7552d667e237b3c0f9505ee09cb51e85c43c
Reviewed-on: https://gerrit.libreoffice.org/50828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Project: help 770c0c1746b5c0b94dc07d5f1d6c2c04802c8540
tdf#116296 remove produt version from help path
Part two.
Part 1 is in sfx2 module
Remove product version from offline help path but keep
in online help.
Product version is kept for online because a help server can have more
than one helponline version.
Change-Id: I1d4ba12a7d6472defd4210c79349e35ccaf32d8d
Reviewed-on: https://gerrit.libreoffice.org/51126
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Part one.
Part 2 is in helpcontent2 module
Remove product version from offline help path but keep
in online help.
Test for existence of old offline help is done now
checking the presence of the file help/<lang>/err.html
Test for new (html) offline help is done now checking
the existence of the folder help/<lang>/text
Change-Id: I1d00a4eac6746f0ace5a40db56910803a5e0d6f4
Reviewed-on: https://gerrit.libreoffice.org/51127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
- give priority to IPA P Gothic and Noto Sans CJK JP
- for Windows, try Yu Gothic UI first, then Meiryo UI
- look for Hiragino Kaku Gothic ProN/Pro on macOS
Thanks to Jun Nogata and AWASHIRO Ikuya for their suggestions.
This addresses only part of the issue; another incoming change
will take care of the rest.
Change-Id: I1491ba63e1447d3b9086dfcfdf3981bee6282661
Reviewed-on: https://gerrit.libreoffice.org/50515
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Instead of a hard-coded check for (effectively) one project name
"LibreOffice" (which is build-time configurable), check for the string
"LibreOffice_project", which has been produced hard-coded ever since
LO 3.3.0.
This now recognises additional downstreams "LibreOffice_Vanilla"
and "Collabora_Office", and also historic "BrOffice".
An important point here is that the build-time configurable version
numbers of any downstream that retains the hard-coded
"LibreOffice_project" *MUST* be the same as the upstream's at least
in their major and minor versions (micro and further digits are
currently not used), and that such downstreams don't backport
changes with ODF export compatibility impact further than upstream.
Add a unit test too, with a representative sample of 4372 distinct
generators in bugzilla attachments.
This revealed that StarOffice 6 and AOO 4.0.1 were falling through
the cracks and not recognised, so fix that too.
Change-Id: I8105222d3428e7b20cc4a6b8e76732c697812594
Reviewed-on: https://gerrit.libreoffice.org/51171
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
According to:
<mst_> noelgrandin: apparently this code exists so you can export a text
frame as an image and then the urls in the text become
image-map links
which means that according to my analysis below, nobody has noticed the
removal in 17 years :-)
SwNoteURL::InsertURLNote was the last place that constructed an
SwNoteURL and it was removed in
commit bb7ade140d
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Wed Mar 7 13:42:58 2018 +0200
loplugin:unusedmethods
and SwNoteURL::InsertURLNote was dead because
void SwTextPaintInfo::NotifyURL_( const SwLinePortion &rPor ) const
was removed in
commit 73139fe600
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Fri Jan 19 13:10:22 2018 +0200
loplugin:unusedmethods
and SwTextPaintInfo::NotifyURL_ was dead because
void SwTextPaintInfo::NotifyURL( const SwLinePortion &rPor ) const
was removed in
commit be8c414567
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Fri Jan 19 09:13:03 2018 +0200
loplugin:unusedmethods also check for functions returning bool
and NotifyURL was dead because calls to it were removed in
commit 1b666235f6
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Wed Jan 3 09:08:52 2018 +0200
loplugin:singlevalfields improve copy constructor check
those calls were removed because the m_bURL field of SwFont was always
false.
tracing back, we find that m_bURL was called bURL before
commit b4e2a13f46
Author: Miklos Vajna <vmiklos@collabora.co.uk>
Date: Mon Oct 26 08:55:17 2015 +0100
sw: prefix members of SwFont
and we find that a method
void SwFont::SetURL(const bool)
that modified bURL was removed in
commit 407731c9f4
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jul 21 10:44:17 2015 +0200
loplugin:unusedmethods sw
and we find that calls to SetURL were removed in
commit da7671e4f7
Author: Andreas Martens <ama@openoffice.org>
Date: Thu Mar 15 14:59:12 2001 +0000
Opt.(FME): The new attribute handler makes a lot of code superfluous
which appears to be the root of the problem
Change-Id: Id2362ce216c06bc8dcf71698695d708eb494af4e
Reviewed-on: https://gerrit.libreoffice.org/51225
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
If nOverPos<i and i was last element, the next pOver=&rRange was
invalid, though not deleted because std::vector::erase() does not
reallocate.
Change-Id: I22d9302e2d45403dd47ac1947d2cf003b3a4f291
I’ve always suspected this check in VCL is wrong since Writer calculates
Kashida positions for Arabic only. If we *really* want to Kashida
justify Syriac, then Writer has to be first taught how to calculate
Kashida positions for it.
Change-Id: I20c03a3a54bce14c9bebb55426bd22537fe50d6a
Reviewed-on: https://gerrit.libreoffice.org/51223
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Also use the return value of the link's Call() [as the SvTreeListBox::ExpandingHdl()
is doing], the appropriate callbacks seem to return the expected 'false' in
the cases I've reviewed...
Change-Id: I0cdd63e8ec4c794839070b914150e0b32f743359
Reviewed-on: https://gerrit.libreoffice.org/51211
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Visual Studio 2015/2017 cannot handle that correctly, and emits a lot
of intellisense errors. So, just prepend the define with "ShellClass_"
Change-Id: I473ceb7e0a88e114b92e6342fd4ae63015cafd3e
Reviewed-on: https://gerrit.libreoffice.org/51135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
In docx a colour value is represented as a 6-digit hex RGB value, or
alternatively the word "auto" to represent automatic colour.
- Add support for reading the value "auto" as COL_AUTO. Previously
this would be read as if it were a hex value, stopping at the
letter 'u' which is not a valid hex digit, resulting in the colour
0x00000A - a very dark blue, which looks close enough to black that
it went unnoticed for a long time :-)
- Remove code which tried to handle this wrong 0x00000A value,
including the constant OOXML_COLOR_AUTO, as it is no longer needed
and will cause surprises for anyone who really wanted this exact
shade of dark blue
- Fix unit tests that were checking for 0x00000A
Change-Id: I6000070341931147ff9341ad6281cd3b53c02b46
Reviewed-on: https://gerrit.libreoffice.org/50995
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
