389403 Commits

Author SHA1 Message Date
Rohan Kumar
a32bfdfd28 tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals
I replaced OSL_DEBUG_LEVEL > 2 conditionals with OSL_DEBUG_LEVEL > 0
conditionals

Change-Id: Ibfb3a4e00da7ef6a213dcd4659c7963935cfad1f
Reviewed-on: https://gerrit.libreoffice.org/23081
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-11 11:45:15 +00:00
Giuseppe Castagno
30b9c6a457 tdf#98416: Explicitly disable curl hardcoded CA certificate store
Add --without-ca-bundle --without-ca-path options to curl configure
in Linux, to explicitly disable the hardcoded curl CA certificate
store.

If the store is not disabled, curl configure will try to find
one suitable for the Linux distro on which it's being built, leading
to possible problems when building on a Linux distro type while
targeting another Linux distro type (e.g. building on Red Hat
derivative targeting Debian derivative).

Change-Id: Id1ddf1d74e33bc66e4f7187e376d7379f5c4f36a
Reviewed-on: https://gerrit.libreoffice.org/23141
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-11 10:56:40 +00:00
Stephan Bergmann
b2d53cc003 typo
Change-Id: I8ae443a69aab715a59f347a2de5a36b458a934f5
2016-03-11 11:50:50 +01:00
Stephan Bergmann
feb480d780 Synchronize all access to _sync_counter, _passedAync
Change-Id: I34e9b3fb9481af30ddda8cde45ccbb27819fc452
2016-03-11 11:49:35 +01:00
Stephan Bergmann
86ce77b925 Don't adertise PresenterCanvas as com.sun.star.rendering.Canvas service
Window::ImplGetCanvas (vcl/source/window/window.cxx) tries to obtain such a
Canvas service (passing in 6 initialization arguments), and the CanvasFactory in
canvas/source/factory/cf_service.cxx apparently goes through the implementations
advertised to implement that service, looking for the best match.  At least for
Linux-rpm_deb-x86_64@70-TDF-dbg tinderbox, it somehow manages to pick the
PresenterCanvas (instead of one of the more obvious choices among the variants
in canvas/soruce/{cairo,directx,vcl}), but which only epects 5 initialization
arguments, so CppunitTest_cppcanvas_emfplus fails with a "PresenterCanvas:
invalid number of arguments" exception. (And the choice of the PresenterCanvas
looks more than dubious anyway.)

Normally, instances of PresenterCanvas appear to be created "directly" from
PresenterHelper::createSharedCanvas (sd/source/ui/presenter/PresenterHelper.cxx)
so it shouldn't hurt to no longer adertise this implementation as providing the
Canvas service---and it might not even be necessary to make it available via the
service manager at all.

Change-Id: Ie76bfc87fec51b6d5361930204e55ef9cb80370e
2016-03-11 11:47:02 +01:00
Miklos Vajna
6d42dc0e7c cppu: SAL_WARN_IF() -> SAL_INFO_IF() where it was dbglevel=2-specific before
As these fire already during the build.

Change-Id: I750ea04be317fffb8bc321a2b7b4da0447789c8f
2016-03-11 11:42:04 +01:00
Caolán McNamara
bcecf9b13b tweat ExtMargins with same recurse protection as Margins
Change-Id: I24640971ea6ca89878043966293492a991f01008
2016-03-11 10:39:24 +00:00
Stephan Bergmann
6aa5bdc371 ...and now it got included twice
Change-Id: I5cb7eda5a8dc1bddd3e76e1d3aae94f264d609d9
2016-03-11 11:09:22 +01:00
Stephan Bergmann
28fb13b473 Missing include
Change-Id: Ia99c17d90f66860bcd9ef6bb1732437e425a4a04
2016-03-11 11:08:28 +01:00
Caolán McNamara
849e78756b include memory
Change-Id: If91042b2a72b0dd70cc630e1140f602ac1b823d2
2016-03-11 10:07:28 +00:00
Xisco Fauli
1868a62a32 tdf#47446: SVGIO: Take markers' parents into account too
Change-Id: I41b7228ab5980581ab5e1c8c4d4d466da6045086
Reviewed-on: https://gerrit.libreoffice.org/23124
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-11 10:03:00 +00:00
Jan Iversen
00badb6fb5 update genLang (l10ntools)
Upgrade gLang to LO standard
Compilation of genLang module is disabled for now
activate manually by adding to Module_l10ntools.mk

Change-Id: Ib82cae6a013d10d158ec5faa81ace512c0096a39
2016-03-11 10:47:13 +01:00
Caolán McNamara
66fee51115 Resolves: tdf#98418 AttributeList must support XCloneable
regression from

commit 8998768a34751d35403678a81464a26835b2230e
Date:   Sat Feb 6 18:38:32 2016 +0100

Change-Id: I217fb66621505b77b6102954c07ef513e2d4b25e
2016-03-11 09:45:43 +00:00
Stephan Bergmann
8e94196776 Better fix for -Werror=shadow
Change-Id: I2dff3eeef6e9d2bcf089f054475c164c8c641941
2016-03-11 10:31:54 +01:00
Wastack
ce549d2a09 tdf#97966: Remove 'static' keywords
Change-Id: Iced527f48afa828cc9acf5b6461674a2706cbcd7
Reviewed-on: https://gerrit.libreoffice.org/23135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11 08:59:30 +00:00
Wastack
9a13cff647 tdf#97966: Remove 'static' keywords
Change-Id: Id991cead4f01830eafd9cf8dd63b519ef07c9451
Reviewed-on: https://gerrit.libreoffice.org/23134
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11 08:57:51 +00:00
Wastack
018c6adf85 tdf#97966: Remove 'static' keywords
Change-Id: I0d9837a7ccecd606e0d43b53f8b920547b0d0bcd
Reviewed-on: https://gerrit.libreoffice.org/23132
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11 08:56:20 +00:00
Wastack
7a0b8decb7 tdf#97966: Remove 'static' keywords
Change-Id: Id70f9e55fb4ad7d3a501399b055208ea10369c82
Reviewed-on: https://gerrit.libreoffice.org/23131
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11 08:54:33 +00:00
Wastack
b91fb8465c tdf#97966: Remove 'static' keywords
Change-Id: I67e6076d65b90fb386ab439c5716820a6322af38
Reviewed-on: https://gerrit.libreoffice.org/23130
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11 08:52:13 +00:00
Wastack
951917e73c tdf#97966: Remove 'static' keywords
Change-Id: I0a3f17d43917d05734980329231ef6e7cadfd58a
Reviewed-on: https://gerrit.libreoffice.org/23129
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11 08:49:50 +00:00
Wastack
83452dd083 tdf#97966 redundant static keywords removed 6
Change-Id: Iaf034f3b2282a973f6503edea41cb3184543fb11
Reviewed-on: https://gerrit.libreoffice.org/23133
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11 08:38:11 +00:00
Miklos Vajna
0fea7b00e2 xmlsecurity: add missing CSP switch to certificate generator script
Without this the generated .p12 test file can't be used for SHA2 signing
on Windows, as xmlsec.git's README points out.

Change-Id: Ib97a337eca3b92dde5e0ccadee7420c492a8971c
2016-03-11 09:11:38 +01:00
Miklos Vajna
eb63915f0a xmlsecurity: clean up no longer relevant email addresses
Change-Id: I224a0914bd3506b4e2ce057c53838ec78187b060
2016-03-11 09:11:38 +01:00
Miklos Vajna
9f9fa48ad0 writerfilter: avoid ugly cross-directory include
Change-Id: I16db4e16e5c2fa3aa3bfb22f83d2c36695499b5c
2016-03-11 09:11:38 +01:00
Stephan Bergmann
5d59315809 There's only a single DispatchWatcher, no need for a static mutex member
Change-Id: I410d07210bd80379fd2de1b8d76843794fa5f660
2016-03-11 09:03:05 +01:00
Tor Lillqvist
32e70912a2 loplugin:unreffun
Change-Id: If96188840ea0d230869a6af8c1aa366dca6a8275
2016-03-11 09:49:09 +02:00
Tor Lillqvist
c914b6ccf1 loplugin:redundantcast
Change-Id: I08d68a1ff4e798d1cace56fa18c7f70a48eb6231
2016-03-11 09:32:43 +02:00
Tor Lillqvist
53e8f64865 loplugin:redundantcast
Change-Id: Ia31f94cd55f16769d8354812619a5faac4623f7a
2016-03-11 09:32:43 +02:00
Takeshi Abe
d31df8fb80 starmath: Make examples of exponential function consistent
... by prefixing "func" so that it is the same as Exponential Function
in Functions of the Elements window (RID_EX in commands.src).

Change-Id: I823c345a0f376f0679930aa7975bdeb03575cd43
Reviewed-on: https://gerrit.libreoffice.org/22389
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-11 07:27:29 +00:00
Julien Nabet
05ff3d112b Let's use the iterator return by erase method of iterator list
and avoid to retrieve list->begin and loop from the first element

Change-Id: I536b7a03c4033b02a7226d25f64764c10c28bdd0
Reviewed-on: https://gerrit.libreoffice.org/23126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11 07:18:59 +00:00
Markus Mohrhard
e94d5233dd work on sane lifecylce for SfxFilter
all SfxFilter instances should now be hold inside of a std::shared_ptr.

This fixes a number of huge memory leaks in the test framework and
removes one huge source of memory issue in sfx2. SfxMedium contains a
pointer to the SfxFilter but does not own. Therefore it is required that
any SfxFilter belonging to a SfxMedium lives longer. However this seems
to work mostly by hoping that all SfxFilter instances are stored in a
global array. As we have seen with the tests this is not true (there are
also some cases inside of sd that seem to not follow that pattern as
well).

Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8
Reviewed-on: https://gerrit.libreoffice.org/23140
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-11 06:38:15 +00:00
Markus Mohrhard
fb827f2a34 fix a few memory leaks in the calc test framework
Change-Id: Ic32d31913f40636e2b579d46ecf287110090772b
Reviewed-on: https://gerrit.libreoffice.org/23139
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-11 06:37:25 +00:00
Markus Mohrhard
63bb0e891e allow to call xpath expression on different files in container
Change-Id: I0b95ac19e2f6a01cadb4de32937282f489dbca7f
Reviewed-on: https://gerrit.libreoffice.org/23137
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-11 06:36:18 +00:00
Markus Mohrhard
a63c9c5de4 just take a reference
Change-Id: I9c156cc931fa1312df3588d86e2c592c8fd79c30
Reviewed-on: https://gerrit.libreoffice.org/23136
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-11 06:35:35 +00:00
Markus Mohrhard
1a474b37ef add assert to prevent memory leak
This is on my way of tracking a nasty memory leak in the change tracking
export code.

Change-Id: Ia46ef201f757dcd7f8764c3adf487de7fec58019
Reviewed-on: https://gerrit.libreoffice.org/23138
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-11 06:35:06 +00:00
Yousuf Philips
129d199d27 tdf#97906 Ensure that F4 isnt used in Writer for Data Sources
Change-Id: I6bc9aa925e7ea0a9d1ee24605127b2e005811aab
Reviewed-on: https://gerrit.libreoffice.org/23047
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-03-11 06:15:57 +00:00
Maxim Monastirsky
42d6a165b0 framework: Kill BmkMenu
Change-Id: I182e752f5602d946f27206a1bb744c5d2248bdf8
2016-03-11 00:53:21 +02:00
Eike Rathke
36722b6b02 wrap vcl::window* pointer members in VclPtr, tdf#97344 follow-up
Trying to satisfy loplugin:vclwidgets

sc/source/ui/inc/checklistmenu.hxx:199:28: error: OutputDevice subclass 'ScCheckListMenuWindow *' declared as a pointer member, should be wrapped in VclPtr [loplugin:vclwidgets]
    ScCheckListMenuWindow* mpMenuWindow;
    ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
sc/source/ui/inc/checklistmenu.hxx:200:21: error: OutputDevice subclass 'ControlToPosMap' (aka 'unordered_map<vcl::Window *, size_t>') declared as a pointer member, should be wrapped in VclPtr [loplugin:vclwidgets]
    ControlToPosMap maControlToPos;
    ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
sc/source/ui/inc/checklistmenu.hxx:201:31: error: OutputDevice subclass 'std::vector<vcl::Window *>' declared as a pointer member, should be wrapped in VclPtr [loplugin:vclwidgets]
    std::vector<vcl::Window*> maControls;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

Change-Id: I47ba432fd76899681ec0afd852c71b584629eeb9
2016-03-10 23:29:22 +01:00
Caolán McNamara
cb00ae0a82 coverity#1355504 Dereference before null check
Change-Id: I1f19fa2b55054bff7bb7e34d8a07dcf29fd229be
2016-03-10 22:15:00 +00:00
Caolán McNamara
b20af8b684 coverity#1355499 Unchecked return value
Change-Id: I0b9329d00bfcebb6e29db6786715b19a7697d087
2016-03-10 22:14:59 +00:00
Caolán McNamara
bd17307216 coverity#1355501 Dereference after null check
Change-Id: I84001559ed2bafee16a176eb11ea991397b733bc
2016-03-10 22:14:59 +00:00
Caolán McNamara
c27d0a583d coverity#1355507 uninitialized scalar field
I think

commit b2fb84499e1f75735e8fd90bc2eece3fed9af5f6
Author: Noel Grandin <noel@peralex.com>
Date:   Mon Mar 7 14:19:22 2016 +0200

    loplugin:write only fields

wrong wrong and took out this param along with the unused nIndex
beside it

Change-Id: Idc34e03b5d59d4b0017fff456b79c807fda2535f
2016-03-10 22:14:59 +00:00
Stephan Bergmann
eee4dd746e Fix memory leaks
Change-Id: If9f7dc4a28d5e005959f0d4a0a2ed317b699f292
2016-03-10 21:43:13 +01:00
Stephan Bergmann
8e9a7cac42 No more need for jfw_freeJavaInfo
Change-Id: I2426a76936b4099a243ce8c102da867e7868aac3
2016-03-10 21:42:31 +01:00
Stephan Bergmann
8546831b3b Turn JavaInfo sal_Sequence* member into rtl::ByteSequence
Change-Id: Iecd476970b0b7a46afe223f71e95b0010048d7b1
2016-03-10 21:41:24 +01:00
Stephan Bergmann
5dcdb35ab1 Turn JavaInfo rtl_uString* members into OUString
Change-Id: Ieb23b0c36ef56a4793a56cdb450df34e4d9bce1d
2016-03-10 21:41:24 +01:00
Stephan Bergmann
81dd7115e8 Manage JavaInfo instances via new/delete
Change-Id: I10a113718e525b646c51aa8a19f9f2b75a36714a
2016-03-10 21:41:23 +01:00
Stephan Bergmann
624f9696a9 No need for SAL_CALL here
Change-Id: Iefa38d62235eb54ed5f1ff78b49127bd7bea1f5e
2016-03-10 21:41:23 +01:00
Stephan Bergmann
bf6c5c9b0f No need to repeat SAL_CALL in definitions
Change-Id: Ief75af9d08d9b7e31d821773db2363fa201f3038
2016-03-10 21:41:23 +01:00
Stephan Bergmann
8471ba7b97 No need for extern "C" here
...and fix resulting loplugin:salbool fallout

Change-Id: I5ae1497608d31c20b0d10676450a7673dee1c651
2016-03-10 21:41:22 +01:00