Commit Graph

396254 Commits

Author SHA1 Message Date
Caolán McNamara
a7b18aaa46 no point in these dtors being virtual
nothing inherits from these classes

Change-Id: Ic887ac8a046b8697e310e19b6e7fdf9efae8f074
2016-08-30 19:26:41 +01:00
Caolán McNamara
2b8b8740f2 default assignment operator is fine
Change-Id: I0b63abbfe7d29c35cf7c7dd047527b20ad46c538
2016-08-30 19:26:41 +01:00
Caolán McNamara
dd5fa4cea7 declare default dtor as virtual
Change-Id: Ic77dbe3ffb2d2856d437158914b877b913296e0e
2016-08-30 19:26:41 +01:00
Caolán McNamara
181c6a8886 coverity#1371300 Missing move assignment operator
Change-Id: I4add8d1f0e1f007d247d4fe9f6fa2048b792c1b0
2016-08-30 19:26:41 +01:00
Caolán McNamara
606232e450 rework for coverity#1371269 Missing move assignment operator
Change-Id: I10f9ed448854b4ece61fd84b8aa49674d0828cac
2016-08-30 19:26:41 +01:00
Caolán McNamara
29730225f2 silence coverity#1371204 Missing move assignment operator
and

silence coverity#1371210 Missing move assignment operator

Change-Id: I6d7a59fd789c16ee11a27d50ba8fd14f17ae77e0
2016-08-30 19:26:41 +01:00
Caolán McNamara
a2dbaac6a8 default assignment and ctor are fine here
Change-Id: I50edc71ee8bb4398764f2e15180a0269aac233ce
2016-08-30 19:26:41 +01:00
Eike Rathke
04311182b6 Resolves: tdf#83376 do not let linguistic tools fall back to known languages
Falling back to known locales was necessary before the new language tag
implementation that can register "unknown" tags on the fly. In fact here we
want to handle tags unknown to us and not fall back to worst case en-US even,
so that dictionaries, grammar checkers, thesauri et al for any language tag can
be used with such tagged document content.

Change-Id: I06e54f41e00e69779b4c0cbbc891f250545a17d2
2016-08-30 20:24:51 +02:00
Khaled Hosny
cf425acfd4 tdf#56403: Text is right aligned in RTL locales
Draw/Impress is setting writing mode to RTL (which in turn sets text
alignment to right) if the current locale is RTL one. This does not make
sense at all since it means document prepared on a LTR locale and
contains LTR text will appear right aligned on RTL locales.

It would have slightly more sense if SetDefaultWritingMode() actually
just set a default (for e.g. new documents), but that is not the case
here as it affects all documents.

This was introduced in 2c32696a04 with a
branch merge and no further explanation.

Change-Id: Idee0f58e153498a6676a22242d2edd5054b908c6
Reviewed-on: https://gerrit.libreoffice.org/28411
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-08-30 17:22:41 +00:00
Eike Rathke
3e289cf10b use static LanguageTag::convertTo...() instead of LanguageTag().get...()
They know best when a temporary LanguageTag instance is needed and when
not.

Change-Id: Ia0dc5b2d165b15362080d60dbb9f58cfa0403014
2016-08-30 17:38:42 +02:00
Laurent Balland-Poirier
022a58136d tdf#64145 Add empty subtitle string as default
Only empty Title create automatic title.
Empty subtitle has no other effect than remove subtitle
if it is kept empty

Change-Id: I7e7de198585885866efea24de3a66c26d3e340ae
Reviewed-on: https://gerrit.libreoffice.org/27904
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-30 15:14:31 +00:00
Zdeněk Crhonek
91545e2661 add HYPERLINK test case
Change-Id: Ic7254e2c69a85f2020b0a79e79d9252fe0a0069d
Reviewed-on: https://gerrit.libreoffice.org/28471
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-30 15:13:03 +00:00
Maarten Bosmans
f8a8a41c2e Translate some German comments and messages
Change-Id: Id15e1afd991f3476e260ba40a8c45c7261113577
Reviewed-on: https://gerrit.libreoffice.org/28493
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2016-08-30 15:04:45 +00:00
Miklos Vajna
3ab2b0625b sc lok: implement getCommandValues(.uno:AcceptTrackedChanges) API
Unlike in Writer, there doesn't seem to be an existing UNO API that can
be reused here.

Change-Id: I011a2f34d4d09ad604991637322ceadf6b2eb181
Reviewed-on: https://gerrit.libreoffice.org/28498
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-08-30 15:00:40 +00:00
Stephan Bergmann
a037f6338c Disable CppunitTest_vcl_wmf_test under --enable-merglibs for now
...the problems caused by that test having the vcl objects linked into both the
test's library and the mergedlib (which the test's library links against) are
just not manageable.

Change-Id: I6976407275f1f8d8cebfe2dfc6c09656a3936200
2016-08-30 16:20:11 +02:00
Stephan Bergmann
e7bbf98659 Fix placement of EXTRA_ENV_VARS
Change-Id: Id9ae15aaf24b65abfcb4006490836eae8a1d8db6
2016-08-30 16:19:36 +02:00
Stephan Bergmann
c5d8cb41a5 loplugin:stringconstant: adapt to improved OUStringLiteral1
Change-Id: I5c9bfbb97f0eabe1ea691faf522d22070243d234
2016-08-30 15:30:36 +02:00
Stephan Bergmann
6427b84b39 loplugin:stringconstant: adapt to improved OUStringLiteral1 (writerfilter)
Change-Id: Ia156b152a5df279d879e91cc0311c2f4da27cd05
2016-08-30 15:30:12 +02:00
Stephan Bergmann
8baef341d5 loplugin:stringconstant: adapt to improved OUStringLiteral1 (vcl)
Change-Id: Ic04f33413713b592c10ebf27c1e3460a44e3794f
2016-08-30 15:30:04 +02:00
Stephan Bergmann
e29b6be3c4 loplugin:stringconstant: adapt to improved OUStringLiteral1 (unotools)
Change-Id: Ic87ea0139f0c8624a8af5700d97375075c091f73
2016-08-30 15:29:59 +02:00
Stephan Bergmann
172b8a5cdb loplugin:stringconstant: adapt to improved OUStringLiteral1 (unoidl)
Change-Id: I8f7fb8bba65f99732bb172b45e309868047f545c
2016-08-30 15:29:54 +02:00
Stephan Bergmann
70986cc3d4 loplugin:stringconstant: adapt to improved OUStringLiteral1 (tools)
Change-Id: I624505ceee232a531826915755717f2e09dc0a72
2016-08-30 15:29:47 +02:00
Stephan Bergmann
32f9120fa0 loplugin:stringconstant: adapt to improved OUStringLiteral1 (sw)
Change-Id: Ifa1a6bafd3628b48ebceb09f8cd864361848e81c
2016-08-30 15:29:41 +02:00
Stephan Bergmann
185c3c8207 loplugin:stringconstant: adapt to improved OUStringLiteral1 (svx)
Change-Id: I4d95f15896327101c1c19abc00edcecd7fee26a2
2016-08-30 15:29:36 +02:00
Stephan Bergmann
4d21c085e6 loplugin:stringconstant: adapt to improved OUStringLiteral1 (svtools)
Change-Id: Ifdfc684ea894e637617de845facbad645ed6331c
2016-08-30 15:29:32 +02:00
Stephan Bergmann
d7beb36e94 loplugin:stringconstant: adapt to improved OUStringLiteral1 (svl)
Change-Id: I5b9c503fd28209b893688e81ddd00eb843b44e37
2016-08-30 15:29:26 +02:00
Stephan Bergmann
f5a99c3748 loplugin:stringconstant: adapt to improved OUStringLiteral1 (starmath)
Change-Id: Ic0a3a2ae6c0e2601cb415cba971620a71ded02a5
2016-08-30 15:29:20 +02:00
Stephan Bergmann
a86df4bbe0 loplugin:stringconstant: adapt to improved OUStringLiteral1 (sd)
Change-Id: Ib044294174c665407dd2c1e8fd083e9f34733ec6
2016-08-30 15:28:57 +02:00
Stephan Bergmann
7a63e5f69a loplugin:stringconstant: adapt to improved OUStringLiteral1 (scaddins)
Change-Id: I30a66d2ff5233d6a2a6ec076e188f75a74843cc7
2016-08-30 15:28:52 +02:00
Stephan Bergmann
d488a646b5 loplugin:stringconstant: adapt to improved OUStringLiteral1 (sc)
Change-Id: I41af3d6acdb5dfdaa27febf99cc3c5aa031ad779
2016-08-30 15:28:44 +02:00
Stephan Bergmann
79a410daa9 loplugin:stringconstant: adapt to improved OUStringLiteral1 (sax)
Change-Id: Ia39a4f4689ae0d6e2b7303a89251634bfe0eeb2f
2016-08-30 15:28:39 +02:00
Stephan Bergmann
0cdfe1cdc1 loplugin:stringconstant: adapt to improved OUStringLiteral1 (package)
Change-Id: I359fcf33039b406d614bf71361a7882a101667d2
2016-08-30 15:28:34 +02:00
Stephan Bergmann
cd252e3ad8 loplugin:stringconstant: adapt to improved OUStringLiteral1 (opencl)
Change-Id: I0da7434b67148824d1c2343f8ecb2b069df6baa2
2016-08-30 15:28:28 +02:00
Stephan Bergmann
bbecf93134 loplugin:stringconstant: adapt to improved OUStringLiteral1 (oox)
Change-Id: I1a3190f136b69702615cdf796ff45abfd89155dc
2016-08-30 15:28:22 +02:00
Stephan Bergmann
82b27577d2 loplugin:stringconstant: adapt to improved OUStringLiteral1 (i18npool)
Change-Id: If4bc7dd5af49cca85f474e817cc3cc358c2b48c2
2016-08-30 15:28:17 +02:00
Stephan Bergmann
1a212efd3a loplugin:stringconstant: adapt to improved OUStringLiteral1 (forms)
Change-Id: I25323e586bb80b833d1b2dace5498de853aa039e
2016-08-30 15:28:09 +02:00
Stephan Bergmann
0b288bf8e9 loplugin:stringconstant: adapt to improved OUStringLiteral1 (filter)
Change-Id: I3c58c694e869c0825b90479ac572f6af9d030c4d
2016-08-30 15:28:03 +02:00
Stephan Bergmann
5d268dcbaf loplugin:stringconstant: adapt to improved OUStringLiteral1 (embeddedobj)
Change-Id: I4d1d29155c09b15514f96a8b53f9865eefc78704
2016-08-30 15:27:57 +02:00
Stephan Bergmann
0c9a71a7b2 loplugin:stringconstant: adapt to improved OUStringLiteral1 (editeng)
Change-Id: If8d2eb5e02a107cc1805e349a70df54160fed02a
2016-08-30 15:27:48 +02:00
Stephan Bergmann
56f21320f3 loplugin:stringconstant: adapt to improved OUStringLiteral1 (desktop)
Change-Id: Icdfcdb168d5570e37818bf866e2b4296c02824be
2016-08-30 15:27:40 +02:00
Stephan Bergmann
d42bc6e313 loplugin:stringconstant: adapt to improved OUStringLiteral1 (cui)
Change-Id: I75013800fca4475ff2cb93a1f5c34cd37b93bc6e
2016-08-30 15:27:34 +02:00
Stephan Bergmann
489a47dfa0 loplugin:stringconstant: adapt to improved OUStringLiteral1 (cppcanvas)
Change-Id: I98a9e1404c2a9a39c8f930609c199c75f0a572f1
2016-08-30 15:27:26 +02:00
Stephan Bergmann
d0cb35f3be loplugin:stringconstant: adapt to improved OUStringLiteral1 (connectivity)
Change-Id: I1c9e33d3f4306199320e60cf0eb2970e687576ef
2016-08-30 15:27:16 +02:00
Stephan Bergmann
6f821ca4a1 loplugin:stringconstant: adapt to improved OUStringLiteral1 (chart2)
Change-Id: Id8699d6923f8c3e1133db5ef66a21d939b9c5668
2016-08-30 15:27:05 +02:00
Stephan Bergmann
1bab5c7419 loplugin:stringconstant: adapt to improved OUStringLiteral1 (basic)
Change-Id: I7e9ceb5513b34115bb1f41e627af06bbffc6ecf1
2016-08-30 15:26:56 +02:00
Miklos Vajna
30b84816eb gtktiledviewer: don't crash on unimplemented tracked change list
As it's currently implemented only for Writer.

Change-Id: I8c281b2294564472f2c2c5b7de5dd3f86a11a94a
2016-08-30 15:15:42 +02:00
Jochen Nitschke
c9493b344a tdf#96248 delete SfxPoolItems with Which Id >= 4000
Which Ids > 4999 (SFX_WHICH_MAX) are Slot Ids and handled above.
Which Ids >= 4000 and <= 4999 are used by EditEngineItemPool,
defined in eeitem.hxx (values 3994 to 4048).

the former hack prevented that some of PoolItems got deleted
when RefCount dropped to 0. when trying to Remove the PoolItem again,
an earlier assert hits.

hack and comment are in source since initial commit,
other referenced comment is nowhere to be found.

Change-Id: I299b2ae4aed088d4ee438397d0bb91ca8d055cef
Reviewed-on: https://gerrit.libreoffice.org/28429
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-30 13:07:47 +00:00
Michael Stahl
1ae5c5ea82 Makefile: improve JAVA_HOME check
On Fedora it often happens that the $JAVA_HOME directory is not actually
deleted but contains a bunch of ".rpmnew" and ".rpmsave" files in
jre/lib/security - so check that the "include" directory exists.

Change-Id: I34bf945b346e79dbe6f1a6e96ba1ba5139ff8f13
Reviewed-on: https://gerrit.libreoffice.org/28491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-30 12:53:54 +00:00
Noel Grandin
4e8ff25ff7 loplugin:countusersofdefaultparams
Change-Id: I69f55593e6101906e0e97565f2cfc818852258dd
Reviewed-on: https://gerrit.libreoffice.org/28486
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-30 12:48:10 +00:00
Stephan Bergmann
88c80411cb loplugin:implicitboolconversion
Change-Id: Ia50bd6ecc6a4b5efc2de81282a16203e89087314
2016-08-30 14:38:24 +02:00