mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
444,609 Commits 1 Branch 0 Tags
aa7a23f4f71853b7a256435404b7f73ddefc061e
Commit Graph

444609 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Gabor Kelemen
aa7a23f4f7 tdf#42949 Fix IWYU warnings in svgio/ 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I66cde1ea02569cd8244b23be16a5550cac8adf12
Reviewed-on: https://gerrit.libreoffice.org/85237
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-12-20 10:31:39 +01:00
Gabor Kelemen
8f4087138c tdf#42949 Fix IWYU warnings in emfio/ 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I644bbebe798329e68665b8c751eccbb829178e91
Reviewed-on: https://gerrit.libreoffice.org/85182
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-12-20 10:25:19 +01:00
Stephan Bergmann
dee81fb2e1 Make it clear that the comment talks about class data members 
...and revert 0fdb73c9e0 "Fix grammar"

Change-Id: I212f874f0ae74c97f35f372092b85a9ed5587faa
Reviewed-on: https://gerrit.libreoffice.org/85540
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-12-20 09:56:24 +01:00
Caolán McNamara
2a5d4ed38d Resolves: tdf#129484 install decimal key handler for all widgets again 
reparent notebook back to its original parent so its not destroyed
when the overflow parent is destroyed

and

add g_object_ref/g_object_unref guard to GtkInstanceWidget

Change-Id: I85d691c05e82531e398736258668e024c4aa1e64
Reviewed-on: https://gerrit.libreoffice.org/85508
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-20 09:56:10 +01:00
Caolán McNamara
e59bbb72b1 Resolves: tdf#129484 just install decimal key handler for spinbuttons 
as a simple interim fix

Change-Id: I7e393fe20f4fb7ea277c423f9fc9789d658b1e18
Reviewed-on: https://gerrit.libreoffice.org/85505
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-20 09:55:26 +01:00
Caolán McNamara
3e71e97e00 ofz#19594 Invalid-enum-value 
Change-Id: Iffd708aa30d8dde2badc4748d2adb53b64c376aa
Reviewed-on: https://gerrit.libreoffice.org/85534
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-20 09:54:58 +01:00
Caolán McNamara
49285e4370 weld GraphicPropertyPanel 
Change-Id: I05293f7421815e7588dcf344fcd221ca337b116d
Reviewed-on: https://gerrit.libreoffice.org/85550
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-20 09:54:36 +01:00
Caolán McNamara
07754d0102 weld ShadowPropertyPanel 
Change-Id: I5ffd5881955726823b0e4c6f347e9a1e1767b640
Reviewed-on: https://gerrit.libreoffice.org/85535
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-20 09:54:14 +01:00
Caolán McNamara
4a5fe0d1b7 SpacingListBox is now unused 
Change-Id: I051200802c7841dc6feb9e3ab852385887c29b09
Reviewed-on: https://gerrit.libreoffice.org/85533
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-20 09:53:51 +01:00
Caolán McNamara
011dda766e destroy SystemChildWindow at the right stage 
Change-Id: I4deab0b7ed184684b95548b090bbcbabe9082f61
Reviewed-on: https://gerrit.libreoffice.org/85549
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-20 09:53:32 +01:00
Chris Sherlock
2d46f14fa0 drawinglayer: better logging for brushes in EmfPlusRecordTypeDrawString 
Change-Id: I8ac039fd81767a52593721f211f3887276230ccf
Reviewed-on: https://gerrit.libreoffice.org/84841
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
 2019-12-20 08:43:36 +01:00
Chris Sherlock
1bd303a4c3 drawinglayer: improve pen object logging 
Change-Id: Iaae081ddee8097346000b7c2d987a2321d5e98cd
Reviewed-on: https://gerrit.libreoffice.org/84833
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
 2019-12-20 08:42:18 +01:00
Chris Sherlock
aa59b09830 drawinglayer: improve more EMF+ logging 
- Fixed logging of objects
- Fixed indenting in log statements

Change-Id: If29dc2a0d781f9d4c3fd2c810aa29fe607f0a9c9
Reviewed-on: https://gerrit.libreoffice.org/84467
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
 2019-12-20 08:41:15 +01:00
Bakos Attila
10f29d8bf0 tdf#87569 tdf#109411 DOCX import: fix shape anchor in tables 
Import "relative from page" horizontal setting of
VML and DrawingML shapes as "relative from column"
in tables, just as MSO handles it.

Change-Id: If71f2e52bbba324a98651e701feaeb99acfefc48
Reviewed-on: https://gerrit.libreoffice.org/85141
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
 2019-12-20 08:04:15 +01:00
Jim Raykowski
fdb5ce011c tdf#108458 Show tooltips in CuiConfigFunctionListBox 
Change-Id: I6644e939c644c827e2b3ad019b975a3845585063
Reviewed-on: https://gerrit.libreoffice.org/84555
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
 2019-12-20 07:22:04 +01:00
Noel Grandin
f2f5d74067 tdf#129228 speedup load xls file with lots of comments 
by locking the underlying SdrModel while the comments are added, so we
avoid the reformatting that happends when the model is unlocked

Takes the time from 3m30 to 1m for me.

Change-Id: Ibc3d2b1ded548d5eee7715d9a655a0af61b0eb2b
Reviewed-on: https://gerrit.libreoffice.org/85523
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-12-20 07:16:04 +01:00
Andras Timar
6142062844 interface domain is sw for this ui resource 
Change-Id: I9a0fce51d52ab3c0d1c7540834112cff1f3e572f
Reviewed-on: https://gerrit.libreoffice.org/85451
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2019-12-20 04:35:45 +01:00
Ilmari Lauhakangas
a7b58f2953 Point to the right readme 
Part of Redmine issue 2556

Change-Id: I4bc21162d10170caff6ee44330747a698f7f6b41
Reviewed-on: https://gerrit.libreoffice.org/85423
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2019-12-20 04:26:46 +01:00
Miklos Vajna
fd92740a86 DOCX table import: fix interaction of 1-cell rows and "inside" vertical borders 
The interesting part of the bugdoc was:

- table style wants visible borders
- table direct formatting clears left and right borders
- 1st row of the table has 1 cell (2 cells in fact, but they are
  merged)

Fix the "inside" vertical border handling, so that the first cell gets
these vertical borders as a right border only in case there are multiple
cells.

Change-Id: Id847109ecfa95d1745abe62ddf36c4936b730855
Reviewed-on: https://gerrit.libreoffice.org/85536
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
 2019-12-20 00:32:35 +01:00
Caolán McNamara
3e0c33395c weld WrapPropertyPanel 
Change-Id: I8ff662fbdcd4defc3d04795e70d95df31b154e20
Reviewed-on: https://gerrit.libreoffice.org/85532
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 22:11:45 +01:00
Caolán McNamara
2f9376bd80 SameContentListBox is newly unused 
Change-Id: I73b2aa5a140d1442901e6b1c7e1334bce74c5e41
Reviewed-on: https://gerrit.libreoffice.org/85529
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 22:11:22 +01:00
Caolán McNamara
3f0b93eb92 weld PageHeaderPanel 
Change-Id: I261f277b54938fa04f26bcd7f8e482517695b5e5
Reviewed-on: https://gerrit.libreoffice.org/85528
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 22:11:04 +01:00
Caolán McNamara
0a2b871ccd weld PageFooterPanel 
Change-Id: Ice9e7c5ab9c1085021ebb3561cfb2bd0a6727066
Reviewed-on: https://gerrit.libreoffice.org/85526
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 22:08:44 +01:00
Caolán McNamara
cbca3beb99 weld PageFormatPanel 
Change-Id: I98b40be22d11bee055ae321e8a93430bc69fe023
Reviewed-on: https://gerrit.libreoffice.org/85525
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 22:08:28 +01:00
Caolán McNamara
e3a002c53a get native gtk widgets in sidebars working 
Change-Id: If65aef1249f54a87d7854c3fa2db4319a24a5a05
Reviewed-on: https://gerrit.libreoffice.org/85326
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 22:07:19 +01:00
Noel Grandin
e994b3fc3b sal_Char->char in remotebridges..sax 
Change-Id: I6d32942960a5e997f16eb1301c45495661cd4cea
Reviewed-on: https://gerrit.libreoffice.org/85514
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-12-19 19:17:57 +01:00
Noel Grandin
7c18da2dc6 sal_Char->char in oox..registry 
Change-Id: Icc7f2a32696c30317c1ee77ef39d682d5f5a80b9
Reviewed-on: https://gerrit.libreoffice.org/85512
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-12-19 19:17:40 +01:00
Stephan Bergmann
f22044a49a Fix mid-air collision 
Change-Id: Iedfd0df670e4aa81fc2acbee5c3bda50c53b9fc7
Reviewed-on: https://gerrit.libreoffice.org/85538
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2019-12-19 19:08:28 +01:00
LibreOfficiant
117963ad68 Update git submodules 
* Update helpcontent2 from branch 'master'
  - RGB function new index entry
    
    Change-Id: I8d13e1462d95f292e0f4807c96239d745bf3691c
    Reviewed-on: https://gerrit.libreoffice.org/85531
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
 2019-12-19 18:36:54 +01:00
Chris Sherlock
ac793c7d9d tdf#129188 drawinglayer: implement EMF+ SetTextContrast 
Change-Id: I5e249d5ba85df020ab90c6e543c0d8aefe0b572f
Reviewed-on: https://gerrit.libreoffice.org/84455
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2019-12-19 17:51:45 +01:00
Caolán McNamara
0c764bfd7a add a SystemChildWindow::GetOptimalSize override 
Change-Id: I812d996e78a6d627fda6612307ca4cb2f111b6a9
Reviewed-on: https://gerrit.libreoffice.org/85325
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 17:14:06 +01:00
Caolán McNamara
b37540b1b3 remove can-focus when focus is lost 
so main window is not a candidate to be tabbed into when focus is in sidebar

Change-Id: Ifca270e16bc3766cb12bda95f595887d5f01efe6
Reviewed-on: https://gerrit.libreoffice.org/85405
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 16:53:35 +01:00
Caolán McNamara
a3f2c64d5e handle change of focus between widgets within the toplevel GtkWindow 
Change-Id: I3515b33fdb74d294992df516fbe8cebb7ae68376
Reviewed-on: https://gerrit.libreoffice.org/85324
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 16:53:21 +01:00
Andrea Gelmini
85c10c4e49 Fix typo in code 
Change-Id: I7c71e16628819bd60664f9b4dc70f0f0762afb48
Reviewed-on: https://gerrit.libreoffice.org/85521
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Tested-by: Jenkins
 2019-12-19 16:23:21 +01:00
Caolán McNamara
bce3b6af1a allow default GtkWindow to handle key events first 
which, in the case of native GtkWidget children of a LibreOffice window would
get the keystrokes to the correct focused widget

Change-Id: I0c0864701668f0b6b017517c3065c11322fdc45d
Reviewed-on: https://gerrit.libreoffice.org/85308
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 16:20:46 +01:00
Michael Stahl
27b6c82b79 tdf#129247 writerfilter,sw: improve handling of CONTROL fields 
The "CONTROL Forms.CheckBox.1" field has a shape as its result.

Previously this was imported as an unknown generic field by writerfilter
and exported as a CONTROL field followed by a SHAPE field; the CONTROL
field was discarded by Writer on a subsequent import.

Now this is exported as nested fields to WW8, i.e., SHAPE inside the
result of CONTROL, which is an improvement.

Unfortunately the WW8 import discards the result of the CONTROL field,
because its field code is written as ww::eUNKNOWN = 1, not
ww::eCONTROL = 87.

To fix that, set the ODF_ID_PARAM parameter in writerfilter for these
fields, which is checked in MSWordExportBase::OutputTextNode().

This reveals that the field code was set wrongly on the fieldmark too,
it should be set as a ODF_CODE_PARAM parameter and not as the type.

Furthermore the WW8 import needs to allow nested fields in the eCONTROL
field.

Change-Id: If79a186ea30c3b4a933ba1d8325111215250b833
Reviewed-on: https://gerrit.libreoffice.org/85418
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Tested-by: Michael Stahl <michael.stahl@cib.de>
 2019-12-19 15:11:03 +01:00
Andrea Gelmini
e1c2bb5712 Remove comma 
Change-Id: Ie8b573d2b319c046013e7189fa3cc19c9409f499
Reviewed-on: https://gerrit.libreoffice.org/85517
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-12-19 14:20:23 +01:00
Andrea Gelmini
4ca2d35c4b Fix typo 
Change-Id: Ida0438cc5c3e5b9ebad345f14891d246456df243
Reviewed-on: https://gerrit.libreoffice.org/85519
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-12-19 14:19:35 +01:00
Andrea Gelmini
86e8060c1e Fix typo 
Change-Id: Idf0d3b9ded4a6f69faf36f28c9cfdc7f1f385606
Reviewed-on: https://gerrit.libreoffice.org/85518
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-12-19 14:19:09 +01:00
Andrea Gelmini
3803f2adb7 Fix typo 
Change-Id: Ic6ec67b7a13506c6242b2863360b065724844c5a
Reviewed-on: https://gerrit.libreoffice.org/85520
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-12-19 14:18:36 +01:00
Andrea Gelmini
0fdb73c9e0 Fix grammar 
Not sure about this...

Change-Id: I264670c92b3387e9da194021a07054e4bedaed19
Reviewed-on: https://gerrit.libreoffice.org/85510
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-12-19 14:15:58 +01:00
Andrea Gelmini
36467b45f3 Fix typo 
Change-Id: Id746a7c0ed00cd70660bb31e1843939fbc5b09d3
Reviewed-on: https://gerrit.libreoffice.org/85511
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-12-19 14:13:14 +01:00
Caolán McNamara
51ac2d08b9 multiline edit appears for a moment when loading 
Change-Id: I69b0922ebf1aae9d5a22842745b7f0e4f914d2be
Reviewed-on: https://gerrit.libreoffice.org/85495
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 13:03:42 +01:00
Tor Lillqvist
3e4a4767a5 Fix build in the !HAVE_FEATURE_SCRIPTING case 
Change-Id: Ia2425839dc77ecf6eed247e3a8e0557c98b27598
 2019-12-19 13:49:39 +02:00
Caolán McNamara
b03c503c08 focus-in/out should return a value 
Change-Id: I82df9b24a5f08830eda1e511d6a7d45a1edcc08e
Reviewed-on: https://gerrit.libreoffice.org/85496
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 12:20:27 +01:00
Noel Grandin
821bdf5f79 sal_Char->char in formula..i18npool 
Change-Id: I765979f41842befcf25909944100d1caa97f81a8
Reviewed-on: https://gerrit.libreoffice.org/85476
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-12-19 12:05:51 +01:00
Caolán McNamara
0c5f36e5f7 these .ui no longer need special handling 
Change-Id: I1b112ea6780ff5da2b8aa86f8039b47e98219f08
Reviewed-on: https://gerrit.libreoffice.org/85407
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-12-19 11:56:31 +01:00
Mike Kaganski
0cd3b7926c tdf#65038: use trailing string characters for look-ahead assertions 
... like commit eb973a46ba did for
look-behind assertions

Change-Id: I86ece5d3ee49b0c5d86f2cfab5fed2830d5ad777
Reviewed-on: https://gerrit.libreoffice.org/85487
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2019-12-19 10:59:01 +01:00
Andrea Gelmini
fe17fd7b0f Fix typo 
Change-Id: I5a0f79d4000c823a1fe05cafcb7cbc064b04169e
Reviewed-on: https://gerrit.libreoffice.org/85500
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-12-19 10:45:45 +01:00
Andrea Gelmini
17d2516521 Fix typo 
Change-Id: I20d29dd50644889b5e802229ca7cdbd7fa22bf56
Reviewed-on: https://gerrit.libreoffice.org/85497
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-12-19 10:37:58 +01:00