mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
396,784 Commits 1 Branch 0 Tags
abbe7584543ad27e658de515c7dafcc1ce34a18c
Commit Graph

396784 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Caolán McNamara
abbe758454 Resolves: tdf#101924 fatal exception on Sounds like Japanese options 
suspected regression from

commit 1a967fead6
Author: Eike Rathke <erack@redhat.com>
Date:   Tue Mar 24 15:53:23 2015 +0000

    do not include non-mask bits in masks

Change-Id: Ic35a4aecc4834fc255eae81d3d83cc4e74618604
Reviewed-on: https://gerrit.libreoffice.org/28764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2016-09-13 18:00:59 +00:00
Yousuf Philips
9adafa3283 tdf#87794 Hide contextual media player toolbar 
Change-Id: I71dce7a5ad7f898b4338f95b1fc3bfca5080907a
Reviewed-on: https://gerrit.libreoffice.org/28820
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-09-13 17:32:10 +00:00
Caolán McNamara
a6a193666d Enable breeze dark icon theme 
This reverts commit 480ee0a664.

Change-Id: Iad58d7c4b6f9196845efda9a22479093a8c4e367
Reviewed-on: https://gerrit.libreoffice.org/28869
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-09-13 17:27:11 +00:00
Tor Lillqvist
6e18d56c77 Remove totally bogus comment 
Was initially in German with glorious ASCII graphics, but equally
bogus.

Change-Id: I9f7286049ed6a0ec7c1511dd3da018e5f6442b15
 2016-09-13 18:12:27 +03:00
Tor Lillqvist
647360d948 Add comment wondering whether a #if makes sense 
Change-Id: Ib6e6ab79632325dd3d592265a9ee859b1bc2c3ca
 2016-09-13 18:12:27 +03:00
Stephan Bergmann
8332db757c loplugin:override 
Change-Id: Ia2445bb53ea3508ee3be4e3eb5eb031e26f1bf9c
 2016-09-13 17:09:34 +02:00
Michael Stahl
66bdcb96ed xmloff: invoke SvXMLImportContext destructor with proper namespace map 
The recent pRewindMap fix revealed that the xContext object is destroyed
too late so the destructors containing half the import code (because
where else would you put complex logic that can fail?) are invoked with
the namespace map of the parent element, which breaks RDFa import and
JunitTest_sfx2_complex.

(regression from 32ccb4ea86)

Change-Id: I0c897ea0cae2db4d35f2ba19ba2f6e8026f1b3ec
 2016-09-13 17:01:12 +02:00
Miklos Vajna
586789fe75 sw draw text: emit LOK_CALLBACK_INVALIDATE_VIEW_CURSOR from registerCallback() 
With this, in case the first view has an active text edit and a new view
is created, then the cursor position is instantly visible in the second
view, even if the first view's cursor does not move later.

Change-Id: Ia82e7dc1ce9bb58c67a280179ecadc74d3b63026
 2016-09-13 16:48:28 +02:00
Yousuf Philips
798d55fcd8 Adjust controls in animation deck and make it a11y accessible 
Change-Id: I0a9bbfdc88f3432a80900aeee04c2de71c1c54fb
Reviewed-on: https://gerrit.libreoffice.org/28796
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-09-13 14:41:10 +00:00
Andreas Kainz
1fe95cc793 Breeze Dark icons for use on dark themes 
Change-Id: I160131bf2f91f33cbe9f885fd851b3e49a8ae300
Reviewed-on: https://gerrit.libreoffice.org/27756
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-09-13 14:38:57 +00:00
Caolán McNamara
480ee0a664 Revert "Enable breeze dark icon theme" 
This reverts commit ee5df53075.
 2016-09-13 15:27:58 +01:00
Noel Grandin
df89e03809 rename ContentInfo attribs field and methods to charAttribs 
to match naming higher up the call stack

Change-Id: I8a89625de5d834b32fd6ea863ebc4152956a21fe
 2016-09-13 16:14:47 +02:00
Noel Grandin
c010ed6ba4 impress: extend dumpAsXml to style information in ContentInfo nodes 
Change-Id: I783f6ad9b71f18c070537e4806381a103960b6eb
 2016-09-13 16:14:47 +02:00
Yousuf Philips
a915b14640 Change presets label from default to preset in border tab 
Change-Id: I77bd74579ca254c880276deaceffd3be425a8e70
Reviewed-on: https://gerrit.libreoffice.org/28654
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-09-13 14:07:37 +00:00
Yousuf Philips
4addd72e2d tdf#102006 tweak start center and make it more a11y accessible 
Change-Id: Ib7cd1bbb9d827cc5d8dcc413cb489be6a0111cfa
Reviewed-on: https://gerrit.libreoffice.org/28791
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-09-13 14:05:50 +00:00
Yousuf Philips
2075a1e4a4 tdf#101951 Add shortcuts to common alignment shortcuts 
Change-Id: I0e5b63fa1167b44d79c433f7ab864e11f18e3b42
Reviewed-on: https://gerrit.libreoffice.org/28724
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-09-13 14:04:27 +00:00
Yousuf Philips
a2d48a4eef Adjust controls in sw paragraph dialog alignment tab 
Change-Id: I87a07d9cd1c4ec3edb4022c4ed3a42c8a891acc0
Reviewed-on: https://gerrit.libreoffice.org/28656
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-09-13 13:57:59 +00:00
Yousuf Philips
ee5df53075 Enable breeze dark icon theme 
Change-Id: I3f89d5ecce57e0901a31b76b986c4f72353f0a1f
Reviewed-on: https://gerrit.libreoffice.org/27766
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-09-13 13:54:58 +00:00
Eike Rathke
4ef10fce39 recognize NaN with no bits set in lower word as error 
Which can happen for example for -nan(0x8000000000000) as a result of
calculating with -inf. This was displayed as NaN instead of a proper error
value, now #NUM!

Example test case:
=FORECAST.ETS.ADD(50, {-1,-2,-3,-4}, {10,20,30,40})

Change-Id: I1e1d95e1f188e0036b72be37dd20039c9a9a13f6
 2016-09-13 15:29:08 +02:00
Jochen Nitschke
7aa10d2be1 fix out of bounds error 
there are 22 entries, but Sequence was allocated with 21 fields

Change-Id: I6af71e2ece99b643843b4d82e0c6be332be361fa
Reviewed-on: https://gerrit.libreoffice.org/28852
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-09-13 13:09:44 +00:00
Caolán McNamara
fad9786b06 detangle gadzillion checks into something readable 
no logic change intended

Change-Id: Ib6af93afc1f80b7fc36239c96d5e0a71fcbcb789
 2016-09-13 12:47:11 +01:00
Stephan Bergmann
6dd32d4274 chmod 644 some source files 
Change-Id: Icd8821278635c1bd27b5185cddf5dc25dfba7eb4
 2016-09-13 13:23:53 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Eike Rathke
6f8ea7e89e avoid loading all calendars of a locale 
Change-Id: I42d572a5dbd4c89351bd1f03aae75b9b7dbe7e30
 2016-09-13 13:03:39 +02:00
Eike Rathke
f882555332 switch to using LocaleDataWrapper::doesSecondaryCalendarUseEC() 
Change-Id: I6621e82249feeed3d88ee463447d08c4f812259c
 2016-09-13 12:54:41 +02:00
Eike Rathke
c22f9f0e00 introduce LocaleDataWrapper::doesSecondaryCalendarUseEC() 
Preparing to replace the number format import hack of
95c91f098e and generalizing for known locales.

Change-Id: I0413987e302eaa84ef6a7dde2ecb365144313e81
 2016-09-13 12:54:41 +02:00
Eike Rathke
1e0b7b7e4b cosmetics 
Change-Id: I32c1df5a8e7164c59ebfe0d1e1d11dd6f3b8edf8
 2016-09-13 12:54:40 +02:00
Caolán McNamara
5f58670b43 add xdg-email as the default email route 
because xdg-email is apparently the only route
that knows how to support adding an attachment
to thunderbird

Change-Id: Ife1b56ccfe2434eb31ad67bef00f55197e96151e
 2016-09-13 11:49:29 +01:00
Caolán McNamara
187e2dbd6e coverity#1372877 I'm guessing this is what might have been the intent 
warning is 'Constant' variable guards dead code

Change-Id: I06e65f576180d7ff62417828c26f969982788b55
 2016-09-13 11:49:29 +01:00
Caolán McNamara
3a10baaf8f coverity#1372442 Unchecked return value 
Change-Id: I2ff6c844e62ced35477f96a710a31cdd902f3505
 2016-09-13 11:49:29 +01:00
Caolán McNamara
780ac20278 Graphyic->Graphic 
Change-Id: Id405e6a41d8c8ed56471ec058633a21ee4346737
 2016-09-13 11:49:29 +01:00
Caolán McNamara
441f043471 coverity#1371335 Self assignment 
these copy ctors are seriously confused

Change-Id: I07b2d8cc16ba983cd74782207260b3057f8e7d7d
 2016-09-13 11:49:29 +01:00
Stephan Bergmann
b017f869e8 loplugin:rangedforcopy 
Change-Id: Ie3faef85382f7e23244e10362bfbe3469357dbfd
 2016-09-13 12:26:02 +02:00
Miklos Vajna
786cc8a5a3 sw: emit LOK_CALLBACK_GRAPHIC_VIEW_SELECTION as part of registerCallback() 
Have a Writer shape selection in the first view, create a new view, the
second view doesn't see the selection. But the same works if the shape
selection is created when the second view was created earlier.

Emit the svx selection state as part of SwCursorShell::NotifyCursor() to
fix the problem, but take care of not sending the status to the new view
itself.

Change-Id: Iff3979235e1c12cc64867c3184354967f451370b
Reviewed-on: https://gerrit.libreoffice.org/28857
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-09-13 09:36:27 +00:00
jan iversen
465d307683 Revert "tdf#73797 Enable object rotation (.uno:ToggleObjectRotateMode) for writer" 
This reverts commit 594182ce7c.

Change-Id: Idf2580e84d4190ba0aaba1a3394a4318043da458
Reviewed-on: https://gerrit.libreoffice.org/28858
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
 2016-09-13 09:17:23 +00:00
Caolán McNamara
2546ca9dde coverity#1372879 Integer overflowed argument 
Change-Id: I9e5115a00781d07c9c57e39854d6e1482bd02795
 2016-09-13 09:21:33 +01:00
Justin Luth
5aaf4d89c5 tdf#89315 writerfilter add missing parents to out-of-order styles 
Styles that inherit from a parent style, but were defined in style.xml
before the parent, were losing their base style.

Change-Id: Ic12876dddb1aa961cd8ef7579061cca30c320c71
Reviewed-on: https://gerrit.libreoffice.org/28785
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2016-09-13 08:16:12 +00:00
Tor Lillqvist
714de95ec5 Remove nonsense comments: // bitfield 
Surely the actual bitfield syntax is enough to tell the code reader
that it is a bitfield.

Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
 2016-09-13 11:09:06 +03:00
Miklos Vajna
0ae863c8ac tdf#101976 cui: fix crash when setting AutoCheckEnabled and it is read-only 
With instdir/share/registry/data/registrymodifications.xcu being:

<?xml version="1.0" encoding="UTF-8"?>
<oor:items xmlns:oor="http://openoffice.org/2001/registry" xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <item oor:path="/org.openoffice.Office.Jobs/Jobs/org.openoffice.Office.Jobs:Job['UpdateCheck']/Arguments">
    <prop oor:name="AutoCheckEnabled" oor:op="fuse" oor:type="xs:boolean" oor:finalized="true">
      <value>false</value>
    </prop>
  </item>
</oor:items>

and then trying to set 'Check for updates automatically' in Tools ->
Options -> LibreOffice -> Online Update.

Change-Id: Ifb196b6351c8a9182dfcf2ddf0a1e0555bcccedd
Reviewed-on: https://gerrit.libreoffice.org/28856
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-09-13 08:07:02 +00:00
Tor Lillqvist
94d952dfbe Add comment 
Change-Id: I53db8747403d55faf5e94f089c925e7491aae911
 2016-09-13 10:52:02 +03:00
Tor Lillqvist
677666d724 Bin noise comments 
Change-Id: Ie89d4a18d06b81748ceb593a08d10cd1c14640cc
 2016-09-13 10:36:22 +03:00
Szymon Kłos
7aa6e5ce82 tdf#102065 Notebookbar: Menu bar disappears when cancelling dialog 
Change-Id: I6f83248eddfc279fe69f0f9c1d64d6b453bb1d3e
Reviewed-on: https://gerrit.libreoffice.org/28843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
 2016-09-13 06:56:50 +00:00
Giuseppe Castagno
e137caed30 tdf#101094 (30): Better explanation of OPTIONS errors in debug build 
Change-Id: Iea0eef5d3cd67c73325eb7af883ef8ce286187cd
Reviewed-on: https://gerrit.libreoffice.org/28850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
 2016-09-13 06:36:26 +00:00
Noel Grandin
757fd37747 fix a TODO in XclImpExtName::MOper::MOper 
where it was not mapping the XLS error code to CALC

Change-Id: Ia44d6a6793960b52f43a0983d231347ba193636c
Reviewed-on: https://gerrit.libreoffice.org/28839
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-09-13 06:18:18 +00:00
Noel Grandin
2cfcf12836 remove open-coded versions of GetDoubleErrorValue and CreateDoubleError 
Change-Id: I07a1540a1b9ca60fa1e62e9cc0091866d9f2f64d
Reviewed-on: https://gerrit.libreoffice.org/28838
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-09-13 06:17:28 +00:00
Noel Grandin
6dd4905a7a loplugin:constantparam in dbaccess..editeng 
Change-Id: I1d0dc3d89933d86cd229e503b350fccc1523dedc
Reviewed-on: https://gerrit.libreoffice.org/28833
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-09-13 06:14:41 +00:00
Markus Mohrhard
a46076245c avoid crash with nullptr access 
e.g.
http://crashreport.libreoffice.org/stats/crash_details/7d19c6e6-19cb-4ba0-a51f-7b7eef514ae1

Change-Id: I97c9da78bc30b730843753da677574ae247cb430
Reviewed-on: https://gerrit.libreoffice.org/28853
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-09-13 05:40:58 +00:00
Zdeněk Crhonek
e006b6889e add FINV test case 
Change-Id: I787608e8927ad61feb01c61dd17959ba763004d7
Reviewed-on: https://gerrit.libreoffice.org/28846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-09-13 02:17:13 +00:00
Markus Mohrhard
ed7e74ae1c try to avoid the deadlock around the clipboard, tdf#56818 
This deadlocks in the case that we have an external process
communicating with LibreOffice as the SolarMutexReleaser allows a
connection to be processed while the normal code has just released the
SolarMutex. If the external call code now goes down the same code path
we deadlock on the SolarMutex together with other mutexes in the
clipboard code.

Change-Id: I18fd6953c9566452a31b1a4c32c68494ec7a52ac
Reviewed-on: https://gerrit.libreoffice.org/27251
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-09-13 02:15:15 +00:00
Takeshi Abe
b570fa88ad sw: Make DelHFFormat() local 
Change-Id: Ifcfcccfa5a7c6f8696de5c2084736fa40659998d
Reviewed-on: https://gerrit.libreoffice.org/28842
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2016-09-13 00:30:26 +00:00