Refactor the copy-pasted code in StartRuby of WW8AttributeOutput,
RtfAttributeOutput, so that it can be used it in DocxAttributeOutput
later.
Change-Id: I63631be7604a62899c5630f3e57985993f128728
Reviewed-on: https://gerrit.libreoffice.org/48764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
Allow RubyPosition property to be set via UNO
interface.
Change-Id: I506312b1b5b27f016d0ee1c66231ff90747e5538
Reviewed-on: https://gerrit.libreoffice.org/48327
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
The original code introduced with 1d10fb1197ea93f3532726c55ddd5a0eaa9ed944 "New:
Text adjustment in multiportions" read
+ if( nMultiSpace < KSHRT_MAX )
+ {
+ pCurr->GetpSpaceAdd()->Insert(KSHORT(nMultiSpace),0);
+ bRet = sal_True;
+ }
so needed nMulitSpace to fit into KSHORT (an alias for USHORT back then),
whereas today nMultiSpace is inserted into a std::vector<long>.
Change-Id: I24cafa7e295b87bf93f4e0ef5fbda5f99834286a
Reviewed-on: https://gerrit.libreoffice.org/49034
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
by using for range loops
Change-Id: I52d6e6c9e1c2c321dc81d8258943a1a9a611441c
Reviewed-on: https://gerrit.libreoffice.org/48987
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Project: help 11adc4492b11253c5d24d217354581956da1f52b
Fixes for MS browsers and tweaks to fuzzy search
Some experimental JS tech had slipped into the mix.
Search settings should also be a bit more performant now.
Change-Id: Ifae9986efc02d20fefa9480ae463107fe4743944
Reviewed-on: https://gerrit.libreoffice.org/48988
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
PPTNumberFOrmatCreator's nTextOfs and nBulletOfs are both sal_uInt32, while
SvxNumberFormat's SetAbsLSpace and SetFirstLineOffset both take short parameters
Change-Id: I2512fad4387bc8393be694b67be03ac8ea543cce
Reviewed-on: https://gerrit.libreoffice.org/48954
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
OBookmarkContainer actually re-uses the reference count of
ODatabaseSource, so converting ODatabaseSource::m_aBookmark to Reference
created a cycle, which somehow causes the dataloss, because evidently
something as important as storing the data must be done in the
destructor.
(regression from 2660d24a07866e083c5135ea263030f3e3a2e729)
Change-Id: I4cad01dc9cdaf405c1eb31d6c0e161eb6712b78f
Look for a whole column at once so we don't have to iterate all draw objects
for every cell, but only once per column.
Follow-up for 3a2a430ae8e2c1647c18d8904477949f6e2e7941
Change-Id: Ic8740fca7d595528785b432c1cedf4fad4f13ba1
Reviewed-on: https://gerrit.libreoffice.org/48416
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
...so there appears to be no good reason to cast from sal_Int32 to sal_uInt16 first
Change-Id: I67384bc736685269acb6c2033b2c4edffd27a510
Reviewed-on: https://gerrit.libreoffice.org/48953
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...implicitly casting it to smaller types where necessary, instead of the other
way around
Change-Id: Ib7673fbae016b0c91bf37d6768692fa99ccae46c
Reviewed-on: https://gerrit.libreoffice.org/48955
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...so there appears to be no good reason to cast from long etc. to sal_uInt16 first
Change-Id: I870e63404bed09cd42673692e08fc12c1c1e2fdf
Reviewed-on: https://gerrit.libreoffice.org/48958
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...and none of the places that call SvxNumberFormat::GetAbsLSpace (also
returning short) look like they deliberately cast back to sal_uInt16 (i.e., to
tunnel a genuinely unsigned value through SvxNumberFormat), so it looks more
plausible to restrict values here to short and SHRT_MAX, instead of sal_uInt16
and USHRT_MAX.
Change-Id: I6807c1b29d30c3f9bfe1ad8b98d0b3ef64dd6a5a
Reviewed-on: https://gerrit.libreoffice.org/48957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...(and both calls of CorrectTabStopInSet pass in the result of a GetAbsLSpace
call), and SvxTabStop::GetTabPos() is sal_Int32& (and that's what nAbsLeft is
combined with inside CorrectTabStopInSet), so why use an intermediary parameter
of type sal_uInt16?
Change-Id: I1cd1869ead58c419eecb3e2d1fbfb87f96bca86f
Reviewed-on: https://gerrit.libreoffice.org/48956
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...so there appears to be no good reason to cast from long to sal_uInt16 first
Change-Id: I5baf699fbf043eae6a20e2055b53aef10103f591
Reviewed-on: https://gerrit.libreoffice.org/48952
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
by using for range loops
Remark: some iterators were used outside loops,
these have been replaced by the counterpart origin variable
Change-Id: I0b1e69811f16752b0962f5c5e662ea20064e26b4
Reviewed-on: https://gerrit.libreoffice.org/48829
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
