Commit Graph

440702 Commits

Author SHA1 Message Date
Arkadiy Illarionov
c1e1806c9c tdf#39593 drop comphelper::getImplementation
Replace with comphelper::getUnoTunnelImplementation.

Change-Id: I96277aa9c17532ea6e2781dbc3305b2dbaa4e5c2
Reviewed-on: https://gerrit.libreoffice.org/78733
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-07 12:34:16 +02:00
Andrea Gelmini
b9b39acea7 Fix typos
Change-Id: Ia6760e685e7f38458a8c78e6304d06d0e7222805
Reviewed-on: https://gerrit.libreoffice.org/78740
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-07 10:39:08 +02:00
Bjoern Michaelsen
f2bc27972c kill SwXShape SwClient
this completely removes calbck.hxx from sw/source/core/unocore -- may it
never return.

Change-Id: Ie4c8b3a29fd4038a19c34116d47672b504ee9f2c
Reviewed-on: https://gerrit.libreoffice.org/78735
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-07 08:23:17 +02:00
Bjoern Michaelsen
8ac6d2e7e7 make page bookkeep the SwXShapes
- and remove SwClient/Modify between SwXShape and Page

Change-Id: I482f5357dbd361e957fef54b5cbc594351c70b96
Reviewed-on: https://gerrit.libreoffice.org/78734
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-07 08:23:08 +02:00
Aron Budea
29bda20c91 lokdocview: Add missing callback cases
To prevent gtktiledviewer from crashing.

Change-Id: Ia23504c20eac185f3302e8d694672ebf6d853585
Reviewed-on: https://gerrit.libreoffice.org/78737
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>
2019-09-07 06:12:44 +02:00
Arkadiy Illarionov
03747db026 tdf#39593 use isUnoTunnelId in connectivity
Change-Id: I458049e23e9fc1855cb4ba9519b9b940f170b024
Reviewed-on: https://gerrit.libreoffice.org/78732
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-07 00:05:26 +02:00
Andrea Gelmini
6c5a9db12e Update git submodules
* Update helpcontent2 from branch 'master'
  - Fix typo
    
    Change-Id: I1a9958dedf6b836acef6e1033a9d79f3f94202e0
    Reviewed-on: https://gerrit.libreoffice.org/78730
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-09-06 23:21:04 +02:00
Michael Weghorn
1dccd6814f tdf#126184 Use max paper dimensions to calculate clip region
Assuming at least A4 for the page size isn't enough if
e.g. A2 or larger is used, so too much was clipped in that case.

Therefore, use the the maximum paper width/height instead, which
is 6 m by default. This is still far from the 19 km that caused
tdf#63955 and I cannot reproduce tdf#63955 with that new limit.

A big thanks to Regina Henschel for the great analysis in
tdf#126184!

(Side note: Comments 18 and 19 in tdf#63955 suggest to do the whole
 clipping elsewhere, so if anybody wants to take a look at this...)

Change-Id: Iccacad621675df6c7b4477182d7332c4a3d67139
Reviewed-on: https://gerrit.libreoffice.org/78690
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-09-06 22:39:24 +02:00
Noel Grandin
374782be55 use unique_ptr in Outliner
Change-Id: I022cf01f2c36f8846227a89418735271880d1f95
Reviewed-on: https://gerrit.libreoffice.org/78715
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-06 21:40:03 +02:00
Noel Grandin
f76a7bcc65 return unique_ptr from :svt::GraphicAccess::getImageStream
Change-Id: Ie63259ce826101e553c1cb03a85e7c0ba5f0f9f5
Reviewed-on: https://gerrit.libreoffice.org/78719
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-06 21:39:41 +02:00
Noel Grandin
08e09136a6 use unique_ptr in EditNodeIdx
Change-Id: I59702aa3d54f60cb3e41410e82b0532bac05274f
Reviewed-on: https://gerrit.libreoffice.org/78717
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-06 21:39:19 +02:00
Eike Rathke
2b591a40b0 Related: tdf#98844 CreateMatrixFromDoubleRef() for bCalcAsShown ScCellIterator
... to cover ForceArray cases like SUMPRODUCT().

Change-Id: I149ef4a9633f3237d48fc4f2b6011b03bccebc49
Reviewed-on: https://gerrit.libreoffice.org/78721
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2019-09-06 20:02:18 +02:00
Christian Lohmaier
551f757b27 WINDOWS_BUILD_SIGNING: check for explicit TRUE for signing msi
it's one of those variables that are set to FALSE and not left empty...

Change-Id: Ic26888e4e983db625b5943a2c094eacc84fe1331
2019-09-06 18:31:23 +02:00
Olivier Hallot
1da37c216e Update git submodules
* Update helpcontent2 from branch 'master'
  - tdf#42990 Different handling of Text Cells in Calc
    
    Change-Id: I96d54394fc4191ae80f593040b2b870e8a6e9e39
    Reviewed-on: https://gerrit.libreoffice.org/78612
    Tested-by: Jenkins
    Reviewed-by: Eike Rathke <erack@redhat.com>
2019-09-06 18:13:02 +02:00
Eike Rathke
4321d8c8b0 Resolves: tdf#98844 calculate as shown with SUM() again
Change-Id: I0032bdb9a8f54baa2e599861e45691a255f45275
Reviewed-on: https://gerrit.libreoffice.org/78708
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2019-09-06 17:26:44 +02:00
Tamas Bunth
cc876706b1 mysqlc: Support connection to utf8mb4 server
This charset is backward compatible with 'normal' utf-8.

Change-Id: I4407894bf9029b9c56eb0d2530796e85bd226591
Reviewed-on: https://gerrit.libreoffice.org/78650
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-09-06 16:05:01 +02:00
Samuel Mehrbrodt
9219242d42 Disable inserting HTML comments as notes by default
Usually HTML comments have no value, so I guess it's better to not import them by default

Change-Id: Ie518e754797d3cf4874eb7d272663f21e68bc44d
Reviewed-on: https://gerrit.libreoffice.org/78694
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-09-06 15:30:00 +02:00
Noel Grandin
77e39d5545 use unique_ptr in CreatePrintGraphics
Change-Id: Ib9ca0173f3b5bb090ae71f8622fef717a47e8a2b
Reviewed-on: https://gerrit.libreoffice.org/78704
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-06 14:31:32 +02:00
Andrea Gelmini
77902a3cb2 Fixing '....'
Change-Id: Icf2a34500acc18b28f113c85366bf24edc6d20b9
Reviewed-on: https://gerrit.libreoffice.org/78695
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-06 14:12:27 +02:00
Heiko Tietze
9b021e87e0 Resolves tdf#125130 - UI: Show 'Go to first/last page' in new print dialog
Buttons added
gtk-media* replaced by gtk-go*

Change-Id: I274bccb747d6f5e899e826ee8bebf3c1127e6374
Reviewed-on: https://gerrit.libreoffice.org/78635
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-06 13:59:18 +02:00
László Németh
9f6d1d5c4c tdf#124604 DOCX import: fix indentation at numbering
If the actual numbering style was associated to a base
paragraph style, indentation of the base paragraph
style has also priority over the indentation defined
in the numbering style.

Change-Id: Ic57b6b854be291c75c0eb7a9dfd4c376585fe26b
Reviewed-on: https://gerrit.libreoffice.org/78659
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-06 13:38:34 +02:00
Tünde Tóth
0416342223 tdf#127339 DOCX import/export: fix image hyperlink to bookmark target
Images as hyperlinks didn't work with internal bookmark targets.

Change-Id: I5f3bf150f62d11837b45851e221119dcff93dcaa
Reviewed-on: https://gerrit.libreoffice.org/78639
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
2019-09-06 12:54:57 +02:00
Noel Grandin
fc161dc07c use unique_ptr in DoConvertToPolyObj
Change-Id: Ia7f9ff4d8f7b9834b6634e5c126bd65014dacf19
Reviewed-on: https://gerrit.libreoffice.org/78684
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-06 12:50:57 +02:00
Luboš Luňák
dc79dc76f1 make clangplugin analyzer use internally a PCH to speed things up
This generally makes the sharedvisitor performance reasonable.
The only costly thing that remains is compiling the large sharedvisitor.cxx,
which with optimizations takes quite some time, but there's ccache for that.

Change-Id: Iffa5fc9df34cdb5edf1cde34fc558fd007ef8263
Reviewed-on: https://gerrit.libreoffice.org/78569
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-06 12:07:23 +02:00
Luboš Luňák
ceb26770b3 split clangplugins sharedvisitor generator into two steps
Analysing all the plugin sources using just one process takes a lot of time,
so split out a separate analyzer tool that'll analyse one source and
print out the data to a .plugininfo file. The generator then will read
all of these and generate sharedvisitor.cxx . This allows parallelising
the expensive analysis.

With this commit sharedvisitor.cxx is no longer included in the repository,
as this and the next commit should make the generation fast enough.

Change-Id: Idfc33c4ea6ccfd84f829b51001c8ddeb0be09961
Reviewed-on: https://gerrit.libreoffice.org/78568
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-06 12:06:54 +02:00
Arkadiy Illarionov
f599c31fe6 tdf#39593 use isUnoTunnelId
Adapt getUnoTunnelId methods where required: rename or make public.

Change-Id: I0fd2120bf9f0ff1aa690329a65ff64a154c89315
Reviewed-on: https://gerrit.libreoffice.org/78680
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-06 11:55:50 +02:00
Christian Lohmaier
8811516e2e split msi signing from creation to reduce number of singtool calls
as with private key on crypto-smartcard you'd have to enter your pin
over a hundred times while creating full-lang builds and that is not
fun.
This reduces it to
* once for dll/exe
  (at least in case for mergelib is is less than 350 objects and
  that doesn't break commandline limits - previously it was set to
  only sign 20 objects at a time, forcing a pin-entry over 15 times) and
* once for main installation set
* once for SDK
* once for all the helppacks
  (signing description previously also contained the language, this
  change drops that to just "<productname> <version> Helppack"

and last three are not scattered timewise, but are done after all
packaging is complete, so the build only waits twice for user-input.

Change-Id: Ibb8bb233e967556f9654573ad30d0ed5883b533f
Reviewed-on: https://gerrit.libreoffice.org/78649
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-09-06 11:36:44 +02:00
Stephan Bergmann
4ea98c922f Fix typo in comment (ASCII 0x42 is "B")
Change-Id: Iba8411cede4dc47aaa1d9d433de2606c0d66e0bf
Reviewed-on: https://gerrit.libreoffice.org/78692
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-06 11:36:27 +02:00
Heiko Tietze
54a3044ebd Resolves tdf#127317 - Make text of tips of the day selectable
Change-Id: If0e0b04be8f7086d18fe3481c3bd8f65b48a0676
Reviewed-on: https://gerrit.libreoffice.org/78683
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-06 10:43:55 +02:00
Caolán McNamara
966a51dfc6 Resolves: tdf#125461 32bit XImage is not premultiplied
regressions since...

commit 86ea64f216
Date:   Fri Feb 15 13:14:32 2019 +0100

    Support for native 32bit Bitmap in VCL and SVP (cairo) backend

32bit cairo data is premultiplied with alpha but not so 32bit XImages which
don't have alpha at all, so restore the pre-change 32bit accessors, which
effectively ignore their alpha channel, beside the post-change ones and
toggle which one to use depending on the back end capability

Change-Id: Ibfec18b4ddb6e93ab19e44e7127e7a16982e2f49
Reviewed-on: https://gerrit.libreoffice.org/78665
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-06 10:09:01 +02:00
Caolán McNamara
00df1cd5d6 ofz#15225 Timeout cut out uninteresting slow path
Change-Id: Ia9c1187891e4bf5515417b2e5ffc093ef2335af3
Reviewed-on: https://gerrit.libreoffice.org/78674
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-06 10:08:45 +02:00
Andrea Gelmini
39214c54ef Typos
Mainly fixing '....' and '..'

Change-Id: Ic928701b319868671b826d757dd94c296fd5e942
Reviewed-on: https://gerrit.libreoffice.org/78668
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-06 09:24:07 +02:00
Andrea Gelmini
22ef2a15bb Fixing "...."
Change-Id: Id005a7531d546dd43de13b49bcb3e93081c5ad8d
Reviewed-on: https://gerrit.libreoffice.org/78679
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-06 09:15:58 +02:00
Andrea Gelmini
c12c84e6d8 Fixing "...."
Change-Id: I3424e17cfdfb563fdc5882942031deafae8689fe
Reviewed-on: https://gerrit.libreoffice.org/78678
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-06 09:13:38 +02:00
Tomaž Vajngerl
3c1c1b8885 Revert "lok: Don't send any cursor changes for table in Writer"
This reverts commit 7af38dd4fd.

Change-Id: Ic9de4c0f7a2dd71c4aeff71ca17b71bff0ffe817
Reviewed-on: https://gerrit.libreoffice.org/78682
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-09-06 09:08:14 +02:00
Andrea Gelmini
73e3604fc1 Fixing '....' and '..'
Change-Id: I926069d6c1f2712e5020d930f7ff6c62fd00e912
Reviewed-on: https://gerrit.libreoffice.org/78667
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-06 09:05:50 +02:00
Noel Grandin
396473a3d6 use unique_ptr in ImpConvertContainedTextToSdrPathObjs
Change-Id: I7995bb3e8732ec20b941bd029e5a77aa78d09592
Reviewed-on: https://gerrit.libreoffice.org/78673
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-06 08:50:50 +02:00
Noel Grandin
8494a95f29 return unique_ptr from ImpConvertMakeObj
Change-Id: I24b53dceb79bd43aed92c8130dc33b637410d231
Reviewed-on: https://gerrit.libreoffice.org/78672
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-06 08:50:35 +02:00
Zdeněk Crhonek
42eb80c12a uitest add test for Impress - Custom slide show dialog
Change-Id: Ief7fc017f69f4daa706d1a40050143f5d33b4f10
Reviewed-on: https://gerrit.libreoffice.org/78681
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-09-06 08:31:34 +02:00
Tamás Zolnai
ced915bf4c tdf#127379: PPTX: Gradient background fill of a slide is lost during RT.
Change-Id: I149bf161f53d566d461347e00d04fc45394bc051
Reviewed-on: https://gerrit.libreoffice.org/78670
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-09-06 08:00:02 +02:00
Tamás Zolnai
0417fb9ccd tdf#127372: PPTX: Shape's background transparency changes during RT
Need to use a better null value for FillTransparenceGradient.
Use black-black which has equal effect than having no transparency at all.

XFillFloatTransparenceItem has also an enabled attribute, but it
can not be accessed via the UNO API. We can acces only the gradient object,
so with a better null value we can check whether the API attribute is
actually set or not.

Change-Id: I480489f588376582f80d5062145b7f398ef61ad7
Reviewed-on: https://gerrit.libreoffice.org/78657
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-09-06 07:59:38 +02:00
Stephan Bergmann
27c886f5aa Clean up {osl_,osl::}systemPathEnsureSeparator combo
Change-Id: Iafa953725c1ca8e6f3032945dc0700ae989519b9
Reviewed-on: https://gerrit.libreoffice.org/78671
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-05 23:31:44 +02:00
Eike Rathke
de14678468 Resolves: tdf#126577 stop filling a series when threshold is reached
... instead of filling the remainder of the selection with #NUM! errors.

Change-Id: I12f3943196878c7631f3dc6ac182631faab17323
Reviewed-on: https://gerrit.libreoffice.org/78675
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2019-09-05 23:18:29 +02:00
Stephan Bergmann
001f739f1b Clean up {osl_,osl::}systemPathMakeAbsolutePath combo
Change-Id: Iec4c2ff8c8239069f95fff195c49fac9f7c865d4
Reviewed-on: https://gerrit.libreoffice.org/78656
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-05 21:18:38 +02:00
Khaled Hosny
467387ed2f Merge GetFontCodeRanges() into GetFontCharMap()
Change-Id: I61d8edf0be492c1c06274c11ac5d2e65415525a9
Reviewed-on: https://gerrit.libreoffice.org/78638
Tested-by: Jenkins
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2019-09-05 19:24:10 +02:00
Khaled Hosny
fc0119d0af Remove effectively dead code
We dropped support for non-SFNT fonts for a while now.

Change-Id: Iaa2ea308effa7328bd84240cf29fc3fd117d418a
Reviewed-on: https://gerrit.libreoffice.org/78637
Tested-by: Jenkins
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2019-09-05 19:24:01 +02:00
Noel Grandin
8b7434bc04 use unique_ptr in SdrObject::getFullDragClone
Change-Id: I904f1f13bb4958e3457476e6e682ec7d7b97c670
Reviewed-on: https://gerrit.libreoffice.org/78660
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-05 18:59:52 +02:00
Andras Timar
4c16f79b30 tdf#121983 add whitelist for libcairo.so.2
Change-Id: If255e5af56d78047af9d38d6a7f0df070888816e
(cherry picked from commit df92637754c5e7fd59d0aec8bf646c8b42416fd5)
Reviewed-on: https://gerrit.libreoffice.org/78595
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins
2019-09-05 18:46:06 +02:00
Andrea Gelmini
71740e6303 Fix typos
Change-Id: Ibfff5af316a2c18b5735245caf5a27a562bc0f52
Reviewed-on: https://gerrit.libreoffice.org/78664
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-05 18:43:22 +02:00
Caolán McNamara
ad657dddd0 consistently use RemoveScanline
Change-Id: Iad0bbbf1e2a522778fe4a88632bd7cbce4e2008c
Reviewed-on: https://gerrit.libreoffice.org/78661
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-05 18:27:08 +02:00