Commit Graph

378895 Commits

Author SHA1 Message Date
Stephan Bergmann
c571bcd775 loplugin:defaultparams
Change-Id: I797b986b227381bc066ea3aa305c0abf78cd156a
2015-08-23 21:55:05 +02:00
Caolán McNamara
63cbf8fb02 fail on exception
Change-Id: Ib48c6b05b7002db19e47d07fcfc0241468452190
2015-08-23 19:59:58 +01:00
Caolán McNamara
e903601e63 can replace sequence with simple array here
Change-Id: I1b5125f5354dc2a1f4b4312dbe2b921d5cf13b49
2015-08-23 19:59:58 +01:00
Zolnai Tamás
8d933132ab tdf#91969: Parts of paragraph border is missing
...when border is around more than one paragraph

Regression from:
16f637dab3

Change-Id: Iea9455dd7cc3c301c3e2d5d7903c98d98e515595
2015-08-23 19:15:14 +02:00
Zolnai Tamás
9a23428ff0 Use less operator here to be consistent with the original idea (see comment)
This doesn't change the result of the BestIndex method

Change-Id: If1efc04feac3d4966c126b1fa93d017a4beafbe1
2015-08-23 19:10:42 +02:00
Zolnai Tamás
3f339c5e77 Better to call this msfilter test
Change-Id: I2abd6aedb16303d8988c17e7204c9607bf8336a3
2015-08-23 19:10:41 +02:00
Caolán McNamara
b164d08f0c check for bad locations
Change-Id: I635585f664e700047d92821fb965d42b803a8a15
2015-08-23 17:13:23 +01:00
Caolán McNamara
de26ef857b coverity#1242865 Untrusted loop bound
Change-Id: I9c6f821f7bd1e9bd3eb8f47e269e62a792523f1a
2015-08-23 16:57:37 +01:00
Caolán McNamara
ca09871bc0 coverity#1317301 Uncaught exception
Change-Id: I580c1c873b440d5230a0c9e6a2a2af5d5d8c0e0e
2015-08-23 16:57:37 +01:00
Maxim Monastirsky
7d92b27aff Clean trailing whitespace
Change-Id: I3b4adb5ac75b9761ae058834e3e64779a07851c9
2015-08-23 09:29:08 +03:00
Takeshi Abe
7f4e0d6aa2 oox: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: I8a82df7ea24874d8e246dc983418d872f1943c8e
Reviewed-on: https://gerrit.libreoffice.org/17919
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-23 06:06:04 +00:00
Michael Weghorn
9beb2bedc0 tdf#39440 sc: reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: Ia7f58c24429310b66f4464d8ba8b4f2e5c6fef38
Reviewed-on: https://gerrit.libreoffice.org/17922
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-23 06:04:49 +00:00
Michael Weghorn
90b086e480 tdf#39440 reduce variable scope, adapt indentation
This addresses a cppcheck "variableScope" warning and adapts the
indentation of some code lines according to the surrounding code.

Change-Id: I76eca59a808740ab0366dd41c889a6ef19a2436d
Reviewed-on: https://gerrit.libreoffice.org/17923
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-23 06:03:38 +00:00
Michael Weghorn
b712b1f634 tdf#39440 cppcheck: redundantAssignment
This addresses some of cppcheck's "redundantAssignment" warnings
("Variable '<varName>' is reassigned a value before the old one
has been used").

Change-Id: I8fd2950d5aa1a3f4bd9e1c4c336abe465d1f657e
Reviewed-on: https://gerrit.libreoffice.org/17926
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-23 06:02:42 +00:00
brinzing
93cd7b78c2 exclude unnamed Library/Executable from ide integration
unnamed (None) Library/Executable will prevent correct
vs 2013 ide integration

Change-Id: Ia00c02609a83b5f891995e54fd3f365cd63cb7a4
Reviewed-on: https://gerrit.libreoffice.org/17933
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-23 06:01:43 +00:00
Eike Rathke
fdafa5302d adapt mapping lines to current isolang.cxx entries
and some usage comments

Change-Id: I264d6e1ed52046e58284a2090eff3e8911c87f6a
2015-08-23 00:48:18 +02:00
Eike Rathke
304ce084e9 new list of [MS-LCID] rev. 7.0 2015-06-30
See http://msdn.microsoft.com/library/cc233965.aspx

Change-Id: I5b86a309049806c2c67fe185acc421bf20de89cd
2015-08-23 00:48:17 +02:00
Eike Rathke
eaa60ff180 Russian Moldova ru-MD, mo-MD merged with ro-MD
Change-Id: Id168238f85fcec6ead008e0757c584dfd4326883
2015-08-23 00:48:17 +02:00
Maxim Monastirsky
0eda609312 tdf#84277 Use the same logic for native separators
If in some cases we don't want a visible separator, I can't
understand why it shouldn't apply also to platforms that
support native separator drawing.

Change-Id: Ib88bece62cfbb092808f3257a7ba9bd63f4cb1d7
2015-08-23 01:06:32 +03:00
Michael Meeks
f2f97ec5bf tdf#93077 - basic dialog localization issues.
Don't remove non-existent languages to clean the dialog.
Avoid crashing when adding languages to a non-localized dialog.

Change-Id: Ie356177e00e56c214727d513ae0ce6d62d32591c
Reviewed-on: https://gerrit.libreoffice.org/17929
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-22 19:10:46 +00:00
Michael Meeks
1ce2375b17 tdf#93188 - avoid crash in media player.
ToggleFloatingMode can be run during dispose, and should handle that,
thanks to Maxim Monastirsky for the analysis.

Change-Id: I72c5aff9b75fa2c1b6795e239370244dafdafae2
2015-08-22 19:11:58 +01:00
Khaled Hosny
26f3a64703 Remove bogus ligatures from OpenSymbol font
http://nabble.documentfoundation.org/Bogus-ligatures-in-OpenSymbol-font-tp4157549.html

Change-Id: Ic9da9f9234dfc945324f38407df4094eb91038c8
Reviewed-on: https://gerrit.libreoffice.org/17913
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-22 15:54:06 +00:00
Takeshi Abe
7fa5f876fd mysqlc: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: If0eccdcb56f8196db5eea539eb54dd145ac57a8d
Reviewed-on: https://gerrit.libreoffice.org/17918
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-22 15:53:18 +00:00
Caolán McNamara
3230c8cf1c check that src index is in doc range
Change-Id: Ic81e7a14701ff30aa46a9293dd6db351bd350ba5
2015-08-22 15:09:45 +01:00
Michael Weghorn
7e318570dc tdf#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: Ie492fb9c106b37c3fe7b0105236ad6315f4f159e
Reviewed-on: https://gerrit.libreoffice.org/17921
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-22 13:04:12 +00:00
Michael Weghorn
25accda781 tdf#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: I6ab170c4426494ab9fc53017f88e47fbfdbd9aad
Reviewed-on: https://gerrit.libreoffice.org/17920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-22 13:02:08 +00:00
Christian Lohmaier
159bace378 Updated core
Project: help  7a2cad733d9090afec58f6ac7cd9e97ca410a1fb

<item>Start </item><item>at</item> -> <item>Start at</item>

Change-Id: I45b5ab070d8b3ae2b76e9d32b73cdb9e1cb93551
2015-08-22 11:58:51 +00:00
Christian Lohmaier
6dfd601bb6 remove superfluous " at end of string
Change-Id: Id5280f3ea136e061f4c1e21a60aeedf2d56d0bea
2015-08-22 13:45:47 +02:00
Michael Stahl
79fb61efb8 tdf#92379: svx: don't overwrite fo:background-color on ODF import
getSvxBrushItemFromSourceSet() is called once for each property of a
frame style that is set, and the "solid" fill-style is set by first
applying the BackColorRGB and then BackTransparency property.  So there
is an intermediate state that has fill-style NONE but a XFillColorItem
set - don't reset the color to white in that case!

Apparently writerfilter generally relies on the current reset-to-AUTO
implementation (loads of test failures), so for now limit the fix for
when we know that a frame style is imported from ODF.

(regression from 3d399b0e45)

Change-Id: Ia987fe586ec819a1f3cd85acdbfb03c74ca0ec2c
2015-08-22 01:00:03 +02:00
Michael Stahl
ece9da2f47 sw: translate that
Change-Id: If218ecd47435c261de14bd5f838c1e54f826a6ab
2015-08-22 01:00:02 +02:00
Michael Stahl
2ea45a407e tdf#93240: replace boost::ptr_map with std::map<std::unique_ptr>
Change-Id: I7bc614dc45154c8dd5a7d3948f2129e5127876b3
2015-08-22 01:00:02 +02:00
Eike Rathke
395e67764c disentangle the Dzongkha mess a little
As per [MS-LCID] rev. 7.0 2015-06-30

Change-Id: If4980d2b1149d93b39e5b57f5741bbdfb5680516
2015-08-22 00:50:12 +02:00
Katarina Behrens
11b8a74d78 tdf#93437: Calc RefDialogs were never actually destructed
as ScTabViewShell::CreateRefDialog was still holding VclPtr
reference to them and never released it -- regression from
commit 087f7fe50b which is hereby
reverted.

Now it is *DlgWrapper holding the reference (via
SfxChildWindow::pWindow) and dialogs get properly destructed
when SfxChildWindow dies in SfxViewFrame::SetChildWindow(0, false)

Re tdf#91125, it turns out that the follow-up commit
06ecf7d2ae is actually enough to
prevent the crash.

Change-Id: I895825da59aabc7c0de530ecb528b9bf5acde562
Reviewed-on: https://gerrit.libreoffice.org/17899
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-21 22:34:59 +00:00
Michael Weghorn
373e71ee65 tdf#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: I97726ed32e5aa92e7da7d248380a78b1b201e46e
Reviewed-on: https://gerrit.libreoffice.org/17912
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-21 22:25:03 +00:00
Ashod Nakashian
d0489d0827 tdf#92612 Right-clicking after applying "paint buckets" leads to multiple Undo
In paint bucket mode the user can undo by right-clicking.
Undoing, however, is only possible after the first paint op.
After undoing is enabled, the user can undo indefinetely by
righ-clicking. This is not consistent and can be confusing.

This patch tracks the changes done after entering the paint
bucket mode, and allows the user to undo them using right-clicking
until they reach the first operation before entering this context.

Because the user can undo/redo using other means, the patch takes
it into account and will reset its tracking to accomodate this.

Ultimately, the user is able to make any changes in paint bucket
mode and undo them all by right-clicking, but no further than that.

Change-Id: I93380fb60db83aee37a1d324218ba6ab1700a2e5
Reviewed-on: https://gerrit.libreoffice.org/16951
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-21 22:02:05 +00:00
Varun
4ffbf64fd8 Added Test for tdf#77342 copy/paste of footnote cross references
Change-Id: Ie5d24f9a24be6e2b572f36b1776fc48d445827ce
Reviewed-on: https://gerrit.libreoffice.org/17878
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-08-21 21:05:47 +00:00
Matteo Casalin
6257ea7d92 sal_uLong to size_t
Change-Id: Ie1774045329f543c05316ba2acfa332e3b323c7c
2015-08-21 22:29:42 +02:00
Matteo Casalin
adc5e7d554 ColorMask: sal_uLong to better types, minor code rework
Change-Id: I426fa847038e7a6f788761242cb43e38cb355a36
2015-08-21 22:29:42 +02:00
Matteo Casalin
aa62086495 sal_uLong to sal_uInt16 as return type of BitmapColor::GetColorError
Change-Id: I62c0d073d6b22346b65e3560303d7fc9373bfc7e
2015-08-21 22:29:41 +02:00
Matteo Casalin
e28c9ccb01 There's no need to loop backward, in the end
Change-Id: I2ef533fcc2ac29446a07b98ab34acf1887909c6b
2015-08-21 22:29:41 +02:00
Matteo Casalin
2c3fcc57ea Bail-out early and rework loops to use correct unsigned type
Change-Id: If70d600e1253e9d9271282c361e7edf01314eaa1
2015-08-21 22:29:40 +02:00
Matteo Casalin
b6d799b548 Improve readability (minor code modification, formatting)
Change-Id: I2ce0087493f53579f155f8c399909cdb542aa8a3
2015-08-21 22:29:40 +02:00
Matteo Casalin
a3b3da8d98 Force #defined constants to sal_uInt32 to reduce conversion warnings
Change-Id: I3968bcd55ab4d0ff6215f76be242acc17cf5ccab
2015-08-21 22:29:40 +02:00
Matteo Casalin
c80833fd0e Use sal_uInt16, as required, and use < in for loop condition
Change-Id: Iae44d45d749c6f51be72c0b2d16639c7287c42b2
2015-08-21 22:29:39 +02:00
Matteo Casalin
eb4cbea657 Silence some conversion warnings
Change-Id: I676ed010576f3a24b193ffc6c28a319bcc5ac968
2015-08-21 22:29:39 +02:00
Andras Timar
4215bca955 export 'Chapter' field type as 'StyleRef' into .doc
Change-Id: I7e635c76b08636a9915cee30aaebb08fc854633d
Reviewed-on: https://gerrit.libreoffice.org/17888
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-08-21 20:13:42 +00:00
Caolán McNamara
ade2c591ec add lwp to fftester
Change-Id: I1b31d486de3964a1198fe34e355e9c9542c16c00
2015-08-21 20:10:09 +01:00
Stephan Bergmann
7c473eb789 Enable loplugin:defaultparams
Change-Id: Ie0a17569d1216816fd6357cd2ba1e125d2172408
2015-08-21 18:07:36 +02:00
Stephan Bergmann
cbe115061a loplugin:defaultparams
Change-Id: Id81d6a9aeeb282acf9b961c1a0c7c3961bc17b72
2015-08-21 18:07:11 +02:00
Stephan Bergmann
732f69e623 loplugin:defaultparams
Change-Id: I900ddfbba7f58d4ed78a709170506222a1feb320
2015-08-21 18:06:54 +02:00