Commit Graph

474492 Commits

Author SHA1 Message Date
Andrea Gelmini
c69db531ed Removed duplicated include
Change-Id: I09556d8041023f765980d8b5cf953b955545d0b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133023
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-04-17 10:29:41 +02:00
Noel Grandin
33bd16b344 loplugin:stringviewparam convert methods using copy()
which converts to std::string_view::substr()

Change-Id: I3f42213b41a97e77ddcc79d84d512f49d68ca559
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132729
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-17 10:27:33 +02:00
Mike Kaganski
fe597a3379 Test StarBasic's native non-ASCII name syntax
Change-Id: Ie9f0cd21e59ffc1e3fbe2616e2ae7abbd0169424
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133103
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-17 10:08:08 +02:00
Noel Grandin
00e5bf746f use more string_view in sc
Change-Id: I5f77167ad874200fa4f7bc16e5de8a3348cb1886
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133097
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-17 08:45:20 +02:00
Jim Raykowski
8f27cde891 tdf#148237 Show 'Footnote' and 'Endnote' as field name for field cross
references to footnotes and endnotes

Change-Id: Ie1828c9c4ec0c3c8159c8e5653b09b2b7bd8a5e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133092
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-04-17 05:21:25 +02:00
Jim Raykowski
f7102dafc4 SwNavigator content tracking: clear selections and entry cursor
when entry is not found in content tree

This happens when the document cursor is positioned on table of content
hyperlinks.

Change-Id: I717b2dae31780b26cf5450fbea0c8f461659770c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132989
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-04-17 05:19:20 +02:00
Noel Grandin
7337c41813 use more string_view in sw
Change-Id: Iaf4db41d913dde13ea1ceb3fbbb3dafc21f90d24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133098
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-16 21:25:42 +02:00
Hossein
622b92dab2 Update README.md files
* Fix typo
* Improve links

Change-Id: Ie77ec795675bf7497c90620eb44ebb3191c003b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133067
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-16 20:43:11 +02:00
Andrea Gelmini
670d07cc05 Fix typo
Change-Id: I3f2da2522f80fdcbbd377686032a1f8e919e4484
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133065
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-04-16 20:39:50 +02:00
Caolán McNamara
95ee4f074f Resolves: tdf#148197 crash on launching context menu with no row selected
Change-Id: I4b05e6013ec4fb8f3968484a59c2dacf1e1c97ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133095
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-16 15:21:17 +02:00
Seth Chaiklin
553dd8c722 Update git submodules
* Update helpcontent2 from branch 'master'
  to 8d70f37fcc80c0b6c4fbfa36709ec1b1e9002a40
  - refactoring Line tab help pages
    
          text/shared/01/05200100.xhp  (Line dialog)
            *refactor <h1>,<h2>,<h3>
    
          text/shared/01/05200300.xhp (Arrow Styles tab)
            *refactor <h1>,<h2>
    
          text/shared/00/00040502.xhp  (#line2: "howtoget" line tab)
             +add appl-switch for "howtoget" Line tab
    
    Change-Id: I800a4c69ffce4edc88aec86b5e6cbe6a2e4d4f9c
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132707
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-04-16 13:11:41 +02:00
Stephan Bergmann
590eb262e7 -Werror,-Wunused-const-variable
...since a838334517 "No Win16-style WIN.INI since
Windows Vista"

Change-Id: I36fa3f6516a6bd9ac6593e01163c1f3427933e42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133090
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-16 10:37:38 +02:00
Justin Luth
d9b33ed664 tdf#148380 docx export: support CHANGEDATE/PRINTDATE without format
This is the same idea as the earlier patch for CREATEDATE.
However, it isn't safe to import these as fields,
so a round-trip test can only test the string itself.

The unit test here really doesn't test any of the code changes,
but is just pre-emptive to ensure that if DI_CHANGE
is imported as a field that it will have the right
output.
(P.S. Expected date output matches MS Word 2003
 even after an F9 refresh.)

Change-Id: I30a8b1fc851246898a67e6241a35e927f85dfbb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132664
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2022-04-16 05:47:06 +02:00
Caolán McNamara
4659fc2f0a ofz#46632 Direct-leak
there is no DeinitVCL for fuzzing, so fill the fontoptions,etc cache
before starting

Change-Id: I14a30c3d38490d03c31b4c349674ba48dd32de15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133088
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-16 00:14:25 +02:00
Xisco Fauli
cb21bbc121 tdf#148551: sw: Add UItest
Change-Id: I118c0c91f0ba90f57761512e8e9984186ab4ac19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133080
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-15 23:22:01 +02:00
Xisco Fauli
b4b3398736 tdf#135377: sw: Add UItest
Change-Id: I6e00601e1e8a6971e2668a744a3faac06344403f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133084
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-15 22:35:48 +02:00
Regina Henschel
b195cf4db4 tdf#109169 use custGeom for Octagon Bevel shape
The shapes 'Octagon Bevel', type col_60da8460, and 'Diamond Bevel',
type col-502ad400, are LO specific preset shapes. They have neither a
counterpart in MS binary nor in OOXML. So they need to be exported
with custGeom. To force custGeom these shape types are moved from
vDenylist to vAllowlist.
These shapes were exported as prst='rect' before.

Change-Id: I9619345812b6dba8f14ec2cc6a92ae808a56b595
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133069
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-04-15 22:16:40 +02:00
Noel Grandin
65e846d73c use more string_view in jvmfwk
Change-Id: I05f3b171578b8fef5b15dcbbf10ae9b7cf2d1b02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133075
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-15 21:33:17 +02:00
Noel Grandin
15d8762dd0 use more string_view in cui
Change-Id: I377d95ec2d80cef611c6fce274f1e17504132564
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133074
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-15 21:32:59 +02:00
Xisco Fauli
267a0e9492 tdf#143483: sw: Add UItest
Change-Id: I10d05ea3f2866523e5adaac9ba768073b03c15a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133081
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-15 21:22:44 +02:00
Stephan Bergmann
4cc5ceb9e3 Adapt to clang::PPCallbacks::InclusionDirective change in Clang 15 trunk
<d79ad2f1db>
"[clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective()"

Change-Id: Ib2ea325cca3be03d3b5dfb9dfc3d870be659b129
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133085
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15 21:05:03 +02:00
Caolán McNamara
d1da1c59d1 tdf#148349 add a way to call the user's attention to a widget
Change-Id: I2846155a44f3e51ddd8cc1acd81e84a38b4d3934
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133030
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-15 20:44:49 +02:00
Caolán McNamara
fbfda267e8 gtk[3|4] add the css "warning" "error" to GtkEntry when those states fit
Change-Id: I4063155d25b80f6b5912f0b63dc3c8fa21c7263b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133079
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-15 20:43:47 +02:00
Caolán McNamara
211fb75306 gtk4: warning and error are explicitly mentioned in the documentation
Change-Id: If61b40e6d104ba54e71c4473bf1214a6df999089
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133078
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-15 20:43:31 +02:00
Caolán McNamara
37fb1cbf7b Related: tdf#147237 change the SalObject background when the settings change
which solves the problem of parts of the gtk ui remaining in the old
theme when switching dark<->light

Change-Id: I59060dfdf3937ca13cd706eefc9e67c133478992
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133076
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-15 20:43:16 +02:00
Rene Engelhard
67c577c692 apply ICU test workaround to < 70 to "fix" test with ICU 71
See also 263961306e

Change-Id: Ib64ec43dba59ffddb34fe7f1a0f0d2e589c3455c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133063
Tested-by: René Engelhard <rene@debian.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2022-04-15 20:23:13 +02:00
Noel Grandin
f9a15395dc use more string_view in connectivity
Change-Id: I916db7599e600ba795e02b7afd29b54d1dc7187e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133073
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-15 20:12:11 +02:00
Noel Grandin
558aaa9ed2 use more string_view in xml*
Change-Id: Ie219cb3feb98660463858d00f82f882881946ad0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133072
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-15 20:11:48 +02:00
Noel Grandin
ba74c925a5 use more string_view in fpicker
Change-Id: I2568dfa05082bbd2d3a433c54b47039455d91153
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133071
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-15 20:11:29 +02:00
Xisco Fauli
c5d5c7e8c3 tdf#148494: export: Always add space separator
Otherwise, the macro is saved as MACROBUTTONAllCaps
instead of MACROBUTTON AllCaps

Change-Id: Id1288e23f21ce72884bc1197f171e255ea7458f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133077
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-15 19:17:54 +02:00
Vasily Melenchuk
b2b821715a tdf#148551: sw ui: set default format value for Insert Field dlg
My previous implementation was changing current format selection
only for field edit dialog. However it should be initialized also
for insert field dlg. It is not always first element. Instead of
older confusing approach right now there is a switch to set
defaults: it is less confusing IMO.

Change-Id: I189339ba66effc49267004a42345a28892cb693c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132980
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-15 18:02:00 +02:00
Caolán McNamara
9efab24f38 use the same colors for warning/error for gen ComboBox as Entry does
Change-Id: I0fb24c0d60c66348052334c9a86e6a5425dccb46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133070
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-15 17:57:30 +02:00
Caolán McNamara
a0f9f8ddaa tdf#148448 pick a warning color more likely to be readable in dark theme
I can't see anything that is useful which could be used to derive this
so just pick a better hard coded color

Change-Id: Ia351e636ed3a44e9af79147b2d9dfcf347bd8ea9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133068
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-15 16:16:35 +02:00
Noel Grandin
b9c806b9e3 address potential find/rfind failures
in the conversion in
    commit 74957c7d2f
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Wed Apr 13 13:54:22 2022 +0200
    use more string_view in l10ntools

where the prior code might have been relying on the -1 returned by
indexOf and lastIndexOd

Change-Id: Ief5dedccbaf4e14e5f59aa3c2f7481ff0bb7e2e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133027
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15 14:06:06 +02:00
Stephan Bergmann
6fd447aaf2 loplugin:stringviewparam
Change-Id: I6b7e0482fca0d1b82afa13131ef5206763e1ccb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133032
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15 13:42:34 +02:00
Szymon Kłos
dcc9d7f0a0 jsdialog: close popup correctly
call popdown so we will mark popup as closed in DockingManager
this fixes crash when trying to open autofilter popup second time

Change-Id: I9f2db6fe284d9b9770c20dea4b8a4054524a998b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132619
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132917
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-15 11:26:34 +02:00
Szymon Kłos
02c9687b07 jsdialog: autofilter: unify with regular popup
- remove special type "autofilter"
- now autofilter will be handled by dialog code in online

Change-Id: I3478c3e05ab2e83030a8d68632d0426a5cc0accd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132539
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132916
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-15 11:26:16 +02:00
Caolán McNamara
53ec893208 warning: found </li> tag without matching <li>
so use same solution as com/sun/star/style/XStyleLoader.hdl

Change-Id: I53e77cb6547338f66d7e259779bb5391bc780765
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132999
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-15 10:17:43 +02:00
Caolán McNamara
0ba7674c73 ofz: Timeout 23s->4s
Change-Id: I10d48584e0ab0ce52cabe8077602f557b6392492
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133012
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-15 10:17:00 +02:00
Stephan Bergmann
21121b0cba Also add C++20 char8_t overloads
Change-Id: I1c55ca09b9fd24927acce9f0e2e2d435f23a3e42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133031
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15 09:49:53 +02:00
Stephan Bergmann
020cf33af4 loplugin:stringview
Change-Id: I4e03bb0674dff734c41f4206b1849ede3c6949ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133055
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15 09:37:48 +02:00
Stephan Bergmann
6a9f342add Introduce rtl::createUriCharClass
...to make those char class array initializations more readable.  (Making the
corresponding variables constexpr is mostly done so that failures in the
provided `unencoded` arguments, like non-ASCII characters or duplicate
character typos, would lead to compile-time errors also for !HAVE_CPP_CONSTEVAL.
And assigning to a sal_Bool std::array needs another hack to avoid false
loplugin:implicitboolconversion warnings.)

Change-Id: Ieb8827f69f55f1212a9428817d5331fcb18ef1d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133058
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15 08:39:21 +02:00
Stephan Bergmann
d7480ed72d Add some clarifying comments for o3tl::getToken overloads
Change-Id: Ia81b11b659f6045f9e474b3a32b72e2c5242a80b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133057
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15 08:39:01 +02:00
Stephan Bergmann
f23f594b17 loplugin:stringviewparam
Change-Id: Id3bd8576b134728140dc68b00eebf78a8f3fd4ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133056
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15 08:38:43 +02:00
Stephan Bergmann
6457b72667 loplugin:stringviewparam
Change-Id: Iac1655373f5f30e3499fa5335405fb422fa8dc9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133054
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15 08:38:25 +02:00
Stephan Bergmann
dcd969ba52 loplugin:stringviewparam
Change-Id: Ie9dc89642c197baaf1ecfdfcd340cb6a427147ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133033
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15 08:38:07 +02:00
Mike Kaganski
a838334517 No Win16-style WIN.INI since Windows Vista
Change-Id: I75bc8c7c61e863747cdfc65fb4ed7603c0eb1c0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133034
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-15 07:06:57 +02:00
Tomaž Vajngerl
e1f3f2e00c sc: introduce SparklineShell and Sparkline context
Having a separate sparkline context is very useful, so we can add
a custom UI when the user has the cursor over a sparkline. This
will allow a "Sparkline" tab for NotebookBar and its own deck in
Sidebar, activated only when the sparkline is present. Also the
pop-up menu can be customized specifically for the sparkline, but
this may be less useful.

For the sparkline context we need a custom shell - SparklineShell
where now all the UNO commands can be implemented (not done in
this commit).

Change-Id: Idca2ad946af3afdd1b494744b80c9c093eec602c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133022
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-15 02:49:00 +02:00
Eike Rathke
abe0080d66 Prepare SvNumberFormatter::GetEditFormat() to obtain for another locale
Change-Id: Iab8b9a802ebac60b52007754430352d3de925374
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133026
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2022-04-15 01:40:05 +02:00
Tomaž Vajngerl
32e38ec654 oox: move DataTable{Context,Model} into own file, prop. "showKeys"
Move DataTableContext and DataTableModel into its own files and
add the missing "showKeys" property of the data table (dTable).

Change-Id: I44fb436000c7f00a596fc9b12489d15ea1368e68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133021
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-15 01:35:09 +02:00