Commit Graph

452964 Commits

Author SHA1 Message Date
Caolán McNamara
6ad2f46378 restore removing the entries which are not enabled currently
Change-Id: If24474e362aa80a3a0240a6ab899aa9e71066aef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100389
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-10 10:24:30 +02:00
Caolán McNamara
dd0ee0ccf7 tdf#135529 today/none only used by DateControl
Change-Id: Id8987e65ef3fae9c009af59d3a1f9d0e83726648
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100404
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-10 10:24:04 +02:00
Gülşah Köse
33696b2820 tdf#133015 Inherit numCol from placeholder.
Change-Id: I402a40be7e8899ca017996f2bf77a2fb884b9462
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100372
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-10 06:18:49 +02:00
Gülşah Köse
7b64bd9063 tdf#133015 Do not import multicol table text on master.
Change-Id: I0a1b1dc2f9b314858ed90347065407bcd1dbbb73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100311
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-10 06:18:12 +02:00
Sarper Akdemir
28022cee39 make physics based animation effects part of the animation engine
Wiring up and creating required classes for physics based
animation effects to be part of the animation engine.

Creating a new animation node AnimationPhysicsNode
for physics based animation effects and PhysicsAnimation
class that inherits the NumberAnimation in the animation
factory.

Change-Id: I1f125df5324673e9937b8164c0fc267c9683afa0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100151
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-09 23:44:00 +02:00
Shivam Kumar Singh
6ce2eddfdc tdf#135406 - Border properties not properly listed in the Styles Inspector
Several Border properties are stored as STRUCT internally.
Added support to show them in the Inspector.

Change-Id: Ida1014691ab2245eea04487ce753c23bdf0bddb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100288
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2020-08-09 21:50:11 +02:00
Eike Rathke
3b5fccb308 Resolves: tdf#134876 Absolute range references when selecting in Wizard
Not doing the same for ScInputHandler::SetReference() now because
selecting by keyboard is more likely to keep the existing
behaviour and is easily edited to change.

Change-Id: I368aa21c7f1099d175805493c92070da280cafa4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100267
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
2020-08-09 21:46:00 +02:00
Caolán McNamara
72aeda11bd weld OTasksWindow
moving the InterimItemWindow one layer higher

Change-Id: I500da55f4d4bf4dd31583c9c055564cf299a2166
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100304
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-09 21:43:35 +02:00
Caolán McNamara
7614efb59d weld OCreationList
Change-Id: Ia234233cd44b91518c22e125fef4180068b07be4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100255
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-09 20:18:47 +02:00
Caolán McNamara
a3a6ff25f5 block gen's focus in/out callbacks from grab_focus like gtk's
Change-Id: I6102022495f5ffe644b4aa2b71df2fcf4e0a7b6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100299
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-09 20:17:48 +02:00
Noel Grandin
a7c8c5f49a loplugin:flatten in sc/ui/vba
Change-Id: I9015274bdc71baac2bbef9d34e3d69557533d92e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100399
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-09 19:05:46 +02:00
Noel Grandin
8c505204f2 loplugin:flatten in sc
Change-Id: Iedb6ca37d1b006131d1fc77eca3303a12ccb60c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100401
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-09 19:05:34 +02:00
Caolán McNamara
966b156cbd explain CF for translation
Change-Id: Id3076ad1feb7e2d7d73209a30077b79311eca1c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100388
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-09 17:25:23 +02:00
Noel Grandin
0e1264f44c loplugin:flatten in sc/ui/unoobj
Change-Id: I9b03672387aa555eb11149763a1113e0768f3f37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100398
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-09 15:48:32 +02:00
Noel Grandin
f97077c5fe loplugin:flatten sc/miscdlgs
Change-Id: I41bb4eb1ea06aef2f4e58e0f00d275dcf8879154
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100397
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-09 13:28:29 +02:00
László Németh
f4ca7ea131 tdf#135573 sw: add Székely rovás (Old Hungarian) numerals
Change-Id: Ic309fc9b07186ce0b86ca54028d62e0fafd104fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99950
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-09 12:37:13 +02:00
Regina Henschel
acfd9e9ca2 tdf#128345 PPTX: add transparence gradient for fill in chart
Export cases:
Add transparence gradient on solid color fill by treating the
color fill as gradient with identical start and end color.
Add solid transparence on color gradient, by treating transparence
as gradient.
Import: Add missing property PROP_FillTransparenceGradientName to
spnCommonPropIds so that it is available in spObjTypeFormatEntries.
Otherwise transparence gradients will be skipped on import.

Change-Id: I56218ec1afcc5bd1ce0324ca50c03e0b44f76c58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99464
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-08-09 12:15:54 +02:00
Noel Grandin
3d44c6a49b ucb/core: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: Ieabf6d417a482ea7cc17e78a78954687e8894cb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98801
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-09 12:03:30 +02:00
Noel Grandin
d2140a6320 i18npool: create instances with uno constructors
and rename some classes to match their UNO implementation name.

See tdf#74608 for motivation.

Change-Id: I16aa64781d30a500f234029da6f6b00a645c46bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100133
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-09 09:01:11 +02:00
Johnny_M
2c6e81468e Update git submodules
* Update helpcontent2 from branch 'master'
  to 297a0c90cb07b299bf89bc031b770c3c49ee96a6
  - tdf#132643 Translate German section IDs
    
    Change-Id: Ia874ceab5ff35a79938b6fa6494272b32f276568
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100383
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-09 00:31:42 +02:00
Johnny_M
2c3341877c Update git submodules
* Update helpcontent2 from branch 'master'
  to de46029cbe9d1c7f33592d59095f2220d2e9739a
  - tdf#132643 Translate German section IDs
    
    Change-Id: I9d6dd60e4261f28671331f9ceb3dc926550e51f4
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100382
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-09 00:30:51 +02:00
Stephan Bergmann
11a54f7358 Remove unnecessary, wrong downcast
...during UITest_writer_tests4:

> /sw/source/core/tox/txmsrt.cxx:310:30: runtime error: downcast of address 0x60f00032cd40 which does not point to an object of type 'const SwTOXIndex'
> 0x60f00032cd40: note: object is of type 'SwTOXCustom'
>  47 07 80 4f  90 c1 34 d7 39 2b 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  01 00 00 00
>               ^~~~~~~~~~~~~~~~~~~~~~~
>               vptr for 'SwTOXCustom'
>     #0 0x2b39cf605eb9 in SwTOXIndex::sort_lt(SwTOXSortTabBase const&) /sw/source/core/tox/txmsrt.cxx:310:30
>     #1 0x2b39cc9223b7 in SwTOXBaseSection::InsertSorted(std::unique_ptr<SwTOXSortTabBase, std::default_delete<SwTOXSortTabBase> >) /sw/source/core/doc/doctxm.cxx:1946:19
>     #2 0x2b39cc90c5a7 in SwTOXBaseSection::UpdateMarks(SwTOXInternational const&, SwTextNode const*, SwRootFrame const*) /sw/source/core/doc/doctxm.cxx:1219:13
>     #3 0x2b39cc8f6ab1 in SwTOXBaseSection::Update(SfxItemSet const*, SwRootFrame const*, bool) /sw/source/core/doc/doctxm.cxx:872:9
>     #4 0x2b39d02a07b0 in SwXDocumentIndex::refresh() /sw/source/core/unocore/unoidx.cxx:1261:19
>     #5 0x2b39d028bcd3 in SwXDocumentIndex::update() /sw/source/core/unocore/unoidx.cxx:517:12
>     #6 0x2b3e6a642d3b in SwMultiTOXTabDialog::CreateOrUpdateExample(TOXTypes, unsigned short, unsigned short) /sw/source/ui/index/cntex.cxx:383:67
>     #7 0x2b3e6a637d45 in SwMultiTOXTabDialog::CreateExample_Hdl(SwOneExampleFrame&) /sw/source/ui/index/cntex.cxx:117:9
>     #8 0x2b3e6a63602a in SwMultiTOXTabDialog::LinkStubCreateExample_Hdl(void*, SwOneExampleFrame&) /sw/source/ui/index/cntex.cxx:85:1
>     #9 0x2b39d33ffc99 in Link<SwOneExampleFrame&, void>::Call(SwOneExampleFrame&) const /include/tools/link.hxx:111:45
>     #10 0x2b39d33fa895 in SwOneExampleFrame::TimeoutHdl(Timer*) /sw/source/uibase/utlui/unotools.cxx:403:28
>     #11 0x2b39d33e7d3a in SwOneExampleFrame::LinkStubTimeoutHdl(void*, Timer*) /sw/source/uibase/utlui/unotools.cxx:210:1
>     #12 0x2b396b968321 in Link<Timer*, void>::Call(Timer*) const /include/tools/link.hxx:111:45
>     #13 0x2b396b9678b8 in Timer::Invoke() /vcl/source/app/timer.cxx:75:21
>     #14 0x2b396b7ad806 in Scheduler::ProcessTaskScheduling() /vcl/source/app/scheduler.cxx:484:20
>     #15 0x2b396b7a7680 in Scheduler::CallbackTaskScheduling() /vcl/source/app/scheduler.cxx:287:5
>     #16 0x2b396c3fb790 in SalTimer::CallCallback() /vcl/inc/saltimer.hxx:54:13
>     #17 0x2b396c3eeefc in SvpSalInstance::CheckTimeout(bool) /vcl/headless/svpinst.cxx:209:53
>     #18 0x2b396c3f5665 in SvpSalInstance::DoYield(bool, bool) /vcl/headless/svpinst.cxx:444:21
>     #19 0x2b396b8a6af9 in ImplYield(bool, bool) /vcl/source/app/svapp.cxx:455:48
>     #20 0x2b396b8a5cb7 in Application::Yield() /vcl/source/app/svapp.cxx:519:5
>     #21 0x2b396b8a58f9 in Application::Execute() /vcl/source/app/svapp.cxx:434:9
>     #22 0x2b39302e879c in desktop::Desktop::Main() /desktop/source/app/app.cxx:1600:17
>     #23 0x2b396b94ff29 in ImplSVMain() /vcl/source/app/svmain.cxx:201:35
>     #24 0x2b396b959e00 in SVMain() /vcl/source/app/svmain.cxx:233:12
>     #25 0x2b39304ca014 in soffice_main /desktop/source/app/sofficemain.cxx:98:12
>     #26 0x4efc6c in sal_main /desktop/source/app/main.c:48:15
>     #27 0x4efc46 in main /desktop/source/app/main.c:47:1
>     #28 0x2b393208f504 in __libc_start_main (/lib64/libc.so.6+0x22504)
>     #29 0x41b5c1 in _start (/instdir/program/soffice.bin+0x41b5c1)

(<https://ci.libreoffice.org//job/lo_ubsan/1721/>)

Change-Id: I02fcbd23d13843563042aca7b1e9fed73823ecb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100394
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-08 23:58:33 +02:00
Justin Luth
538898d6b9 related tdf#135216 writerfilter: don't bRemove para with field
So the lovely task of building up every possible exception
where a paragraph has content without noticed character properties
continues...

Change-Id: I1df13f1ea96866b82f44cbbedd52bb525e0d3c2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99761
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-08-08 19:31:50 +02:00
Noel Grandin
c8b7a833c8 loplugin:unusedmethods
Change-Id: I58819edd0965ff52c3fc6c20d84bc5951a79bbe2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100381
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08 18:57:02 +02:00
Justin Luth
a5ada62f56 tdf#135329 sw MS export: prevent skipping at-char anchors
This patch is step 1 - write out bypassed flies.
Step 2 - don't bypass fly positions.

The SearchNext function is skipping some flies
because it is not returning them as a stopping
position (nextAttr), and so OutFly just skipped
them since they didn't exactly match the position
it was acting on.

Generally a bad idea to just ignore a picture etc.
Perhaps this is safe enough to backport all the
way to stable. But pictures are such a mess in
general, and so fragile that I don't know what
the implications might be. Thus I am breaking
this fix down into as small pieces as I possibly
can for the benefit of regression finding/fixing.

Prior to this test, there were no unit tests that failed
    assert ( nPos >= nSwPos );

Change-Id: Idad0ea9d229f107a8b55150c476f3d4a6bdef3f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100375
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-08-08 18:48:47 +02:00
Noel Grandin
000424566d loplugin:unnecessaryvirtual
Change-Id: Idcb25f62f0371178222fb05fb8e3ec9fd335305b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100379
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08 15:12:55 +02:00
Caolán McNamara
f43078e028 don't make InterItemWindow a WB_DIALOGCONTROL
which means pressing tab searches it children, let it be the target, and it
will delegate focus

Change-Id: I353ae6b5a6b62c91b844fcd10508f8689db77038
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100298
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-08 14:58:41 +02:00
Caolán McNamara
4ea3ac6bba cid#1465675 Uninitialized scalar field
Change-Id: I518129aa01bbe10a5050edb9ecef669d7b4b1bc8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100292
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-08 14:58:15 +02:00
Caolán McNamara
f0f1d1fb2f merge dbaui::OMarkableTreeListBox with dbaui::OTableTreeListBox
Change-Id: I5cde5c453493e5287faa770eede2e42b21075477
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100330
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-08 14:57:56 +02:00
Stephan Bergmann
2f2246d22e external/cppunit: Run tests in deterministic order
What prompted me to make this change is that when I tried an --enable-lto build,
CppunitTest_xmlsecurity_signing failed in a non-obvious way, and I noticed that
it ran the individual tests in a different order than a --disable-lto build.

With this change, CppunitTest_xmlsecurity_signing also started to fail in the
--disable-lto build, which has meanwhile been fixed with
800eebfa82 "Database document apparently needs to
be closed before it is disposed".  No other tests started to fail in my
Linux --disable-lto-build with this change, and my Linux --enable-lto build
(using recent Fedora 32 GCC 10.2 and the default linker) also succeeds `make
check` after 800eebfa82, both with and without
this cppunit change.
(<https://bugs.documentfoundation.org/show_bug.cgi?id=126442> "LTO build
segfaults in sw_apitests" and <https://src.fedoraproject.org/rpms/libreoffice/c/
5d644f1606b76ffa4a102433849a824d7293a404> "%check fails with lto enabled"
indicate that older branches also fail CppunitTest_sw_apitests with
--enable-lto, but I could not reproduce that on current master.)

What happens in cppunit is that every CPPUNIT_TEST_SUITE_REGISTRATION (or other
macro like CPPUNIT_TEST_FIXTURE internally calling
CPPUNIT_TEST_SUITE_REGISTRATION) creates a global static variable whose ctor
inserts the address of a sub-object of that global static variable into the
TestFactoryRegistry::m_factories set.  Even if the order of invocation of those
ctors from one .cxx is deterministic, the relative order or the addresses of
those sub-objects inserted into the TestFactoryRegistry::m_factories set need
not be (though they probably typically are).  Another source of nondeterminism
is that the order of ctors from different .cxx is not specified (which might
have caused the CppunitTest_xmlsecurity_signing failures, given that test
includes suites from two different .cxx).

So to make test execution more reproducible, make the order in which the tests
are run deterministic, sorting them by name.  (When
TestFactoryRegistry::addTestToSuite the adds the sorted tests to
TestSuite::addTest, they are inserted into a TestSuite::m_tests vector, from
which point on things appear to already happen in a deterministic order.)

Change-Id: I40741f397a96772974fd41bacdb3dd763c885417
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100384
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-08 14:18:54 +02:00
Noel Grandin
7d8c8af4b2 loplugin:unusedfields
Change-Id: I9fd1e742fea5d2f6c45fb2086df79b420d514e98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100380
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08 13:47:49 +02:00
Noel Grandin
5a79c78338 loplugin:virtualdead
Change-Id: Ib2a4ebad50e9c6f0d71a9ac3a1bc8ac11e775496
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100378
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08 12:58:58 +02:00
Noel Grandin
5d47604c0a use std::string_view
Change-Id: Iac8367a1ea3ec603b5db8b3dd8bdc7dd7265eb83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100377
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08 12:58:29 +02:00
Stephan Bergmann
393c3930c8 Remove dead code
mxComponent is known to be null at the start of a test function

Change-Id: Ifb3b7dd33769ef71d980fb110eab2dceb03bc52c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100370
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-08 12:36:13 +02:00
Noel Grandin
358bdc5eb3 loplugin:flatten in sc/filter/oox
Change-Id: Idd536dbeaee1f1db3317d96b90e56691976a89ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100338
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08 10:42:13 +02:00
Stephan Bergmann
800eebfa82 Database document apparently needs to be closed before it is disposed
Otherwise, if a test like testPreserveMacroTemplateSignature10::TestBody from
xmlsecurity/qa/unit/signing/signing.cxx happens to be executed after
testPreserveMacroSignatureODB::TestBody from
xmlsecurity/qa/unit/signing/signing2.cxx during CppunitTest_xmlsecurity_signing,
it would SIGABRT with something like

> warn:sfx.view:1935717:1935717:sfx2/source/view/frmload.cxx:489: DBG_UNHANDLED_EXCEPTION in static void (anonymous namespace)::SfxFrameLoader_Impl::impl_handleCaughtError_nothrow(const com::sun::uno::Any &, const ::comphelper::NamedValueCollection &) exception: com.sun.star.lang.DisposedException message: Frame disposed /home/sbergman/lo/core/framework/source/services/frame.cxx:362
> warn:legacy.osl:1935717:1935717:vcl/source/window/window.cxx:273: Window ( 19SfxFrameWindow_Impl()) with live children destroyed:  23SfxFrameViewWindow_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl()
> Window ( 19SfxFrameWindow_Impl()) with live children destroyed:  23SfxFrameViewWindow_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl()

at

> #7  0x00007ff59b2599e9 in SalAbort(rtl::OUString const&, bool) (rErrorText="Window ( 19SfxFrameWindow_Impl()) with live children destroyed:  23SfxFrameViewWindow_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl() 14SfxSplitWindow("..., bDumpCore=true) at vcl/source/app/salplug.cxx:303
> #8  0x00007ff59b08c751 in Application::Abort(rtl::OUString const&) (rErrorText="Window ( 19SfxFrameWindow_Impl()) with live children destroyed:  23SfxFrameViewWindow_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl() 14SfxSplitWindow() 21SfxEmptySplitWin_Impl() 14SfxSplitWindow("...) at vcl/source/app/svapp.cxx:281
> #9  0x00007ff59a846f98 in vcl::Window::dispose() (this=0x4ea35d0) at vcl/source/window/window.cxx:274
> #10 0x00007ff5954ff853 in SfxFrameWindow_Impl::dispose() (this=0x4ea35d0) at sfx2/source/view/frame2.cxx:82
> #11 0x00007ff59aad5161 in VclReferenceBase::disposeOnce() (this=0x4ea3818) at vcl/source/outdev/vclreferencebase.cxx:38
> #12 0x00007ff591c3815b in VclPtr<OutputDevice>::disposeAndClear() (this=0x7ffd92f67810) at include/vcl/vclptr.hxx:206
> #13 0x00007ff591cbaeb8 in VCLXWindow::dispose() (this=0x52fb4c0) at toolkit/source/awt/vclxwindow.cxx:920
> #14 0x00007ff59300e147 in (anonymous namespace)::XFrameImpl::setComponent(com::sun::uno::Reference<com::sun::awt::XWindow> const&, com::sun::uno::Reference<com::sun::frame::XController> const&) (this=0x4f02260, xComponentWindow=empty uno::Reference, xController=empty uno::Reference) at framework/source/services/frame.cxx:1514
> #15 0x00007ff5930104ee in (anonymous namespace)::XFrameImpl::close(unsigned char) (this=0x4f02260, bDeliverOwnership=1 '\001') at framework/source/services/frame.cxx:1692
> #16 0x00007ff593016633 in (anonymous namespace)::XFrameImpl::implts_checkSuicide() (this=0x4f02260) at framework/source/services/frame.cxx:3189
> #17 0x00007ff59300ffb4 in (anonymous namespace)::XFrameImpl::removeActionLock() (this=0x4f02260) at framework/source/services/frame.cxx:2683
> #18 0x00007ff592fa892f in framework::ActionLockGuard::freeResource() (this=0x7ffd92f68bd0) at framework/source/inc/loadenv/actionlockguard.hxx:123
> #19 0x00007ff592f9e2de in framework::LoadEnv::impl_reactForLoadingState() (this=0x7ffd92f68ac8) at framework/source/loadenv/loadenv.cxx:1637
> #20 0x00007ff592f9d9fc in framework::LoadEnv::impl_setResult(bool) (this=0x7ffd92f68ac8, bResult=false) at framework/source/loadenv/loadenv.cxx:515
> #21 0x00007ff592f9d851 in framework::LoadEnv::impl_loadContent() (this=0x7ffd92f68ac8) at framework/source/loadenv/loadenv.cxx:1160
> #22 0x00007ff592f9a502 in framework::LoadEnv::start() (this=0x7ffd92f68ac8) at framework/source/loadenv/loadenv.cxx:395
> #23 0x00007ff592f98261 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&, com::sun::uno::Reference<com::sun::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) (this=0x7ffd92f68ac8, sURL="file:///xmlsecurity/qa/unit/signing/data/tdf42316.ott", lMediaDescriptor=uno::Sequence of length 2 = {...}, xBaseFrame=uno::Reference to (class framework::Desktop *) 0x18b3c48, sTarget="_default", nSearchFlags=0, eFeature=LoadEnvFeatures::NONE) at framework/source/loadenv/loadenv.cxx:300
> #24 0x00007ff592f96bdc in framework::LoadEnv::loadComponentFromURL(com::sun::uno::Reference<com::sun::frame::XComponentLoader> const&, com::sun::uno::Reference<com::sun::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&) (xLoader=uno::Reference to (class framework::Desktop *) 0x18b3c58, xContext=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0xa6aeb0, sURL="file:///xmlsecurity/qa/unit/signing/data/tdf42316.ott", sTarget="_default", nSearchFlags=0, lArgs=uno::Sequence of length 2 = {...}) at framework/source/loadenv/loadenv.cxx:169
> #25 0x00007ff592ff8ce2 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&) (this=0x18b3be0, sURL="file:///xmlsecurity/qa/unit/signing/data/tdf42316.ott", sTargetFrameName="_default", nSearchFlags=0, lArguments=uno::Sequence of length 2 = {...}) at framework/source/services/desktop.cxx:593
> #26 0x00007ff592ff8da5 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&) () at workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XComponent.hpp:136
> #27 0x00007ff593d7bb28 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&) (this=0x18a6d80, rURL="file:///xmlsecurity/qa/unit/signing/data/tdf42316.ott", rDocService="", rExtraArgs=uno::Sequence of length 1 = {...}) at unotest/source/cpp/macros_test.cxx:61
> #28 0x00007ff5956b132d in testPreserveMacroTemplateSignature10::TestBody() (this=0x18a6d30) at xmlsecurity/qa/unit/signing/signing.cxx:1243

Change-Id: If2c45a8fc8d907b12f4d92c77f524d50d9e928cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100344
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-08 10:28:02 +02:00
Julien Nabet
749ac5f415 Typo bSlideBackgoundPainted
Change-Id: Ice11d37e9832b5841f36e8873f4d11e9c0d6b3c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100376
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-08 10:21:28 +02:00
Julien Nabet
ba20c2b187 tdf#58518: add message in case of not text file with "Insert->File" in Writer
Change-Id: I5d3d6153cdb58485043e80331e0b4f1e55a03412
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99941
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-08 09:34:15 +02:00
Rene Engelhard
7f8c2d8f96 bump libnumbertext requirement to >= 1.0.6
because otherwise

Test name: SwUiWriterTest::testTdf133589
equality assertion failed
- Expected: 𐳥𐳋𐳓𐳉𐳗
- Actual  : székely 0

Failures !!!
Run: 305   Failure total: 1   Failures: 1   Errors: 0

happens with (system-)libnumbertext 1.0.5

Change-Id: Ibbb33f41840b239c58e80c2a1a2c8ff5d41df58a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100342
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
2020-08-08 09:31:50 +02:00
Noel Grandin
66d0815d79 loplugin:flatten in sc/filter/excel
Change-Id: I48ab5b20a3345cd40d4715c3ff025d2df3b491fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100337
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08 08:48:28 +02:00
Noel Grandin
37c3da6d2c loplugin:flatten in sc/filter
Change-Id: I3fa60b5c1ef253d9e9e9a727e29c052de277e77a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100339
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08 08:46:37 +02:00
Stephan Bergmann
47b19a51c4 Make use of std string_view
Change-Id: I81d8a0ccff0a9d0ff1aa7fbb6006e80e1fce76fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100315
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08 08:45:51 +02:00
Heiko Tietze
13d788b476 Clean-up of abstdlg
Unnecessary functions regarding the about dialog removed

Change-Id: I739a6b1383a0096ec46e2316da3c5327dafe1675
Follow-up to 39e83e2e42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99985
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-08 07:56:12 +02:00
Srijan Bhatia
d04260e531 Presenter console new vertical separator
Change-Id: I82e30a8dd73ba91605ae839847fb6378b1d54b3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100044
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-08-08 07:55:34 +02:00
Johnny_M
7657fecbce Update git submodules
* Update helpcontent2 from branch 'master'
  to d94a25c58b03f7619430ec7bf66564de16600548
  - tdf#132643 Translate German section IDs
    
    Change-Id: If138eff022dc58dda7c6f6f7d9bb749a0f717684
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100341
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-08 01:27:18 +02:00
Andrea Gelmini
255d7e562c Fix typos
Change-Id: Ic28a1cdc779af9438555acd3bf85312e5e244fe6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100336
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-07 23:08:59 +02:00
Andrea Gelmini
621580eda6 Fix typos to complete commit cfce486
See:
https: //gerrit.libreoffice.org/c/core/+/100172
Change-Id: Iefcf549f23fa27affe7b6254d82eb2fc8ecf283b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100334
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-07 23:08:45 +02:00
Caolán McNamara
e17e3dd6d9 cid#1465671 Unchecked return value
Change-Id: I796799f2964f70f107acc53d376379a79e044472
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100294
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-07 21:44:29 +02:00
Caolán McNamara
c8284fea44 cid#1465674 silence Copy-paste error
Change-Id: I5b90774ffae5ee0ce32de1d557bd50f2d6b775cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100293
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-07 21:24:11 +02:00
Xisco Fauli
bdbf72d9a2 tdf#134572: sw_ooxmlimport: Add unittest
Change-Id: I9162211edb583201ba4600362045379fbed2b05c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100302
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-08-07 21:07:05 +02:00