452964 Commits

Author SHA1 Message Date
Michael Stahl
c7d1bb119d nss: fix Android build
Change-Id: I8d6704a00ee70c1cb397f8f12dac8050f24f44be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100917
Tested-by: Michael Stahl <michael.stahl@cib.de>
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-18 15:38:45 +02:00
Michael Weghorn
b1b1b8f8c1 tdf#135432 native-code: Add missing include for locales
While commit ed8bce1909f658d8e3d950f374931242f91ba811
("fix i18n constructors and android scripts", 2020-08-12)
had added the missing constructors to the native-code.py
script after commit 155c056b1d4674d5ff73bbb5e1ad1dcd1e6aae36
("i18npool: create instances with uno constructors",
2020-07-29), the include for the header containing the
corresponding 'WITH_LOCALE_*' defines was missing,
so expressions like

    #if WITH_LOCALE_ALL || WITH_LOCALE_ja

always evaluated to 0, effectively always keeping the
constructors from actually being included.

Therefore, add the missing 'config_locales.h' include.

Change-Id: Icb00e058cc67a6aedac825c122c151c222f40b43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100915
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-08-18 14:58:31 +02:00
Noel Grandin
16d9d1d112 new loplugin:unusedvarsglobal
I copied and modified the unusedfields plugin to find unused
variables.

Change-Id: I18ed6daa202da70a2e564e4fe4760aed7ce070ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100891
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-18 14:48:51 +02:00
Rizal Muttaqin
e98694bd78 Update Line Numbering icons
Change-Id: Ib0f4595b7a9fe3f60e272bdd998609f510af03db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100914
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-08-18 14:42:34 +02:00
Rizal Muttaqin
cff430c6ba Sifr: tdf#135872, missing Line Numbering icon
Change-Id: Ic44d598b7f7c66f45dbf1e4e419f6f76e13c7f6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100910
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-08-18 14:22:35 +02:00
Caolán McNamara
4b97463059 merge OSqlEdit and MultiLineEditSyntaxHighlight
Change-Id: Ie3e38afd976620068c644809c4a88cd3809759a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100907
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18 13:50:01 +02:00
Stephan Bergmann
1b006f8aaa Add missing punctuation/spaces to error messages
Change-Id: I4be46342b24a5993df74dbd047d88842a8df0412
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100901
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-18 13:29:22 +02:00
Caolán McNamara
a2d9713541 annotation label doesn't need to be a MultiLine edit, FixedText is enough
Change-Id: Ib5db02be9d29f0ba21bf4295be8cf81be2cb409b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100905
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18 12:56:41 +02:00
Caolán McNamara
660e82ee8c move TextWindowPeer to its only user
Change-Id: I16cc2f75c3e639915c90edc626829e455bda4383
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100889
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18 12:40:51 +02:00
Caolán McNamara
643d62d603 move VCLXMultiLineEdit and MultiLineEdit to toolkit
Change-Id: I9aa4b1efbecb71141647dbf5d8809482be15d266
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100888
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18 12:40:27 +02:00
Caolán McNamara
ed64a526fd ofz#24942 missing constructor
Change-Id: I481845a3d64cb2ec0749c9a113db09234dc99143
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100912
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18 12:26:22 +02:00
Caolán McNamara
2ff4321021 remove newly unused ExtMultiLineEdit
Change-Id: If9a1639d28aa7a540f301657387a04309ba82580
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100873
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18 12:18:59 +02:00
Caolán McNamara
be3b1a8393 weld OAppDetailPageHelper
Change-Id: I0fa9f21c30bba8f781178b0811f3f7d755af1bb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100627
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18 12:18:34 +02:00
Caolán McNamara
f1a458a508 we want the child of the node, not the toplevel child
Change-Id: I22be4c4670422ab88e6ebcf9edc21e34db29a0a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100900
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18 12:18:10 +02:00
Caolán McNamara
15e75a08a2 keep m_nCursorIndex updated with the most recent used entry
so right clicking on the tree keeps current entry selected on re-focus
in

Change-Id: I25ecb11b8fefbff6464e02936b2a669c34c42b8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100852
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18 12:17:38 +02:00
László Németh
e1aea22f3f tdf#123354 DOCX import: fix ABS formula
Convert ABS(x) to the equivalent, but
working Writer formula SQRT(x POW 2).

Note: this is a temporary conversion, which
supports only 1-level nesting of function calls.

Change-Id: I96ad01dc5ac26160792e6a4cb050e103c2ad7bca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100898
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-18 12:05:52 +02:00
Mike Kaganski
3a7a06067e tdf#133661: make soffice.odt a bare minimal ODT, with no data at all
Hopefully this would prevent in the future the sequences like what has
happened in the past, when first 9fceed463ba6ab752ef49f40e628a98e21cf525e
removed page dimensions, then 2a33c69b16cce539951a796d7afa45c13b097cf6
added them back when trying to provide better font defaults, and then
5d9348b13674baf1d27f406767274e764c758bd5 changed the dimensions from one
standard to another...

Of course, this is just a simple solution, still not allowing one to use
custom templates when using ShellNew functionality.

Change-Id: I7b48fedad8ba7f85f8cfdd0f98ccb505c51d1e76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100899
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-18 12:04:21 +02:00
Stephan Bergmann
15914df5f0 Silence new Clang 12 trunk -Werror,-Wstring-concatenation
"suspicious concatenation of string literals in an array initialization; did you
mean to separate the elements with a comma?"

Change-Id: I83828d8cc6f8ab9b0c1ca8a1c3fb528592c46504
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100897
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-18 11:45:52 +02:00
Stephan Bergmann
dcff0c200f unoidl-read: Avoid redundant redeclarations
...of interfaces for which such a forward declaration has already been emitted.
Update the reference rdbs accordingly with

LD_LIBRARY_PATH=.../master/instdir/program \
 .../master/workdir/LinkTarget/Executable/unoidl-read --published \
 .../libreoffice-7.0.0.3/instdir/program/types.rdb \
 >.../master/udkapi/type_reference/udkapi.idl

LD_LIBRARY_PATH=.../master/instdir/program \
 .../master/workdir/LinkTarget/Executable/unoidl-read --published \
 .../libreoffice-7.0.0.3/instdir/program/types.rdb \
 .../libreoffice-7.0.0.3/instdir/program/types/offapi.rdb \
 >.../master/offapi/type_reference/offapi.idl

Change-Id: I7448ae44d479a8c622f6f534abe6087ce8a8ea32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100896
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-18 11:36:26 +02:00
Stephan Bergmann
1e6dc8e4f7 Update the reference rdbs to libreoffice-7.0.0.3
LD_LIBRARY_PATH=/data/sbergman/lo-clang/core/instdir/program \
 /data/sbergman/lo-clang/core/workdir/LinkTarget/Executable/unoidl-read --published \
 /data/sbergman/lo-7.0/core/instdir/program/types.rdb \
 >/data/sbergman/lo-clang/core/udkapi/type_reference/udkapi.idl

* no changes

LD_LIBRARY_PATH=/data/sbergman/lo-clang/core/instdir/program \
 /data/sbergman/lo-clang/core/workdir/LinkTarget/Executable/unoidl-read --published \
 /data/sbergman/lo-7.0/core/instdir/program/types.rdb \
 /data/sbergman/lo-7.0/core/instdir/program/types/offapi.rdb \
 >/data/sbergman/lo-clang/core/offapi/type_reference/offapi.idl

* (XDcoumentHandler getting moved around now is a consequence of this being the
  first fully-automated generation of the file again after the manual
  modifications done by the preceding 214e6caf2c503d817c47ebcc419e4f7e33b336ac
  "[API CHANGE] remove BasicImport UNO interfaces" and
  ebb66ee09b6041cbf755f24e54f2d1a510bbc3d3 "Fixed update of the reference rdbs
  to libreoffice-6.4.0.3-buildfix1".)

Change-Id: I841b6b5a059c78750fa7f02f9276c6b6f86c9afd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100892
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-18 09:28:42 +02:00
Miklos Vajna
b784ee4feb tdf#135016 DOCX export: fix unexpected error on save with undo/redo
Regression from commit d379d18666aa42031359ca8eb34b0021960347ae (oox:
import WPS shape with text as shape with textbox, 2014-06-18), then
problem was that when undo restored text deleted by cut, we ended up
with an SwXShape that had no frame format.

Fix the problem by deleting the cached old UNO wrapper after changing
the association between a textbox's shape and text frame.

An alternative would be to handle errors better when the TextBox UNO
property is not of type bool, but that would still lead to silent data
loss, so don't fix the problem that way.

Change-Id: Id45ad292befc746e7c49a3b827c91efd069d29df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100876
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-18 09:03:45 +02:00
Mike Kaganski
b7b4565473 Dereference of nullptr
... opening attachment 164348 from tdf#135799

Change-Id: I7d9b38bf34c7120fee39707ed99a0e6e2c2c84e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100878
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-18 08:02:30 +02:00
Rizal Muttaqin
c8a059643b elementary & Colibre: tdf#131456 Orientation icons
- elementary: Update page margin & page size icons

Change-Id: Ie5189a1b29ab791c6ec74a6c2c692d8864f8d9a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100890
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-08-18 02:12:52 +02:00
László Németh
82189fdc93 tdf133647 tdf123386 tdf123389 fix DOCX table formula export
Keep original DOCX table formula during round-trip
using grab-bagging.

This is a temporary solution until fixing formula export
and a proposed solution for formula cannot be converted.

Follow-up of commit 68e74bdf63e992666016c790e8e4cfd5b28d6abe
(tdf133647 tdf123386 tdf123389 Improved .docx table formula import).

Change-Id: Ia4759e250c06e9cc0495fb0b57fccd1ee1f50da9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100872
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-17 23:30:21 +02:00
Mike Kaganski
7da32109ec Don't forget to increment refcount when loading from image
Otherwise it will fail assertion in SbxValue::Clear, because
SvRefBase::ReleaseRef would check that its current count is
not zero. In release builds, not doing this would leak.

Change-Id: I80dfc815f8a2b651ff290af10808212281abf246
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100879
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-17 22:05:05 +02:00
Mike Kaganski
d7d9d3cf1a tdf#135799: properly load arrays in user-defined types from image
This requires to reset Fixed flag temporarily, as in SbiParser::DefType
for non-image case.

And save the dimensions of the arrays in the custom types correctly:
the dimensions are numbered from 1, not from 0.

The existing unit test (that happened to not test anything actually)
was fixed.

Change-Id: I48c6b6d5d735d9972a2c0dd40345d5db75f87f39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100877
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-17 22:03:34 +02:00
A_GAN
b6e508fc47 tdf#134052:shadow appears solid instead of blurry in presentation mode
Add shadow primitive id into the switch case to run
ProcessPrimitive2DOnPixelProcessor function.

Change-Id: I059771ba4c56eca50c74aad81c4dec193b454dca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100861
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-17 21:02:36 +02:00
Justin Luth
15d3a38648 tdf#135338 sw layout: show FirstLeft on very first left page style.
Although extremely unlikely, the Left Page style can have a different
Left and FirstLeft. In the even more unlikely case that the document
starts off using a left-page-only style, then the first header
would not show on the first page, but only on all of the following
left-only pages.

So, of course, we want the very first visible page in the document
to show the defined First header/footer.

Change-Id: I7e74fdc085509fb8d6b80f36d1402309b9db9404
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99862
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-08-17 20:53:00 +02:00
Andrea Gelmini
d7484b08c6 Fix typos
Change-Id: Id31299912b822baf9eecbb03cba53339f0528ae8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100867
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-17 19:42:42 +02:00
Tomaž Vajngerl
bda18edf18 Add test for preserving page number when suapping
Change-Id: I1a7028d1768d0098aabbbc519d1b7936ddfc4a48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100838
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-17 16:49:56 +02:00
Tomaž Vajngerl
74e2f2178f move vector graphic search to View, so it works in multiple views
VectorGraphicSearch was instantiated for the Outline, which is
the same for every view. The problem with this is that when we
have multiple views, the search would interfere with each other,
which is especially distracting in online when multiple users
connect to the same document and try searching.
This adds VectorGraphicSearchContext class, that is added to the
View, which makes the search view dependent and multiple instances
of VectorGraphicSearch are created, each one for its own view.

Change-Id: Ia0f34647b30b35f4ddb84d33353990d635756905
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100837
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-17 16:49:39 +02:00
Noel Grandin
e40e5726e0 loplugin:unusedmethods
Change-Id: I31002cc322c43498ef8c37f6b7f94ae1a8278ba9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100857
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17 16:26:34 +02:00
Michael Meeks
4a31ceba3b Remove redundant Invalidate()
Probable merge error in CWS impressfunctions dc5479dcc39.

Change-Id: Ifa8dc9dbeeecf2dd6da44909060b72a20a7042a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100783
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-08-17 15:58:02 +02:00
Sarper Akdemir
3bc2154ebf fix box2dtools build error for non debug builds
Removed the asserts and moved the functions out of the
box2DWorld class.

Change-Id: Ifa58bceb2c64c1012e5d0e65bc12646312ab1c16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100856
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-17 14:19:03 +02:00
Stephan Bergmann
f7fe1e93da Always display highlighted JRE's location
...when opening the Advanced options page and after adding a new JRE via the
"Add..." button, not only after highlighting another JRE line.  (I suspect this
broke with 1aa246a8e8c7d974ab0f7bdfa16cda36cb700e03 "weld SvxJavaOptionsPage"
towards LO 6.4.)

Change-Id: I5f9b63e2d33a351eeef09712969b703f1e99ef7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100860
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17 14:17:36 +02:00
Christian Lohmaier
fff00151fa Update git submodules
* Update translations from branch 'master'
  to e8c9e70e057aec51c783b7230f1995020374d06f
  - update translations for master
    
    and force-fix errors using pocheck
    
    Change-Id: I9e806cc79950a35df80dc1ffeab84cd5f18dc861
2020-08-17 14:15:08 +02:00
Noel Grandin
dd6db74abd inline some use-once typedefs
Change-Id: I683175c1e788a2a4cfec9504dc8dc3ebfee7c5de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100858
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17 14:11:12 +02:00
Tomaž Vajngerl
28beaffba6 vcl: save and load the page number when swapping the graphic
PDF vector graphic includes a page number, of the page that the
graphic is rendering. This however isn't remembered when swapping
out and back in the graphic, because the serialization format
doesn't include it.

This adds a version 2 of the serialization format, with an
additional page number (page index) attribute.

Also changes the GraphicTest to account for an additional 4 bytes
written and the change of the checksum.

Change-Id: Ic0fbfc4ad983f7880e06956da3b4664bd4b610d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100836
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-17 13:45:08 +02:00
Stephan Bergmann
cbafdc3561 Move compilerplugins-related .gitignore content to compilerplugins/.gitignore
...and expand it to precisely match the three .dwo files, like had already been
done for the corresponding .o files.  (Those .dwo files are generated when
-gsplit-dwarf is added to CLANGCXXFLAGS when manually overriding CLANGDEBUG=1.)

Change-Id: Ib6f1c505c754d54201273f08f987a9451af75bc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100855
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17 13:38:04 +02:00
Stephan Bergmann
3d0aca29e3 Remove dead comment
...which had been dead ever since b525a3115f54576017a576ff842dede5e2e3545d
"initial import" and whose removal has already been suggested in
04bb20f5ad182fd1aa8a4e2e7f569043be8405c1 "Fix typo"

Change-Id: I57d1e284e9c38836dca620fd3d0058fc5c6f098e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100854
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17 13:36:08 +02:00
Stephan Bergmann
931e923cdc solenv/flatpak-manifest.in: Merge "Clean krb5 module"
<0b374f83d1>

Change-Id: Ib7aa25f6296a49d3ffaa7055d4d5c055ce6dacbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100849
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17 13:13:18 +02:00
Caolán McNamara
a59f45d580 Related: tdf#135743 position combobox dropdowns correctly for RTL
Change-Id: I4f8e70e128fd8506e7f95291226fc52599f15896
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100758
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17 12:17:08 +02:00
Caolán McNamara
4d7bf28b2c tdf#135743 only overwrite our geometry with the valid entries
Change-Id: I228ebfed17d922704d72529c714fde220b9d20cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100825
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17 12:16:50 +02:00
Noel Grandin
9951d41460 [API CHANGE] remove OSL_SIGNAL_USER_RESOURCEFAILURE
which is unused since
    commit 00657aef09d854c74fb426a935a3e8b1fc390bb0
    Date:   Sun Jun 11 20:56:30 2017 +0100
    migrate to boost::gettext

Change-Id: Ia66a3a729dc4999c95b96ae1754b07c372121370
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100810
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17 12:08:07 +02:00
Michael Warner
68e74bdf63 tdf133647 tdf123386 tdf123389 Improved .docx table formula import
Converts table formula syntax from MS Word to LibreOffice.
This version uses the list separator of the document for the
formula regexen; however, it does not convert the decimal or
list separators in the case where the person opening the document
is using a different locale from the author.

Change-Id: I9600a0bea060a76705a7ad6b051ed4fdd50b9d40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98614
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-17 11:15:25 +02:00
Miklos Vajna
3297c44c14 sw: prefix members of SwNode2LayImpl, SwRetrievedInputStreamDataManager, ...
... SwXDrawPage and SwXShape

See tdf#94879 for motivation.

Change-Id: I0cfdc1a1b7e1667dccf8db29616b895a76b8fea5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100843
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2020-08-17 10:20:48 +02:00
Caolán McNamara
bb4ebb8bd1 tdf#132892 Revert "sw: paragraph-sign: erase metafields ... correctly"
This reverts commit b402d0112a0bb53221b847fa372bfa3f6390a0e2.

Change-Id: I210d2fded01fb952d7384b78240e32d868b08575
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100753
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17 10:20:38 +02:00
Caolán McNamara
00c9b04028 tdf#135743 ignore size-allocations triggered by an embedded SalObject
getting configured, we already ignored them for painting, do the
same for the size-requests it output from our internal configuring

Change-Id: I4c0153535459b089ba6c31e3d9f09bfae2545806
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100824
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17 10:17:23 +02:00
Stephan Bergmann
daa7d18222 "loplugin:stringstatic also look for local statics" macOS redux
...plus addressing follow-up loplugin:stringconstant when inlining the literals
at their sole call sites

Change-Id: I727e2d3fe53e85af328afc5fba92e52fb63c49b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100839
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17 09:42:00 +02:00
Stephan Bergmann
3f2e85ae2c Remove leftover debug include
Change-Id: Idca54798ab5ad464f8a641eb6250cb20aa2147ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100840
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17 09:41:30 +02:00