Commit Graph

340679 Commits

Author SHA1 Message Date
Adam Co
c7e66b3214 Revert code that push copy of 'rPr' inside 'pPr' in DOCX export
There was code that was inserted by commit id
'8c178a50334109b34ef456ca6aa51cd3d98699ae' that added logic to
also export 'rPr' in the 'pPr' node.
The 'rPr' represents the paragraph marker formatting.
However - simply copying the last run's formatting and assuming
it is the same for the paragraph marker should not be used.

Also refer to 'aafffe6d1c3734fb2acef4b2bb1385c1e2f49043' for
details on test-case disable.

Change-Id: I6004e4c706abfeb5f51d86d11d3ebf46256a68c5
Reviewed-on: https://gerrit.libreoffice.org/7121
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-12-18 09:02:09 +00:00
Stephan Bergmann
a107c6bd8c Remove unnecessary macros
Change-Id: I1d7cdea37db59f58ca100489e593b882a951d96a
2013-12-18 09:38:19 +01:00
Matúš Kukan
5888cb101f missing boost_headers external
Change-Id: Ib30dddbc1b105c89c5882f5f857dc20134eca7e6
2013-12-18 07:24:06 +01:00
Matúš Kukan
ff9614a744 Add a unit test trying to create every available service with default ctor.
Change-Id: I79e70aeabdb816eaf7a719d2094034d78d11c90b
2013-12-18 07:15:50 +01:00
Matúš Kukan
d8bbae2fd6 Get more --disable-dynamic-loading code out of shlib.cxx.
It's not terribly nice, but, hopefully, better.
The hope is that one day, lo_get_library_map will be no more.
In lo_get_implementation_map we can specify more precisely what to link
into the binary.

Change-Id: I99a1854fbae05be2f70302cc56bea88e522ec129
2013-12-18 07:15:49 +01:00
Matúš Kukan
e20f27f0a0 bootstrap component: Split into implementation functions.
Change-Id: I91cb0177edd79485eab885e995e79b1a19a769d5
2013-12-18 07:15:49 +01:00
Matúš Kukan
291e846db9 sax: various clean up. Move _getFactory next to the implementation.
Use more anonymous namespaces, de-duplicate code, bin some comments.
Makes the library smaller.

Change-Id: Id0cefdcaa72a74741303fc27e36038488ef8b059
2013-12-18 07:15:48 +01:00
Matúš Kukan
562b21949f Deduplicate some foo_component_getFactory declarations.
Change-Id: I9304b62134bab375b721399ae078bf66e01191d8
2013-12-18 07:15:47 +01:00
Matúš Kukan
b6cebf4a3e Allow UNO component libraries to have each implementation in its own function.
Demonstrating on expwrap library.

There is hope, this will bring code size savings for mobile
platforms, where we don't need every implementation.

Change-Id: I3519fb6148fd7a47ed9df092c73779ea6add552f
2013-12-18 07:15:46 +01:00
Norbert Thiebaud
4c539fac01 vcl get rid of xub_StrLen and STRING_LEN in outdev3
a new log section (sal.rtl.xub) is used to display alert in case of
suspicious len == 0xFFFF (aka STRING_LEN)

Change-Id: I3ed2aa7896e12592be9e003580dd6c8eda4add5e
Reviewed-on: https://gerrit.libreoffice.org/7117
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-12-18 01:54:16 +00:00
Michael Stahl
8272ffb8ed fix integral ambiguity
Change-Id: Idf022c8a4cd78c525a5c40ec8fe7a1e304b9aecc
2013-12-18 00:20:02 +01:00
Michael Stahl
22355042a6 fdo#72452: ODF import/export: fix handling of style:page-number
Class XMLNumberWithAutoInsteadZeroPropHdl (which appears to be used only
for this attribute) needs to be adapted to the change that
"PageNumberOffset" value 0 is no longer invalid; use "void" value for
invalid instead, which appears more appropriate anyway.

Unfortunately the type of style:page-number is positiveInteger so
writing 0 would be invalid; write "auto" instead for now.

Change-Id: I9621ea201fd928087b863c562607c3d77a3b0269
2013-12-18 00:12:09 +01:00
Matúš Kukan
975f62aeaa gbuild: remove obsolete SOLARLIB
Change-Id: I6fcf5ff3a8f543079c3c8d37a728eb0ba6e0587e
2013-12-17 21:31:15 +01:00
Caolán McNamara
669c282fea embedded nulls in literals
these used to be used with OUString::createFromAscii so a blank
string is fine here

Change-Id: I744d2be5471fad2675741f908e1ad78f0d5eefbc
2013-12-17 20:28:18 +00:00
Herbert Dürr
802ca8cd36 Related: #i123840# normalize SalFrame resolution type to sal_Int32
(cherry picked from commit 8a7cfd2bded9a531a034222c71ba3eda9df7d436)

Conflicts:
	vcl/aqua/source/gdi/salgdi.cxx
	vcl/aqua/source/gdi/salprn.cxx
	vcl/aqua/source/window/salframe.cxx
	vcl/inc/aqua/salframe.h
	vcl/inc/aqua/salgdi.h
	vcl/inc/os2/salgdi.h
	vcl/os2/source/gdi/salgdi.cxx
	vcl/unx/generic/gdi/salgdi3.cxx

Change-Id: I86f2902d765422b4b850619c72119ad4e03452d7
2013-12-17 20:10:24 +00:00
Miklos Vajna
73a808f6b3 test::FiltersTest: add support for export tests
For now, this is only implemented for the Writer RTF filter.

Change-Id: I0c7ae5b0e544bd4738652a38474f4d262ce65661
2013-12-17 20:52:35 +01:00
Jacobo Aragunde Pérez
25dc9aaf69 ooxml: preserve font theme color shade property
Change-Id: I40fa3f172f98b319a97a855231b854651be2d784
2013-12-17 19:51:18 +01:00
Jacobo Aragunde Pérez
3d126bcf1f ooxml: preserve font theme color property
The property is called w:themeColor and it belongs to the w:color tag
inside run properties.

On import, the themeColor prop is stored in the character interop
grab bag together with the val prop.

On export, the current color of a text run is compared with the
stored val prop to know if the color has been changed during the
document edition. If it hasn't changed, the themeColor property
must be written to the document; if it has, it must not be written to
avoid overwriting the new color.

Also added a unit test for this property.

Change-Id: Icc95ee023aecc741adcba23d23206aadd6c30e1f
2013-12-17 19:51:18 +01:00
Jacobo Aragunde Pérez
79aecccf04 sw: Small code rewrite
The purpose is improve legibility of future patches

Change-Id: I15bcfdc74feab25cf3ce4dcf246969f3d9f152d2
2013-12-17 19:51:18 +01:00
Michael Stahl
64575a5b91 sax: avoid usage of double for parsing nanoseconds here too
Change-Id: Iddf93a116cb333db6465a915dae692c33a60241a
2013-12-17 18:32:43 +01:00
Michael Stahl
77378cde59 SvxTextEditSourceImpl::Notify(): attempt to fix chart2_unoapi crash
Apparently SvxTextEditSourceImpl::mpView is not properly invalidated
when the instance it points to is deleted; the SvxTextEditSourceImpl
is registered as listener so try to handle this in Notify(); not sure
if there isn't something that ought to have cleaned this up...

Crash running with SAL_FORCE_IACCESSIBLE2=1:

svxcorelo.dll!SdrPaintView::FindPaintWindow(const OutputDevice & rOut) Line 70
svxcorelo.dll!SvxTextEditSourceImpl::GetVisArea() Line 923
svxcorelo.dll!SvxTextEditSource::GetVisArea() Line 1113
svxlo.dll!accessibility::AccessibleTextHelper_Impl::UpdateVisibleChildren(bool bBroadcastEvents) Line 868
svxlo.dll!accessibility::AccessibleTextHelper_Impl::ProcessQueue() Line 1376
svxlo.dll!accessibility::AccessibleTextHelper_Impl::Notify(SfxBroadcaster & __formal, const SfxHint & rHint) Line 1530
svllo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 48
svxcorelo.dll!SvxTextEditSourceImpl::NotifyHdl(EENotify * aNotify) Line 1021
svxcorelo.dll!SvxTextEditSourceImpl::LinkStubNotifyHdl(void * pThis, void * pCaller) Line 1013
tllo.dll!Link::Call(void * pCaller) Line 123
editenglo.dll!Outliner::ImplBlockInsertionCallbacks(unsigned char b) Line 2098
editenglo.dll!Outliner::Clear() Line 2036
svxcorelo.dll!SdrOutlinerCache::disposeOutliner(SdrOutliner * pOutliner) Line 91
svxcorelo.dll!SdrModel::disposeOutliner(SdrOutliner * pOutliner) Line 1960
svxcorelo.dll!SvxTextEditSourceImpl::dispose() Line 489
svxcorelo.dll!SvxTextEditSourceImpl::Notify(SfxBroadcaster & __formal, const SfxHint & rHint) Line 458
svllo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 48
svxcorelo.dll!SdrModel::~SdrModel() Line 270
chartcorelo.dll!chart::DrawModelWrapper::~DrawModelWrapper() Line 191
chartcorelo.dll!chart::DrawModelWrapper::`vector deleting destructor'(unsigned int)
chartcorelo.dll!boost::checked_delete<chart::DrawModelWrapper>(chart::DrawModelWrapper * x) Line 34
chartcorelo.dll!boost::detail::sp_counted_impl_p<chart::DrawModelWrapper>::dispose() Line 78
chartcorelo.dll!boost::detail::sp_counted_base::release() Line 104
chartcorelo.dll!boost::detail::shared_count::~shared_count() Line 381
chartcorelo.dll!boost::shared_ptr<chart::DrawModelWrapper>::~shared_ptr<chart::DrawModelWrapper>()
chartcorelo.dll!boost::shared_ptr<chart::DrawModelWrapper>::reset() Line 626
chartcorelo.dll!chart::ChartView::~ChartView() Line 202
chartcorelo.dll!chart::ChartView::`scalar deleting destructor'(unsigned int)
cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 204
chartcorelo.dll!cppu::WeakImplHelper10<com::sun::lang::XInitialization,com::sun::lang::XServiceInfo,com::sun::datatransfer::XTransferable,com::sun::lang::XUnoTunnel,com::sun::util::XModifyListener,com::sun::util::XModeChangeBroadcaster,com::sun::util::XUpdatable,com::sun:🫘:XPropertySet,com::sun::lang::XMultiServiceFactory,com::sun::qa::XDumper>::release() Line 115
chartcorelo.dll!com::sun::uno::Reference<com::sun::uno::XInterface>::~Reference<com::sun::uno::XInterface>() Line 106
chartcorelo.dll!chart::ChartModel::~ChartModel() Line 188
chartcorelo.dll!chart::ChartModel::`vector deleting destructor'(unsigned int)
cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 204

Change-Id: Ife6d6275eae74750858a7a7f57153c76a1a228a4
2013-12-17 18:32:43 +01:00
Michael Stahl
ebb6c4407d ChildrenManagerImpl::AddShape: do not use member after releasing mutex
This crashed here once during some JunitTest with an rDescriptor that
did not match maVisibleChildren.back().
[The mrContext member used here is const so shouldn't cause problems.]

Change-Id: I31e54b166badef6472127c64f0a4f49c51c73b30
2013-12-17 18:32:42 +01:00
Michael Stahl
133b18e677 sw: revert PaintArea change in SwAccessibleFrame
76c549eb01 changes some calls to
SwAccessibleChildSList to use the PaintArea() of the given SwFrm
instead of the given rVisArea, which makes
SwAccessibleFrame::GetChildCount() and GetChildIndex() inconsistent
with other methods such as GetChild(), GetChildAtPixel() etc.

Not sure which way is better, but it should be consistent;
revert the partial change for now and see.

Change-Id: I7d7edf2ec3dd0860ac2331d36757096186185e4f
2013-12-17 18:32:42 +01:00
David Tardon
21a36be172 add more graphics apps to launchpad list
Change-Id: I8f80b4aa07fd923aea4f50fd50d4ce68230cde06
2013-12-17 18:09:10 +01:00
Stephan Bergmann
8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
Stephan Bergmann
b9bcc9c5c1 ...and nDigits > 9 is harmless in following for loop and need not be capped
Change-Id: I30c4005e5983f5007edfed692b74f07b31899755
2013-12-17 17:29:58 +01:00
Stephan Bergmann
71448690d7 readUnsignedNumberMaxDigits can read more than maxDigits chars
...so that is what the std::min was good for that the previous commit erroneously removed.

Change-Id: I0cb08ab79f85ce4b919232845994c9b8bae35646
2013-12-17 17:20:42 +01:00
Stephan Bergmann
acb9da3d4a Fix naming
Change-Id: Ia7c62d57c56a27e097dbe252b6c6cac8fba7ace5
2013-12-17 16:56:36 +01:00
Stephan Bergmann
695671eb18 Avoid inaccurate floating-point computations
...otherwise at least my --disable-dbgutil --disable-debug Linux x86_64 build
failed the CppunitTest_sax_cpputest with 8999999 vs. 9000000 nanoseconds.

Change-Id: I05e0febf413f9f9e01227a0cc4e0f46a5243fe61
2013-12-17 16:56:35 +01:00
Stephan Bergmann
0b2bc82f3c Improve CPPUNIT_ASSERTs
Change-Id: I971602ce562ae0e11be5ac7b4d1eefbd342b625c
2013-12-17 16:56:35 +01:00
Miklos Vajna
0d1e734739 CppunitTest_sw_ooxmlexport: handle mc namespace in assertions
Change-Id: I17c8e5b4716652585d5612a4796140e7f54aaddb
2013-12-17 16:38:54 +01:00
Miklos Vajna
1279f9c835 DOCX drawingml export: give drawinglayer pictures the correct namespace
This is triggered by testVMLData in CppunitTest_sw_ooxmlexport when DML export
is enabled in non-experimental mode.

Change-Id: Id636b1ab701ff49da1b05b720fcb2173360584ba
2013-12-17 16:30:04 +01:00
Tor Lillqvist
236c0762c1 touch -h requires the file to exist, funnily enough
Change-Id: I38639236f9e7cc2ec8f4e4f9adc708822bc2f73d
2013-12-17 15:41:54 +02:00
Tor Lillqvist
05fa566b17 Touch a plain file and not /dev/null to avoid problem on Cygwin at least
Touch the "warn" file that we use to save warnings detected during
configury.

Change-Id: I44ad9a878f7768af6046337c0465e00061306dda
2013-12-17 15:33:20 +02:00
Miklos Vajna
46fcde38cf DocxExport::OutputDML: fix export of shapes in headers
This is triggered by testVMLData in CppunitTest_sw_ooxmlexport when DML export
is enabled in non-experimental mode.

Change-Id: I5e157f75909d05fc18d9a8790839030f4056860d
2013-12-17 14:19:06 +01:00
Tor Lillqvist
f4502a2f7f These get defined through lo.xcconfig now
Change-Id: I4d574b728aa0a60808bcfdd36c503476c226599a
2013-12-17 15:17:42 +02:00
Stephan Bergmann
16b48021e1 Fix cross-compilation "make distclean" 2013-12-17 14:06:42 +01:00
Tor Lillqvist
13b73d94dc Pass also Xcode's ARCHS, OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS in lo.xcconfig
ARCHS tells Xcode to build the architecture for which the LO code has
been built. The CFLAGS properties make sure the same -D flags are used
as for the LO code.

Change-Id: I3c8af0ff9fba7d0b4eddbc0af9aad44fb385314c
2013-12-17 14:22:11 +02:00
Douglas Mencken
fa66ae3a73 Bump curl version check to 7.19.4 in configure.ac
Constants CURLPROTO_HTTP, CURLPROTO_HTTPS, ... have been introduced in curl 7.19.4.
With current requirement (>= 7.13.1), we would get build errors like
  "cmis/src/libcmis/base-session.cxx:841: error: CURLOPT_PROTOCOLS was not declared in this scope"
in cases of using curl < 7.19.4.

Change-Id: Ifa6c56fc71715cceb19d30bb2d6f48f0b1dbd7da
Reviewed-on: https://gerrit.libreoffice.org/7050
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-12-17 12:19:22 +00:00
Caolán McNamara
bd225bc2b8 convert gallery search progress dialog to .ui
Change-Id: I77d9530ebc6529d87e2484c8440794e246aab5b9
2013-12-17 12:15:59 +00:00
Caolán McNamara
0240aa98de support setting end ellipsis from .ui
Change-Id: I426f41ffdf107b7dcff8ae713e2dc63610f915af
2013-12-17 12:15:58 +00:00
Douglas Mencken
877f7e6eae Add check for touch -h to configure.ac
Change-Id: I53c452dac9cef64fce9a3e7e28956efe95fc4c24
Reviewed-on: https://gerrit.libreoffice.org/7046
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-12-17 12:15:44 +00:00
Douglas Mencken
9cd1ab37e9 Add OSX@PowerPC support to UNO/C++ bridge
It is the same as Linux@PowerPC 32-bit (cp -r gcc3_linux_powerpc gcc3_macosx_powerpc),
with differences applied:
      * Use 13 FP registers and correct 'codeSnippetSize' (8*4 + 13*8 = 136).
      * Use "frame pointer + 24", not "+8".
      * Don't USE_DOUBLE_MMAP and 'sal_PtrDiff writetoexecdiff'.
      * Don't use "__NO_FPRS__", OS X capable PowerPC machines all have FPRs.
      * Use "rN"/"fN" syntax to avoid "Parameter syntax error" errors.
      * Include sys/types.h, sys/malloc.h instead of malloc.h;
        don't include string.h.

Change-Id: I5b251c65466af2a06bd309d3a7b1aaf26ac12656
Reviewed-on: https://gerrit.libreoffice.org/7072
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-12-17 12:13:27 +00:00
Jelle van der Waa
417c85bf58 fdo#72598 Remove SunStudio cruft from code base
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc
Reviewed-on: https://gerrit.libreoffice.org/7104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-12-17 11:57:04 +00:00
Caolán McNamara
4e89311f5c fix deadlock on pressing cancel in find files for gallery
progress thread blocked on solarmutex
press cancel in main thread which has solarmutex locked
call terminate
call join, which waits for thread to finish, which it can't
because its waiting on the locked solarmutex

so...
just call terminate on cancel. Let the thread get the solarmutex
and do its last round of work, at which point it will exit and post
an event to the main thread to call Cleanup, put the join there
instead and which point we know the progress thread is finished and
has no more interest in the solarmutex.

Change-Id: Ibe3976377288ac76b1b37c875a32e20b8d5daae1
2013-12-17 11:53:16 +00:00
Lionel Elie Mamane
edbbc471bc HSQLDB: correct syntax of change password from MySQL to HSQLDB
Change-Id: Iacf60c456912f2e38c7a082e48c45164e79c1097
2013-12-17 12:16:24 +01:00
Lionel Elie Mamane
9203ae338f HSQLDB: quote usernames
Change-Id: I8384920bc55dafb2cc6581fe82f38d4e2659cc3d
2013-12-17 12:16:23 +01:00
Miklos Vajna
64dc8acbf1 DocxSdrExport: there is no DML syntax for watermarks
At least what we wrote previously is not accepted by Word and even Word
2013 writes watermarks as VML-only.

This fixes testWatermark in CppunitTest_sw_ooxmlexport when DML export is
enabled in non-experimental mode.

Change-Id: I231014dd7ad60b5a4b0d79e76cdc3386641af032
2013-12-17 11:53:43 +01:00
Caolán McNamara
944a086d92 if there is one typo, its guaranteed to duplicated somewhere
Change-Id: Ia81069afa47fa5790b973247c68bead7de87d718
2013-12-17 10:26:21 +00:00
Caolán McNamara
2e4360815b fix caption dialog
Change-Id: I499f47b116ff6957bbbc20b91224fe95593d1da1
2013-12-17 10:24:07 +00:00